GNU bug report logs - #61996
30.0.50; Submitting elixir-ts-mode and heex-ts-mode

Previous Next

Full log

Message #58 received at 61996-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
Cc: 61996-done <at> debbugs.gnu.org, theo <at> thornhill.no, casouri <at> gmail.com
Subject: Re: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Sun, 12 Mar 2023 17:46:41 +0200

> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> Cc: 61996 <at> debbugs.gnu.org, casouri <at> gmail.com, theo <at> thornhill.no
> Date: Sun, 12 Mar 2023 17:14:03 +0200
> 
> Attached are the updated patches with added test cases and
> indentation rule enhancements.

Thanks, installed on master.

> I still see this warning on a non-treesitter build:
> 
> In elixir-ts--forward-sexp:
> elixir-ts-mode.el:490:8: Warning: reference to free variable
>     ‘heex-ts--sexp-regexp’

Doesn't happen here, so I think we are good.

> Random concern: how will backwards compatibility work when the
> grammars get updated?

Let's discuss this when such problems actually happen.  The answer
depends on what kind of incompatibilities are introduced by changes in
the grammars.

> It might just be better to add both modes in one patch if more
> changes are required perhaps?

I'm not sure I understand the question.

In general, we like each commit to be as self-contained and
independent of the others as possible.  Not sure if this answers your
question.

Thanks, I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.