GNU bug report logs - #61996
30.0.50; Submitting elixir-ts-mode and heex-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#61996: closed (30.0.50; Submitting elixir-ts-mode and
 heex-ts-mode)
Date: Sun, 12 Mar 2023 15:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 12 Mar 2023 17:46:41 +0200
with message-id <83sfeat1jy.fsf <at> gnu.org>
and subject line Re: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
has caused the debbugs.gnu.org bug report #61996,
regarding 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
61996: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61996
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: casouri <at> gmail.com, theo <at> thornhill.no
Subject: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Mon, 06 Mar 2023 09:04:13 +0200

[Message part 3 (text/plain, inline)]

I would like to submit elixir-ts-mode and heex-ts-mode to emacs 
master.

The package elixir-ts-mode and its dependency heex-ts-mode is
currently a melpa package: https://melpa.org/#/elixir-ts-mode. 
This is a
slightly simplified version, also authored by me.

There is one change not authored by me:
https://github.com/wkirschbaum/elixir-ts-mode/commit/21ad74877ebb55f4bf0b31c2f463bbfda72590ef
which is a duplication removal.

I completed the assignment process in Jan.

[0001-Add-heex-ts-mode.patch (text/x-patch, attachment)]

[0002-Add-elixir-ts-mode.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
Cc: 61996-done <at> debbugs.gnu.org, theo <at> thornhill.no, casouri <at> gmail.com
Subject: Re: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Sun, 12 Mar 2023 17:46:41 +0200

> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> Cc: 61996 <at> debbugs.gnu.org, casouri <at> gmail.com, theo <at> thornhill.no
> Date: Sun, 12 Mar 2023 17:14:03 +0200
> 
> Attached are the updated patches with added test cases and
> indentation rule enhancements.

Thanks, installed on master.

> I still see this warning on a non-treesitter build:
> 
> In elixir-ts--forward-sexp:
> elixir-ts-mode.el:490:8: Warning: reference to free variable
>     ‘heex-ts--sexp-regexp’

Doesn't happen here, so I think we are good.

> Random concern: how will backwards compatibility work when the
> grammars get updated?

Let's discuss this when such problems actually happen.  The answer
depends on what kind of incompatibilities are introduced by changes in
the grammars.

> It might just be better to add both modes in one patch if more
> changes are required perhaps?

I'm not sure I understand the question.

In general, we like each commit to be as self-contained and
independent of the others as possible.  Not sure if this answers your
question.

Thanks, I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.