GNU bug report logs - #61996
30.0.50; Submitting elixir-ts-mode and heex-ts-mode

Previous Next

Full log

Message #41 received at 61996 <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61996 <at> debbugs.gnu.org, theo <at> thornhill.no, casouri <at> gmail.com
Subject: Re: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Sun, 12 Mar 2023 11:54:33 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
>> Cc: 61996 <at> debbugs.gnu.org, casouri <at> gmail.com, theo <at> thornhill.no
>> Date: Sat, 11 Mar 2023 20:01:32 +0200
>> 
>> > Please accompany the changes with a commit log message 
>> > according
>> > to our conventions (see CONTRIBUTE for the conventions; 
>> > search for
>> > "ChangeLog" there).  In this case, just "New file" log should 
>> > be
>> > sufficient for the new files you add.
>> >
>> Thanks, was not aware of it. I hope it is correct in the new 
>> patches. 
>
> Yes, it is.  Thanks.
>
>> The new patches should hopefully cover all of the above issues. 
>
> Almost there.  Byte compiler shows warnings, which I think are 
> real
> problems in the code:
>
>   In elixir-ts--call-parent-start:
>   progmodes/elixir-ts-mode.el:459:38: Warning: Unused lexical 
>   argument `node'
>   progmodes/elixir-ts-mode.el:463:15: Warning: reference to free 
>   variable `parent'
>
>   In elixir-ts--forward-sexp:
>   progmodes/elixir-ts-mode.el:482:8: Warning: reference to free 
>   variable `heex-ts--sexp-regexp'

Ah, not sure how I missed them. The new patches have further 
tweaks and
should resolve the above issue.

[0001-Add-heex-ts-mode-Bug-61996.patch (text/x-patch, attachment)]

[0002-Add-elixir-ts-mode-Bug-61996.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.