GNU bug report logs - #61996
30.0.50; Submitting elixir-ts-mode and heex-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: casouri <at> gmail.com, Eli Zaretskii <eliz <at> gnu.org>, theo <at> thornhill.no, 61996 <at> debbugs.gnu.org
Subject: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Sat, 11 Mar 2023 20:27:35 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 11/03/2023 11:16, Eli Zaretskii wrote:
>>> +(defun heex-ts-mode--forward-sexp (&optional arg)
>>> +  (interactive "^p")
>> Why is a command an internal function?  That is unusual, as 
>> commands
>> are by definition public.  It looks like you thought the 
>> double-hyphen
>> "--" notation is a simple delimiter between the package-name 
>> part of
>> the symbol name and the rest?  If so, you were mistaken: the
>> double-hyphen means this is an internal function/variable. 
>> Please
>> review all your symbol names in this patch and rename as 
>> appropriate.
>
> I'm guessing it was made interactive for debugging purposes.
>
> But even that doesn't seem necessary: calling 'forward-sexp' 
> through
> its regular binding will invoke forward-sexp-function basically 
> right
> away.
>
> (treesit-forward-sexp doesn't need to be interactive either.)

This was a mistake and still learning some basic conventions. I 
don't see a
reason to call this function interactively.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.