GNU bug report logs - #61996
30.0.50; Submitting elixir-ts-mode and heex-ts-mode

Previous Next

Full log

Message #20 received at 61996 <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61996 <at> debbugs.gnu.org, theo <at> thornhill.no, casouri <at> gmail.com
Subject: Re: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Mon, 06 Mar 2023 21:24:11 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> >> +(if (treesit-ready-p 'elixir)
>> >> +    (progn
>> >> +      (add-to-list 'auto-mode-alist '("\\.elixir\\'" . 
>> >> elixir-ts-mode))
>> >> +      (add-to-list 'auto-mode-alist '("\\.ex\\'" . 
>> >> elixir-ts-mode))
>> >> +      (add-to-list 'auto-mode-alist '("\\.exs\\'" . 
>> >> elixir-ts-mode))
>> >> +      (add-to-list 'auto-mode-alist '("mix\\.lock" . 
>> >> elixir-ts-mode))))
>> >> +
>> >> +(if (treesit-ready-p 'heex)
>> >> +    (add-to-list 'auto-mode-alist '("\\.[hl]?eex\\'" . 
>> >> heex-ts-mode)))
>> >                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> > Copy/paste error, I presume?
>> >
>> > Thanks.
>> 
>> This was intentional, but perhaps a bad choice and lack of 
>> understanding of how the
>> -ts-modes should be activated. elixir-ts-mode should ideally 
>> load 
>>  the
>> HEEx grammar, but should also technically be able to function 
>> without.
>
> Sorry, I don't understand: are you saying that the HEEx grammar
> supports both modes?  I thought you need a separate grammar for
> Elixir.  I also thought the Elixir files have different 
> file-name
> extensions than the HEEx files.  Was I mistaken?
>

No, you were not mistaken. I corrected this with the new patches.

>> The Elixir language author mentioned that heex can practically 
>> be
>> seen as part of Elixir, so requiring heex-ts-mode makes sense, 
>> sort
>> of.
>> 
>> heex-ts-mode and elixir-ts-mode used to be in one file, but I 
>> was
>> asked to split them for the MELPA submission. The HEEx language
>> should actually also be able to embed Elixir, but this is not
>> essential and we can do without imo. Would it make sense have 
>> them
>> in one file?
>
> Maybe.  Otherwise, if they have a lot in common, you'd need to
> duplicate stuff or have a common file used by both.  Your call.

For this release it will be good just to get the basics to work as 
is, but
good to know it is an option. 

Attached are the updated patches. Is this the right format, or 
should I
add them inline rather?

[0001-Add-heex-ts-mode.patch (text/x-patch, attachment)]

[0002-Add-elixir-ts-mode.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.