GNU bug report logs - #61977
[PATCH] channels: Raise an error if dependency's introduction is malformed

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: bug#61977: closed (Re: [PATCH] channels: Raise an error if
 dependency's introduction is malformed)
Date: Sun, 04 Jun 2023 09:40:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#61977: [PATCH] channels: Raise an error if dependency's introduction is malformed

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 61977 <at> debbugs.gnu.org.

-- 
61977: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61977
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: 61977-done <at> debbugs.gnu.org
Subject: Re: [PATCH] channels: Raise an error if dependency's introduction
 is malformed
Date: Sun, 04 Jun 2023 11:38:55 +0200

[Message part 3 (text/plain, inline)]

Hi everyone,

Josselin Poiret <dev <at> jpoiret.xyz> writes:

> * guix/channels.scm (sexp->channel-introduction): Do it.

Pushed as cacc0cb6ab22218a3783a51ba9986405ede4e0d8, with Simon's
suggestion of adding G_.

Best,
-- 
Josselin Poiret

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH] channels: Raise an error if dependency's introduction is
 malformed
Date: Sun,  5 Mar 2023 11:56:09 +0100

* guix/channels.scm (sexp->channel-introduction): Do it.
---
 guix/channels.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/guix/channels.scm b/guix/channels.scm
index d44e7a0a3a..fc2bf55d65 100644
--- a/guix/channels.scm
+++ b/guix/channels.scm
@@ -256,7 +256,14 @@ (define sexp->channel-introduction
                             ('commit commit) ('signer signer)
                             _ ...)
      (make-channel-introduction commit (openpgp-fingerprint signer)))
-    (x #f)))
+    (x (raise (condition
+               (&message
+                (message (format #f "channel dependency has an invalid\
+ introduction field")))
+               (&error-location
+                (location
+                 (source-properties->location
+                  (source-properties x)))))))))
 
 (define (read-channel-metadata port)
   "Read from PORT channel metadata in the format expected for the

base-commit: 2799ad44234be675f018115f99be98d2c9fd565d
-- 
2.39.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.