From unknown Sat Aug 16 19:17:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61977] [PATCH] channels: Raise an error if dependency's introduction is malformed Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Mar 2023 10:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61977 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61977@debbugs.gnu.org Cc: Josselin Poiret X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16780138109051 (code B ref -1); Sun, 05 Mar 2023 10:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 10:56:50 +0000 Received: from localhost ([127.0.0.1]:38608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYm2r-0002Lv-SO for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:56:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:35362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYm2q-0002Ln-DY for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:56:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYm2q-000689-71 for guix-patches@gnu.org; Sun, 05 Mar 2023 05:56:48 -0500 Received: from jpoiret.xyz ([206.189.101.64]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYm2o-0007Ve-Nw for guix-patches@gnu.org; Sun, 05 Mar 2023 05:56:47 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id C5EEC18530D; Sun, 5 Mar 2023 10:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1678013803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JOpP7+pNfocM+n84MOV5dwBuavhS2IUmTE3PzMowikI=; b=fQkPX/idY3cRO62/5t0HPkOiKCh+Ysdn7vFEeMVkfqU6NOuE3u09B4r5y7zXODBJ83QI6v Tv/0GRThrUIXntL6HaMOeJ1en7odJMSVb+DXQkGqluLyG+ccJUGzWpCCUGPxy5Z6YObmLV RlhT9ivaqrtrh96C48X7DWlguIG+0fHwFLhGllAKq05GCSJYOy45flLJOIU3EnKPBGCoOc M6RgQJtYy8lkz5UFzu3SawkZOdZUdLkpleQ27VuCTgcfM/LSqRRYfMURDP7Wnti1m0RO4r 7IKPmQSsMwEomy2pCdbrIzr6Nheis/1NXS+2HJ+YAeftBLAmHO3/+xdq/Wl1fg== From: Josselin Poiret Date: Sun, 5 Mar 2023 11:56:09 +0100 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** X-Spamd-Bar: ++++ Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/channels.scm (sexp->channel-introduction): Do it. --- guix/channels.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/guix/channels.scm b/guix/channels.scm index d44e7a0a3a..fc2bf55d65 100644 --- a/guix/channels.scm +++ b/guix/channels.scm @@ -256,7 +256,14 @@ (define sexp->channel-introduction ('commit commit) ('signer signer) _ ...) (make-channel-introduction commit (openpgp-fingerprint signer))) - (x #f))) + (x (raise (condition + (&message + (message (format #f "channel dependency has an invalid\ + introduction field"))) + (&error-location + (location + (source-properties->location + (source-properties x))))))))) (define (read-channel-metadata port) "Read from PORT channel metadata in the format expected for the base-commit: 2799ad44234be675f018115f99be98d2c9fd565d -- 2.39.1 From unknown Sat Aug 16 19:17:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61977] [PATCH] channels: Raise an error if dependency's introduction is malformed Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Mar 2023 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61977 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 61977@debbugs.gnu.org Received: via spool by 61977-submit@debbugs.gnu.org id=B61977.167909125610200 (code B ref 61977); Fri, 17 Mar 2023 22:15:02 +0000 Received: (at 61977) by debbugs.gnu.org; 17 Mar 2023 22:14:16 +0000 Received: from localhost ([127.0.0.1]:45841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdIL2-0002eR-EZ for submit@debbugs.gnu.org; Fri, 17 Mar 2023 18:14:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdIL1-0002e6-0a for 61977@debbugs.gnu.org; Fri, 17 Mar 2023 18:14:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdIKv-0002fr-QD; Fri, 17 Mar 2023 18:14:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=K40b/rtBjfYGMI1qV7qxZskix2y04nAG7Chu6kCIiaI=; b=ZivZC1dUygXvscOrxM7J THsPM8LlTbtn4yK70nkKi0h3k03egz6CYo/Sletq4eiFcWyDz+wPKEcYahCyjGFWWr2ROpxES4TFO DvzPd4b42PrvBL+o+LAL9zSe8zBIDr3WpsUdgE+/0xlW24I9UukyEwvM3uHOqhTdZvv1cTecvBcug UYWXwOij8zSbip2/FYAqRH+a6U4hThTdEpSRl0UjnR1NqXCr9r6AENAhssHa/jzT8uNJ6Tu0cB5AP v179BINkxU/i7vCkevlAobyZBXbouaxZ1vK4/5pmKzbYTtJ69QIlcklbEr83c68X8Mb9DodgMz/5p UXZkXEsdK/jK4g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdIKu-0005po-M9; Fri, 17 Mar 2023 18:14:08 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Fri, 17 Mar 2023 23:14:06 +0100 In-Reply-To: (Josselin Poiret's message of "Sun, 5 Mar 2023 11:56:09 +0100") Message-ID: <871qlnvxe9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Josselin, Josselin Poiret skribis: > * guix/channels.scm (sexp->channel-introduction): Do it. To be clear, without this a malformed introduction sexp would be silently ignored; consequently, the channel in question would not be authenticated, in which case the =E2=80=9Cchannel '~a' lacks 'introduction' field=E2=80=9D warning would be printed. Am I right? So the goal here is to catch errors in =E2=80=98.guix-channel=E2=80=99 earl= ier, right? Thanks, Ludo=E2=80=99. From unknown Sat Aug 16 19:17:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61977] [PATCH] channels: Raise an error if dependency's introduction is malformed Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Mar 2023 21:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61977 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61977@debbugs.gnu.org Received: via spool by 61977-submit@debbugs.gnu.org id=B61977.1679175730840 (code B ref 61977); Sat, 18 Mar 2023 21:43:02 +0000 Received: (at 61977) by debbugs.gnu.org; 18 Mar 2023 21:42:10 +0000 Received: from localhost ([127.0.0.1]:49143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdeJV-0000DU-Qs for submit@debbugs.gnu.org; Sat, 18 Mar 2023 17:42:10 -0400 Received: from jpoiret.xyz ([206.189.101.64]:45246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdeJT-0000DL-K9 for 61977@debbugs.gnu.org; Sat, 18 Mar 2023 17:42:08 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 7EFDA185317; Sat, 18 Mar 2023 21:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1679175724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SVBLqMRZASaLuYnBGagpJQrhFHDC+fbOFzgSTe0v5fc=; b=D/bCVnRvgm5jWBNsGapP0DPmJ8TuoL9bky8mW2YkCNQpZKzHrStU7fUPPjsKSfo3HidOrK PjnG6gJ6E0yAOKObZgmgpStVY4INFjkgcVaKVvC5Iyx8k5mCp5mMCUCQ+cS3HSe3I8GedS 3isIBYAlxPu5V2Y8vbERPLphlazHxh94JvYDBVCsETc77WaRX8YFDdKo6WVjJMrxX69Jn9 47CDUTuALOvngGEqc4Vyy+CbPc+2t6v2nD6baqjykPjet6CK1w8oz8rPbdB5+5VTy21To/ 64/L3eJZpsgkNsJSCxUSoE8oM8mfTukoYNHIrroKEAzkm/gmp9rc+YA63rJcZQ== From: Josselin Poiret In-Reply-To: <871qlnvxe9.fsf@gnu.org> References: <871qlnvxe9.fsf@gnu.org> Date: Sat, 18 Mar 2023 22:42:01 +0100 Message-ID: <87mt4968k6.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: -- X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, Ludovic Court=C3=A8s writes: > Hi Josselin, > > Josselin Poiret skribis: > >> * guix/channels.scm (sexp->channel-introduction): Do it. > > To be clear, without this a malformed introduction sexp would be > silently ignored; consequently, the channel in question would not be > authenticated, in which case the =E2=80=9Cchannel '~a' lacks 'introductio= n' > field=E2=80=9D warning would be printed. Am I right? > > So the goal here is to catch errors in =E2=80=98.guix-channel=E2=80=99 ea= rlier, right? Exactly! Someone else reported this elsewhere because they were using the syntax for a channels.scm file instead of the channel dependencies syntax, which is different, and consumers of that channel kept getting warning messages. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmQWMCkQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaiueYDACwcZbIogiaehwk4wGDUZs8HJmodE7yJaEc Yhkqp7ubEaGp0NF28SVg7a2f2OFDFuUvNl92GapjhGf//5+0sqCWTCwQOZwaZt7u o+m0LjOGtgdM4Qzm8BkS6FZ6RmGGvcVeEOFzKjDwFTejuP/qNbjiS/NllOoN54IE tax6Cv3Or6i4RHvmcpipH8gLZNBDOhmiuG9pk4uxQxc7ixcYvhlTSfT+dDLO9eTQ 3VQGbICufsktACsS1zjlMVw4VivvL/MmLfQn53PM+S2wf/2xdZPt6uS01o6N4Cz2 095Da/LwcJaTSl2F7K8Aad8aIdqNQuwnIgqoDIBoa3+DqRWs6lGpRu8jmtKoSwLP 6UmgoElnOdiFlDfJOk/WKTp95LAR6nXSNXH8TdRsa6MZX8pdKmEuv1tmfyG5LC0J XDF2RT0vClsJ8N8GiJ71kAYda+UCMbHvDp3nS0hSAjhU+zxmIgr1cVeomKxL7YPP 8aNDMfe61tk23GVY9Nk5RmrL3yWKmPY= =v148 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 19:17:20 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61977] [PATCH] channels: Raise an error if dependency's introduction is malformed Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 May 2023 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61977 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 61977@debbugs.gnu.org Received: via spool by 61977-submit@debbugs.gnu.org id=B61977.168329621930707 (code B ref 61977); Fri, 05 May 2023 14:17:02 +0000 Received: (at 61977) by debbugs.gnu.org; 5 May 2023 14:16:59 +0000 Received: from localhost ([127.0.0.1]:57200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puwF1-0007zD-Gc for submit@debbugs.gnu.org; Fri, 05 May 2023 10:16:59 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:39040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puwEw-0007yD-PW for 61977@debbugs.gnu.org; Fri, 05 May 2023 10:16:58 -0400 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-2ff86a12f88so241818f8f.0 for <61977@debbugs.gnu.org>; Fri, 05 May 2023 07:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683296209; x=1685888209; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=SiD6zY9XR0hc7GHtO0RIhTTPn8+7tY5Bpd3cgRrQ6S4=; b=BWGfRylI+Rm23FJVUd94dkZnZBBl139FrhkTGYWrzS2Fk7yYqijkWIaxoNDBRT8+hr 9dQwQDxxluODMC+v8sTlObOhuoEteRyt/KuPGMKelUBdvKx67nRLa/BUTxLqHT8NTDK/ TAULKzvfhhbii8sMAWcMmrf2Skup2yMjyf7o+5pj6DoTqP/Ji7+YLnAKQvAvdpi8c2Xr TZr5KnLQ5Exi3gN8ktt7o0rdnQ+LHj1n8pEfpYpH6Y9aAyt6FamP9CEdm6t2B6pfjMfj StcdnmRXaYxmF0ebg4Bz9QXjOR9VXm5vc0Mdi4CRYVWyk2NUCdCnnq/DjsxsOrc1um+C RpRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683296209; x=1685888209; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SiD6zY9XR0hc7GHtO0RIhTTPn8+7tY5Bpd3cgRrQ6S4=; b=RPEisI3HfEVQewSbhDC22jOz79IHtVw4I8hftyN0R1Y4trsdDxggSaKCTFi9rU2BR2 MO3VhmK22HP/YT9N68YXHbcP66Fp28TqSyYohfbbhOED013i1JdFGcUdCPEm4WYJvuwg t9lsBMVi7AyxKIFb5MZ37WJcZXrMVQ+gPAY6PmmX7qsU3BryvmpL86o4OjjcvUImoiPZ U3/BTqIij7dW7ngTbHU9NcKpaZa7WIcU3HDebRneizMnke4X4/Qji/QpTMNLsagun68Y a48HoOaQXwCP34SP5gunf16Qco5gFHPs9jkC85RJWAf6eEdmwg+7UMf3Tqkj0tFcRgWr 6Saw== X-Gm-Message-State: AC+VfDwv0WBRBhrqnQNLwAG1gwRR+VabE/exbIZelvipn6wBKFKLQ52A mgZ0/2t8/RXItx94nbiUI/4= X-Google-Smtp-Source: ACHHUZ6QpWcs7u1VoFyGCriBgrM9cEB224O85e7L7iwgH9ZFYZW9z7u3nFM5HRg40kjjy92sJzrJMQ== X-Received: by 2002:adf:eb0d:0:b0:306:3a97:e470 with SMTP id s13-20020adfeb0d000000b003063a97e470mr1204827wrn.5.1683296208956; Fri, 05 May 2023 07:16:48 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id y12-20020adffa4c000000b00306281cfa59sm2565724wrr.47.2023.05.05.07.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 07:16:48 -0700 (PDT) From: Simon Tournier References: Date: Fri, 05 May 2023 16:15:18 +0200 In-Reply-To: (Josselin Poiret's message of "Sun, 5 Mar 2023 11:56:09 +0100") Message-ID: <877ctm7tl5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, What is the status of this patch? On dim., 05 mars 2023 at 11:56, Josselin Poiret wrote: > * guix/channels.scm (sexp->channel-introduction): Do it. > --- > guix/channels.scm | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/guix/channels.scm b/guix/channels.scm > index d44e7a0a3a..fc2bf55d65 100644 > --- a/guix/channels.scm > +++ b/guix/channels.scm > @@ -256,7 +256,14 @@ (define sexp->channel-introduction > ('commit commit) ('signer signer) > _ ...) > (make-channel-introduction commit (openpgp-fingerprint signer))) > - (x #f))) > + (x (raise (condition > + (&message > + (message (format #f "channel dependency has an invalid\ > + introduction field"))) > + (&error-location > + (location > + (source-properties->location > + (source-properties x))))))))) I guess the string needs to use =E2=80=99(G_ )=E2=80=99 for translation, no? Cheers, simon From unknown Sat Aug 16 19:17:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Josselin Poiret Subject: bug#61977: closed (Re: [PATCH] channels: Raise an error if dependency's introduction is malformed) Message-ID: References: <87fs77efdc.fsf@jpoiret.xyz> X-Gnu-PR-Message: they-closed 61977 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 61977@debbugs.gnu.org Date: Sun, 04 Jun 2023 09:40:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1685871603-15798-1" This is a multi-part message in MIME format... ------------=_1685871603-15798-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61977: [PATCH] channels: Raise an error if dependency's introduction is ma= lformed which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61977@debbugs.gnu.org. --=20 61977: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61977 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1685871603-15798-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61977-done) by debbugs.gnu.org; 4 Jun 2023 09:39:06 +0000 Received: from localhost ([127.0.0.1]:45022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5kCY-00044T-36 for submit@debbugs.gnu.org; Sun, 04 Jun 2023 05:39:06 -0400 Received: from jpoiret.xyz ([206.189.101.64]:54418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5kCS-00043y-DH for 61977-done@debbugs.gnu.org; Sun, 04 Jun 2023 05:39:04 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 05879185309 for <61977-done@debbugs.gnu.org>; Sun, 4 Jun 2023 09:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1685871539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+OBAuXfhxysVu29Nl5IeD2nOk+loDO541yKFV7fP1lc=; b=sKA8S3Plaru8TlXBcRo7agDfhxCSsrFEFZxSqdwFSYFJj6XFGWdcJxTarYRUaBJUY3/+vU uds5i9CjQ4nUnpEMbN2qPFftQ5ej+oybR5WEQTBuk+Nf7E/rIdem79jzcMvzJW1wpqJ9Nz 8mLoc1aqXpX/szIYHtVhGrFc2Wc8jTvhEE8wYNbAZBhp/pp8sDsHFFnAYSRZlRbedOhohM wplfAaNwrIdxoQ+vaCD1yTu7q4+gaoKW5ie2RCNBnRUxX+rdqe3vJLhIOFKoHh+hXiHf50 pP/6SwMDJARVIkqAq0/oIZAB6ovd8zX35xqM+tXU+UnwyZDzBkGn1ekANJVXuA== From: Josselin Poiret To: 61977-done@debbugs.gnu.org Subject: Re: [PATCH] channels: Raise an error if dependency's introduction is malformed In-Reply-To: References: Date: Sun, 04 Jun 2023 11:38:55 +0200 Message-ID: <87fs77efdc.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61977-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi everyone, Josselin Poiret writes: > * guix/channels.scm (sexp->channel-introduction): Do it. Pushed as cacc0cb6ab22218a3783a51ba9986405ede4e0d8, with Simon's suggestion of adding G_. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmR8W68QHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5Fhcaivh6DAC6pjxl3S86lR/hBafVYxWHQoAvg79f/T9D DuZXsgRo/0OUFdktsKDs1PNEm1y1glqQZ/q6SHUzPr75h6YZrmUzVypdGnPyiqUr X8rTxx99CjWwfGT5bCNGBuLW0/L+1JlpEHByLcoQqnIkre1UBR7USPtoLU1ZuAWV OBbVTW3xydaDUDZTnchQtbcBKrth39od7HAjFsMM3uXrffrMWeRx3uMiibReECI0 zSIwsvvugZ7PfP/pcr04gtIyBZ5k+G4g9sPAeWXmRLHFr4TOiDWv15t4t7QHYTI4 4bkLEeTM1vGOomSmO1t7ORa921N2RG9JJtt3SnEiB8l+gIduBVU9iA5bweor5ftK ijGRIg4BZlQV6U6pZBSIBzmdEAweChrZNC6YFYeIO0HPJzQhJQEqJoKgFAwvkfK5 eW/VdFkKUTK3hxvB2r3bAMELtCJqDjc2Ev2tQwv3ek+gO1QIMZI0eHVy0UVq2bID F0HoNSvACU0bP/Yf/g7HcGgcKsFPkwQ= =4Roc -----END PGP SIGNATURE----- --=-=-=-- ------------=_1685871603-15798-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 10:56:50 +0000 Received: from localhost ([127.0.0.1]:38608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYm2r-0002Lv-SO for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:56:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:35362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYm2q-0002Ln-DY for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:56:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYm2q-000689-71 for guix-patches@gnu.org; Sun, 05 Mar 2023 05:56:48 -0500 Received: from jpoiret.xyz ([206.189.101.64]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYm2o-0007Ve-Nw for guix-patches@gnu.org; Sun, 05 Mar 2023 05:56:47 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id C5EEC18530D; Sun, 5 Mar 2023 10:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1678013803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JOpP7+pNfocM+n84MOV5dwBuavhS2IUmTE3PzMowikI=; b=fQkPX/idY3cRO62/5t0HPkOiKCh+Ysdn7vFEeMVkfqU6NOuE3u09B4r5y7zXODBJ83QI6v Tv/0GRThrUIXntL6HaMOeJ1en7odJMSVb+DXQkGqluLyG+ccJUGzWpCCUGPxy5Z6YObmLV RlhT9ivaqrtrh96C48X7DWlguIG+0fHwFLhGllAKq05GCSJYOy45flLJOIU3EnKPBGCoOc M6RgQJtYy8lkz5UFzu3SawkZOdZUdLkpleQ27VuCTgcfM/LSqRRYfMURDP7Wnti1m0RO4r 7IKPmQSsMwEomy2pCdbrIzr6Nheis/1NXS+2HJ+YAeftBLAmHO3/+xdq/Wl1fg== From: Josselin Poiret To: guix-patches@gnu.org Subject: [PATCH] channels: Raise an error if dependency's introduction is malformed Date: Sun, 5 Mar 2023 11:56:09 +0100 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: **** X-Spamd-Bar: ++++ Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit Cc: Josselin Poiret X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/channels.scm (sexp->channel-introduction): Do it. --- guix/channels.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/guix/channels.scm b/guix/channels.scm index d44e7a0a3a..fc2bf55d65 100644 --- a/guix/channels.scm +++ b/guix/channels.scm @@ -256,7 +256,14 @@ (define sexp->channel-introduction ('commit commit) ('signer signer) _ ...) (make-channel-introduction commit (openpgp-fingerprint signer))) - (x #f))) + (x (raise (condition + (&message + (message (format #f "channel dependency has an invalid\ + introduction field"))) + (&error-location + (location + (source-properties->location + (source-properties x))))))))) (define (read-channel-metadata port) "Read from PORT channel metadata in the format expected for the base-commit: 2799ad44234be675f018115f99be98d2c9fd565d -- 2.39.1 ------------=_1685871603-15798-1--