GNU bug report logs - #61944
[PATCH] services: desktop: Set default value for geoclue-service-type.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#61944: closed ([PATCH] services: desktop: Set default value
 for geoclue-service-type.)
Date: Fri, 03 Mar 2023 19:41:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 03 Mar 2023 20:40:45 +0100
with message-id <87bkl9y633.fsf <at> nckx>
and subject line Re: [bug#61944] [PATCH] services: desktop: Set default value for geoclue-service-type.
has caused the debbugs.gnu.org bug report #61944,
regarding [PATCH] services: desktop: Set default value for geoclue-service-type.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
61944: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61944
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH] services: desktop: Set default value for geoclue-service-type.
Date: Fri,  3 Mar 2023 19:34:39 +0000

* gnu/services/desktop.scm (geoclue-service-type): Set default-value.
---
 gnu/services/desktop.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 8026778ea5..aa9f93997d 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -404,7 +404,8 @@ (define geoclue-service-type
                 (description "Run the @command{geoclue} location service.
 This service provides a D-Bus interface to allow applications to request
 access to a user's physical location, and optionally to add information to
-online location databases.")))
+online location databases.")
+                (default-value (geoclue-configuration))))
 
 (define-deprecated
   (geoclue-service #:key (geoclue geoclue)

base-commit: 2799ad44234be675f018115f99be98d2c9fd565d
-- 
2.39.1

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 61944-done <at> debbugs.gnu.org
Subject: Re: [bug#61944] [PATCH] services: desktop: Set default value for
 geoclue-service-type.
Date: Fri, 03 Mar 2023 20:40:45 +0100

[Message part 4 (text/plain, inline)]

Hi Bruno,

Bruno Victal 写道：
> * gnu/services/desktop.scm (geoclue-service-type): Set 
> default-value.

Thanks!  Pushed.

It's not a rule, but I like to add a reference to the 
broken/incomplete/buggy previous commit (especially if it's my own 
;-) so I did.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.