From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 13:19:00 2023 Received: (at submit) by debbugs.gnu.org; 3 Mar 2023 18:19:00 +0000 Received: from localhost ([127.0.0.1]:33934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY9zf-00023g-Nw for submit@debbugs.gnu.org; Fri, 03 Mar 2023 13:19:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:42066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY9zd-00023Y-FM for submit@debbugs.gnu.org; Fri, 03 Mar 2023 13:18:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY9zd-0002bo-3I for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 13:18:57 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY9zb-00086h-BJ for bug-gnu-emacs@gnu.org; Fri, 03 Mar 2023 13:18:56 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id DE93F5C004F for ; Fri, 3 Mar 2023 13:18:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 03 Mar 2023 13:18:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1677867529; x=1677953929; bh=HOI36EhZLU3hfb3Y3Lj/6JZou ZwEi7F2PuHgYvE5/Po=; b=VrSLcVhRieMtl/9WS/Rgx2dsQYXT1OcvScAGMCFiz AIafuJl2OXxAhuNkdi50cRq73R0nRvC6JOGMgXOiVWGxhU8xZojQqJIAsU+UHIlH +mtwqqFIZg08/X8el2JYP31Pj6ncxgoKvx6vJqVo9kEJ9fUpy6+87XfpYak9QfZy mfED29KF3y84IRSVBQ56VqyrKrcxNZSC1kqp3req8GBODMd2JQz6/M+f74hJiXcL NDU2Ur2TEngEnHAVsEMPctOHWIVmfYVzulxQC7TOjYgzRFH1U1TXH0J+w1FGeZJr 0odxGXVFw1zkM9/W8YLfV7qQnnrBwEdbqcpnv8JxMS3+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1677867529; x=1677953929; bh=HOI36EhZLU3hfb3Y3Lj/6JZouZwEi7F2PuH gYvE5/Po=; b=lOrBJ2s/9RIwYZ7z8E6y8cB2w3e1QWTvUIZ7z2K8MtZFJj1P/N8 zVxa1ubuJGcwmzvUQ4eTqArBHur/8d4oWfyqPtAYUuRzdZ4ZyjmKtyQRGU27SfGv Wn0AJ/qfsnOZ2yukIjSWz05HfS17Bkq5KwQTePQbMF/IL0mjV7YKr3+8yMnWh5nM FeK04Hbc0MqB/vvwv8chQMR2Lgu8OM2+CCaP/d4WGsqxRYj9F1H44kLcmiQ8q95w W1/SobqZWU8tXsxYvz6xEeU/C/X8/+wzwIAQF0dgo/rHZyICZWdMsIN+2VqhbX5W 6nwCbbTEzFKh/PiSh5mPReU+bQJxpRQUeSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelledguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfffgheeggffgheeuvd ethfekuddtgffgtdeukeegkedttefftdeghfdvgfdtjeelnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 3 Mar 2023 13:18:49 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id CE4CC7E2033; Fri, 3 Mar 2023 11:18:48 -0700 (MST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too Date: Fri, 03 Mar 2023 11:18:48 -0700 Message-ID: <87o7p9u29j.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.26; envelope-from=spwhitton@spwhitton.name; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) X-debbugs-cc: juri@linkov.net, joaotavora@gmail.com Many thanks to Juri and Joao for fixing #45763! It's a whole new world! I am a fido-mode user. I noticed that my custom bindings for the fido-mode minibuffer don't work for in-buffer completion. I think that icomplete--in-region-setup should compose in icomplete-fido-mode-map, in addition to icomplete-minibuffer-map, in the case that fido-mode is on? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 15:26:33 2023 Received: (at 61943) by debbugs.gnu.org; 3 Mar 2023 20:26:33 +0000 Received: from localhost ([127.0.0.1]:34054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYBz6-0005NM-LR for submit@debbugs.gnu.org; Fri, 03 Mar 2023 15:26:32 -0500 Received: from mail-oi1-f175.google.com ([209.85.167.175]:35397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYBz5-0005N9-Ig for 61943@debbugs.gnu.org; Fri, 03 Mar 2023 15:26:32 -0500 Received: by mail-oi1-f175.google.com with SMTP id c11so2734961oiw.2 for <61943@debbugs.gnu.org>; Fri, 03 Mar 2023 12:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677875185; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iUj59r91+DZLgCQw219I7Nje1+lo0VjKBwYFoZ7nDUQ=; b=fqFC/lr0Ud9bmELrzO/ieM7GH+7oH1S5EqILI1Bb4jet3yhqvreQmSqsflePtRwwQy 1oRwRqr/MtLCiYFcgyyl5Qtairal9tGYIVJnyXMQDb2gvyQKbiSrBj/b63K1TP/oe1hv aAf2zhLbIT62T2Z1lDZb69SfGiNzbVzQLv0tm7pOPgAXF2b6izH6l631IZBucyjpPr04 zdFJZsxefZ8kDp8M0Pr6sqkXCRDE7SMK8VNo6R8xn9rIDouccB6TxbYxMYNElyvL33ye RGm5heYl+NPdGlludItR9HFXMZpB25MbxQc9vC7EzHwJ/Y1rPQRKFqldtdAJWu6OID3S PZVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677875185; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iUj59r91+DZLgCQw219I7Nje1+lo0VjKBwYFoZ7nDUQ=; b=QKifBD2uaoAk+ifK3aj0my31p6INL/qmhB5KuT+42MLfXCFjs+nzvZgHpEBwptM2cW rWbsGyAQXtjjsbGd9uEsPgcPl6SE3KBfM0yd4ML6MWpDQ5CuDCJb9fMEPmeiB3stmMhL TxjgZ4Cg6d853mI+1lynureTOtpsQjsEYjWn3JcnagtWvqCH2rE0tqgp11npVyemQGT0 JhA5IxwMKXMhdAl0gL/VmtScMh5oIezKCxXSsswnFPHgRuxG0sULRRNCHGmXBbXPqX7B TIvNxNbLKX00Me5ScgNcEUcsZlLR0TN44C7RsTuqWXPLsnt6LOQOyqB5C9jWLLlX3pMW kZKA== X-Gm-Message-State: AO0yUKUxQzOCzK1l/KaMfT/LMUwR4VA4QrPN4rsUwJ7xp4F3cG/plO8s DzibiXzuiHRCdLw27C65SX4cMVJXhfXtG4TyD9s= X-Google-Smtp-Source: AK7set8+TcWBUHhmo8juoVxh/IPflrlEeu2cbR/JdnNf2AJJas8E6ZVAtZxCLG/9kIpl1R4JDtLfKJP9QPwAOTP3AZA= X-Received: by 2002:a05:6808:484:b0:384:21e7:977c with SMTP id z4-20020a056808048400b0038421e7977cmr909686oid.8.1677875185602; Fri, 03 Mar 2023 12:26:25 -0800 (PST) MIME-Version: 1.0 References: <87o7p9u29j.fsf@melete.silentflame.com> In-Reply-To: <87o7p9u29j.fsf@melete.silentflame.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Fri, 3 Mar 2023 20:26:14 +0000 Message-ID: Subject: Re: bug#61943: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too To: Sean Whitton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Mar 3, 2023, 18:19 Sean Whitton wrote: > > X-debbugs-cc: juri@linkov.net, joaotavora@gmail.com > > Many thanks to Juri and Joao for fixing #45763! It's a whole new world! You're welcome, but I think Juri did most of the work. I had planned to tackle this some time ago but it got lost in somewhere in the bucket of TODOs. I haven't given it much testing, but I'm suprised it works the way it does. I imagined it would show the typical constantly-adjusting fido-mode/icomplete list of candidates in the echo area, but it doesn't, only for in-buffer instead of minibuffer. Instead, it seems to popup *Completions* as usual. Am I being dense here? How do you set it up? Is it just (setq icomplete-in-buffer t) + M-x fido-mode as I did? And how do you invoke it? Is it C-M-i? > I am a fido-mode user. I noticed that my custom bindings for the > fido-mode minibuffer don't work for in-buffer completion. I think that > icomplete--in-region-setup should compose in icomplete-fido-mode-map, in > addition to icomplete-minibuffer-map, in the case that fido-mode is on? This probably makes sense, but please, for my benefit, try to show a minimal config with just Emacs -Q and your keybindings that you want to use in both fido modes. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 21:13:14 2023 Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 02:13:14 +0000 Received: from localhost ([127.0.0.1]:34347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYHOb-0008PV-Uh for submit@debbugs.gnu.org; Fri, 03 Mar 2023 21:13:14 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:55539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYHOZ-0008PH-9K for 61943@debbugs.gnu.org; Fri, 03 Mar 2023 21:13:12 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EDE3C5C00C4; Fri, 3 Mar 2023 21:13:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 03 Mar 2023 21:13:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1677895985; x=1677982385; bh=WNNPJ6enFCQLenSroHnGbI+bxdaD6PJjyYD zJx138BE=; b=sVuvrEquP0/95FpcGtK6fQ/DNcvudCkO6d07MrDgnv2drw+s7PG ++Mpp/w2QyeQ3WvFTEi+jsq2LalwheQZFgMrXB0PrTS6iyrC7o8/GnxkfkVr4Y+j hMqnWY3jyD3YvHILqNodY4ltVxVWyNbkrknYCKt+yMJVuq1bAgO5lRvqoEE5gjHk Gns+6WAVJMMJO1MokcT3Fq/y6+ikRdg1wioVqlWgHY11IKCUYBCerm+Nrv1n8Vt9 OUbdxpjSIKM+cNJQSe8qBniPyL5GpL3WpMcL6Wz+af8DzOuvBFUoSxjVTig5NIn2 K8fpKLIOa0rhlpATFD4K8Renv7oJYaRXHGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677895985; x= 1677982385; bh=WNNPJ6enFCQLenSroHnGbI+bxdaD6PJjyYDzJx138BE=; b=J D+aMBOCFXhPMMku2aJZhhWeNZd+GVkONNXZSO9n+09+2bpmAkFlu5tKGuLP22xmj mKem0MbEvpF2jxKrG92CjWfEeGbAgQqeKA00fkF/dOTg644qcfvSwlreqS4tcq6n g1wek0Hi8g7b/lsn3MmLKrUwgkbVI1b7E32Rk7qMTOVR/HQ5VYbceVULZ6peTjop MnFa1TJ1onTjxxIMI60da39GeDwpJyLKtqfDgak98+urphq51acxfKiqvOwDJYo8 MgkrWthM/72BO7bkokicei5Zsru10fmnbfOa5hLiKdAQHuaY21MC+MSaUCz1DC3I AkLIiEnItXDMXZBFhg2PQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddttddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtgfesthhqtddttderjeenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedugfehledtgfegkedvudetheffvddvfeegveduleehhefg geehhffhveekteejfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Mar 2023 21:13:05 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id B13567E3C80; Fri, 3 Mar 2023 19:13:04 -0700 (MST) From: Sean Whitton To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , 61943@debbugs.gnu.org, juri@linkov.net Subject: Re: bug#61943: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Fri, 3 Mar 2023 20:26:14 +0000") References: <87o7p9u29j.fsf@melete.silentflame.com> Date: Fri, 03 Mar 2023 19:13:04 -0700 Message-ID: <87lekds1qn.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 03 Mar 2023 at 08:26PM GMT, Jo=C3=A3o T=C3=A1vora wrote: > I imagined it would show the typical constantly-adjusting > fido-mode/icomplete list of candidates in the echo area, but it > doesn't, only for in-buffer instead of minibuffer. > Instead, it seems to popup *Completions* as usual. > > Am I being dense here? How do you set it up? Is it just > (setq icomplete-in-buffer t) + M-x fido-mode as I did? > And how do you invoke it? Is it C-M-i? Well, the candidates are meant to appear as an overlay after point, not in the minibuffer. However, there's something strange going on in that sometimes you can get the candidates display in-buffer but *also* the *Completions* buffer popping up. Sometimes this happens and sometimes it doesn't, I haven't figured out the pattern yet ... >> I am a fido-mode user. I noticed that my custom bindings for the >> fido-mode minibuffer don't work for in-buffer completion. I think that >> icomplete--in-region-setup should compose in icomplete-fido-mode-map, in >> addition to icomplete-minibuffer-map, in the case that fido-mode is on? > > This probably makes sense, but please, for my benefit, try to show > a minimal config with just Emacs -Q and your keybindings that > you want to use in both fido modes. Sure, e.g. evaluating these forms in emacs -Q: (setq icomplete-in-buffer t) (fido-mode 1) (define-key icomplete-fido-mode-map [?\M-.] #'icomplete-forward-completions) (define-key icomplete-fido-mode-map [?\M-,] #'icomplete-backward-completion= s) .. then do something like typing "icomplete- into *scratch* and then C-M-i. --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 21:35:43 2023 Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 02:35:43 +0000 Received: from localhost ([127.0.0.1]:34942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYHkN-0000g9-JH for submit@debbugs.gnu.org; Fri, 03 Mar 2023 21:35:43 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYHkM-0000fw-7W for 61943@debbugs.gnu.org; Fri, 03 Mar 2023 21:35:42 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D54485C01C0; Fri, 3 Mar 2023 21:35:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 03 Mar 2023 21:35:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1677897336; x=1677983736; bh=kv KncBgwb7JB3P+p1GvvLnDCr73DeMyDdQDY8X/ZygU=; b=oAOEtKQGVyIyCXX5Ar P8YQlxEKWOatQzSlnC20ZxI7JCncx8PAQSy/rZnhP4Ryo6Njtm6E9385DYW3STOs l3PTG+PiRyml3a6mKSghZaCFKk5c5o1ne2wqq6pUEojTRLlFHClsafDqZTnA1OKe macpIEI2M74NWfeW9Iggvce6PohgBkc9pUKYNiTttlD/IQac5TgqXHY9TK8GtSAO uQzJAgaJ/hc8E9ocLcFK+nxRFRj/WpalrWuGbMLbqtahYaLnpVnh8paHZS62TzZ+ bgxUgnEbeU7rzPY0KMzL41FjSBM0LXVe7ZML7tt9O9xM7G/7zSG+N/5u/kPDTIoH nOeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1677897336; x=1677983736; bh=kvKncBgwb7JB3 P+p1GvvLnDCr73DeMyDdQDY8X/ZygU=; b=EEGYNwOAjUD1HTkqB7vkyACRb+iI5 t3ngP8MAt4+XeUPWxwLpNqz66y6yLOQI2OORF1sorZjFhvoa9j8iEjdXOjBGWqKc 7NkbcdTRBdZz/tpTwyVKtC8P8Yjn/vZdTmp0Kvv8jlPyjtn58BESzHu10W4s+1RM 73ngutUVPeahGRyLIuDLiuWvz3uhtVwpnppwXLiURdCMjl/sIqu+qshkJv7bEoNU Rvwv3yZml1ydtKX6RBko/ezV+27p6gNLhXMPB+JxmIRGHYz5cj4xItxGCih0+rGU pO3u7BDQERsqPvvmWDS1HYwVgXP+iXi7xG+1bDcxKBCuJD5iStREPgmEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddttddggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Mar 2023 21:35:36 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 8516A7E3834; Fri, 3 Mar 2023 19:35:35 -0700 (MST) From: Sean Whitton To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , 61943@debbugs.gnu.org, juri@linkov.net Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: <87o7p9u29j.fsf@melete.silentflame.com> (Sean Whitton's message of "Fri, 03 Mar 2023 11:18:48 -0700") References: <87o7p9u29j.fsf@melete.silentflame.com> Date: Fri, 03 Mar 2023 19:35:35 -0700 Message-ID: <87h6v1s0p4.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 03 Mar 2023 at 11:18AM -07, Sean Whitton wrote: > X-debbugs-cc: juri@linkov.net, joaotavora@gmail.com > > Many thanks to Juri and Joao for fixing #45763! It's a whole new world! > > I am a fido-mode user. I noticed that my custom bindings for the > fido-mode minibuffer don't work for in-buffer completion. I think that > icomplete--in-region-setup should compose in icomplete-fido-mode-map, in > addition to icomplete-minibuffer-map, in the case that fido-mode is on? I noticed that icomplete-hide-common-prefix etc. are wrong too. I think that icomplete--in-region-setup also needs to do something equivalent to the setq-local in icomplete--fido-mode-setup. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 06:29:10 2023 Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 11:29:10 +0000 Received: from localhost ([127.0.0.1]:35319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYQ4b-0000SB-TQ for submit@debbugs.gnu.org; Sat, 04 Mar 2023 06:29:10 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:43731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYQ4a-0000Rw-CF for 61943@debbugs.gnu.org; Sat, 04 Mar 2023 06:29:08 -0500 Received: by mail-oi1-f176.google.com with SMTP id bk32so3692110oib.10 for <61943@debbugs.gnu.org>; Sat, 04 Mar 2023 03:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677929343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XMRZoXUjWBmIBHq44MSkXzMOBiqLbamI1WuyyrPvrrU=; b=b3t8RgvD6tmJT0dl4krXPU96pQQLc+EaWoXQCqIOE4TqgEfGEPGSylYow8JZgAkTW3 g6IIEJMd5Y40Wdr0EMlgglfL6RZYecKrwZ3kHvDcYCaArlx3EAp2fjFjWIR7U5E4jQQJ xSLCc+0fIsGltK/osIDITtCxFN8EXzPos0s8P1HMJjk6kc0GmqxbEC1GAwpqQg0liWVF KNK06/6ds31CqFIdmpKNc8yqtCayx1bweCoIy0kUNEQQ/GPSH6so9Cg4EtKgIMLM2POw DAcHYcgHnvaoOm3gTA/P1uf39zzbK5w5j+8OA8hQ6UWbjg3IhTPr9pXJLF61UvF5H0pe PbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677929343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMRZoXUjWBmIBHq44MSkXzMOBiqLbamI1WuyyrPvrrU=; b=640MveCGmm305s8mW9ctUHLA8y2SHKzJpTrBMGvkwPea8QWFIvmKZRHFS0dD8vQKC6 bUALxuWEYa2ThWiD+fv6DukRRHdy0ivwm45VPaXolqDEGUktuaN8F/t1DX2UoIl35U6x OvpEQBIcYl+Mk/8+9SyDnnbvZc5sJZGm/I98Y6AgLERh+7fmlj4zwQAMv5VTRl7nf9Gf xYNAlTfk9TlajPzfC54uC6aKSCMLNHVgLsmg5nOSBKYFoq9H7ta3UgD/h8ahtECfktfn 3VXFVGpWSRaGiJmmIJH+a39GH8oCr8JGqBHgGY9Qofr8rVOX4daApfkHB0ePJ9nMH7II k8lA== X-Gm-Message-State: AO0yUKXIGYbOmPC102uVzsN2g/zLTqbkCPVffFkbEYerTZZ+ZhFQIfVh Tot7slXwkpxRCEvE4IUsxi8HST1jDshLiE0E0hg= X-Google-Smtp-Source: AK7set/36x4f5lBnbFuGEfrsd6ki0a9Vfl4GxVK3Irq6WcUCWgGrHwFyVUIFu54zc7L9YWOwrVvXkwn9ZlL8zvq4mgY= X-Received: by 2002:aca:1c09:0:b0:384:2019:c201 with SMTP id c9-20020aca1c09000000b003842019c201mr1523637oic.8.1677929342682; Sat, 04 Mar 2023 03:29:02 -0800 (PST) MIME-Version: 1.0 References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> In-Reply-To: <87h6v1s0p4.fsf@melete.silentflame.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 4 Mar 2023 11:30:48 +0000 Message-ID: Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too To: Sean Whitton , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Mar 4, 2023 at 2:35=E2=80=AFAM Sean Whitton wrote: > > Hello, > > On Fri 03 Mar 2023 at 11:18AM -07, Sean Whitton wrote: > > > X-debbugs-cc: juri@linkov.net, joaotavora@gmail.com > > > > Many thanks to Juri and Joao for fixing #45763! It's a whole new world= ! > > > > I am a fido-mode user. I noticed that my custom bindings for the > > fido-mode minibuffer don't work for in-buffer completion. I think that > > icomplete--in-region-setup should compose in icomplete-fido-mode-map, i= n > > addition to icomplete-minibuffer-map, in the case that fido-mode is on? > > I noticed that icomplete-hide-common-prefix etc. are wrong too. > I think that icomplete--in-region-setup also needs to do something > equivalent to the setq-local in icomplete--fido-mode-setup. Yes, Sean, please report an Emacs -Q recipe for what you are trying to get working. I've now found a way to test this, and I was surprised at how easy it was, but also skeptical. As I remember analyzing it more than a year ago, and finding this a reasonbaly hard job. Also it seems to be completely broken for fido-vertical mode and icomplete-vertical-mode, so I think an approach that takes these cousin modes into consideration. All in all, I'm not sure we should be shipping this half-baked enhancement for emacs-29, at least not in this phase. I propose we revert it in emacs-29. I propose we revert it from there, keep the changes in master, and focus on making it more consistent there. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 13:56:20 2023 Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 18:56:20 +0000 Received: from localhost ([127.0.0.1]:37728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYX3M-0000vy-Cr for submit@debbugs.gnu.org; Sat, 04 Mar 2023 13:56:20 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYX3K-0000vg-JF for 61943@debbugs.gnu.org; Sat, 04 Mar 2023 13:56:18 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1AAC840007; Sat, 4 Mar 2023 18:56:09 +0000 (UTC) From: Juri Linkov To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora=22's?= message of "Sat, 4 Mar 2023 11:30:48 +0000") Organization: LINKOV.NET References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> Date: Sat, 04 Mar 2023 20:52:08 +0200 Message-ID: <861qm4fixz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, Eli Zaretskii , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > All in all, I'm not sure we should be shipping this half-baked > enhancement for emacs-29, at least not in this phase. I propose > we revert it in emacs-29. > > I propose we revert it from there, keep the changes in master, > and focus on making it more consistent there. The patch that I created fixed a bug where in-buffer completion erased the whole buffer so it needs to stay in emacs-29. Also for your convenience I pushed your patch that adds support for in-buffer completion to fido-mode in the hope that the patch is already in the finished state. However, if you think that fido-vertical mode and/or icomplete-vertical-mode needs more work to support in-buffer completions, please decide whether to revert it or to write an additional patch for these modes in emacs-29. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 14:03:02 2023 Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 19:03:02 +0000 Received: from localhost ([127.0.0.1]:37736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYX9q-00019h-KD for submit@debbugs.gnu.org; Sat, 04 Mar 2023 14:03:02 -0500 Received: from mail-oi1-f179.google.com ([209.85.167.179]:34417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYX9o-00019B-WD for 61943@debbugs.gnu.org; Sat, 04 Mar 2023 14:03:01 -0500 Received: by mail-oi1-f179.google.com with SMTP id e21so4295315oie.1 for <61943@debbugs.gnu.org>; Sat, 04 Mar 2023 11:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677956575; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=asmPAY9Vaod8RJEW++qAjxOkw+ahZrqr6+e5sN8SY+M=; b=bzy3yp0OUA+oL/TMX+wmrkFhCc3DxxQPZdS1PhnmAhMSDi2GfcnyGMqcmsUYjZJ8k0 7yMQr86CyurZV7OitbM8+aaGabYBb7zznUVmTbpZRTzlg/x5XGrxSe8glVbX6LcmU84t +iOi+vSARzlQfLZP1zVe1Gi5npT94bF2BxiC9ivXIywoBUxdVIK/QsQ0kOGZAU0ZKkoK O+uEL03jLvBUZ+/n5/BZGxqiuNq/tuq3pwE8O49imZiY2e/zCPl06d1rg0tlQeerhfPu UM70ljuYKzdoBnUZm/x9Re25oDtRXhaydy8aY9TwWGjiO5mJcktLusnirwvCSvGf61G/ mb3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677956575; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=asmPAY9Vaod8RJEW++qAjxOkw+ahZrqr6+e5sN8SY+M=; b=Sq2x6jD9M90rvPO1zqZBrY9WxHFIMp/Bl3nVBzXItbRGwX8a2pwq1915F+FomLgO0O PrBarHyD3F8FNsvVXDCto8ieA16d0NYTRA4X7D5diSJs2ALGER6Mw4cgheVMAbi88uRk 7qeUBnzV8XIFk1F7hrXTchp0rONtIObmOFVveHYnpB449kgCIhWopc0X7UHdDybU/YeL gbJeuOHGpVharjM3ISq2W3dMJPrjpqWZjCKIcvZjJKpQmpFGB06B4LpGRzYNm7uWsQzO 8SPbZlq3M9lrjc/mzAPfqLR4+F/94sLsuamjVlHPsZvOyzj8fk0vLqk8Z6KAxhhrvUYI xCNw== X-Gm-Message-State: AO0yUKVPgJKX3Esl5V2NhEE6FGczvu5dLX7ULcqAwaDX5dK9q6OHA49k Ut2faAbgtLj7qFSg8tSMTyF6ei79hkMvgUQo2mjKu59Q X-Google-Smtp-Source: AK7set9UtfiYH74waNYR16EDBJCcGkNls9AiAFNNZY+i5dI51bRnnT/bb4fNqC7BtQSncOyaK4pXUdZbu1euEvSrgx0= X-Received: by 2002:a05:6808:7c5:b0:37f:a3b7:c877 with SMTP id f5-20020a05680807c500b0037fa3b7c877mr1891455oij.8.1677956575389; Sat, 04 Mar 2023 11:02:55 -0800 (PST) MIME-Version: 1.0 References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <861qm4fixz.fsf@mail.linkov.net> In-Reply-To: <861qm4fixz.fsf@mail.linkov.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 4 Mar 2023 19:04:41 +0000 Message-ID: Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too To: Juri Linkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, Eli Zaretskii , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Mar 4, 2023 at 6:56=E2=80=AFPM Juri Linkov wrote: > fido-vertical mode and/or icomplete-vertical-mode needs more work > to support in-buffer completions, please decide whether to revert it > or to write an additional patch for these modes in emacs-29. OK, I'll revert just the fido-mode-specific patch in emacs-29. But are you sure that icomplete-in-buffer works consistently for icomplete-mode? If it doesn't it'll need more changes, and -- crucially -- changes that don't break other icomplete cousins like fido and vertical modes. If it does work OK, then no problem. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 14:16:16 2023 Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 19:16:16 +0000 Received: from localhost ([127.0.0.1]:37755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYXMe-0001Yr-A1 for submit@debbugs.gnu.org; Sat, 04 Mar 2023 14:16:16 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:57143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYXMd-0001Yc-25 for 61943@debbugs.gnu.org; Sat, 04 Mar 2023 14:16:15 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 747A3240002; Sat, 4 Mar 2023 19:16:06 +0000 (UTC) From: Juri Linkov To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora=22's?= message of "Sat, 4 Mar 2023 19:04:41 +0000") Organization: LINKOV.NET References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <861qm4fixz.fsf@mail.linkov.net> Date: Sat, 04 Mar 2023 21:14:44 +0200 Message-ID: <86h6v0e3bv.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, Eli Zaretskii , Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> fido-vertical mode and/or icomplete-vertical-mode needs more work >> to support in-buffer completions, please decide whether to revert it >> or to write an additional patch for these modes in emacs-29. > > OK, I'll revert just the fido-mode-specific patch in emacs-29. But are > you sure that icomplete-in-buffer works consistently for icomplete-mode? > If it doesn't it'll need more changes, and -- crucially -- changes that > don't break other icomplete cousins like fido and vertical modes. > If it does work OK, then no problem. icomplete-in-buffer works consistently in all my tests. But maybe Sean will show more recipes if there are more problems. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 15:44:27 2023 Received: (at 61943) by debbugs.gnu.org; 4 Mar 2023 20:44:27 +0000 Received: from localhost ([127.0.0.1]:37885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYYjz-0004CL-3u for submit@debbugs.gnu.org; Sat, 04 Mar 2023 15:44:27 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYYjx-0004C5-4e for 61943@debbugs.gnu.org; Sat, 04 Mar 2023 15:44:25 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 07BD05C0112; Sat, 4 Mar 2023 15:44:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 04 Mar 2023 15:44:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1677962659; x=1678049059; bh=q0DUZRBybP5/JTIJCYUw9pvpbPWjVpfA1he s2g0b5fU=; b=zUac+Wg5M2nETIveAEf7rPjuZ8wRNszuLa604PZ3cG9OkJB7HH+ ZKet8Ygz/jcNnOfOI4ktBSvTMDveTwVkT3Z1mT5QWWyhU/JhgCi0QqCiQCLsOUmZ vMh5wbcJGzrSVrqWTfD5UvqaA1uenlYw6w377uUFreWWyHRn/SEBYUag+rRiljrW ofept6mVd1qb7boT1i2EMUaB4zfnWGIaqG3YUc8MMLGM7U4XwzWh3ltfTaQcrPjA DHPVePZlmz3r+b9B8no4OhsBgcBmvlijsGgcd8AWFkMRVPm+iEJ1Va3ugPsaRd/E r4GjBYjKmFxUfE5TKthxL0opHng50RW4Jsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677962659; x= 1678049059; bh=q0DUZRBybP5/JTIJCYUw9pvpbPWjVpfA1hes2g0b5fU=; b=O BaGsK970IOaaH7RVLvyli1c6UXaZkGskWMQAAkj89r7SkRsa1FAB2M05r3bxePwE LqTNjrqu24h0drdFBOcawQkTKku5p+JUrZhIWvku+ua8Oa2GccSkH9EFtDul3dvV sDBxcfeIWwS5BIIoWI66bIIeinSZvWoZglxM7ksxMLws99IiON2vzVWQyp6cq0jL SM2HzGUPUgbqek/h9zT0FWz67PPBVk9JvO3Q4FAbHGerzKdiKzjuXY94sUL7pd5Y IMjz/UPMaeOo7ydQHu4IcOzmVKTaPaEC+gfcb8N2MCfy1IY86iMeX8oHGq1XndJQ 0DADHGyoj2Oc17vwxASYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtuddgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnhepudfgheeltdfggeekvdduteehffdvvdefgeevudelheeh gfeghefhhfevkeetjeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 4 Mar 2023 15:44:18 -0500 (EST) Received: by melete.silentflame.com (Postfix, from userid 1000) id 45A447E72A1; Sat, 4 Mar 2023 13:44:17 -0700 (MST) From: Sean Whitton To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , 61943@debbugs.gnu.org, juri@linkov.net Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Sat, 4 Mar 2023 11:30:48 +0000") References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> Date: Sat, 04 Mar 2023 13:44:17 -0700 Message-ID: <87cz5os0v2.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Sat 04 Mar 2023 at 11:30AM GMT, Jo=C3=A3o T=C3=A1vora wrote: > On Sat, Mar 4, 2023 at 2:35=E2=80=AFAM Sean Whitton wrote: >> >> Hello, >> >> On Fri 03 Mar 2023 at 11:18AM -07, Sean Whitton wrote: >> >> > X-debbugs-cc: juri@linkov.net, joaotavora@gmail.com >> > >> > Many thanks to Juri and Joao for fixing #45763! It's a whole new worl= d! >> > >> > I am a fido-mode user. I noticed that my custom bindings for the >> > fido-mode minibuffer don't work for in-buffer completion. I think that >> > icomplete--in-region-setup should compose in icomplete-fido-mode-map, = in >> > addition to icomplete-minibuffer-map, in the case that fido-mode is on? >> >> I noticed that icomplete-hide-common-prefix etc. are wrong too. >> I think that icomplete--in-region-setup also needs to do something >> equivalent to the setq-local in icomplete--fido-mode-setup. > > Yes, Sean, please report an Emacs -Q recipe for what you are trying > to get working. Alright, how about this: (setq icomplete-in-buffer t) (fido-mode 1) M-x eshell touch foobarbaz C-x C-f fbb =3D> matches the file C-g type "ls fbb" TAB =3D> No matches C-g (setq completion-styles '(flex)) TAB =3D> matches the file & expands but with fido-mode you shouldn't need to set completion-styles like this. (In Eshell TAB is completion-at-point and C-M-i is something else.) --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 18:06:43 2023 Received: (at 61943) by debbugs.gnu.org; 21 Mar 2023 22:06:43 +0000 Received: from localhost ([127.0.0.1]:32850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pek7v-0006SU-E7 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 18:06:43 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pek7t-0006SH-G9 for 61943@debbugs.gnu.org; Tue, 21 Mar 2023 18:06:42 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0C7485C0079; Tue, 21 Mar 2023 18:06:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 21 Mar 2023 18:06:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm1; t=1679436396; x=1679522796; bh=v3TIAzgb1pUTADCDlhzg/EBY5 e6Az+DJi2VrP5UnF38=; b=FV3sQq2LGJ0QsIjTnDEtrr3eiD/KxRvYvE1oDK4q8 fpfYBALS99PFp4Gsa4axtLHLzIzoSldOi/1lgcVbzbmJaLy8EVc8/7j/vTX3ACGG aWf/IHv6xgxrJNIFHq4Cjwu9N3K4Si79jIKTfiOCsKEjcX/Z3Cn48PlrQGpxVOc2 Qwe1eOnAhTXgpriBIzoOF3ABCPCMgtnTQgAYoceza59Zkkyew4qv+fG74g3PRxyR iwV9oX6Q/H4eq4FuXw3VTVbTeJ2Tr4YlPjsART4QThURw+8lrhdEw9yNL/NYOiQL YJHM51MFuBfNGFScWioAi6KFXZ4RQxCFUSnMI+hfn0y0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679436396; x=1679522796; bh=v3TIAzgb1pUTADCDlhzg/EBY5e6Az+DJi2V rP5UnF38=; b=USDHMhroeUkOgwNbOCzoVXSlbKVkski8qUlt7kXIv4QflRXghjZ HI2JVInHmdwu3KyUBT889GuGRpyltpwcPnMN/7AKa5hkmqXkXt3Kuq3Rstd5w1RL Ki3PfRB6NzYC6eAYnXzpoMV61g3lOZ9tT+KkSeWKRELdloDGx1vbFwUwBxhq69wg jjI14unE85lSYuvLqgfuuReff7ci6MF9a3zOKktwa+sgnnBDKbfkRmof5tIpHXuv +0eCQ2YriMBpEMQ1617qetQCl31YBFyNDesFkzYEHPIjcazngpKUf+ONS5fRRe+A PewFd+r3RRUkUwApMWP7P+60bAkWBAR0auw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegtddgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtgfesthhqtddttderjeenucfhrhhomhepufgv rghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmh gvqeenucggtffrrghtthgvrhhnpefffefhjedugedutddukeejkeeuveevvdeigefhgeel teeuhfekgeekhfeljedvudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Mar 2023 18:06:35 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id BE1B57E4398; Tue, 21 Mar 2023 15:06:34 -0700 (MST) From: Sean Whitton To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: <87cz5os0v2.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 04 Mar 2023 13:44:17 -0700") References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <87cz5os0v2.fsf@melete.silentflame.com> Date: Tue, 21 Mar 2023 15:06:34 -0700 Message-ID: <87y1npg3o5.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Jo=C3=A3o, On Sat 04 Mar 2023 at 01:44PM -07, Sean Whitton wrote: > On Sat 04 Mar 2023 at 11:30AM GMT, Jo=C3=A3o T=C3=A1vora wrote: > >> Yes, Sean, please report an Emacs -Q recipe for what you are trying >> to get working. > > Alright, how about this: > > (setq icomplete-in-buffer t) > (fido-mode 1) > M-x eshell > touch foobarbaz > C-x C-f fbb =3D> matches the file > C-g > type "ls fbb" > > TAB =3D> No matches > C-g > (setq completion-styles '(flex)) > TAB =3D> matches the file & expands > > but with fido-mode you shouldn't need to set completion-styles like this. > > (In Eshell TAB is completion-at-point and C-M-i is something else.) May I ask whether you've had a chance to look into this yet? --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 19:41:09 2023 Received: (at 61943) by debbugs.gnu.org; 21 Mar 2023 23:41:09 +0000 Received: from localhost ([127.0.0.1]:32907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pelbJ-0000Vx-5O for submit@debbugs.gnu.org; Tue, 21 Mar 2023 19:41:09 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:40789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pelbH-0000Vj-9W for 61943@debbugs.gnu.org; Tue, 21 Mar 2023 19:41:07 -0400 Received: by mail-oi1-f174.google.com with SMTP id r36so12446642oiw.7 for <61943@debbugs.gnu.org>; Tue, 21 Mar 2023 16:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679442061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t2fRvnY7FbtIsElKIaNB1FjyVjb1k9m2enzH3lGLveM=; b=Khq3B9x5DBPOEhelCaJ8lPpWuvpxDUo8lEqWfXcTlF3PIfZ2W9UNA3qlNayhdE0GJu NyiICVL/u9mIICNLccN2tmInQS1Eio3V/Vm0lYT6dxhySxAKqgrFrVixnX6uWkntKBYx kOCnahvcsvslI0NN05+VUJYnOXFJRRSrBVki+09rSHDNMSq/nr880kepJz7CrPrtbxH3 wByg5uM+mLAWqG8YpqI7eMlYU3vqoK9ZMyzNTzgANtz93QSjcKpnYUdIc0uvG0BxY6d2 +29ax0JcihbQnwfsFubPZ3XSnTiIZpO4V+j7JszBIr6piI3CFYwh75egCUI3cP/O2+jt UqPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679442061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t2fRvnY7FbtIsElKIaNB1FjyVjb1k9m2enzH3lGLveM=; b=P6scO/rMvbRorkTv8Ov3D3bxvpyI0PfJaixHdFqfC8oDgvy2mrMzW1ggWXR98KI1nn ZFN5KxPWIEPA/0Y94mv87HtA7YYspzAm0t2/rWoxFfgSp4xYk5NUiy0JWVB1mXuoH2vF CEHMJZlq/TSqRPZfCFnEC/X/jU4/cNU9Rz1GSmRRLaPgxLuy/PUFpMdxOD2izlbiy1Au zqSUDujXJJ6eCoG26+6VxKpVLpxmcjiaZvzObEN4Y9NukWXDFJG9+44Vi6GVMRo+Wx6j 2uNlGINMLdVGbWDiXKa7KxobbBWd6XS0R0PxfdSjwSHP6lM+JMkieNHjzclFB36wY4RN Byzw== X-Gm-Message-State: AO0yUKXgzLXP7L1ZTo0aTuaTPWKuatK2Sepr431I0LgpCBgyhmJmkUhO nrxud9I9UhRNOY0AMO08uGdD/6hbo13pSGB7WeA= X-Google-Smtp-Source: AK7set96GfBCBEV3TnW7iwsPI/np/+Bx0aQWj/te7ijNNjS9JHGwIIjTQt01z5LP+DQ5xG/aGfaEuSNiigGI8IV4BLY= X-Received: by 2002:a05:6808:1526:b0:384:1cf9:912e with SMTP id u38-20020a056808152600b003841cf9912emr348598oiw.5.1679442061670; Tue, 21 Mar 2023 16:41:01 -0700 (PDT) MIME-Version: 1.0 References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <87cz5os0v2.fsf@melete.silentflame.com> <87y1npg3o5.fsf@melete.silentflame.com> In-Reply-To: <87y1npg3o5.fsf@melete.silentflame.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 21 Mar 2023 23:40:50 +0000 Message-ID: Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too To: Sean Whitton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Mar 21, 2023 at 10:06=E2=80=AFPM Sean Whitton wrote: > > Hello Jo=C3=A3o, > > On Sat 04 Mar 2023 at 01:44PM -07, Sean Whitton wrote: > > > On Sat 04 Mar 2023 at 11:30AM GMT, Jo=C3=A3o T=C3=A1vora wrote: > > > >> Yes, Sean, please report an Emacs -Q recipe for what you are trying > >> to get working. > > > > Alright, how about this: > > > > (setq icomplete-in-buffer t) > > (fido-mode 1) > > M-x eshell > > touch foobarbaz > > C-x C-f fbb =3D> matches the file > > C-g > > type "ls fbb" > > > > TAB =3D> No matches > > C-g > > (setq completion-styles '(flex)) > > TAB =3D> matches the file & expands > > > > but with fido-mode you shouldn't need to set completion-styles like thi= s. > > > > (In Eshell TAB is completion-at-point and C-M-i is something else.) > > May I ask whether you've had a chance to look into this yet? Yes you may, but no, I haven't. Icomplete and Fido and cousins, it's true. But icomplete-in-buffer wasn't around (at least wasn't in any way functional) when Fido was born. So I don't have any plans of integrating this part of icomplete in Fido, because it's not really how I envision Fido being used for non-minibuffer completion. I have other plans for a future fido-in-buffer where the feedback overlay -- in horizontal or vertical form -- shows in the echo area instead. That said, if a simple patch to make icomplete-in-buffer work with fido-mode can be achieved, I have no problem reviewing it. As you suggested, it could be as simple as integrating icomplete--fido-mode-setup into icomplete--in-region-setup. But that is relatively tricky as whatever variables are set when entering this mode but be properly reset when leaving it. Doing this elegantly might not be hard, but it's not trivial either. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 13:25:16 2023 Received: (at 61943) by debbugs.gnu.org; 22 Mar 2023 17:25:16 +0000 Received: from localhost ([127.0.0.1]:36530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf2D5-00044L-Lv for submit@debbugs.gnu.org; Wed, 22 Mar 2023 13:25:15 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:34623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf2D3-000447-Dc for 61943@debbugs.gnu.org; Wed, 22 Mar 2023 13:25:14 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 137953200786; Wed, 22 Mar 2023 13:25:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 22 Mar 2023 13:25:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm1; t=1679505906; x=1679592306; bh=h4u0q3A0L0GXlX0+/qvRbowqe eczI6Td4JUmWVYUV8Q=; b=WaO/YU1JVl72TBv2z0LAI3aHjoMtJ6ekk4ks9nStF gUdCklWmuITdQsDba0OiwKKllEBVBvrYu6VuGnGh9OneenpJmmJTQRUcsSnaHfpy FyMcTJcFJz1oBqShXVAMqB0GkQT7lxV/CCsWtRv6wdeRNwE+sDMxm6zEbMp+gI65 DPHxJBjYaU14fuFqziM7LGcAx028cQK0EmN/2rXC0nEnbmIut/VrR31DNBg5DCN0 KiSOVmN3co0JUBYAFokh11m35HVEpwlsfgFT1yU8tGoeBxsXEsBRkv+q9yEVncEJ aiDZ0XQiSCi5mBprtGR/SeprIg4GIz23oDFcijhSmyNMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679505906; x=1679592306; bh=h4u0q3A0L0GXlX0+/qvRbowqeeczI6Td4JU mWVYUV8Q=; b=slT2CEZ2DY1WZi+nEHN0QJ5tk4jvuC75RKO5Hb/zhUTFpK6Fgzm 1wAsNL5kGDzbhdn0tLAu3yYPmNnEY2AifjKul0Sso6sUrvuPlahKk30wOFqk4A0Y KR3kMTVXBRn6ZlIXvqm53NT9tX7P8tb6f21N/sPNAV0CYH04t9yK5z1UhYC9pEnl nSc+emDJHY93ZnCoLzmYdw4BfmJc2rJu3CLTJ8Df/wvMyo+YcMWxpd18aNG/DDLs xiLuONn5pcOfz4W9Im3weFmLybpDt7YiNCbt0YMxaxhyQAvLTptYpwsYuDeI6Cyq 2FSvYz3Us8sOvKcHhvFrPGeYEip1+UZmi1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegvddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtgfesthhqtddttderjeenucfhrhhomhepufgv rghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmh gvqeenucggtffrrghtthgvrhhnpefffefhjedugedutddukeejkeeuveevvdeigefhgeel teeuhfekgeekhfeljedvudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Mar 2023 13:25:05 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7AC267E0630; Wed, 22 Mar 2023 10:25:04 -0700 (MST) From: Sean Whitton To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 21 Mar 2023 23:40:50 +0000") References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <87cz5os0v2.fsf@melete.silentflame.com> <87y1npg3o5.fsf@melete.silentflame.com> Date: Wed, 22 Mar 2023 10:25:04 -0700 Message-ID: <87pm90g0lr.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 21 Mar 2023 at 11:40PM GMT, Jo=C3=A3o T=C3=A1vora wrote: > Yes you may, but no, I haven't. Icomplete and Fido and cousins, > it's true. But icomplete-in-buffer wasn't around (at least wasn't > in any way functional) when Fido was born. So I don't have > any plans of integrating this part of icomplete in Fido, because > it's not really how I envision Fido being used for non-minibuffer > completion. > > I have other plans for a future fido-in-buffer where > the feedback overlay -- in horizontal or vertical form -- shows > in the echo area instead. Interesting idea. What do you think the advantages are? It's breaking with how such things usually work, in Emacs and in other editors. Since you're up for reviewing a patch to make icomplete-in-buffer work with fido-mode, I assume you are interested in keeping both working? > That said, if a simple patch to make icomplete-in-buffer work with > fido-mode can be achieved, I have no problem reviewing it. > As you suggested, it could be as simple as integrating > icomplete--fido-mode-setup into icomplete--in-region-setup. > But that is relatively tricky as whatever variables are set > when entering this mode but be properly reset when leaving it. > Doing this elegantly might not be hard, but it's not trivial > either. Currently icomplete--in-region-setup sets completion-show-inline-help locally and then unconditionally kills that local variable. So we could do the same for fido-mode's variables, but is it possible that a major mode might want to set one of them? Otherwise, if there is to be some mechanism for restoring old buffer-local values, then we should use it for completion-show-inline-help too. --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 14:41:59 2023 Received: (at 61943) by debbugs.gnu.org; 22 Mar 2023 18:41:59 +0000 Received: from localhost ([127.0.0.1]:36719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf3PK-0000G7-KG for submit@debbugs.gnu.org; Wed, 22 Mar 2023 14:41:58 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:46907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pf3PI-0000Fs-RX for 61943@debbugs.gnu.org; Wed, 22 Mar 2023 14:41:57 -0400 Received: by mail-wm1-f50.google.com with SMTP id l15-20020a05600c4f0f00b003ed58a9a15eso12099843wmq.5 for <61943@debbugs.gnu.org>; Wed, 22 Mar 2023 11:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679510511; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J+k/WvXrJKtaZXm+Kp87wM8klxw774PvXcFBbXWVcMM=; b=R52LQQCGBgV2YBbxZsm+e3FrTOxvRB/6irC5MovWj0O/vEv//pKV0/R5bYY1iMWeDL an0jYEdYqIRSTfOYNRusn/xOgvN6WeTni+P1XKbaBxIYB/YYshVsWm5SGhjjq212iMkE BBh/K+g+dl0mh0GhHk7cNqMdU0884Yo5Cla1lw95dIcpS7Xt/PkuG+BAod6u6taG9Dh3 HGt7cNl73zvQOG+Mj2pR9T1Sn7IX+77ai7QkHqsGy04EqQGOwf7H6TOBWWEpxdP7nM3T ILtrp52qCzEsAN3bIYR0TwpYDP6vo7VFgaPYN2UAA7cGPt/tmt0CI8jWDAAWLtd9yv4Z caFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679510511; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J+k/WvXrJKtaZXm+Kp87wM8klxw774PvXcFBbXWVcMM=; b=KHEca3Pbk9qGPjwbXOdfS9KNRFJOjiyosFBi+tdIbBGApPL1g9DWP0CSPpDcrmemdX a8RzxDtwuKoqQDldJnXVnOYwU+SSOOqgOH8ohLkriNxQHA6SOFMauMoIow3KI+IyDYuR eW5w4Rs3F1fXtszRUj8a1nOVS/4koDkFGWMNf85UnS7SVpI1RcravAsNN0qRxAcXjomc TWmtizzcVlC5awpP7OBOhdVmrsxr4/ZA388vzJ61cw31wjRS9wes7sRXUyWG3SHzsMoD unVZqoNq+jGb7UadIwQ1sbCxtcCQPSnnT7cgt2EmHV52VAMDn/x9Nu9i333MI5Qmsd9E t6NA== X-Gm-Message-State: AO0yUKWZvFpnKXtHQYPekLnty0OccjcH9u4RyCgkwGdqcWhNTZPzHilJ fvsF2IskIAp3keSYEsjYrX4= X-Google-Smtp-Source: AK7set+mdY7XY1K4pLBgrwM0pfRX7D/CNMYzY7OF/CK8ZOaSQufu0/9pQLGaqH2GO2S5d1Oni516Vw== X-Received: by 2002:a7b:c8c4:0:b0:3ea:f75d:4626 with SMTP id f4-20020a7bc8c4000000b003eaf75d4626mr351657wml.38.1679510510988; Wed, 22 Mar 2023 11:41:50 -0700 (PDT) Received: from krug ([87.196.72.142]) by smtp.gmail.com with ESMTPSA id m16-20020a7bcb90000000b003edf2dc7ca3sm10286778wmi.34.2023.03.22.11.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 11:41:50 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Sean Whitton Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: <87pm90g0lr.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 22 Mar 2023 10:25:04 -0700") References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <87cz5os0v2.fsf@melete.silentflame.com> <87y1npg3o5.fsf@melete.silentflame.com> <87pm90g0lr.fsf@melete.silentflame.com> Date: Wed, 22 Mar 2023 18:43:51 +0000 Message-ID: <87pm90vd7c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: > Hello, > > On Tue 21 Mar 2023 at 11:40PM GMT, Jo=C3=A3o T=C3=A1vora wrote: > >> Yes you may, but no, I haven't. Icomplete and Fido and cousins, >> it's true. But icomplete-in-buffer wasn't around (at least wasn't >> in any way functional) when Fido was born. So I don't have >> any plans of integrating this part of icomplete in Fido, because >> it's not really how I envision Fido being used for non-minibuffer >> completion. >> >> I have other plans for a future fido-in-buffer where >> the feedback overlay -- in horizontal or vertical form -- shows >> in the echo area instead. > > Interesting idea. What do you think the advantages are? It's breaking > with how such things usually work, in Emacs and in other editors. I wouldn't call it breaking, it's just a different UI. Fido modes (fido-mode and fido-vertical-mode) work in the minibuffer which shares its display space with the echo area already, so I wouldn't think it's that odd. > Since you're up for reviewing a patch to make icomplete-in-buffer work > with fido-mode, I assume you are interested in keeping both working? As I said, only if an elegant enough patch can be devised for the current icomplete-in-buffer functionality. >> That said, if a simple patch to make icomplete-in-buffer work with >> fido-mode can be achieved, I have no problem reviewing it. >> As you suggested, it could be as simple as integrating >> icomplete--fido-mode-setup into icomplete--in-region-setup. >> But that is relatively tricky as whatever variables are set >> when entering this mode but be properly reset when leaving it. >> Doing this elegantly might not be hard, but it's not trivial >> either. > > Currently icomplete--in-region-setup sets completion-show-inline-help > locally and then unconditionally kills that local variable. So we could > do the same for fido-mode's variables, but is it possible that a major > mode might want to set one of them? > > Otherwise, if there is to be some mechanism for restoring old > buffer-local values, then we should use it for > completion-show-inline-help too. Yes, that's what's needed. "killing the variable" isn't the right approach since that erases a pre-override buffer-local setting. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 15:13:37 2023 Received: (at 61943) by debbugs.gnu.org; 23 Mar 2023 19:13:37 +0000 Received: from localhost ([127.0.0.1]:39342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfQNV-0002I3-69 for submit@debbugs.gnu.org; Thu, 23 Mar 2023 15:13:37 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfQNT-0002Ho-6B for 61943@debbugs.gnu.org; Thu, 23 Mar 2023 15:13:35 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 112135C00BE; Thu, 23 Mar 2023 15:13:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 23 Mar 2023 15:13:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm1; t=1679598809; x=1679685209; bh=WlxYD32/amML86aVjP8NSyA34 ZF2GlInqKD8wUyWvIU=; b=dw9wsVT2t3mhCN/65cVcBR7ssgsA1OoQWNwUnor4f /AwvaSr2cHJy7E+adWEwlD2SHcjSXOrNZmp1mxB5nLR/rNiogEKoRQeJq04prNe/ IoXqYN67TS9GKVZ4RDx7wuQJG+RxHF2UqM4qnTU119Pz0aZP1tlXlR/gfpLA+rNg NneQ9+zAOcg75ySnF0CXqPew0cLarptDBrjkH9IR7kIzYAXawPfGn/4yLRNyQe6O 4tz0UErv5FSFIwANvuQM9dOIm9j677WVpO4TVS6IcO4q81aSMHowONF/d6OhmbxV PHYsYnSlKg/p8je26/WaRcmlWuqBZYamKKHdF+c21I5Zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679598809; x=1679685209; bh=WlxYD32/amML86aVjP8NSyA34ZF2GlInqKD 8wUyWvIU=; b=C8LcweR94OdePYlyiSfjM5HnZjrpmIG5/zA/W5pr4rPuOs3CMOs C8v0vpF2uwOf2WuTCV6C6VNDco0PjtA+2ImfLPgfHfudomGXJ2CbhyOoGVKSnzVy 3DGtLNzTFHZBGu70MQDGax3zSQzKjkAVVcB6+A0m86+CJQSCtTm9NZNxIRDDTjJG oxvJk9tp9gAcHKDQpA9fS/nYc3udqZROTOMq5oo74NV4/O3z0snHJKrOiF5J7gxA kC/7M+JHbIJlOvYFBCdNgywwraTI1gS4Ez+yv5SyU68oLuvXft/64m/Ev7lHjbRi q4PvQheOWE4hf/GbRv/QPmIauUkEZV6d1ew== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeggedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtgfesthhqtddttderjeenucfhrhhomhepufgv rghnucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmh gvqeenucggtffrrghtthgvrhhnpefffefhjedugedutddukeejkeeuveevvdeigefhgeel teeuhfekgeekhfeljedvudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Mar 2023 15:13:28 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 8230A7EEC8A; Thu, 23 Mar 2023 12:13:27 -0700 (MST) From: Sean Whitton To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too In-Reply-To: <87pm90vd7c.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Wed, 22 Mar 2023 18:43:51 +0000") References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <87cz5os0v2.fsf@melete.silentflame.com> <87y1npg3o5.fsf@melete.silentflame.com> <87pm90g0lr.fsf@melete.silentflame.com> <87pm90vd7c.fsf@gmail.com> Date: Thu, 23 Mar 2023 12:13:27 -0700 Message-ID: <87h6ubffhk.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61943 Cc: 61943@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 22 Mar 2023 at 06:43PM GMT, Jo=C3=A3o T=C3=A1vora wrote: > Sean Whitton writes: > >> Interesting idea. What do you think the advantages are? It's breaking >> with how such things usually work, in Emacs and in other editors. > > I wouldn't call it breaking, it's just a different UI. Fido modes > (fido-mode and fido-vertical-mode) work in the minibuffer which shares > its display space with the echo area already, so I wouldn't think it's > that odd. Looking forward to trying it. >> Since you're up for reviewing a patch to make icomplete-in-buffer work >> with fido-mode, I assume you are interested in keeping both working? > > As I said, only if an elegant enough patch can be devised for the > current icomplete-in-buffer functionality. Cool. --=20 Sean Whitton