From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 11:58:44 2023 Received: (at submit) by debbugs.gnu.org; 3 Mar 2023 16:58:44 +0000 Received: from localhost ([127.0.0.1]:33839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY8jz-0005x0-Tx for submit@debbugs.gnu.org; Fri, 03 Mar 2023 11:58:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:58792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY8jx-0005wi-O9 for submit@debbugs.gnu.org; Fri, 03 Mar 2023 11:58:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY8jv-0004oR-MU for guix-patches@gnu.org; Fri, 03 Mar 2023 11:58:39 -0500 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY8js-0004kk-Mr for guix-patches@gnu.org; Fri, 03 Mar 2023 11:58:38 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id 5305AFF809; Fri, 3 Mar 2023 16:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1677862711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=f0mIwDO2g/agapUGNspNPJ9e4JjggIwdHBzRujsYULk=; b=BWozCE3KRTNCbSqGAu6wIVnTMhRyCrcpvb8VURJL/EyGbVqnP6YdrtGe6l+VbfOp73cNWj +aGNKZUMB4xdVz1wNe6MYC/xm2dkCgwLVwm/JvQdPkemL3oItF4zFiKSuL7wLiFVPXjwlG MEL4gfahKYY+V2q4vYe5X1L79Yb5PN6dl+Y98Y+Rl/96PWa1ysdNvhNN0/uiJ/UmZweW1B aUwYRFVygBdrln+KACEPFBh1gc4rfIt03J/iMiCaeseRkqTlXtXQqeRBLL6OnGM2OYLUI+ EGNirH7pWOGlL/e1xtDQR7/geN2uF7Vkq2Wyj44VgozgcAdDT/FhwsjJ5mHcRw== From: conses To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f. Message-Id: Date: Fri, 03 Mar 2023 17:58:26 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=contact@conses.eu; helo=relay9-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: contact@conses.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.20.1c98f6f. [source]: Remove fix-docstring-test.patch. [propagated-inputs]: Remove emacs-shut-up. --- gnu/packages/emacs-xyz.scm | 52 +++++++++++++++++++------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 3f7fcf4481..a3535728f8 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -23126,31 +23126,31 @@ (define-public emacs-download-region (license license:gpl3+)))) (define-public emacs-helpful - (package - (name "emacs-helpful") - (version "0.19") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/Wilfred/helpful") - (commit version))) - (file-name (git-file-name name version)) - (sha256 - (base32 "0qwsifzsjw95l83m7z07fr9h1sqbhggwmcps1qgbddpan2a8ab8a")) - ;; Cherry-picked from upstream, remove when bumping to 0.20. - (patches (search-patches "emacs-helpful-fix-docstring-test.patch")))) - (build-system emacs-build-system) - (propagated-inputs - (list emacs-elisp-refs emacs-dash emacs-s emacs-f emacs-shut-up)) - (native-inputs - (list emacs-ert-runner emacs-undercover)) - (arguments - `(#:tests? #t - #:test-command '("ert-runner"))) - (home-page "https://github.com/Wilfred/helpful") - (synopsis "More contextual information in Emacs help") - (description "@code{helpful} is an alternative to the built-in Emacs help + (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9") + (revision "0")) + (package + (name "emacs-helpful") + (version (git-version "0.20" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Wilfred/helpful") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l")))) + (build-system emacs-build-system) + (propagated-inputs + (list emacs-elisp-refs emacs-dash emacs-s emacs-f)) + (native-inputs + (list emacs-ert-runner emacs-undercover)) + (arguments + `(#:tests? #t + #:test-command '("ert-runner"))) + (home-page "https://github.com/Wilfred/helpful") + (synopsis "More contextual information in Emacs help") + (description "@code{helpful} is an alternative to the built-in Emacs help that provides much more contextual information. @itemize @@ -23169,7 +23169,7 @@ (define-public emacs-helpful @item Trace, disassemble functions from inside Helpful. This is discoverable and doesn't require memorisation of commands. @end itemize\n") - (license license:gpl3+))) + (license license:gpl3+)))) (define-public emacs-logview (package -- 2.39.1 -- Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 12:00:06 2023 Received: (at 61941) by debbugs.gnu.org; 3 Mar 2023 17:00:06 +0000 Received: from localhost ([127.0.0.1]:33844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY8lK-000623-Ej for submit@debbugs.gnu.org; Fri, 03 Mar 2023 12:00:06 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:59885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY8lH-00060x-So for 61941@debbugs.gnu.org; Fri, 03 Mar 2023 12:00:04 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id 8A4CFE000E; Fri, 3 Mar 2023 16:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1677862797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IypvL7Tt4xqmgm8T8aKA6LgDpIOhJQXa2IbtKU7/ICo=; b=c5MFNjkbPujlB5lxWlH8qNYvkN1nxarZal8f+JScnRcX9c2ecYiGqjF2yVmPpP1fESpq4/ fyTYkYIFHHiv08k32oCKqx4h7pfr1DZGNuK4GM7Rwv89mlfQG5wkx5QrgkcJrpW84ynIL9 aRCiMjcTT8X9GQQrhQYheC9OL2xictvG5tZI5HoJYfDUxhvkLKLalXPepnTlCWFejaOiL2 xR63sn4CjByEufMjB+r+u3M6WtT+c1CggjL+Y2Tte8URqS4OehgJkKitnfL1us8aFPnF3d ay3VZcIJuIzoprS9/WNhMvgEiWMW5QIxPfqAZUvNRn+gXx11IZPOlRj1/yLqvQ== From: conses To: 61941@debbugs.gnu.org Subject: [PATCH 2/2] gnu: Remove unused emacs-helpful-fix-docstring-test.patch. In-Reply-To: References: Message-Id: <04d652b97d0cb534e1963263ad5e2ca6b4e52c15.1677862554.git.contact@conses.eu> Date: Fri, 03 Mar 2023 17:59:54 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61941 Cc: contact@conses.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --- .../emacs-helpful-fix-docstring-test.patch | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 gnu/packages/patches/emacs-helpful-fix-docstring-test.p= atch diff --git a/gnu/packages/patches/emacs-helpful-fix-docstring-test.patch b/= gnu/packages/patches/emacs-helpful-fix-docstring-test.patch deleted file mode 100644 index de40010fa2..0000000000 --- a/gnu/packages/patches/emacs-helpful-fix-docstring-test.patch +++ /dev/null @@ -1,18 +0,0 @@ -This patch fixing a build failure has been cherry-picked from upstream. -Originally submitted as pull request by Erik =C5=A0abi=C4=8D. -See also . -diff --git a/test/helpful-unit-test.el b/test/helpful-unit-test.el -index a07aa8e..8a95129 100644 ---- a/test/helpful-unit-test.el -+++ b/test/helpful-unit-test.el -@@ -119,7 +119,9 @@ bar"))) - (should - (equal - (helpful--docstring #'test-foo-advised t) -- "Docstring here too."))) -+ (if (version< emacs-version "28") -+ "Docstring here too." -+ "Docstring here too.\n\nThis function has :around advice: `ad-Advice-= test-foo-advised'.")))) -=20 - (defun test-foo-no-docstring () - nil) --=20 2.39.1 --=20 Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 09:58:10 2023 Received: (at 61941) by debbugs.gnu.org; 8 Mar 2023 14:58:10 +0000 Received: from localhost ([127.0.0.1]:49872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZvF3-0006hN-TL for submit@debbugs.gnu.org; Wed, 08 Mar 2023 09:58:10 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:44815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZvF1-0006gs-NA for 61941@debbugs.gnu.org; Wed, 08 Mar 2023 09:58:08 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id B89FE60004; Wed, 8 Mar 2023 14:57:58 +0000 (UTC) From: Nicolas Goaziou To: conses Subject: Re: [bug#61941] [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f. References: Date: Wed, 08 Mar 2023 15:57:51 +0100 In-Reply-To: (conses's message of "Fri, 03 Mar 2023 17:58:26 +0100") Message-ID: <87r0tz8f4g.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61941 Cc: 61941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, conses writes: > * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.20.1c98f6f. > [source]: Remove fix-docstring-test.patch. > [propagated-inputs]: Remove emacs-shut-up. Thank you. Some comments follow. > + (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9") > + (revision "0")) Is there a particular reason to use an unreleased version? > + (package > + (name "emacs-helpful") > + (version (git-version "0.20" revision commit)) Base version is actually still 0.19. Upstream bumped Version keyword, but the README mentions there is no official 0.20 yet. I suggest to stick to 0.19. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Wilfred/helpful") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l")))) > + (build-system emacs-build-system) > + (propagated-inputs > + (list emacs-elisp-refs emacs-dash emacs-s emacs-f)) While you're at it, could you re-order inputs alphabetically? You can also merge both patches. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 09 17:47:42 2023 Received: (at 61941) by debbugs.gnu.org; 9 Mar 2023 22:47:42 +0000 Received: from localhost ([127.0.0.1]:53280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paP2z-00086r-Us for submit@debbugs.gnu.org; Thu, 09 Mar 2023 17:47:42 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paP2x-00086J-Aq for 61941@debbugs.gnu.org; Thu, 09 Mar 2023 17:47:40 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id C5E9020008; Thu, 9 Mar 2023 22:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1678402052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/fixPKqmix2reP+Vp2pVseOhvoDAmfup0Ir417xr3uY=; b=ZUTrCUWhJSHs+JpI8X3dCq90y6LghYx0NXukB1gxvZCThwhxLILVNxiIj1++1arhCkHB86 rLnqEcdfOUWwT4kv4VYktgmiUakGUObZxQseIJ9r90hr/GRcJIawRDbOqP3qD35sQYKQah ahSytGIF+3XgWaTymSQ4ihqXcr1kKFSt219Axa8jnqBnJVjYSsay/fWO3c23J/fIN22EhT YY3ISuA9ZweuPCqOI3HEdzNlA+/B5NrLXcxdHtkuYV2QBnZET+Q04R6Ofp4M23HpV83sex rTwOMSRzQBlmD2u5Ic1ld96Uxvim+2f5BPL6kJN473ce03he15QtEB0q3V5TJA== From: conses To: 61941@debbugs.gnu.org Subject: Re: [bug#61941] [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f. In-Reply-To: <87r0tz8f4g.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 08 Mar 2023 15:57:51 +0100") References: <87r0tz8f4g.fsf@nicolasgoaziou.fr> Date: Thu, 09 Mar 2023 23:47:29 +0100 Message-ID: <86zg8la6f2.fsf@conses.eu> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61941 Cc: contact@conses.eu, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicolas Goaziou writes: >> + (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9") >> + (revision "0")) > > Is there a particular reason to use an unreleased version? > The latest release was over two years ago and a lot of functionality has been added. >> + (package >> + (name "emacs-helpful") >> + (version (git-version "0.20" revision commit)) > > Base version is actually still 0.19. Upstream bumped Version keyword, > but the README mentions there is no official 0.20 yet. I suggest to > stick to 0.19. > Ok, will send a revised patch. >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/Wilfred/helpful") >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l")))) >> + (build-system emacs-build-system) >> + (propagated-inputs >> + (list emacs-elisp-refs emacs-dash emacs-s emacs-f)) > > While you're at it, could you re-order inputs alphabetically? > > You can also merge both patches. > Sure. Thanks for having a look! > Regards, -- Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 09 17:55:46 2023 Received: (at 61941) by debbugs.gnu.org; 9 Mar 2023 22:55:47 +0000 Received: from localhost ([127.0.0.1]:53289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paPAo-0008OO-B3 for submit@debbugs.gnu.org; Thu, 09 Mar 2023 17:55:46 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paPAn-0008OC-2Y for 61941@debbugs.gnu.org; Thu, 09 Mar 2023 17:55:45 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id 7074120003; Thu, 9 Mar 2023 22:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1678402539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Juem8ydde8zF48Z47TYWnLVEzpAgDbzwIRH4a1kwjvI=; b=WNyCtPaBqTwDZuoUxaoqgXNDusL9ChPRaLjvMikaUjRrGdf5bQ2q1L5dMx5raFXnA89DFj GFpLmN2NiXl6HIYDlNJCRhBojzzAvS6+eYBAMti5RXpZznkxAPjovn1K3i2YQJyojqMQZW KiHQSDTJlChZt+aXm2erFjPZA8DQlP2WybqEX2XAcL0XGjdkb1+M3FcJ6K/QnZKHpr76B5 LkKTf8xg9gHGJDiQIzvKm/QOw1WUxzDTfJt7FkjVQ36+Dn8tfEfRCFSD1ar4gqgVexkKze 9dr2sUfmBx0+f2SNRdmpIIWDoUdNPE2t8uzbiOFrHxk/FgqNRvbYdR7BI8o8mQ== From: conses To: 61941@debbugs.gnu.org Subject: [PATCH v2] gnu: emacs-helpful: Update to 0.19.1c98f6f. Date: Thu, 09 Mar 2023 23:55:37 +0100 Message-ID: <86v8j9a61i.fsf@conses.eu> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61941 Cc: contact@conses.eu, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.19.1c98f6f. [source]: Remove fix-docstring-test.patch. [propagated-inputs]: Remove emacs-shut-up. --- gnu/packages/emacs-xyz.scm | 52 +++++++++---------- .../emacs-helpful-fix-docstring-test.patch | 18 ------- 2 files changed, 26 insertions(+), 44 deletions(-) delete mode 100644 gnu/packages/patches/emacs-helpful-fix-docstring-test.p= atch diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 3c067fe16c..fa528432cb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -23303,31 +23303,31 @@ (define-public emacs-download-region (license license:gpl3+)))) =20 (define-public emacs-helpful - (package - (name "emacs-helpful") - (version "0.19") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/Wilfred/helpful") - (commit version))) - (file-name (git-file-name name version)) - (sha256 - (base32 "0qwsifzsjw95l83m7z07fr9h1sqbhggwmcps1qgbddpan2a8ab8a")) - ;; Cherry-picked from upstream, remove when bumping to 0.20. - (patches (search-patches "emacs-helpful-fix-docstring-test.patch"))= )) - (build-system emacs-build-system) - (propagated-inputs - (list emacs-elisp-refs emacs-dash emacs-s emacs-f emacs-shut-up)) - (native-inputs - (list emacs-ert-runner emacs-undercover)) - (arguments - `(#:tests? #t - #:test-command '("ert-runner"))) - (home-page "https://github.com/Wilfred/helpful") - (synopsis "More contextual information in Emacs help") - (description "@code{helpful} is an alternative to the built-in Emacs h= elp + (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9") + (revision "0")) + (package + (name "emacs-helpful") + (version (git-version "0.19" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Wilfred/helpful") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))= )) + (build-system emacs-build-system) + (propagated-inputs + (list emacs-dash emacs-elisp-refs emacs-f emacs-s)) + (native-inputs + (list emacs-ert-runner emacs-undercover)) + (arguments + `(#:tests? #t + #:test-command '("ert-runner"))) + (home-page "https://github.com/Wilfred/helpful") + (synopsis "More contextual information in Emacs help") + (description "@code{helpful} is an alternative to the built-in Emacs= help that provides much more contextual information. =20 @itemize @@ -23346,7 +23346,7 @@ (define-public emacs-helpful @item Trace, disassemble functions from inside Helpful. This is discovera= ble and doesn't require memorisation of commands. @end itemize\n") - (license license:gpl3+))) + (license license:gpl3+)))) =20 (define-public emacs-logview (package diff --git a/gnu/packages/patches/emacs-helpful-fix-docstring-test.patch b/= gnu/packages/patches/emacs-helpful-fix-docstring-test.patch deleted file mode 100644 index de40010fa2..0000000000 --- a/gnu/packages/patches/emacs-helpful-fix-docstring-test.patch +++ /dev/null @@ -1,18 +0,0 @@ -This patch fixing a build failure has been cherry-picked from upstream. -Originally submitted as pull request by Erik =C5=A0abi=C4=8D. -See also . -diff --git a/test/helpful-unit-test.el b/test/helpful-unit-test.el -index a07aa8e..8a95129 100644 ---- a/test/helpful-unit-test.el -+++ b/test/helpful-unit-test.el -@@ -119,7 +119,9 @@ bar"))) - (should - (equal - (helpful--docstring #'test-foo-advised t) -- "Docstring here too."))) -+ (if (version< emacs-version "28") -+ "Docstring here too." -+ "Docstring here too.\n\nThis function has :around advice: `ad-Advice-= test-foo-advised'.")))) -=20 - (defun test-foo-no-docstring () - nil) --=20 2.39.1 --=20 Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 04:25:40 2023 Received: (at 61941-done) by debbugs.gnu.org; 17 Mar 2023 08:25:40 +0000 Received: from localhost ([127.0.0.1]:43589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5PA-0007iM-49 for submit@debbugs.gnu.org; Fri, 17 Mar 2023 04:25:40 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:33429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5P8-0007i6-Ia for 61941-done@debbugs.gnu.org; Fri, 17 Mar 2023 04:25:39 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id EEBF21BF20E; Fri, 17 Mar 2023 08:25:29 +0000 (UTC) From: Nicolas Goaziou To: conses Subject: Re: [bug#61941] [PATCH v2] gnu: emacs-helpful: Update to 0.19.1c98f6f. References: <86v8j9a61i.fsf@conses.eu> Date: Fri, 17 Mar 2023 09:25:29 +0100 In-Reply-To: <86v8j9a61i.fsf@conses.eu> (conses's message of "Thu, 09 Mar 2023 23:55:37 +0100") Message-ID: <87lejvdbt2.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61941-done Cc: 61941-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, conses writes: > * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.19.1c98f6f. > [source]: Remove fix-docstring-test.patch. > [propagated-inputs]: Remove emacs-shut-up. You also need to dereference the patch file in gnu/local.mk. I did that, updated the commit message and applied your patch. Thank you. Regards, -- Nicolas Goaziou From unknown Fri Sep 19 22:29:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Apr 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator