GNU bug report logs - #61913
java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Subject: bug#61913: closed (Re: bug#61913: java-ts-mode query error for
 string highlight, due to recent commit in tree-sitter-java.)
Date: Thu, 09 Mar 2023 10:26:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#61913: java-ts-mode query error for string highlight, due to recent commit in tree-sitter-java.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 61913 <at> debbugs.gnu.org.

-- 
61913: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61913
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Cc: 61913-done <at> debbugs.gnu.org, casouri <at> gmail.com, theo <at> thornhill.no
Subject: Re: bug#61913: java-ts-mode query error for string highlight,
 due to recent commit in tree-sitter-java.
Date: Thu, 09 Mar 2023 12:24:55 +0200

> From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
> Cc: casouri <at> gmail.com, 61913 <at> debbugs.gnu.org
> Date: Mon, 06 Mar 2023 15:03:46 +0100
> 
> Is this patch okay? Please feel free to make any changes you see fit.

Thanks, installed on the emacs-29 branch.

Btw, this patch all but exhausts the amount of changes we can accept
from you without a copyright assignment.  Would you like to start you
legal paperwork of assigning the copyright to the FSF?  If yes, I will
send you the form to fill.

[Message part 3 (message/rfc822, inline)]

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: java-ts-mode query error for string highlight,
 due to recent commit in tree-sitter-java.
Date: Thu, 02 Mar 2023 13:21:05 +0100

[Message part 4 (text/plain, inline)]

Hi, 
a recent commit in tree-sitter-java (https://github.com/tree-sitter/tree-sitter-java/commit/2b3b776b953a34ccffb647dd89732db79690d4c5) 
removed "text_block" from grammar.js. This causes a bug in java-ts-mode when treesit-fon-lock-level is > 1

Error during redeployment: (jit-lock-function 8295) reported (treesit-query-error "Node type error at" 42 "(string_literal) @font-lock-string-face (text_block) @font-lock-string-face" "Debugging the query with `treesit-query-validate'")


The attached patch fixes the problem. 
Thank you very much.

Vincenzo

[java_ts_mode_string_highlight.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.