GNU bug report logs - #61906
[PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)

Previous Next

Package: guix-patches;

Reported by: Sarthak Shah <shahsarthakw <at> gmail.com>

Date: Thu, 2 Mar 2023 06:07:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Sarthak Shah <shahsarthakw <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61906 <at> debbugs.gnu.org
Subject: [bug#61906] [PATCH] Revised patch that respects changelog format
Date: Thu, 9 Mar 2023 16:44:09 +0530
[Message part 1 (text/plain, inline)]
Got it, thank you for your patience.
I guess it won't be necessary as you have already sent a corrected patch,
but should I resend my commit with the required fixes?

On Thu, Mar 9, 2023 at 3:32 PM Simon Tournier <zimon.toutoune <at> gmail.com>
wrote:

> Hi,
>
> Please see v3 for nitpicking. :-)  But since it is a more than trivial
> patch, the only interesting part is the nitpicking part.
>
>
> 1. Since the Subject line is the Commit headline, it must also respect
>    the format.  When modifying a package, it is:
>
>       gnu: packag-name: One line summarizing the change.
>
> On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw <at> gmail.com> wrote:
>
> > * gnu/packages/pumio.scm (pumpa): Replace pumpa origin
>
> 2. The ChangeLog format ends with a period.          --^
>
>
> Cheers,
> simon
>
[Message part 2 (text/html, inline)]

This bug report was last modified 2 years and 70 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.