GNU bug report logs - #61901
30.0.50; [PATCH] Add permanently-enabled-local-variable-dirs variable.

Previous Next

Full log

Message #49 received at 61901 <at> debbugs.gnu.org (full text, mbox):

From: Antero Mejr <antero <at> mailbox.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61901 <at> debbugs.gnu.org
Subject: Re: bug#61901: 30.0.50; [PATCH v3] Add
 safe-local-variable-directories variable.
Date: Thu, 11 May 2023 21:38:33 +0000

[Message part 1 (text/plain, inline)]

Antero Mejr <antero <at> mailbox.org> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> > This actually means that I misunderstood the code.  Now that I see the
>>> > truth, why is it a good idea to compare directories case-sensitively
>>> > when the filesystem is not?  That's not something users will expect.
>>> 
>>> To accurately assess if a directory name matches with possible
>>> case-sensitivity, the process would be:
>>> 1. check the case-sensitivity of the filesystem
>>> 2. If case insensitive, check the case-sensitivity of each subdirectory
>>> (using Windows queryCaseSensitiveInfo if applicable)
>>> 3. map over the components of the directory name, checking each subdirectory
>>> with the correct case-sensitivity setting
>>
>> We already have all that in file-equal-p.  We should just use is
>> there.
>
> Ok, patch is attached (tested on FAT32 disk).

Please ignore that last patch, here is a corrected version with updated
docs. Since file-equal-p handles the trailing slash, now it doesn't
matter if there is/isn't one.

[0001-Handle-case-insensitivity-for-safe-local-variable-di.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.