GNU bug report logs - #61893
29.0.60; Indentation in c-ts-mode broken again

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 61893 <at> debbugs.gnu.org, theo <at> thornhill.no, mardani29 <at> yahoo.es
Subject: bug#61893: 29.0.60; Indentation in c-ts-mode broken again
Date: Sun, 05 Mar 2023 10:22:56 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 4 Mar 2023 15:03:46 -0800
> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>  Daniel Martín <mardani29 <at> yahoo.es>,
>  61893 <at> debbugs.gnu.org
> 
> >>>> The elif directive’s and subsequent directives aren’t indented properly. Looking at the parsed tree, the elif directives are nested in the if directive, and the nesting can be arbitrarily deep. We probably need a custom function rather than great-grand-parent to find the anchor, like a function that keeps going up the tree until the node isn’t a preproc directive anymore.
> >>>> 
> >>>> Yuan
> >>> 
> >>> Yeah, you're right. I'll see what I can do, but bandwidth is a little low at the moment, so if you have some extra time, don't hesitate to improve it :)
> >> 
> >> Absolutely, I’ll work on it. 
> >> 
> >> Yuan
> > 
> > Thanks :)
> 
> Done!

Thanks.

Some problems still remain.

Line 1761 of dispnew.c: type "C-e RET" -- point goes to column 7
instead of the expected column 2.

Line 3381 of dispnew.c: type "C-e RET" -- point goes to the correct
column, but line 3381 is reindented incorrectly.

Line 6611 of dispnew.e: type "C-e RET" -- point goes to column 0
instead of the expected column 2.  If you type "C-e RET" on the next
line 6612, point goes to column 0 and the line is reindented
incorrectly.

Line 13925 of xdisp.c: type "C-e RET" -- point goes to column 33(!)
and line 13925 is reindented incorrectly.

Lines 34529 and 34530 of xdisp.c: "C-e RET" produces incorrect column
of point and reindents line 34530.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.