From unknown Mon Jun 23 13:08:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61873] [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: whatson@tailcall.au, andreas@enge.fr, mail@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Tue, 28 Feb 2023 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61873@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Andrew Whatson , Andreas Enge , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Andrew Whatson , Andreas Enge , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.167760596026551 (code B ref -1); Tue, 28 Feb 2023 17:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Feb 2023 17:39:20 +0000 Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX3wb-0006u8-5F for submit@debbugs.gnu.org; Tue, 28 Feb 2023 12:39:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:36860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX3wW-0006tt-AU for submit@debbugs.gnu.org; Tue, 28 Feb 2023 12:39:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX3wV-00007u-4V for guix-patches@gnu.org; Tue, 28 Feb 2023 12:39:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX3wN-0001Ji-AT; Tue, 28 Feb 2023 12:39:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=DskgGtcoREawGdAGvzf78UwwbIEJY8S1blnB7JugkXk=; b=Sxqe/g+H3zWYbL XmIAURUvzX0b70iFZUnx6w4W2SW6rHzDHN9lwsM2cXBE1CEjRz6CaTqHQn8nVy2IPfszHlLuBGy84 Y00cxBDRwCNBKXY4GZfHcvPbcPywn97d9VGelbqMJPOyocx22VV2BlUBv7v8Zl8SRwfXXLhyXbIE9 YPIvjlkeFq/rmxppHhEpTkC7qsgDg6foHOsI/ksoEzYfx+6keiYxm2TrEoAfww00CDM46YB5ZNbwq YdiRU/Az9jkqv+xaZlKOtPzsdjP39rCKXnz4hXd7IHZdQgFSgsL4U4v8XC2/ZG3wG0hZT2Ju9dR8r CixVRAADAc/ZT2cFUxgw==; Received: from [193.50.110.164] (helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pX3wM-00029T-G3; Tue, 28 Feb 2023 12:39:02 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 28 Feb 2023 18:38:54 +0100 Message-Id: <20230228173854.25132-1-ludo@gnu.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/bdw-gc.scm (libgc): Update to 8.2.2. [arguments]: Remove "--disable-munmap" from #:configure-flags. * gnu/packages/guile.scm (guile-3.0)[source]: Leave 'test-out-of-memory' test untouched. (guile-next)[arguments]: Likewise, in 'skip-failing-tests' phase. (guile-for-guile-emacs)[arguments]: Likewise, in 'bootstrap' phase. --- gnu/packages/bdw-gc.scm | 9 +++------ gnu/packages/guile.scm | 16 +++------------- 2 files changed, 6 insertions(+), 19 deletions(-) Hello Guix! This is another proposal for a world-rebuild change, hopefully the latest (I swear!). It’s quite important because it fixes a libgc bug that led us to build libgc with ‘--disable-munmap’, meaning it would not return memory to the OS: https://github.com/ivmai/bdwgc/issues/353 Thanks to Andrew Whatson for tackling this and for letting me know! I tested on x86_64-linux on top of 4895846197bd445dd68c832364c667dea4337f8c like so: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build guix guile@2.2 guile@2.0 -nguix build: warning: ambiguous package specification `guile@2.2' guix build: warning: choosing guile@2.2.7 from gnu/packages/guile.scm:253:2 /gnu/store/4nhq6kmqcfk2qnzhi4xifbb0zjav0f01-guile-2.0.14-debug /gnu/store/4p1l5bdxxbyyqc3wh0d07jv9rp1pdcy7-guile-2.0.14 /gnu/store/k47958rhcrk176i9sabxda2rgmnlig4c-guile-2.2.7-debug /gnu/store/ka0v3fk21lqrnwj4fzbf8z154mpbnjvx-guile-2.2.7 /gnu/store/agrv086cfa0a5f9cmj94k9zgwi1a08q6-guix-1.4.0-3.d5fece6 --8<---------------cut here---------------end--------------->8--- Given that the test suite of Guix passed and that everything in between went fine, I’m rather confident. Thoughts? Ludo’. diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm index cfa037dec0..86caa62d7e 100644 --- a/gnu/packages/bdw-gc.scm +++ b/gnu/packages/bdw-gc.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012, 2013, 2014, 2016, 2017, 2020, 2021 Ludovic Courtès +;;; Copyright © 2012, 2013, 2014, 2016, 2017, 2020, 2021, 2023 Ludovic Courtès ;;; Copyright © 2014 Mark H Weaver ;;; Copyright © 2016, 2018 Leo Famulari ;;; Copyright © 2017 Rene Saavedra @@ -34,14 +34,14 @@ (define-module (gnu packages bdw-gc) (define-public libgc (package (name "libgc") - (version "8.0.6") + (version "8.2.2") (source (origin (method url-fetch) (uri (string-append "https://github.com/ivmai/bdwgc/releases" "/download/v" version "/gc-" version ".tar.gz")) (sha256 (base32 - "04ga3c95w5az5sznzm73j19lvvfpf6k4sgkpjqsmjxpsr6mi8j9v")))) + "181ni2rn9qjbl4ilqdjrd1a4h8siv5bgmzqgg4595q32n2y0f0gk")))) (build-system gnu-build-system) (arguments (list @@ -50,9 +50,6 @@ (define-public libgc ;; Install gc_cpp.h et al. "--enable-cplusplus" - ;; Work around . - "--disable-munmap" - ;; In GNU/Hurd systems during the 'check' phase, ;; there is a deadlock caused by the 'gctest' test. ;; To disable the error set "--disable-gcj-support" diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index c2ffbefeec..64a815dbd4 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -325,11 +325,8 @@ (define-public guile-3.0 (patches '()) ;; Replace the snippet because the oom-test still ;; fails on some 32-bit architectures. - (snippet '(begin - (substitute* "test-suite/standalone/Makefile.in" - (("test-out-of-memory") "")) - (for-each delete-file - (find-files "prebuilt" "\\.go$")))))) + (snippet '(for-each delete-file + (find-files "prebuilt" "\\.go$"))))) ;; Build with the bundled mini-GMP to avoid interference with GnuTLS' own ;; use of GMP via Nettle: . @@ -444,10 +441,7 @@ (define-public guile-next (display ,version port))))) (add-before 'check 'skip-failing-tests (lambda _ - (substitute* "test-suite/standalone/test-out-of-memory" - (("!#") "!#\n\n(exit 77)\n")) - (delete-file "test-suite/tests/version.test") - #t)))))) + (delete-file "test-suite/tests/version.test"))))))) (native-inputs (modify-inputs (package-native-inputs guile-3.0) (prepend autoconf @@ -571,10 +565,6 @@ (define-public guile-for-guile-emacs (substitute* "test-suite/tests/version.test" (("\\(pass-if \"version reporting works\"" m) (string-append "#;" m))) - ;; Warning: Unwind-only `out-of-memory' exception; skipping pre-unwind handler. - ;; FAIL: test-out-of-memory - (substitute* "test-suite/standalone/Makefile.am" - (("(check_SCRIPTS|TESTS) \\+= test-out-of-memory") "")) (patch-shebang "build-aux/git-version-gen") (invoke "sh" "autogen.sh") base-commit: 4895846197bd445dd68c832364c667dea4337f8c -- 2.39.1 From unknown Mon Jun 23 13:08:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61873] [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'. Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Feb 2023 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , 61873@debbugs.gnu.org, Andrew Whatson Received: via spool by 61873-submit@debbugs.gnu.org id=B61873.167760644027336 (code B ref 61873); Tue, 28 Feb 2023 17:48:02 +0000 Received: (at 61873) by debbugs.gnu.org; 28 Feb 2023 17:47:20 +0000 Received: from localhost ([127.0.0.1]:51950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX44O-00076q-5u for submit@debbugs.gnu.org; Tue, 28 Feb 2023 12:47:20 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:40908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX44M-00076d-Ca for 61873@debbugs.gnu.org; Tue, 28 Feb 2023 12:47:18 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 617D6E8E; Tue, 28 Feb 2023 18:47:11 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r2XouZdi4fgG; Tue, 28 Feb 2023 18:47:11 +0100 (CET) Received: from jurong (unknown [147.94.72.48]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6BA8B19D; Tue, 28 Feb 2023 18:47:10 +0100 (CET) Date: Tue, 28 Feb 2023 18:47:09 +0100 From: Andreas Enge Message-ID: References: <20230228173854.25132-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230228173854.25132-1-ludo@gnu.org> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Tue, Feb 28, 2023 at 06:38:54PM +0100 schrieb Ludovic Courtès: > This is another proposal for a world-rebuild change, hopefully the latest > (I swear!). It’s quite important because it fixes a libgc bug that led > us to build libgc with ‘--disable-munmap’, meaning it would not return > memory to the OS: > https://github.com/ivmai/bdwgc/issues/353 > Thanks to Andrew Whatson for tackling this and for letting me know! > > Given that the test suite of Guix passed and that everything in between > went fine, I’m rather confident. > Thoughts? Indeed, the bug looks important to fix! Concerning world rebuilding, I do not know if anybody did; I did not ;-) So maybe after pushing this, we could set up jobs on the build farms to rebuild the world twice. Andreas From unknown Mon Jun 23 13:08:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61873] [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'. Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Mar 2023 14:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , 61873@debbugs.gnu.org, Andrew Whatson Received: via spool by 61873-submit@debbugs.gnu.org id=B61873.167776778323791 (code B ref 61873); Thu, 02 Mar 2023 14:37:01 +0000 Received: (at 61873) by debbugs.gnu.org; 2 Mar 2023 14:36:23 +0000 Received: from localhost ([127.0.0.1]:56242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXk2h-0006Bf-Io for submit@debbugs.gnu.org; Thu, 02 Mar 2023 09:36:23 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXk2f-0006BS-RP for 61873@debbugs.gnu.org; Thu, 02 Mar 2023 09:36:22 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 18EB51A25; Thu, 2 Mar 2023 15:36:16 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ANjIhiSxGeJk; Thu, 2 Mar 2023 15:36:15 +0100 (CET) Received: from jurong (unknown [147.94.72.84]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 67AA0383; Thu, 2 Mar 2023 15:36:15 +0100 (CET) Date: Thu, 2 Mar 2023 15:36:14 +0100 From: Andreas Enge Message-ID: References: <20230228173854.25132-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Could you push it? Before that there is not much point in rebuilding core-updates, knowing it will have to be rebuilt right after that again. Andreas From unknown Mon Jun 23 13:08:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61873] [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Mar 2023 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andreas Enge , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , 61873@debbugs.gnu.org, Andrew Whatson Received: via spool by 61873-submit@debbugs.gnu.org id=B61873.16777818033625 (code B ref 61873); Thu, 02 Mar 2023 18:31:02 +0000 Received: (at 61873) by debbugs.gnu.org; 2 Mar 2023 18:30:03 +0000 Received: from localhost ([127.0.0.1]:58363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXngo-0000wE-76 for submit@debbugs.gnu.org; Thu, 02 Mar 2023 13:30:02 -0500 Received: from jpoiret.xyz ([206.189.101.64]:43616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXngm-0000vn-Fr for 61873@debbugs.gnu.org; Thu, 02 Mar 2023 13:30:01 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 9C34C184CE0; Thu, 2 Mar 2023 18:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1677781799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ulq3Ae/SquTcqzIoJMWsVZfuSTa1DV1xJfcfolEbgF0=; b=fu7fWDNXmGIAGG4NW6P/ThewjSBJ3z4TkzOkkCt6y3FfX9IfyI0mr9R9xfrV7L2Yc+Zm88 UEVR4+mcz/CYibcbcrfImQG047wvImTN6SuqEO0L5H/3quLtCkvLyTA1OzYywLACaIgm3U vZcymdZN0NNIISu/thIhHwtqOmhRaTzx92k3ShjekGhdyVaMbL96tX43cwadNz68Ap1EG2 JFip0Tv7v1S47GxPKbFHi36RwXohCt6rtQizznOxEjPgUpTKH7oO2aCJxeCmLNZYkljgB0 SFzdV+1bCqwSqzHIr0VUKAj8aHfGQswL8eNbSb1qeGvxq6ni4EQVKSzgaualmg== From: Josselin Poiret In-Reply-To: References: <20230228173854.25132-1-ludo@gnu.org> Date: Thu, 02 Mar 2023 19:29:55 +0100 Message-ID: <87356nropo.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: * X-Spamd-Bar: + X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Ludo and Andreas, I agree with Andreas here, better push it now so that momentum doesn't die out. FWIW, the patch looks good to me, although the important part will be how the new version fares in real applications :) Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmQA6yMQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaikCQC/wMz//ZlCCJ5FO4+ewKLBwrw3SinSiSeSi6 Sz/UjWzNDDwKl8aCxxVXnrwPoRKLqvIhJ9fBKJPef0ftx6IR6soS1rAajmAPXYDF /CVfASei4Eu/ZubUxPrdbTu9eyV70PmlSOzh5jfZVK/wVlvRMQyJ+euPtGDlRBJd 0fTLdXYa+kbFCrkAF9lvkVqvvLdnDXLSm54hiTCG+WZ+jDDI00qzyxytaxAJG1VI RU7aZ9EpV23fNVMF/1+rhYYxw8vhw2Zvab7ss+UtbwteslW2+HrynHXNDx5zKm5V cZx3I47h7MHV5pEcnWiwBrbd1x3OguSEffXQvmwvLmjX54Qp9BmFG16+vEmw1Jcn 2FC6hCnd14CFHHRHlCtqfKT0aDVS6oCkWWONnk4xhB/ElB4vjxDgjgfCh00VlID2 wfaOr5DiRB0NhEm+fK8IGd/qoY83fPlLVP3ANWnmAzSvE5OARDsnBZHlg1s7QKqB mT1fzMDN5nXeswE4GBsywinlZhw8bJM= =L5pt -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 13:08:56 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#61873: closed (Re: bug#61873: [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'.) Message-ID: References: <87y1oe3mcg.fsf_-_@gnu.org> <20230228173854.25132-1-ludo@gnu.org> X-Gnu-PR-Message: they-closed 61873 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 61873@debbugs.gnu.org Date: Thu, 02 Mar 2023 20:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1677790562-5642-1" This is a multi-part message in MIME format... ------------=_1677790562-5642-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61873: [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disa= ble-munmap'. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61873@debbugs.gnu.org. --=20 61873: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61873 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1677790562-5642-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61873-done) by debbugs.gnu.org; 2 Mar 2023 20:55:10 +0000 Received: from localhost ([127.0.0.1]:58474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXpxG-0001Rk-1A for submit@debbugs.gnu.org; Thu, 02 Mar 2023 15:55:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXpxD-0001RS-NH for 61873-done@debbugs.gnu.org; Thu, 02 Mar 2023 15:55:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXpx4-0006l9-Rm; Thu, 02 Mar 2023 15:54:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=bCoNBkjhq5DjwXKlgFQGijw0DygGF/xTZ30+3lSL000=; b=pDurFY91Xp6/ZA6aNtKt GTZaSEaCFbMtQDwbGtYakGaBvnRT2XhJjTYFmPJlIyxZ+LTv/jiU4QqUdVMa9W3Ex1M/coswSvmYG sav9Q0ARSOsUq+tElqk0Q2ptR3NyUmLDTywMjlGcSvZVA9+RcGd93KKI5deY/d2m/Zwu+43dXsJ7q eKTpLkSxWeJa3O57lM56I3onvqqqvevZsQOf/eG/5xWGKuf2eShi8bM2twv6xDdHZPClNiXeMJvi9 L3vMv9sqvJ6vGVJxh/Jpcj4vu634pXPj3bxg4vbwV11I8BLjpb1oU9K1Ykga8FdT44cwWfGsfBV6U awilhUg8GSW0SA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXpx4-0003R5-8X; Thu, 02 Mar 2023 15:54:58 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Andreas Enge Subject: Re: bug#61873: [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'. References: <20230228173854.25132-1-ludo@gnu.org> Date: Thu, 02 Mar 2023 21:54:55 +0100 In-Reply-To: (Andreas Enge's message of "Thu, 2 Mar 2023 15:36:14 +0100") Message-ID: <87y1oe3mcg.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61873-done Cc: Josselin Poiret , Christopher Baines , Simon Tournier , 61873-done@debbugs.gnu.org, Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Andrew Whatson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Andreas Enge skribis: > Could you push it? Before that there is not much point in rebuilding > core-updates, knowing it will have to be rebuilt right after that again. Pushed as 5222ed8dc364f13a36bca13c151856a3edab795a. Apologies for the delay! Ludo=E2=80=99. ------------=_1677790562-5642-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Feb 2023 17:39:20 +0000 Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX3wb-0006u8-5F for submit@debbugs.gnu.org; Tue, 28 Feb 2023 12:39:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:36860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX3wW-0006tt-AU for submit@debbugs.gnu.org; Tue, 28 Feb 2023 12:39:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX3wV-00007u-4V for guix-patches@gnu.org; Tue, 28 Feb 2023 12:39:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX3wN-0001Ji-AT; Tue, 28 Feb 2023 12:39:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=DskgGtcoREawGdAGvzf78UwwbIEJY8S1blnB7JugkXk=; b=Sxqe/g+H3zWYbL XmIAURUvzX0b70iFZUnx6w4W2SW6rHzDHN9lwsM2cXBE1CEjRz6CaTqHQn8nVy2IPfszHlLuBGy84 Y00cxBDRwCNBKXY4GZfHcvPbcPywn97d9VGelbqMJPOyocx22VV2BlUBv7v8Zl8SRwfXXLhyXbIE9 YPIvjlkeFq/rmxppHhEpTkC7qsgDg6foHOsI/ksoEzYfx+6keiYxm2TrEoAfww00CDM46YB5ZNbwq YdiRU/Az9jkqv+xaZlKOtPzsdjP39rCKXnz4hXd7IHZdQgFSgsL4U4v8XC2/ZG3wG0hZT2Ju9dR8r CixVRAADAc/ZT2cFUxgw==; Received: from [193.50.110.164] (helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pX3wM-00029T-G3; Tue, 28 Feb 2023 12:39:02 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'. Date: Tue, 28 Feb 2023 18:38:54 +0100 Message-Id: <20230228173854.25132-1-ludo@gnu.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Debbugs-Cc: Andrew Whatson , Andreas Enge , Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/bdw-gc.scm (libgc): Update to 8.2.2. [arguments]: Remove "--disable-munmap" from #:configure-flags. * gnu/packages/guile.scm (guile-3.0)[source]: Leave 'test-out-of-memory' test untouched. (guile-next)[arguments]: Likewise, in 'skip-failing-tests' phase. (guile-for-guile-emacs)[arguments]: Likewise, in 'bootstrap' phase. --- gnu/packages/bdw-gc.scm | 9 +++------ gnu/packages/guile.scm | 16 +++------------- 2 files changed, 6 insertions(+), 19 deletions(-) Hello Guix! This is another proposal for a world-rebuild change, hopefully the latest (I swear!). It’s quite important because it fixes a libgc bug that led us to build libgc with ‘--disable-munmap’, meaning it would not return memory to the OS: https://github.com/ivmai/bdwgc/issues/353 Thanks to Andrew Whatson for tackling this and for letting me know! I tested on x86_64-linux on top of 4895846197bd445dd68c832364c667dea4337f8c like so: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build guix guile@2.2 guile@2.0 -nguix build: warning: ambiguous package specification `guile@2.2' guix build: warning: choosing guile@2.2.7 from gnu/packages/guile.scm:253:2 /gnu/store/4nhq6kmqcfk2qnzhi4xifbb0zjav0f01-guile-2.0.14-debug /gnu/store/4p1l5bdxxbyyqc3wh0d07jv9rp1pdcy7-guile-2.0.14 /gnu/store/k47958rhcrk176i9sabxda2rgmnlig4c-guile-2.2.7-debug /gnu/store/ka0v3fk21lqrnwj4fzbf8z154mpbnjvx-guile-2.2.7 /gnu/store/agrv086cfa0a5f9cmj94k9zgwi1a08q6-guix-1.4.0-3.d5fece6 --8<---------------cut here---------------end--------------->8--- Given that the test suite of Guix passed and that everything in between went fine, I’m rather confident. Thoughts? Ludo’. diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm index cfa037dec0..86caa62d7e 100644 --- a/gnu/packages/bdw-gc.scm +++ b/gnu/packages/bdw-gc.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012, 2013, 2014, 2016, 2017, 2020, 2021 Ludovic Courtès +;;; Copyright © 2012, 2013, 2014, 2016, 2017, 2020, 2021, 2023 Ludovic Courtès ;;; Copyright © 2014 Mark H Weaver ;;; Copyright © 2016, 2018 Leo Famulari ;;; Copyright © 2017 Rene Saavedra @@ -34,14 +34,14 @@ (define-module (gnu packages bdw-gc) (define-public libgc (package (name "libgc") - (version "8.0.6") + (version "8.2.2") (source (origin (method url-fetch) (uri (string-append "https://github.com/ivmai/bdwgc/releases" "/download/v" version "/gc-" version ".tar.gz")) (sha256 (base32 - "04ga3c95w5az5sznzm73j19lvvfpf6k4sgkpjqsmjxpsr6mi8j9v")))) + "181ni2rn9qjbl4ilqdjrd1a4h8siv5bgmzqgg4595q32n2y0f0gk")))) (build-system gnu-build-system) (arguments (list @@ -50,9 +50,6 @@ (define-public libgc ;; Install gc_cpp.h et al. "--enable-cplusplus" - ;; Work around . - "--disable-munmap" - ;; In GNU/Hurd systems during the 'check' phase, ;; there is a deadlock caused by the 'gctest' test. ;; To disable the error set "--disable-gcj-support" diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index c2ffbefeec..64a815dbd4 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -325,11 +325,8 @@ (define-public guile-3.0 (patches '()) ;; Replace the snippet because the oom-test still ;; fails on some 32-bit architectures. - (snippet '(begin - (substitute* "test-suite/standalone/Makefile.in" - (("test-out-of-memory") "")) - (for-each delete-file - (find-files "prebuilt" "\\.go$")))))) + (snippet '(for-each delete-file + (find-files "prebuilt" "\\.go$"))))) ;; Build with the bundled mini-GMP to avoid interference with GnuTLS' own ;; use of GMP via Nettle: . @@ -444,10 +441,7 @@ (define-public guile-next (display ,version port))))) (add-before 'check 'skip-failing-tests (lambda _ - (substitute* "test-suite/standalone/test-out-of-memory" - (("!#") "!#\n\n(exit 77)\n")) - (delete-file "test-suite/tests/version.test") - #t)))))) + (delete-file "test-suite/tests/version.test"))))))) (native-inputs (modify-inputs (package-native-inputs guile-3.0) (prepend autoconf @@ -571,10 +565,6 @@ (define-public guile-for-guile-emacs (substitute* "test-suite/tests/version.test" (("\\(pass-if \"version reporting works\"" m) (string-append "#;" m))) - ;; Warning: Unwind-only `out-of-memory' exception; skipping pre-unwind handler. - ;; FAIL: test-out-of-memory - (substitute* "test-suite/standalone/Makefile.am" - (("(check_SCRIPTS|TESTS) \\+= test-out-of-memory") "")) (patch-shebang "build-aux/git-version-gen") (invoke "sh" "autogen.sh") base-commit: 4895846197bd445dd68c832364c667dea4337f8c -- 2.39.1 ------------=_1677790562-5642-1--