From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 07:50:03 2023 Received: (at submit) by debbugs.gnu.org; 28 Feb 2023 12:50:03 +0000 Received: from localhost ([127.0.0.1]:49895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWzQh-0006uA-9V for submit@debbugs.gnu.org; Tue, 28 Feb 2023 07:50:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:42142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWzQg-0006ts-56 for submit@debbugs.gnu.org; Tue, 28 Feb 2023 07:50:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWzQf-0001my-Ls for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2023 07:50:01 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWzQe-0004gR-0I for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2023 07:50:01 -0500 Received: by mail-ed1-x52e.google.com with SMTP id cq23so39537602edb.1 for ; Tue, 28 Feb 2023 04:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=b8vGc1VoKaxu/FDE8yQOkgF4Dxk/WLzXJE+jT8pqqD4=; b=NdPgCf3d8L1yml4SFkExlmj4YgXQuTve0UnVlEJdF1PgB5J3wOXU/Qw4SxYgCvOAr/ R9WgBGW52zfOEFudi1usEaSP0UPs65lOqXFwyAH36iynbwhMMsLYjNmxJwc4fbff9doq TNCJ2y8nszsvsnfSjbH5chxOEII1GdPEtig83vyltbx2WCX/9LlXXb1WXXB8Eag4BMzf apslbLghM/8M7sj2VWT8R5vSDl5PtZHAISKnjWek6pvBfNBK9scheKxZ8QhHwXKoPHB2 nc2J2qPvDN3FEj0HBwZbB8jW0DkZ3HBZuFO4T1gN3OoInmY3o5shId9U9mRuX9rvoB66 Y5RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b8vGc1VoKaxu/FDE8yQOkgF4Dxk/WLzXJE+jT8pqqD4=; b=wgI5rYJYx4l2A59HTr8Gf25lUW6sXe43mf3sRa92ZqEPotYEeVWhVm5AQi1LLGGJ2j nH6Bg5Tdy9otXI0+qvSMVqM8qgctv5ey/TxM8iU1h6UgmTzDNGCPWkhsoVgsIGe6gtzb DfAr12iERhtxSD0G2Mx3IlANTPElLhyu1MAi54JZufdSEzZqhfJDZORpzDriUvf7Hxn7 ItZbEtDidtsQdjk5vix3JoTUvP6zjT7kCZPMcF5l2/X/zOYy9riWZUwRNQAH6ZVV0K0u hewFdhfVosTq7947PIspnGVv7HEagsf1QVwPwRsoVkv+Jm0YQ89H3xWSYVN7wy0F+VH5 dlFg== X-Gm-Message-State: AO0yUKXns5asQg3jWdLeEOMwbnjFQp4NCh/3KR5jKQgoMcf55g2rfppx 8HC+pUCfuwMGPdA414NN0Vcvpfpi22mvlg== X-Google-Smtp-Source: AK7set9CXq+WySwui5YG30XWNU1bVauQ3mFUV6XGgkETNywMWeC1xFY1r1apUd/U8102kgLFnTBwmg== X-Received: by 2002:a17:906:7e5a:b0:8b1:30da:b586 with SMTP id z26-20020a1709067e5a00b008b130dab586mr2786286ejr.49.1677588597553; Tue, 28 Feb 2023 04:49:57 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::8b3a]) by smtp.gmail.com with ESMTPSA id g10-20020a50d0ca000000b004acc123cd94sm4386638edf.30.2023.02.28.04.49.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 04:49:57 -0800 (PST) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: 29.0.60; Eglot: setting "workspace" configurations should be easier X-Debbugs-Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 28 Feb 2023 13:49:55 +0100 Message-ID: <878rgiar9o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=arstoffel@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Arranging for Eglot to send the correct configuration via the `eglot-signal-didChangeConfiguration' command or `eglot-workspace-configuration' variable is very tricky and error prone. The following command, which reads a configuration plist from the minibuffer with history, makes this trial and error process much easier for me: (defvar eglot-edit-workspace-configuration--history nil) (defun eglot-edit-workspace-configuration () (interactive) (let* ((server (eglot-current-server)) (config (read-from-minibuffer (format "New configuration for `%s': " (eglot-project-nickname server)) (when-let ((old (eglot--workspace-configuration-plist server))) (concat "\n" (pp-to-string old))) minibuffer-local-map t 'eglot-edit-workspace-configuration--history))) (setq-local eglot-workspace-configuration config) (save-window-excursion (let ((default-directory (project-root (eglot--current-project)))) (add-dir-local-variable nil 'eglot-workspace-configuration config) (save-buffer))) (eglot-signal-didChangeConfiguration server))) I would suggest adding a refined version of this, using a regular buffer for input. Moreover, one could allow editing the configuration as a JSON (perhaps also retaining the option to edit as a plist). This would be a natural extension of the existing `eglot-show-workspace-configuration' command. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 14:31:58 2023 Received: (at 61868) by debbugs.gnu.org; 28 Feb 2023 19:31:58 +0000 Received: from localhost ([127.0.0.1]:52036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX5he-0001ZR-9t for submit@debbugs.gnu.org; Tue, 28 Feb 2023 14:31:58 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:37432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX5hb-0001ZA-UJ for 61868@debbugs.gnu.org; Tue, 28 Feb 2023 14:31:57 -0500 Received: by mail-wm1-f46.google.com with SMTP id j19-20020a05600c1c1300b003e9b564fae9so10373772wms.2 for <61868@debbugs.gnu.org>; Tue, 28 Feb 2023 11:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677612708; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jbbpceK0ICzKTdSYGzO7RTQVFMtfn2ncWzuXEciEAgY=; b=jr0raNdaUMQpP9FZ4IDOrPyAWo1bISDT09hKlr98Ode9Az6rn/0N7VZk39hPTlKLQX dLGWCMx1yaSThTjeUoxrEL9GNk4unXATSUgiHlAQX7fugVCinSlInPa50DX9y5RpUT2C cX4r2L+w/iQ+C26EYGIPOYZ4CSZKlEnyXr8nfao0ebSJ9xMKNJRa+CkJhK5yOBEe/lPf c2Jizj6+fw3AETqddMTZtmV39aM2ctT0Fwxb9eFZ+YnDzjgrE8hCnqceJ83gimWL++sL xP3XhLa+U43/HSxNRO2nDygc5hJ1nJ3yoU/ThwzqCkQeFRRkb+86+2rUbWllD/nKoro0 lMwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677612708; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jbbpceK0ICzKTdSYGzO7RTQVFMtfn2ncWzuXEciEAgY=; b=rp+FNKpzLI0r9fyry6uOx6Z5GSdGtOzIN9z5viluz1lg+MEbdF7VoeYD4tZXLUfHv6 dkPsVIYN2aDdhv477qqGLZ+9SgPsM75vMQbTICeKwVxrrruGzYBr78H4+7Ky924m0O+I UKtG8NFHh03dQHvSWeQI8CS7lP3qr6QUPyclRcYaQkNZqLgmQZO0IFZC1Lhx2kKq/YXO OoOjyhuxI/f1ShgqqP4k/pn60B0f9P4BBqoH1rCALnUIWuXBgvOAPKI6VO1cZNCJmt1E pc3nVXKxBYh0BEZHnydH1g7ZQsV/B10E5PYvV03HHWGNEEp/5K9Zr/qoKe1rpxEH24hg 5I8Q== X-Gm-Message-State: AO0yUKW3wwgBTqRubgbb/Rsd78Hl3qoJTR6F6DH3JGEMiQu27cnfjwJm d0AX1C8GH7vzsCiWfQoaSR2AsysBGxA= X-Google-Smtp-Source: AK7set8/W73ihaI/+OTb16g4O5inyArkT8bpRfKMgita4rQS/xNS/wJGoAt/qVfgqQkPfLTPtlOW7Q== X-Received: by 2002:a05:600c:4d24:b0:3eb:3986:9bfc with SMTP id u36-20020a05600c4d2400b003eb39869bfcmr3076875wmp.37.1677612708626; Tue, 28 Feb 2023 11:31:48 -0800 (PST) Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id bd12-20020a05600c1f0c00b003e0015c8618sm17085056wmb.6.2023.02.28.11.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 11:31:48 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Augusto Stoffel Subject: Re: bug#61868: 29.0.60; Eglot: setting "workspace" configurations should be easier In-Reply-To: <878rgiar9o.fsf@gmail.com> (Augusto Stoffel's message of "Tue, 28 Feb 2023 13:49:55 +0100") References: <878rgiar9o.fsf@gmail.com> Date: Tue, 28 Feb 2023 19:33:42 +0000 Message-ID: <87o7pdpotl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61868 Cc: 61868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Augusto Stoffel writes: > I would suggest adding a refined version of this, using a regular buffer > for input. Moreover, one could allow editing the configuration as a > JSON (perhaps also retaining the option to edit as a plist). This would > be a natural extension of the existing > `eglot-show-workspace-configuration' command. I like this idea. I agree it's crazy hard to set and get right. But this idea needs to be refined indeed. I'm not crazy about adding this complexity to Eglot, especially because there's nothing really eglot-specific about it. It could be used for any variable you want to add to the current project's root .dir-locals.el. But that involves much more consultation in emacs-devel. Here's an idea. Let's make a bare-bones eglot-show-workspace-configuration that simplifies this 80%. The other 20% can for later. In the patch I sent for the other "workspace configuration" bug, the .dir-locals.el is consulted late (actually it is even now). So a simple implementation of eglot-edit-workspace-configuration could be just: (defun eglot-edit-workspace-configuration () (interactive) (find-file (expand-file-name ".dir-locals.el" (project-root (project-cu= rrent))))) My bet is that that two-liner would go a long way. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 15:35:31 2023 Received: (at 61868) by debbugs.gnu.org; 28 Feb 2023 20:35:31 +0000 Received: from localhost ([127.0.0.1]:52083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX6h8-0003GK-LX for submit@debbugs.gnu.org; Tue, 28 Feb 2023 15:35:30 -0500 Received: from mail-ed1-f47.google.com ([209.85.208.47]:41705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX6h7-0003G8-25 for 61868@debbugs.gnu.org; Tue, 28 Feb 2023 15:35:29 -0500 Received: by mail-ed1-f47.google.com with SMTP id ec43so45241239edb.8 for <61868@debbugs.gnu.org>; Tue, 28 Feb 2023 12:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lxmncFOnxodVGEmhUwF+JFr8SYFyF5xP3vyOjYRs83w=; b=MD6/+dp5dtGC07zGp9n0v5MxwCUO8wWFR41674/tBRyK5n7d3YweZp/4Z2F5tYerPq tYxsEbGP52ieaqdZ9b8ZT5PXPo0UuzP1D821Ih1ADNH6XNxs8mqXxTafYZwE5jpj2fIW iR94W2dnsP+zovfg+xG9UchieM0WQbcNxW6L3RBi+EwgN7CLPxHwDnlui5T88Rc2mcRj hvAerOPRvdtnhNIl39NRCMaeq6YfLBce7pgBc/acPGnTaPNYxGzRTmiy3867ald74Qq/ Lfz3oITQoAh11gdpiq6dw5nvrH7BvJ/pXgyfE4971Aa2RsJQ0YPbK6d3X6JwbBHDGq3Q j4VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lxmncFOnxodVGEmhUwF+JFr8SYFyF5xP3vyOjYRs83w=; b=4zvdh9f872vQ8JePbF7M2kPfGDts6BZET9P5pMLCwSA/cbRv1KvBtW9TnK7kd7SzMs L39mvtzBUenu4m7vY8EXG1etSL3SVk/7h5F+4d4ekuakRtUCaNMunKZA4ajd71f66zyC NO1MfcXALw+upD1adE3ySLRennDW9UcYGCyzLYnIhIPssMN8ZQ9udV3H7fzVM9DE8230 2J2s+59OtaAFXot/Vt2NPGiHmpCHvrG965oFhYCtkYM9Sog/KD3lqOMgvFSkTjA5Mqgt ntjQWHQByUFnC+0bJqBAgskbksJ35/EwDfiFpu1OAClzDDXt39RYrM/BXWzN0U7szZOy lPGw== X-Gm-Message-State: AO0yUKVhj4G8ULvyOquDR0KU4HH8OHFsZObCnPPVliLoNyjJfYgIT23z WBqYmQE/6ZgOaeBQVTHrAVoN2p0GcsRxBQ== X-Google-Smtp-Source: AK7set9yB2BwyavaaCZiZtKLxmeoLsqhZUVJEyapY9HGMxthStaVZF4sCBvU5rka5A4O8zAyRvBe5A== X-Received: by 2002:a17:907:d94:b0:8f4:86a9:748d with SMTP id go20-20020a1709070d9400b008f486a9748dmr6130372ejc.12.1677616522443; Tue, 28 Feb 2023 12:35:22 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::8b3a]) by smtp.gmail.com with ESMTPSA id gw26-20020a170906f15a00b008e204a57e70sm4895968ejb.214.2023.02.28.12.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 12:35:21 -0800 (PST) From: Augusto Stoffel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#61868: 29.0.60; Eglot: setting "workspace" configurations should be easier In-Reply-To: <87o7pdpotl.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Tue, 28 Feb 2023 19:33:42 +0000") References: <878rgiar9o.fsf@gmail.com> <87o7pdpotl.fsf@gmail.com> Date: Tue, 28 Feb 2023 21:35:20 +0100 Message-ID: <87sfepa5pz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61868 Cc: 61868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 28 Feb 2023 at 19:33, Jo=C3=A3o T=C3=A1vora wrote: > Augusto Stoffel writes: > >> I would suggest adding a refined version of this, using a regular buffer >> for input. Moreover, one could allow editing the configuration as a >> JSON (perhaps also retaining the option to edit as a plist). This would >> be a natural extension of the existing >> `eglot-show-workspace-configuration' command. > > I like this idea. I agree it's crazy hard to set and get right. But > this idea needs to be refined indeed. > > I'm not crazy about adding this complexity to Eglot, especially because > there's nothing really eglot-specific about it. It could be used for > any variable you want to add to the current project's root > .dir-locals.el. But that involves much more consultation in > emacs-devel. I see this differently. Emacs doesn't have deeply nested namespaces for variables and user options. It's all pretty flat, so there is almost surely never going to be a variable that is nearly as tricky to set. [ Incidentally, when I suggested to allow such syntax: ((python-mode . ((eglot-workspace-configuration . (("pylsp.plugins.jedi_completion.include_params" . t) ("pylsp.plugins.jedi_completion.fuzzy" . t) ("pylsp.plugins.pylint.enabled" . :json-false)))))) you said it was un-Lispy or something, but I really think it's rather the opposite. Emacs has flat names pretty much like the above. ] > Here's an idea. Let's make a bare-bones > eglot-show-workspace-configuration that simplifies this 80%. The other > 20% can for later. > > In the patch I sent for the other "workspace configuration" bug, the > .dir-locals.el is consulted late (actually it is even now). So a simple > implementation of eglot-edit-workspace-configuration could be just: > > (defun eglot-edit-workspace-configuration () (interactive) > (find-file (expand-file-name ".dir-locals.el" (project-root (project-= current))))) > > My bet is that that two-liner would go a long way. No, this is not enough. At the very least I need a history variable to look at the previous configurations. This feature has to be a thing on top of of `eglot-show-workspace-configuration'. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 16:16:21 2023 Received: (at 61868) by debbugs.gnu.org; 28 Feb 2023 21:16:21 +0000 Received: from localhost ([127.0.0.1]:52100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX7Ke-0004LR-Ss for submit@debbugs.gnu.org; Tue, 28 Feb 2023 16:16:21 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:46686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX7Kd-0004LE-BG for 61868@debbugs.gnu.org; Tue, 28 Feb 2023 16:16:19 -0500 Received: by mail-ed1-f49.google.com with SMTP id o15so43184699edr.13 for <61868@debbugs.gnu.org>; Tue, 28 Feb 2023 13:16:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:disposition-notification-to :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A7wJWRXzKllJw/0iJ8uU5WqzgdZI5XJGXAQ5D513RbM=; b=T0VKKmFB3M4obDlSoZtI69b5Dv9l0qpj+wuKbVuMAQ/RTB1cC6EBurbt0vCJWQQfDk ilAmsDed9jF/NWv9lFYjSkdvMr+b5iEahlwIeDtMV/yS3FRX0UVIToifnOtXHIOdH2oL 2ETpJkCX6WUZ+d0xuW7jpI85orUtnv9XBcNMRnD79wk01A4vG3NlUQ4OoUSC8p5EbSqa e+jds9OIfX78zA52w0rkwQw9KyuVt4BVF72xMvEAQo5nX44cAwgpVQTsUdyZ62j7ZF9O ghhE29iiS/HxmZIuoTL0OSE9H0ZG8lTpVN6HF+7jFAr+HCpL0Hrz7YALP+ugGl6SfoQy SpVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:disposition-notification-to :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=A7wJWRXzKllJw/0iJ8uU5WqzgdZI5XJGXAQ5D513RbM=; b=n0tCAzgyEGGTHP+UHb3m1mdrppm35gnEquCFyfYqeJSSgO/jjq9o5kHkUyWE7WU6Tm wLiPIpklba1zwuzjMeh5U4pTE7GctQOKWHyQguQHx5+/iQWB7yaBbKcMbImNbIb+88Sq f64EByCyBPFRtG0naHzq9SLK0ADBvYhrz3uecN138IjtTCV0BWUE2ZsdQsZnv1fz7AyO IYSJY9Pdf189kQEt4mT7C9yEG2tELJrs/uo5plkHeWFa1RKoUwdHyZuoF2eZEoC7e7js l2CyUHYAp5IQpM1xBe7101n4GAXKThb6pP/nItZUEUsLtgcvj54rNciJzTwpM4s8vIOk SHqA== X-Gm-Message-State: AO0yUKVCPxhxXGfPxO6gUe+D+hUNhz9MwQYzDMrqRZmLeFDH0iXIvKVR 7V7nUJmv5eY2852DdtrXzhaqNWhVxTNaQA== X-Google-Smtp-Source: AK7set/ljsnD1qD0BLAaDNm/sscdM4/vVO6B2VZLNevnZ7SO+3ON5QFBm8wKORIBqa+/yRjvFlAM4w== X-Received: by 2002:a17:906:1658:b0:879:ab3:93cd with SMTP id n24-20020a170906165800b008790ab393cdmr4346590ejd.46.1677618972707; Tue, 28 Feb 2023 13:16:12 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::8b3a]) by smtp.gmail.com with ESMTPSA id h6-20020a170906398600b008cf377e8795sm4889797eje.199.2023.02.28.13.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 13:16:12 -0800 (PST) From: Augusto Stoffel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#61868: 29.0.60; Eglot: setting "workspace" configurations should be easier In-Reply-To: <87sfepa5pz.fsf@gmail.com> (Augusto Stoffel's message of "Tue, 28 Feb 2023 21:35:20 +0100") References: <878rgiar9o.fsf@gmail.com> <87o7pdpotl.fsf@gmail.com> <87sfepa5pz.fsf@gmail.com> Date: Tue, 28 Feb 2023 22:16:10 +0100 Message-ID: <87ilfla3tx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61868 Cc: 61868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 28 Feb 2023 at 21:35, Augusto Stoffel wrote: >> My bet is that that two-liner would go a long way. > > No, this is not enough. At the very least I need a history variable to > look at the previous configurations. This feature has to be a thing on > top of of `eglot-show-workspace-configuration'. Here's a hasty sketch of what I have in mind, sans the history commands. --8<---------------cut here---------------start------------->8--- ;; -*- lexical-binding: t; -*- (defvar eglot-configuration-map (let ((map (make-sparse-keymap))) (define-key map "\C-c\C-c" #'eglot-configuration-save) (define-key map "\C-c\C-v" #'eglot-configuration-apply) (define-key map "\C-c\C-k" #'kill-current-buffer) map)) (define-minor-mode eglot-configuration--mode "Mode to edit LSP config" :interactive nil :keymap eglot-configuration-map (setq-local header-line-format (substitute-command-keys "\ \\\ Press \\[eglot-configuration-apply] to apply, \\[eglot-configuration-save] to save, \\[kill-current-buffer] to abort."))) (defun eglot-configuration-apply (&optional save) (interactive) (let ((eglot-workspace-configuration (save-excursion (goto-char (point-min)) (jsonrpc--json-read)))) (with-current-buffer eglot-configure--buffer (eglot-signal-didChangeConfiguration (eglot--current-server-or-lose)) (when save (save-window-excursion (let ((default-directory (project-root (eglot--current-project)))) (add-dir-local-variable nil ;; Tricky choice 'eglot-workspace-configuration eglot-workspace-configuration) (save-buffer))))))) (defun eglot-configuration-save () (interactive) (eglot-configuration-apply t)) (defvar-local eglot-configure--buffer nil) ;; Ugh, get rid of this? (defun eglot-configure (&optional server) "Dump `eglot-workspace-configuration' as JSON for debugging." (interactive (list (and (eglot-current-server) (eglot--read-server "Server configuration" (eglot-current-server))))) (let ((buffer (current-buffer)) (conf (eglot--workspace-configuration-plist server))) (with-current-buffer (get-buffer-create "*EGLOT workspace configuration*") (erase-buffer) (insert (jsonrpc--json-encode conf)) (with-no-warnings (require 'json) (when (functionp #'js-json-mode) (js-json-mode)) (json-pretty-print-buffer)) (setq eglot-configure--buffer buffer) (eglot-configuration--mode) (pop-to-buffer (current-buffer))))) --8<---------------cut here---------------end--------------->8--- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 21:07:18 2023 Received: (at 61868) by debbugs.gnu.org; 1 Mar 2023 02:07:18 +0000 Received: from localhost ([127.0.0.1]:52282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXBsD-0003nb-Tc for submit@debbugs.gnu.org; Tue, 28 Feb 2023 21:07:18 -0500 Received: from mail-ed1-f50.google.com ([209.85.208.50]:41846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXBs8-0003nI-4W for 61868@debbugs.gnu.org; Tue, 28 Feb 2023 21:07:16 -0500 Received: by mail-ed1-f50.google.com with SMTP id ec43so47958361edb.8 for <61868@debbugs.gnu.org>; Tue, 28 Feb 2023 18:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677636425; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ZVEYOBXD8jvhRQ8tTP8oT45/CBNwZv5qeGwGDi9M38=; b=WfksxRH1ntWUtDFjb5Z/V3rvUy4gGpfIeCXDeRwYANsMi+FSHKPBcZOyCvND1oiNAk VwS2ro0ZbQhPvdG14s0isH3YvscPbHB1RMux7/aDrqc/IjSL0CsP6/sV4wBWKSrCR35w rqE/icC/WvnFeRi2K2OCn2LL+ecYc8Pf+otQqcGyfGE4IxLmbHXTPoUQgC0XNaXLzqMi ntNmKY5XtY3HBRzshlkR0G6+9JGiPJ1ZAuYKiL81a+heVgvs8uX7wBglR7QsCSgB3LuX csL6ZszRd2fTzxH4+c0jfXufzuHsONLqB0geLKzuAWRJTDTQL6TLxfySQ+5tMxJtAG7A EFjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677636425; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6ZVEYOBXD8jvhRQ8tTP8oT45/CBNwZv5qeGwGDi9M38=; b=a+4vFbLqZJ6UzwMPJuCQEG+ZaMWSoEtgf92S8p1QWNeHs9W6hPFmh9vrl5F8A1QZR5 CGxWfQPdPrdi1/XZbRzlEmXNlWFljb3NQBae3OZ7MluAU6jaVfcMgo49TtGC/f0N5ceM iqLq5sWjtMyODb2LDfS0VaHhiPZIyoOZoydsOLIQN9Ia0J1wADaVABicLugEf6wwsoQV SJz8pKgWZtFvOAgIAKHczZBCMWiffGV7SPI2NuSHo+1KSQEDEAy5ZSQF2cWYNtIuPtaV IKtFgb4x86AK72RCfF/r2reUdxBYnD2tJuGWXkCBmd1EQXWBeD32z4vljjvYCfX3P+iB e3lw== X-Gm-Message-State: AO0yUKXeyYSiSFPy50dvk8euAg1xNFhgg4Y2cM6v01eBzfnbKrCUPNr8 k5OTwyld2C5XJEOAUqoWchHZR/4bgCQ= X-Google-Smtp-Source: AK7set/S00mbUsJ4er6HgwRTFLtWlIqWeKO1Sk/PSrCQMnCnxNEaFWk7qtKbxreY1MDB748wo9qvdA== X-Received: by 2002:a5d:5604:0:b0:2c7:832:8fc0 with SMTP id l4-20020a5d5604000000b002c708328fc0mr3599532wrv.3.1677636006072; Tue, 28 Feb 2023 18:00:06 -0800 (PST) Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id v16-20020a5d4b10000000b002c56013c07fsm11046508wrq.109.2023.02.28.18.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 18:00:05 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Augusto Stoffel Subject: Re: bug#61868: 29.0.60; Eglot: setting "workspace" configurations should be easier In-Reply-To: <87sfepa5pz.fsf@gmail.com> (Augusto Stoffel's message of "Tue, 28 Feb 2023 21:35:20 +0100") References: <878rgiar9o.fsf@gmail.com> <87o7pdpotl.fsf@gmail.com> <87sfepa5pz.fsf@gmail.com> Date: Wed, 01 Mar 2023 02:02:00 +0000 Message-ID: <87v8jlns9z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61868 Cc: 61868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Augusto Stoffel writes: > I see this differently. Emacs doesn't have deeply nested namespaces for > variables and user options. It's all pretty flat, so there is almost > surely never going to be a variable that is nearly as tricky to set. Oh but no :-) there are even scary DSLs in Emacs variables. See project-kill-buffer-conditions for example. And customize-variable groks it. In effect you want something like customize-variable, but different UI and with support for saving to .dir-locals.el. I sympathize with the idea, I really do, for two distinct reasons: * I agree learning about dir-locals.el and its relation to a project's configuration is confusing for newcomers * I personally get extremely confused, even intimidated, by the Custom UI. So if this UI appears elsewhere, like a separate package, Eglot can take advantage. But I'm afraid I don't like the idea of starting this in Eglot, so it's probably not going to happen as long as I am maintainer. > [ Incidentally, when I suggested to allow such syntax: > > ((python-mode > . ((eglot-workspace-configuration > . (("pylsp.plugins.jedi_completion.include_params" . t) > ("pylsp.plugins.jedi_completion.fuzzy" . t) > ("pylsp.plugins.pylint.enabled" . :json-false)))))) > > you said it was un-Lispy or something, but I really think it's rather > the opposite. Emacs has flat names pretty much like the above. ] It's indeed un-Lispy, but it's not very hard to write a helper function to turn that into a plist, is it? >> (defun eglot-edit-workspace-configuration () (interactive) >> (find-file (expand-file-name ".dir-locals.el" (project-root (project= -current))))) >> >> My bet is that that two-liner would go a long way. > > No, this is not enough. At the very least I need a history variable to > look at the previous configurations. This feature has to be a thing on > top of of `eglot-show-workspace-configuration'. That idea is the best I can offer for now. You'd have undo for history, which is not bad. And Git, since it's a file after all. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 02:39:11 2023 Received: (at 61868) by debbugs.gnu.org; 1 Mar 2023 07:39:11 +0000 Received: from localhost ([127.0.0.1]:52515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXH3O-0007bK-Rn for submit@debbugs.gnu.org; Wed, 01 Mar 2023 02:39:11 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:42497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXH3M-0007b5-M7 for 61868@debbugs.gnu.org; Wed, 01 Mar 2023 02:39:09 -0500 Received: by mail-ed1-f46.google.com with SMTP id o12so50074813edb.9 for <61868@debbugs.gnu.org>; Tue, 28 Feb 2023 23:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :disposition-notification-to:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=7UrYVY8VvzY8ehCq71nzfveaK1S3k9maFHuFkf9/Wzk=; b=MXTRkEFY3AdjxYmjed8YGGou9HRleLLXzDpeHAPhtD0xo80lcHJRQ6M6up76Z0SF6M JQ1hWoB39y1kio2PyrQwQksYsPW2yLTOK7HltO3dzLHeqpxRDm41/oJDQG9e4cJwH6T5 0I6oU3eDkD73+y72iQOVWZf8DsqYSwMSzkRrc2i0+GeuU50rqPdUzkDnTTO1rQkEmel2 qtNnVzG7TG0P3U7/jotq+gV/SF+YP+niBpeBmVIuyEaZN9TLQxs1d8kxC3RWyBHLZ45y N7DIQeU46mYlDA/+UjbeeVn1PT0ryObt3b6dtp1xZiHhQ7yFq3MFUe5G6jcvsL2Tql8m csag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :disposition-notification-to:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7UrYVY8VvzY8ehCq71nzfveaK1S3k9maFHuFkf9/Wzk=; b=qHPCFJU5QRvWCMURDq6D23aB6d//7RCMR0Lesd+Rwuwh9e1jsuK7gsAr1I8b4IFl5Q ZVJjffZt7sNLnpSEhM98/oDirUghfn797+xlIuWbWr/Ue0IE+P4qufuL/+RSMJK0jsdg 0ZH3KNjljnEeX0rQnOAklJUi6cMuR3i5iAbgKlMIXprDkGtxj5gQxlB2A8YAsex7qy9q L+JJQhf3WILmIXqi7/T27bWj9W1JY1H+RNcKRw4HKVda588lqLDsYQoZifReIhKT0zam CRQRxrmoeLOz6Rq75s9TNIWrPQ7x6yEVvDfomh23nDi1E3fqYZGLejsw3Bv4d8lHc69S IjHQ== X-Gm-Message-State: AO0yUKUDvorx3EVAblIRRW13xRxVgaVyBU0WhlfNWqz1nOCLL+dI4+G0 6qVUBSv5KkArQdb+6X3lwB97yL8siEr4qg== X-Google-Smtp-Source: AK7set+6oS7Z9WA2pXzOdwieApfITIFk9hl6EW7ibndtWBfVqJuqoS3r+UIb1pleaFA8gM0I0d+/tg== X-Received: by 2002:a17:907:a0c8:b0:8b1:7de3:cfaa with SMTP id hw8-20020a170907a0c800b008b17de3cfaamr8453762ejc.3.1677656342295; Tue, 28 Feb 2023 23:39:02 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::8b3a]) by smtp.gmail.com with ESMTPSA id v10-20020a50c40a000000b004bd1fe2cc02sm126927edf.16.2023.02.28.23.39.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 23:39:01 -0800 (PST) From: Augusto Stoffel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#61868: 29.0.60; Eglot: setting "workspace" configurations should be easier In-Reply-To: <87v8jlns9z.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Wed, 01 Mar 2023 02:02:00 +0000") References: <878rgiar9o.fsf@gmail.com> <87o7pdpotl.fsf@gmail.com> <87sfepa5pz.fsf@gmail.com> <87v8jlns9z.fsf@gmail.com> Date: Wed, 01 Mar 2023 08:39:00 +0100 Message-ID: <87k000x6nf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61868 Cc: 61868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, 1 Mar 2023 at 02:02, Jo=C3=A3o T=C3=A1vora wrote: > Oh but no :-) there are even scary DSLs in Emacs variables. See > project-kill-buffer-conditions for example. And customize-variable > groks it. Yes, but the server configuration is not a DSL. It's just a list of variable names, but with deeply nested namespace. So, say pylsp.plugins.jedi_completion.include_params can only be true of false. There is no mini-language to say when it's effectively true of false. > In effect you want something like customize-variable, but different UI > and with support for saving to .dir-locals.el. I sympathize with the > idea, I really do, for two distinct reasons: A Customize kind of UI would be really cool, but then LSP needs a new capability whereby the server sends a "schema" of the accepted options (their names, types, documentation, etc.) > So if this UI appears elsewhere, like a separate package, Eglot can take > advantage. But I'm afraid I don't like the idea of starting this in > Eglot, so it's probably not going to happen as long as I am maintainer. The UI I'm suggesting is absolutely commonplace in Emacs: you edit the eglot-show-workspace-configuration buffer and press C-c C-c to commit the changes. Compare with VC log, Magit commit, Org capture, PDF-Tools annotations. We'll just use the same base libraries. >> [ Incidentally, when I suggested to allow such syntax: >> >> ((python-mode >> . ((eglot-workspace-configuration >> . (("pylsp.plugins.jedi_completion.include_params" . t) >> ("pylsp.plugins.jedi_completion.fuzzy" . t) >> ("pylsp.plugins.pylint.enabled" . :json-false)))))) >> >> you said it was un-Lispy or something, but I really think it's rather >> the opposite. Emacs has flat names pretty much like the above. ] > > It's indeed un-Lispy, but it's not very hard to write a helper function > to turn that into a plist, is it? Is it though? Replace the dots by hyphens, and you will find some real Emacs user options: vc.svn.program vc.git.program vc.git.log-edit.summary.target-len vc.git.log-edit.summary.max-len >>> (defun eglot-edit-workspace-configuration () (interactive) >>> (find-file (expand-file-name ".dir-locals.el" (project-root (projec= t-current))))) >>> >>> My bet is that that two-liner would go a long way. >> >> No, this is not enough. At the very least I need a history variable to >> look at the previous configurations. This feature has to be a thing on >> top of of `eglot-show-workspace-configuration'. > > That idea is the best I can offer for now. You'd have undo for history, > which is not bad. And Git, since it's a file after all. This command is not really very useful, and if it were it would belong in files-x.el. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 08:21:04 2023 Received: (at 61868) by debbugs.gnu.org; 1 Mar 2023 13:21:04 +0000 Received: from localhost ([127.0.0.1]:52975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXMOG-0001PT-Mf for submit@debbugs.gnu.org; Wed, 01 Mar 2023 08:21:04 -0500 Received: from mail-oa1-f52.google.com ([209.85.160.52]:43810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXMOE-0001Ob-SH for 61868@debbugs.gnu.org; Wed, 01 Mar 2023 08:21:03 -0500 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-17638494edbso140063fac.10 for <61868@debbugs.gnu.org>; Wed, 01 Mar 2023 05:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677676857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mFn2xHvqVzzMQHZ4HDQlfAV7oI6SbLDHf+fs1e8SpRw=; b=LBaJDF6oJHhfIJa1fXOJscD6tj+yOyImO48nedPRQYnPTqI8g2mSHS4icCrl+3wrtt xRNYgg3S4i1ybJZC8VthNrN9KB+aeGwnyGVnVQH67TiQJFDOkZx91yNgNhpI36VCNA9G GSASfCbI/4NsnZUMswncoeOObQRUcMNo21WM/83SZCBeMfKk+u1g9GGqkiebX5TD08nC avkULuqVIjeOU2Kqfe5j8wG0ssA5Nz0Gw2VqDHd6EgW7OIp6M2nUeSP8zBmx+eErrda9 lcTTbjXrjlsgotJQ9k4bEcjQk+ih0lrmbfH6Af0eLI74epCx+o/HpGECk3iciOXfICdf uJfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677676857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mFn2xHvqVzzMQHZ4HDQlfAV7oI6SbLDHf+fs1e8SpRw=; b=Cux9Ysbq3eW8PRORY8LxTdD+g6+eiZCThBeaO9Xe8cPWwZ9q6tCSBYewut+1Tm8BXx m8WAR8jn6+juIBIcdjne8Zx+jvtPJLB6Zqeo86167jlVfuZKHvk543hcR5YQCJoq4iia guxGcK98hcDTHzfXt8kEqyhYX3IQ6ZIRl3w0ZCYbUNC26BvOJK3a6QgvdhdWJeKyz0wB bDlH/DK5FX1jKThtemO39zK8kpiOX4CUgTTsKZyBuoKiKVZIvFQnDj6mSz09X/rG+KkW jfwC7ZKA4jp5FPzGxi1wvsyo8beNcbNqjvSwvTvoANhL6YMFRjZDhhzvzTC0A/487hRD YApA== X-Gm-Message-State: AO0yUKWoNmz9k9RyhiWlVzR7Gn+20NFZbewoYkbTUDwYwoWMm3NtGEGx zqrznGVzmxGz4dWMUzOG/70wUMKeJ4wqK5Ub/4k= X-Google-Smtp-Source: AK7set9aj1KXbcE7hXsbd/qKDhbA/UyHt6tUPG2QaGuD3yaXWL76YCH42hxXrA/XC13zlXdWJkBVvWjgGQ2wFwEiTHw= X-Received: by 2002:a05:6870:3a11:b0:16d:c1da:ad83 with SMTP id du17-20020a0568703a1100b0016dc1daad83mr1844085oab.8.1677676857304; Wed, 01 Mar 2023 05:20:57 -0800 (PST) MIME-Version: 1.0 References: <878rgiar9o.fsf@gmail.com> <87o7pdpotl.fsf@gmail.com> <87sfepa5pz.fsf@gmail.com> <87v8jlns9z.fsf@gmail.com> <87k000x6nf.fsf@gmail.com> In-Reply-To: <87k000x6nf.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 1 Mar 2023 13:20:46 +0000 Message-ID: Subject: Re: bug#61868: 29.0.60; Eglot: setting "workspace" configurations should be easier To: Augusto Stoffel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61868 Cc: 61868@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Mar 1, 2023 at 7:39=E2=80=AFAM Augusto Stoffel wrote: > A Customize kind of UI would be really cool, but then LSP needs a new > capability whereby the server sends a "schema" of the accepted options > (their names, types, documentation, etc.) If this feature gets added to Emacs, Eglot will probably recommend it in the manual. I hope it's not a "Customize kind of UI", though. Editing sexps deserves better. > > It's indeed un-Lispy > Is it though? Replace the dots by hyphens, and you will find some real > Emacs user options: > > vc.svn.program > vc.git.program > vc.git.log-edit.summary.target-len > vc.git.log-edit.summary.max-len Gargantuan variable names are not what I would call the most Lispy part of Emacs. Jo=C3=A3o