From unknown Mon Jun 23 15:01:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 27 Feb 2023 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 61853@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167753440726339 (code B ref -1); Mon, 27 Feb 2023 21:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Feb 2023 21:46:47 +0000 Received: from localhost ([127.0.0.1]:49025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWlKY-0006ql-Na for submit@debbugs.gnu.org; Mon, 27 Feb 2023 16:46:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:58176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWlKW-0006qd-II for submit@debbugs.gnu.org; Mon, 27 Feb 2023 16:46:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWlKV-00061s-M1 for bug-guix@gnu.org; Mon, 27 Feb 2023 16:46:44 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWlKT-0007LL-69 for bug-guix@gnu.org; Mon, 27 Feb 2023 16:46:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=6wR3J5N1PbcY0Dtne0pKVee45aj1eHsBtxzndwJnN9w=; b=jT+N30uHnJrveimJ58AVXH/63+tMCLIHcpqnEAxM+MTRMdeEWU/5C4gn 4hBy8XG7IbVoxuKjbGqa4Z7ikBwgRKsi1WICsS5JO8dvXv3IHX8G7gPTY RZ7MUJ0p2SJ/xw9b/9sE5LMqY/9A3B8yPB8g1w+UCqN3bgHYDyHTQ67+o Q=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.98,220,1673910000"; d="scan'208";a="48767952" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 22:46:38 +0100 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 =?UTF-8?Q?Vent=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Marsault X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 27 Feb 2023 22:46:37 +0100 Message-ID: <871qmahjcy.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.104; envelope-from=ludovic.courtes@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The two tests/guix-pack*.sh tests fail: --8<---------------cut here---------------start------------->8--- $ make check TESTS=3D"tests/guix-pack.sh tests/guix-pack-relocatable.sh" -j5 make check-recursive make[1]: Entering directory '/home/ludo/src/guix' Making check in po/guix make[2]: Entering directory '/home/ludo/src/guix/po/guix' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/ludo/src/guix/po/guix' Making check in po/packages make[2]: Entering directory '/home/ludo/src/guix/po/packages' make[2]: Nothing to be done for 'check'. make[2]: Leaving directory '/home/ludo/src/guix/po/packages' make[2]: Entering directory '/home/ludo/src/guix' Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... make check-TESTS check-local make[3]: Entering directory '/home/ludo/src/guix' make[3]: Nothing to be done for 'check-local'. make[4]: Entering directory '/home/ludo/src/guix' FAIL: tests/guix-pack-relocatable.sh FAIL: tests/guix-pack.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D Testsuite summary for GNU Guix 1.3.0.28826-3cff7-dirty =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D # TOTAL: 2 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 2 # XPASS: 0 # ERROR: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D See ./test-suite.log Please report to bug-guix@gnu.org =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D make[4]: *** [Makefile:6051: test-suite.log] Error 1 make[4]: Leaving directory '/home/ludo/src/guix' make[3]: *** [Makefile:6159: check-TESTS] Error 2 make[3]: Leaving directory '/home/ludo/src/guix' make[2]: *** [Makefile:6408: check-am] Error 2 make[2]: Leaving directory '/home/ludo/src/guix' make[1]: *** [Makefile:5936: check-recursive] Error 1 make[1]: Leaving directory '/home/ludo/src/guix' make: *** [Makefile:6410: check] Error 2 $ git log |head -1 commit cf9e0508b26196dc985302776d860a0359652c59 --8<---------------cut here---------------end--------------->8--- In both cases this is because $test_directory is read-only: --8<---------------cut here---------------start------------->8--- + drv1=3D' /home/ludo/src/guix/test-tmp/store/6wrnnnab33wv950cflswi8ffncwr= 99b0-guile-tarball-pack.tar.gz.drv' ++ guix pack --no-grafts -n --with-source=3Dguile=3D/tmp/tmp.olhfx3CkHh gui= le ++ grep 'pack.*.drv' accepted connection from pid 30805, user ludo + drv2=3D' /home/ludo/src/guix/test-tmp/store/f909hi2ywyyvy7l5p4ibmy26alr7= d18d-guile-tarball-pack.tar.gz.drv' + test -n ' /home/ludo/src/guix/test-tmp/store/6wrnnnab33wv950cflswi8ffncw= r99b0-guile-tarball-pack.tar.gz.drv' + test ' /home/ludo/src/guix/test-tmp/store/6wrnnnab33wv950cflswi8ffncwr99= b0-guile-tarball-pack.tar.gz.drv' '!=3D' ' /home/ludo/src/guix/test-tmp/st= ore/f909hi2ywyyvy7l5p4ibmy26alr7d18d-guile-tarball-pack.tar.gz.drv' + cat ./tests/guix-pack.sh: line 124: /tmp/tmp.olhfx3CkHh/manifest1.scm: Permissi= on denied + chmod -Rf +w /tmp/tmp.olhfx3CkHh + rm -rf /tmp/tmp.olhfx3CkHh FAIL tests/guix-pack.sh (exit status: 1) --8<---------------cut here---------------end--------------->8--- =E2=80=A6 and: --8<---------------cut here---------------start------------->8--- + run_without_store /tmp/tmp.c5oSwOgOOD/Bin/sed --version ./tests/guix-pack-relocatable.sh: line 85: /tmp/tmp.c5oSwOgOOD/output: Perm= ission denied + chmod -Rf +w /tmp/tmp.c5oSwOgOOD + rm -rf /tmp/tmp.c5oSwOgOOD FAIL tests/guix-pack-relocatable.sh (exit status: 1) --8<---------------cut here---------------end--------------->8--- Ludo=E2=80=99. From unknown Mon Jun 23 15:01:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 27 Feb 2023 23:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 61853@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 61853-submit@debbugs.gnu.org id=B61853.16775392633989 (code B ref 61853); Mon, 27 Feb 2023 23:08:01 +0000 Received: (at 61853) by debbugs.gnu.org; 27 Feb 2023 23:07:43 +0000 Received: from localhost ([127.0.0.1]:49183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmat-00012D-6i for submit@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmaq-00011x-5p for 61853@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmak-0002Lm-SB; Mon, 27 Feb 2023 18:07:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Xqz/Lf6MPYFBVkVre5ul9aNyTANM4X4Fmp+V77YvQU4=; b=WxRhgFm22EF3gGGFQ9er Nk2aM4FVfX436r1eK+Yo4FyZLJOacHTcW8RPxD+f/qZhV/82CAilvftPhz6YfQbllQr/16AuF0j00 T6/NfpU+y/qrOeFtbGrZXHhg0NZ2F2XM/SuUiOZTxYMuAKHvntafCULFhdcGduO1Dfq0DmICziOUf DrTiumV2dvRnsiFEuV3+upm4llTZM5/9nCNYs75pFULsQ1uQZZcZV96IEy+a4qj9gw4o46XroFggm RnnneEfXEm+0o/Xoxw1RS/38feQxLTY0yE7cCmK6LG0Bp5u/aMDGS4WXEyC4W8cQrsaU8E4Vi/HMV S3qLtFgaMCtE8Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmak-0003Od-A4; Mon, 27 Feb 2023 18:07:34 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871qmahjcy.fsf@inria.fr> Date: Tue, 28 Feb 2023 00:07:31 +0100 In-Reply-To: <871qmahjcy.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 27 Feb 2023 22:46:37 +0100") Message-ID: <87wn42emh8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > In both cases this is because $test_directory is read-only: This in turn is due to a permission change in generated tarballs: --8<---------------cut here---------------start------------->8--- $ guix describe Generation 248 Feb 27 2023 16:36:12 (current) guix cf9e050 repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: cf9e0508b26196dc985302776d860a0359652c59 $ guix pack hello /gnu/store/k0mjzvv76s0yn4r4mwzy6mvf71wxpbg2-hello-tarball-pack.tar.gz ludo@ribbon ~/src/guix$ tar tzvf /gnu/store/k0mjzvv76s0yn4r4mwzy6mvf71wxpbg= 2-hello-tarball-pack.tar.gz |head dr-xr-xr-x root/root 0 1970-01-01 01:00 ./ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/include/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/ -r--r--r-- root/root 2056 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/cr= tbegin.o --8<---------------cut here---------------end--------------->8--- Compared to: --8<---------------cut here---------------start------------->8--- $ guix time-machine --commit=3Dv1.4.0 -- pack hello /gnu/store/vjjavmn16mxzgrlfawjcgq5j4iqm7609-hello-tarball-pack.tar.gz $ tar tzvf /gnu/store/vjjavmn16mxzgrlfawjcgq5j4iqm7609-hello-tarball-pack.t= ar.gz | head drwxr-xr-x root/root 0 1970-01-01 01:00 ./ drwxr-xr-x root/root 0 1970-01-01 01:00 ./gnu/ drwxrwxr-t root/root 0 1970-01-01 01:00 ./gnu/store/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/include/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/ dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/ -r--r--r-- root/root 2056 1970-01-01 01:00 ./gnu/store/094bbaq6glba86h= 1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/cr= tbegin.o tar: stdout: write error --8<---------------cut here---------------end--------------->8--- That=E2=80=99s an acceptable change IMO, introduced in 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were evidently not run after that change, which is problematic. Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests now pass for me. One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that it introduces a copy of the profile being built to the store (=E2=80=9Cprofile-directory=E2=80=9D). This was purposefully avoided befor= e because it=E2=80=99s very I/O-intensive, space-consuming, and puts more pressure on= the store. It=E2=80=99s a pattern we avoided for system images too, having not= iced its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.) We may need to come back to a single derivation well or creating packs for big profiles will be too costly. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 18:07:54 2023 Received: (at control) by debbugs.gnu.org; 27 Feb 2023 23:07:54 +0000 Received: from localhost ([127.0.0.1]:49187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmb3-00012n-SZ for submit@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmb2-00012U-TU for control@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmav-0002MW-WD for control@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=V+Rk6XjvUJ3zXjHe0vQvJVvDgAyd8uWukGaTEMVgSqE=; b=oZuCmswYneqvxY ykaK7BcO69pRNs5dUzgzxLf/+pk/F+JCV6spwsoD1SxcPf2Yu4QMmDyBNUGSUKDVajtJIMRtyRt1G IqHMhss4vP9genQp1qRAI6jSZcegZ8Egixcdi7pivseo5QnKw98+w7nUNJQh76kUjjNRD4rjx75Er FTsbF/6eWsLGId83sDoVBkviAZ3Fcjst9v5R+irK7penafr1F7tv8rLfTPbd6ahyQTK7xayzQM+TJ iXxPSHG0dAK4pvlUp7s0eJZzbmbbx0w2rte/Q9WTytzTbys4N8kJRM7hRluOHljwsKY8Gxn9HDtrU 4beGSn+LN0c2x+viJd8w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmav-0003Ok-3D for control@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:45 -0500 Date: Tue, 28 Feb 2023 00:07:43 +0100 Message-Id: <87v8jmemgw.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #61853 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 61853 important quit From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 18:07:58 2023 Received: (at control) by debbugs.gnu.org; 27 Feb 2023 23:07:58 +0000 Received: from localhost ([127.0.0.1]:49191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmb8-000135-6s for submit@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmb6-00012f-OG for control@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmaz-0002Ms-Qq for control@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=910pxX55Bbq3Lq30dM66lwVcPGbKQeLFwgusNtpTpBo=; b=omFm8b2fSAsVGb R93QkMtyZwRWFbJ26Oyo80tnSmjp4aYPLorsTevUG9AP4KN6vDDpLnkyp1uY8rGbYfuENPVD/cI+4 9Tjy0Q+d9yR5Vin4lXD+6muslKq25bB8Mceej5wSHD5gO2ZIXjHqNUyQw9iCiaHVETVkERR5QxAiW vDYq1wdyw4YSvh1eRfHSyTKwDFTMo65vSPvIC3gR8LJS/Gw7Ig3v+mofYIcEdLN/kfix7jy5jNKbf TkBvZSzwk1G3jNbz8GrMskHzVAwwdhscI0bkK585vNLv9B+lW9aURD++nzCd+F9g1NIbqwnerz+HT iVQ0idESa2xnA2RLVxIQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmay-0003QP-Fv for control@debbugs.gnu.org; Mon, 27 Feb 2023 18:07:49 -0500 Date: Tue, 28 Feb 2023 00:07:47 +0100 Message-Id: <87ttz6emgs.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #61853 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 61853 quit From unknown Mon Jun 23 15:01:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 28 Feb 2023 02:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61853@debbugs.gnu.org Received: via spool by 61853-submit@debbugs.gnu.org id=B61853.167755053012590 (code B ref 61853); Tue, 28 Feb 2023 02:16:03 +0000 Received: (at 61853) by debbugs.gnu.org; 28 Feb 2023 02:15:30 +0000 Received: from localhost ([127.0.0.1]:49388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWpWb-0003H0-Ub for submit@debbugs.gnu.org; Mon, 27 Feb 2023 21:15:30 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:39666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWpWY-0003Gj-NY for 61853@debbugs.gnu.org; Mon, 27 Feb 2023 21:15:28 -0500 Received: by mail-qt1-f173.google.com with SMTP id w23so9030762qtn.6 for <61853@debbugs.gnu.org>; Mon, 27 Feb 2023 18:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qu6s89WdOd4+KvCwPnbC8AxBI2o/qWoHeqrEjv2CfWM=; b=pZG6ZkbprMp6UoTUQKmd5Sn97AQ7+QT2xGWNkGHSGgNEb0486RPZzDViHfbdd/wbE/ 9Ca/fzpVVa5W66gTEXpt0igkT9LPXU1dW7ci39lNdGszrgbLNjeVHt8qqrZtmZahLO8K rT8xw5mgWjompHenfcutzcgzD7rEN404mTm2LDgdoyy+6Nfdgr4D4WB2Pvjvf/lFqQs4 I37ZZBr1gQxr9ZrQjVgNGGXEePSRR02DDp7TgLNVZt5GMyaynP9GFbgAm43g5KzwO2HM wkvA7mh/TM5rW/gItrkAq/A9kZahA29P0W9Dc90E2S8fJ2FzWarTu42FvoeKL1bf3KcM SAFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qu6s89WdOd4+KvCwPnbC8AxBI2o/qWoHeqrEjv2CfWM=; b=ukjsffk9tm/I0CWYI+I86PtVRuWmSqx8IzcwOMV/TCiHNKz1KWUKbdoK6hEg+CI2Ik G/cXL+lgpaMniaNyjcHMcw/zb3C6Ha4O9G4vYAlRSjh2VmvdrJxA6FNg+tVJ8gz/t1rl udeXPCvXa+hP49Q80exw0FNVKoqOS0PkCSY4QE3RIf1GKz0twyr2pTcKiIiXGJHuzbWz xONxGPFdiuSSJN0szqL8zGow3jAHN3ej2T57TGIcVm22vAbIvzI+6JRK007Dlp6Egnzp E2BPh0oxgL9TwMISuxJMM4bJrOhBCrxsVxamszLLeoieaZxY/8IUzMCmg9TNOGSIauYn pHgQ== X-Gm-Message-State: AO0yUKXnV/L2PisajR7CSTZkhB3SWuI2Wrv+/mnSmmW92ApMWB3LDS+L sOfFG78beWeHC5G5hKd9b8v6zzjEG2e2/tbL X-Google-Smtp-Source: AK7set9gVi6lQeJbqp42+gPZY9wkfA6NcAtf8Ox67ZuUxO+Nmwfbv7KVdfBxFqal3gQWSW4C1971ew== X-Received: by 2002:a05:622a:1206:b0:3bf:db29:b793 with SMTP id y6-20020a05622a120600b003bfdb29b793mr2246069qtx.20.1677550520928; Mon, 27 Feb 2023 18:15:20 -0800 (PST) Received: from hurd (dsl-156-86.b2b2c.ca. [66.158.156.86]) by smtp.gmail.com with ESMTPSA id c20-20020a05620a269400b0073b81e888bfsm5916465qkp.56.2023.02.27.18.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 18:15:20 -0800 (PST) From: Maxim Cournoyer References: <871qmahjcy.fsf@inria.fr> <87wn42emh8.fsf@gnu.org> Date: Mon, 27 Feb 2023 21:15:18 -0500 In-Reply-To: <87wn42emh8.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 28 Feb 2023 00:07:31 +0100") Message-ID: <87v8jmilhl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> In both cases this is because $test_directory is read-only: > > This in turn is due to a permission change in generated tarballs: > > $ guix describe > Generation 248 Feb 27 2023 16:36:12 (current) > guix cf9e050 > repository URL: https://git.savannah.gnu.org/git/guix.git > branch: master > commit: cf9e0508b26196dc985302776d860a0359652c59 > $ guix pack hello > /gnu/store/k0mjzvv76s0yn4r4mwzy6mvf71wxpbg2-hello-tarball-pack.tar.gz > ludo@ribbon ~/src/guix$ tar tzvf /gnu/store/k0mjzvv76s0yn4r4mwzy6mvf71wxp= bg2-hello-tarball-pack.tar.gz |head > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/include/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/ > -r--r--r-- root/root 2056 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/= crtbegin.o > > > Compared to: > > $ guix time-machine --commit=3Dv1.4.0 -- pack hello > /gnu/store/vjjavmn16mxzgrlfawjcgq5j4iqm7609-hello-tarball-pack.tar.gz > $ tar tzvf /gnu/store/vjjavmn16mxzgrlfawjcgq5j4iqm7609-hello-tarball-pack= .tar.gz | head > drwxr-xr-x root/root 0 1970-01-01 01:00 ./ > drwxr-xr-x root/root 0 1970-01-01 01:00 ./gnu/ > drwxrwxr-t root/root 0 1970-01-01 01:00 ./gnu/store/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/include/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/ > dr-xr-xr-x root/root 0 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/ > -r--r--r-- root/root 2056 1970-01-01 01:00 ./gnu/store/094bbaq6glba8= 6h1d4cj16xhdi6fk2jl-gcc-10.3.0-lib/lib/gcc/x86_64-unknown-linux-gnu/10.3.0/= crtbegin.o > tar: stdout: write error > > That=E2=80=99s an acceptable change IMO, introduced in > 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were > evidently not run after that change, which is problematic. Interesting. I had done all my testing using tests/pack.scm (and the new tests/rpm.scm), and overlooked tests/pack.sh. > Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests > now pass for me. Thanks (again)! > One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that > it introduces a copy of the profile being built to the store > (=E2=80=9Cprofile-directory=E2=80=9D). This was purposefully avoided bef= ore because > it=E2=80=99s very I/O-intensive, space-consuming, and puts more pressure = on the > store. It=E2=80=99s a pattern we avoided for system images too, having n= oticed > its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.) > > We may need to come back to a single derivation well or creating packs > for big profiles will be too costly. I agree it's expensive; we're trading IO for storage though, so the case of generating the same pack in multiple format, it could be beneficial by only computing the union directory once. The real motivation was avoiding code duplication though; perhaps this could be accomplished by moving the common logic to (guix build pack-utils)? --=20 Thanks, Maxim From unknown Mon Jun 23 15:01:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Mar 2023 10:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 61853@debbugs.gnu.org Received: via spool by 61853-submit@debbugs.gnu.org id=B61853.167784024827781 (code B ref 61853); Fri, 03 Mar 2023 10:45:03 +0000 Received: (at 61853) by debbugs.gnu.org; 3 Mar 2023 10:44:08 +0000 Received: from localhost ([127.0.0.1]:59691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY2tT-0007E1-RV for submit@debbugs.gnu.org; Fri, 03 Mar 2023 05:44:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY2tR-0007DR-NU for 61853@debbugs.gnu.org; Fri, 03 Mar 2023 05:44:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY2tM-0000CM-Bt; Fri, 03 Mar 2023 05:44:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Jo1Ia9TDhEf4oQCIq1tFmGcq//6ji0FK4qbmzDBTvus=; b=QuGAdCVnjfzOg2i2e7zf KxwZeSORFWgsI6y5gms2IFlApuPipPQGITXzxiz6dNoIliN+7h9qVuROPOJixLXdzduOwyQPDqBJN OApfNviCBRt3nOA30BNwR3faA5TYbK6Z3S8LlSJcYop4aTYrMEsU6n67tgAJ6Y4Bnk1l8/U22vCKS kkwghalUFO7PgHVHtDpOTGy/73T6D8HW5UpLpTtv2OuUYgmtE5rwoegdQWdO8h6i/r1C8yOrhFQ40 O6WEaDMFI2j/Z3X5uMNS63CgwYcsDVsbt2rAnLK+IOdhrSHTwHTNinPn15lzp98/aBSvU4RkmLvyS 59ytaXYVCjqAnA==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY2tL-0005NA-Oc; Fri, 03 Mar 2023 05:43:59 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871qmahjcy.fsf@inria.fr> <87wn42emh8.fsf@gnu.org> <87v8jmilhl.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 13 =?UTF-8?Q?Vent=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Fumeterre X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 Mar 2023 11:43:55 +0100 In-Reply-To: <87v8jmilhl.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 27 Feb 2023 21:15:18 -0500") Message-ID: <87cz5qyv10.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: [...] >> That=E2=80=99s an acceptable change IMO, introduced in >> 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were >> evidently not run after that change, which is problematic. > > Interesting. I had done all my testing using tests/pack.scm (and the > new tests/rpm.scm), and overlooked tests/pack.sh. =E2=80=A6 >> Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests >> now pass for me. > > Thanks (again)! To be clear, it=E2=80=99s time-consuming and stressful. That=E2=80=99s not= sane and I=E2=80=99d rather not work that way. >> One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that >> it introduces a copy of the profile being built to the store >> (=E2=80=9Cprofile-directory=E2=80=9D). This was purposefully avoided be= fore because >> it=E2=80=99s very I/O-intensive, space-consuming, and puts more pressure= on the >> store. It=E2=80=99s a pattern we avoided for system images too, having = noticed >> its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.) >> >> We may need to come back to a single derivation well or creating packs >> for big profiles will be too costly. > > I agree it's expensive; we're trading IO for storage though, so the case > of generating the same pack in multiple format, it could be beneficial > by only computing the union directory once. The real motivation was > avoiding code duplication though; perhaps this could be accomplished by > moving the common logic to (guix build pack-utils)? Yes, that=E2=80=99s a good idea. There=E2=80=99s already (guix build pack)= and I guess we could move roughly the contents of =E2=80=98self-contained-tarball/build= er=E2=80=99 and =E2=80=98populate-profile-root=E2=80=99 there. How does that sound? Thanks, Ludo=E2=80=99. From unknown Mon Jun 23 15:01:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 04 Mar 2023 03:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61853@debbugs.gnu.org Received: via spool by 61853-submit@debbugs.gnu.org id=B61853.16779001407012 (code B ref 61853); Sat, 04 Mar 2023 03:23:02 +0000 Received: (at 61853) by debbugs.gnu.org; 4 Mar 2023 03:22:20 +0000 Received: from localhost ([127.0.0.1]:35018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYITT-0001p1-Ks for submit@debbugs.gnu.org; Fri, 03 Mar 2023 22:22:20 -0500 Received: from mail-qv1-f50.google.com ([209.85.219.50]:33413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYITR-0001op-SP for 61853@debbugs.gnu.org; Fri, 03 Mar 2023 22:22:18 -0500 Received: by mail-qv1-f50.google.com with SMTP id jo29so3139169qvb.0 for <61853@debbugs.gnu.org>; Fri, 03 Mar 2023 19:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=E0VFeWboHlwqpQOcR8roaeVfgQN/KzxqaDG2QVRIK3Q=; b=HnD7C2LZ9viRInov8mGvn34tQL6saVKEGDYs7CtMImhAutRvGYIvZ308fSeSX+h5ZZ WMg96A9sY0pFSwRHz4c90zs7JWsAULpe2KMHMJI4olY+VTRZNW2ObvONYwZtQAd/SM+L IrYUPiJK1Cs3KOnmYKAF4A9rzvTj/MNkDOp97X6mZQr9npshK4lmHFZ9FB9slu0tsNgu RqGgIowpDureiT4GroKuItACuwdO+C71XNUk9KT1o6JnQTlWdlcF/hRfVlZtlfOihfH2 R/fUpOnJFdQ0TjkWEZLmQXmm1bfcIFQYaqf1W04W57ZR6l45HPntcRfr0Hlt7RGF6lLm lrVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=E0VFeWboHlwqpQOcR8roaeVfgQN/KzxqaDG2QVRIK3Q=; b=sfOsKfLqhtNg9RAuVT4iUbVwmL4l1SAnyhmhqusGZ+e/EQfIEfiWHkzgUA79epuw2c 7i0lLnT1cw2PA0l/5xLlx3oVycMeNVuppzC/MEuhPewV1JYtk9pOj7+3yR+vMbIhROr2 tYy+ADPhff87xsThhR4SDSjCcC61nZwEO9Wm0zd92fat/ICGIgdiDiflFpdVW3T9l1Vn +35s8Luyu1eoeMAqlOjuzGvUexn22SZ69pQlmPIZfd/jBOznUyTjNTtKbXMpKhPiTcn4 HfZKaTud+zVmq8R3vmBW2jbZnlC8aXoxa9EJ99sQ5nhYWJkNKVqAbYB3n8HNJ2DH8gF3 n3Pw== X-Gm-Message-State: AO0yUKVEvG/doQl07vM89zz3MliRmH3U5J3iYajtTnvY1NWIlVRhesdR 8ICSDWJV6w9imgNo446EVuyB1rXFqFtpmw== X-Google-Smtp-Source: AK7set/QhB/W3LrpIF1xCc37BrGmTaC+mU1QjYSjMi4dIidlZmvsV3Ag5XWVX3aUHJKAk5m82FV2+g== X-Received: by 2002:a05:6214:f23:b0:56e:8a00:f3a with SMTP id iw3-20020a0562140f2300b0056e8a000f3amr7766883qvb.32.1677900131817; Fri, 03 Mar 2023 19:22:11 -0800 (PST) Received: from hurd (dsl-10-129-180.b2b2c.ca. [72.10.129.180]) by smtp.gmail.com with ESMTPSA id r62-20020a374441000000b00706c1f7a608sm2914770qka.89.2023.03.03.19.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 19:22:11 -0800 (PST) From: Maxim Cournoyer References: <871qmahjcy.fsf@inria.fr> <87wn42emh8.fsf@gnu.org> <87v8jmilhl.fsf@gmail.com> <87cz5qyv10.fsf@gnu.org> Date: Fri, 03 Mar 2023 22:22:10 -0500 In-Reply-To: <87cz5qyv10.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 03 Mar 2023 11:43:55 +0100") Message-ID: <87bkl942vx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: > > [...] > >>> That=E2=80=99s an acceptable change IMO, introduced in >>> 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were >>> evidently not run after that change, which is problematic. >> >> Interesting. I had done all my testing using tests/pack.scm (and the >> new tests/rpm.scm), and overlooked tests/pack.sh. > > =E2=80=A6 > >>> Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests >>> now pass for me. >> >> Thanks (again)! > > To be clear, it=E2=80=99s time-consuming and stressful. That=E2=80=99s n= ot sane and I=E2=80=99d > rather not work that way. Again, thanks for fixing up after me, but you didn't need to put yourself under such pressure. As the author of the problematic change, the responsibility of fixing it was on me; I understand this well. >>> One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that >>> it introduces a copy of the profile being built to the store >>> (=E2=80=9Cprofile-directory=E2=80=9D). This was purposefully avoided b= efore because >>> it=E2=80=99s very I/O-intensive, space-consuming, and puts more pressur= e on the >>> store. It=E2=80=99s a pattern we avoided for system images too, having= noticed >>> its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.) >>> >>> We may need to come back to a single derivation well or creating packs >>> for big profiles will be too costly. >> >> I agree it's expensive; we're trading IO for storage though, so the case >> of generating the same pack in multiple format, it could be beneficial >> by only computing the union directory once. The real motivation was >> avoiding code duplication though; perhaps this could be accomplished by >> moving the common logic to (guix build pack-utils)? > > Yes, that=E2=80=99s a good idea. There=E2=80=99s already (guix build pac= k) and I guess > we could move roughly the contents of =E2=80=98self-contained-tarball/bui= lder=E2=80=99 > and =E2=80=98populate-profile-root=E2=80=99 there. > > How does that sound? Sounds good. See an implementation in #61949, to which you should be CC'd already (per 'etc/teams.scm cc-members HEAD^ HEAD'). --=20 Thanks, Maxim