GNU bug report logs - #61851
[PATCH] gnu: tesseract-ocr-tessdata-fast: Install tesseract config files.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#61851: closed ([PATCH] gnu: tesseract-ocr-tessdata-fast:
 Install tesseract config files.)
Date: Tue, 21 Mar 2023 03:14:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 20 Mar 2023 23:13:19 -0400
with message-id <87r0tiu78w.fsf <at> gmail.com>
and subject line Re: bug#61851: [PATCH] gnu: tesseract-ocr-tessdata-fast: Install tesseract config files.
has caused the debbugs.gnu.org bug report #61851,
regarding [PATCH] gnu: tesseract-ocr-tessdata-fast: Install tesseract config files.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
61851: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61851
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jlicht <at> fsfe.org
To: guix-patches <at> gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH] gnu: tesseract-ocr-tessdata-fast: Install tesseract config
 files.
Date: Mon, 27 Feb 2023 21:55:16 +0100

From: Jelle Licht <jlicht <at> fsfe.org>

* gnu/packages/ocr.scm (tesseract-ocr-tessdata-fast)[source]: Add recursive?
flag. Adjust hash accordingly.
[arguments]<#:phases>: Remove unneeded workaround.
---

 gnu/packages/ocr.scm | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/ocr.scm b/gnu/packages/ocr.scm
index c1cd4f061e..e07d40bda4 100644
--- a/gnu/packages/ocr.scm
+++ b/gnu/packages/ocr.scm
@@ -82,18 +82,14 @@ (define-public tesseract-ocr-tessdata-fast
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/tesseract-ocr/tessdata_fast")
+                    (recursive? #t) ; for tessconfigs
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1m310cpb87xx8l8q7jy9fvzf6a0m8rm0dmjpbiwhc2mi6w4gn084"))))
+                "1hqdsy3zdy5b9l641fvhnawkw6wpb8nkvjql78q8g47js8109mhm"))))
     (build-system copy-build-system)
-    (arguments (list #:install-plan #~'(("." "share/tesseract-ocr/tessdata"))
-                     #:phases #~(modify-phases %standard-phases
-                                  (add-after 'unpack 'delete-broken-links
-                                    (lambda _
-                                      (delete-file "configs")
-                                      (delete-file "pdf.ttf"))))))
+    (arguments (list #:install-plan #~'(("." "share/tesseract-ocr/tessdata"))))
     (home-page "https://github.com/tesseract-ocr/tessdata_fast")
     (synopsis "Fast integer versions of trained LSTM models")
     (description "This repository contains fast integer versions of trained
-- 
2.39.1

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 61851-done <at> debbugs.gnu.org, Simon South <simon <at> simonsouth.net>
Subject: Re: bug#61851: [PATCH] gnu: tesseract-ocr-tessdata-fast: Install
 tesseract config files.
Date: Mon, 20 Mar 2023 23:13:19 -0400

Hello,

Jelle Licht <jlicht <at> fsfe.org> writes:

> Hey folks,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> Hello,
>>
>> Simon South <simon <at> simonsouth.net> writes:
>>
>>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>>>> Would you be so kind as to open an issue with upstream about the
>>>> misleading doc?
>>>
>>> I would've submitted a patch already were the project not using GitHub.
>>> I don't have a GitHub account and don't intend to get one.
>>>
>>> Would anyone else be willing to be open an issue on this?
>>
>> No problem; see: https://github.com/tesseract-ocr/tesseract/issues/4025.
>
> So it seems the issue was confirmed. In addition there seems to be some
> inconsistencies between build system with regards to how the data dir is
> interpreted by tesseract:
>
> https://github.com/tesseract-ocr/tesseract/issues/4026
>
> I think it makes sense for us to apply [a version of] Simon's patch.  QA
> also seems to show green lights, ignoring the unrelated recent
> openmpi-related failures.
>
> WDYT?

I've now applied it, after writing a proper change log commit message,
and running the xvnc and lightdm system tests to get some confidence
(they make use of tesseract-ocr).

Thank you for looking into it!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.