GNU bug report logs - #61829
[PATCH 00/11] Purge pre-1.3.0 deprecated procedures & variables.

Previous Next

Full log

Message #47 received at 61829 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>, 61829 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: Re: [bug#61829] [PATCH 11/11] guix: packages: Remove
 'origin-sha256' procedure.
Date: Tue, 28 Feb 2023 13:57:49 +0100

Hi,

On lun., 27 févr. 2023 at 00:11, Bruno Victal <mirai <at> makinata.eu> wrote:

> -            origin-sha256                         ;deprecated

[...]

> -(define-deprecated (origin-sha256 origin)
> -  origin-hash
> -  (let ((hash (origin-hash origin)))
> -    (unless (eq? (content-hash-algorithm hash) 'sha256)
> -      (raise (condition (&message
> -                         (message (G_ "no SHA256 hash for origin"))))))
> -    (content-hash-value hash)))

Similarly as previously, I would not remove this without more
advertisement.


> diff --git a/tests/import-utils.scm b/tests/import-utils.scm
> index 44dff14597..1565dd610a 100644
> --- a/tests/import-utils.scm
> +++ b/tests/import-utils.scm
> @@ -141,7 +141,7 @@ (define-module (test-import-utils)
>           (license:license? (package-license pkg))
>           (build-system? (package-build-system pkg))
>           (origin? (package-source pkg))
> -         (equal? (origin-sha256 (package-source pkg))
> +         (equal? (content-hash-value (origin-hash (package-source pkg)))

This LGTM although this test was for testing origin-sha256 specifically,
I guess. :-)

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.