GNU bug report logs - #61816
30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'

Previous Next

Full log

View this message in rfc822 format

From: Visuwesh <visuweshm <at> gmail.com>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 61816 <at> debbugs.gnu.org
Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'
Date: Fri, 03 Mar 2023 07:58:07 +0530

[வியாழன் மார்ச் 02, 2023] Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:

> Manuel Giraud <manuel <at> ledu-giraud.fr> writes:
>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> [...]
>>
>>> You are right, of course.  It just feels strange to need to cater to
>>> themes in a core package, when the way themes are supposed to
>>> customize Emacs exists and can be used in this case as well.
>>>
>>> Alternatively, maybe themes should have settings for features such as
>>> this one?
>>
>> Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the
>> official Emacs themes for a start, WDYT?
>
> ... and in order to be able to use 'custom-theme-set-faces', we could
> have a 'doc-view-svg-face' (used only for its foreground and
> background).  I'm caching you up slowly 😅

Themes can also use `custom-theme-set-variables' so I did not see a need
to introduce a face when I made the patch back then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.