GNU bug report logs - #61816
30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 61816 <at> debbugs.gnu.org
Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'
Date: Thu, 02 Mar 2023 18:32:09 +0200

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: 61816 <at> debbugs.gnu.org
> Date: Thu, 02 Mar 2023 16:51:59 +0100
> 
> Manuel Giraud <manuel <at> ledu-giraud.fr> writes:
> 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> > [...]
> >
> >> You are right, of course.  It just feels strange to need to cater to
> >> themes in a core package, when the way themes are supposed to
> >> customize Emacs exists and can be used in this case as well.
> >>
> >> Alternatively, maybe themes should have settings for features such as
> >> this one?
> >
> > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the
> > official Emacs themes for a start, WDYT?
> 
> ... and in order to be able to use 'custom-theme-set-faces', we could
> have a 'doc-view-svg-face' (used only for its foreground and
> background).  I'm caching you up slowly 😅

Fine by me, that's what I proposed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.