From unknown Mon Aug 18 02:32:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61816 <61816@debbugs.gnu.org> To: bug#61816 <61816@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Reply-To: bug#61816 <61816@debbugs.gnu.org> Date: Mon, 18 Aug 2025 09:32:01 +0000 retitle 61816 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' reassign 61816 emacs submitter 61816 Manuel Giraud severity 61816 normal tag 61816 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 26 10:33:17 2023 Received: (at submit) by debbugs.gnu.org; 26 Feb 2023 15:33:18 +0000 Received: from localhost ([127.0.0.1]:44838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWJ1Y-0003I7-Vj for submit@debbugs.gnu.org; Sun, 26 Feb 2023 10:33:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:37156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWJ1T-0003Hu-Li for submit@debbugs.gnu.org; Sun, 26 Feb 2023 10:33:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWJ1T-0006Rh-Cw for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2023 10:33:11 -0500 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWJ1Q-0004Im-K0 for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2023 10:33:10 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=zoxnUJ6J pWz0rkhg063AAgkdMAav8rDwIS9SDVuedmg=; h=date:subject:to:from; d=ledu-giraud.fr; b=ek2Qpi/tnIlZxO3ZWxiqyk2FsjPEx2yp8Imryri7N1oKBQ3Fbw OGwn9sD/HMyYAP7xpcmOwGcABMIa1ZRD6XAA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=zoxnUJ6JpWz0rkhg 063AAgkdMAav8rDwIS9SDVuedmg=; h=date:subject:to:from; d=ledu-giraud.fr; b=zkZLJNqYZkaNKdvtixOtz6XXvDvlDRyyLlnUUQlgFdeCNHyTmI 6n3ftBRFGaIJH8/g8zllgDr7NsA4OVAnivgnDHscCQ/A2UPvb1nXLPcgr25GEhVnMvaedk fDIrOPp0P+YIvMjeijSBKToSgLD4TjeSEPGu0Ud+amwzFtrkv54Lqg7TibMPAFiGot54p6 CH/HoqZZE6M6UeIbr5TV5KATLhjjA7WfxLhVE5wrx/MLc8BY8NzetsF/0Oly/hhHTHNnzb jgiwL+tf0gJbpP9Ug9TVjSgT+8sCWyPlhjSTRe8MyRNBs5ZyYgONimtEhPwi4xcLUSgWzr 0cRZjJ/QEHKw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9d2f98be (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 26 Feb 2023 16:33:04 +0100 (CET) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Sun, 26 Feb 2023 16:33:02 +0100 Message-ID: <877cw4tpap.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, Here is a new user option to make DocView, with SVG backend, honor the current theme colors. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-New-user-option-doc-view-svg-honor-theme.patch >From c8bf763dc0392ef9059044ff724aca825cd450be Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sun, 26 Feb 2023 16:25:17 +0100 Subject: [PATCH] New user option 'doc-view-svg-honor-theme' * lisp/doc-view.el (doc-view-svg-honor-theme): New user option that makes SVG in DocView to follow the current theme. (doc-view-insert-image): Use it. --- etc/NEWS | 8 ++++++++ lisp/doc-view.el | 19 +++++++++++++++---- 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 4b0e4e6bd46..ea8297f932e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -192,6 +192,14 @@ This command adds a docstring comment to the current defun. If a comment already exists, point is only moved to the comment. It is bound to 'C-c C-d' in 'go-ts-mode'. +** DocView + +--- +*** New user option 'doc-view-svg-honor-theme' +When set to non-nil, this option tells DocView to follow the current +theme background and foreground colors instead of +'doc-view-svg-background' and 'doc-view-svg-foreground'. + * New Modes and Packages in Emacs 30.1 diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 0303fec67a6..5d2348a023f 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -237,17 +237,25 @@ doc-view-imenu-flatten :version "29.1") (defcustom doc-view-svg-background "white" - "Background color for svg images. + "Background color for svg images. This is bypassed if +`doc-view-svg-honor-theme' is non-nil. See `doc-view-mupdf-use-svg'." :type 'color :version "29.1") (defcustom doc-view-svg-foreground "black" - "Foreground color for svg images. + "Foreground color for svg images. This is bypassed if +`doc-view-svg-honor-theme' is non-nil. See `doc-view-mupdf-use-svg'." :type 'color :version "29.1") +(defcustom doc-view-svg-honor-theme nil + "Does SVG foreground and background color honor the current +theme." + :type 'boolean + :version "30.1") + (defcustom doc-view-ghostscript-options '("-dSAFER" ;; Avoid security problems when rendering files from untrusted ;; sources. @@ -1602,8 +1610,11 @@ doc-view-insert-image (unless (member :transform-smoothing args) (setq args `(,@args :transform-smoothing t))) (when (eq doc-view--image-type 'svg) - (setq args `(,@args :background ,doc-view-svg-background - :foreground ,doc-view-svg-foreground))) + (if doc-view-svg-honor-theme + (setq args `(,@args :background ,(face-background 'default) + :foreground ,(face-foreground 'default))) + (setq args `(,@args :background ,doc-view-svg-background + :foreground ,doc-view-svg-foreground)))) (apply #'create-image file doc-view--image-type nil args)))) (slice (doc-view-current-slice)) (img-width (and image (car (image-size image)))) -- 2.39.1 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version 1.17.8) of 2023-02-25 built on computer Repository revision: 50b55656b9c5ce0d7940bec245f2d9725378d0a0 Repository branch: mgi/image-dired-sha1-content Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD computer 7.2 GENERIC.MP#1052 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t gnus-dired-mode: t display-time-mode: t display-battery-mode: t server-mode: t shell-dirtrack-mode: t repeat-mode: t desktop-save-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-0.10.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs /home/manuel/.emacs.d/elpa/transient-0.3.7/transient hides /home/manuel/emacs/share/emacs/30.0.50/lisp/transient Features: (shadow emacsbug ef-dark-theme ffap gnus-dup display-line-numbers debbugs-gnu debbugs-compat debbugs soap-client warnings rng-xsd xsd-regexp doctor ef-summer-theme ef-themes descr-text two-column completion dos-w32 find-cmd find-dired vc-annotate ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table ox-ascii ox-publish ox w3m-cookie w3m-form w3m-symbol w3m-filter w3m-search w3m-bookmark w3m-tabmenu w3m-session shortdoc ibuf-ext ibuffer ibuffer-loaddefs mailalias smtpmail ispell whitespace magit-patch pulse flow-fill gnus-fun sort shr-color mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg qp gnus-ml gnus-topic mm-archive url-http url-gw url-cache url-auth utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nsm nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss w3m w3m-hist bookmark-w3m w3m-ems w3m-favicon w3m-image w3m-fb tab-line w3m-proc w3m-util cl-print magit-extras face-remap magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode diff git-commit log-edit add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-section magit-utils dash misearch multi-isearch dabbrev image-dired-dired tabify cus-start image-file image-converter image-dired image-dired-tags image-dired-external image-dired-util help-fns radix-tree gnus-cite org-indent vc-dir ewoc reveal sh-script executable texinfo texinfo-loaddefs org-element org-persist org-id org-refile avl-tree oc-basic ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi doc-view jka-compr vc-hg conf-mode css-mode treesit smie sgml-mode facemenu imenu eww xdg url-queue mm-url vc-cvs vc-rcs log-view pcvs-util make-mode image-mode exif vc gnus-dired bug-reference paredit edmacro autorevert filenotify vc-git diff-mode emacs-news-mode time battery exwm-randr xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server modus-operandi-theme modus-themes ytdious mingus libmpdee reporter edebug debug backtrace transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt cl-extra help-mode speedbar ezimage dframe eieio-base pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func org-version org-compat org-macs visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp format-spec slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads view mule-util cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays holiday-loaddefs vc-dispatcher vc-svn appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-aux dired-x dired dired-loaddefs notifications dbus xml repeat easy-mmode desktop frameset osm-autoloads rust-mode-autoloads compat-autoloads ebdb-autoloads magit-autoloads debbugs-autoloads git-commit-autoloads magit-section-autoloads ef-themes-autoloads with-editor-autoloads paredit-autoloads dash-autoloads ytdious-autoloads transmission-autoloads transient-autoloads exwm-autoloads hyperbole-autoloads detached-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 1512155 229321) (symbols 48 82894 34) (strings 32 400421 16188) (string-bytes 1 11938432) (vectors 16 205097) (vector-slots 8 3788745 177059) (floats 8 1337 1048) (intervals 56 78970 13761) (buffers 984 173)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 07:39:37 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 12:39:37 +0000 Received: from localhost ([127.0.0.1]:56071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXiDh-0006ml-1d for submit@debbugs.gnu.org; Thu, 02 Mar 2023 07:39:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXiDg-0006mW-3Z for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 07:39:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXiDY-0005Wx-8o; Thu, 02 Mar 2023 07:39:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/Ivibr+sldO6kKbJ53VGjdGaVfsrnFTtXqCvBE7cj/8=; b=ZHQUvFtTFwg0 q83CeD16SFkpduTHgQSfKh5e6TWBiiN4GX4FTiCdlKb9PdgmQzE0ClyRcATf4cZ89kDZ7vdRsQFib FqdGWSg2DeaVH7BLhqb+t10P3WnuduGYzUjrqw+vEzohQXuyqy/HAR308btwbC6enhVrnQ9/LMKVd o8xPqbUP6/1Occl8Me+m0iVNJlWGcEka7GnydUcLQ56tUGqUuyp5MwGJYqJuva05GLxvvGRe5+rT1 wTgQTJ9aK2kkWlZsbJkRBDwcgqWfqauEZFQOwuzrttbKRPvhGPtpBaWVa2MYnElTxCqWKspc5XXkA Nx1Jityj8wVaNKXUVSGxSw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXiDX-0001xn-K5; Thu, 02 Mar 2023 07:39:27 -0500 Date: Thu, 02 Mar 2023 14:39:23 +0200 Message-Id: <838rgfe39g.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <877cw4tpap.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' References: <877cw4tpap.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 26 Feb 2023 16:33:02 +0100 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Here is a new user option to make DocView, with SVG backend, honor the > current theme colors. I have nothing against the feature, but wouldn't it be better to modify DocView to use faces for this, and then themes could override those faces? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 08:12:50 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 13:12:50 +0000 Received: from localhost ([127.0.0.1]:56141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXijq-0001cK-20 for submit@debbugs.gnu.org; Thu, 02 Mar 2023 08:12:50 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:34053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXijm-0001c7-PI for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 08:12:47 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=781Efekj fn2xypTnogp2CSJeeWqYnLYdhV/UBiPu/+0=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=GV2CHuOYsnDGmoRJLDAkOmvN2sWGJz 2TkOT7a0yF8Q5nfGJrqkV75SucWR745Z+PHotHoOBmemiYSIZggU5eCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=781Efekjfn2xypTn ogp2CSJeeWqYnLYdhV/UBiPu/+0=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=tK9EpOTLWN8fCmSRbGDB/ttvUzxHKCUuUhHwpZ L/KJjJfDZfrU44AwX0yoYCNknn8qmvTOIkA6psPw2NjKcwD/1sdHPVPs80P1KTsy18pfmk /o6VTJH9UbuLny+c9qSzt/HT2OmO61XxowdlwpBnFGwEZyG8WAhQ0av8dxyF9q2ZS6VjLT +bQ2iro76J4Y7+nblJlXF4iTaYK78yExsCAb35LYYl9GDSvLejQiu04u9gwClb6dFS4AII RfH1Hd29k+bm0cDh1H7OCrG4xl8+OZb8Z6X9Z+J5JkyUp9DHcWxXyOwghN5UtbMkG1aVaj G4ECWcs/cughuymRfpj5d2fQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c3efec62 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 14:12:45 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' In-Reply-To: <838rgfe39g.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 14:39:23 +0200") References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> Date: Thu, 02 Mar 2023 14:12:43 +0100 Message-ID: <87ttz3jnzo.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Sun, 26 Feb 2023 16:33:02 +0100 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Here is a new user option to make DocView, with SVG backend, honor the >> current theme colors. > > I have nothing against the feature, but wouldn't it be better to > modify DocView to use faces for this, and then themes could override > those faces? Why not but I have two issues with this: - we had to set those new faces in every Emacs' themes and also wait for any theme maker to use them - those are really just two colors not real faces as the rendering is controlled by an external tool anyway -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 08:56:27 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 13:56:28 +0000 Received: from localhost ([127.0.0.1]:56202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXjQ3-0005BL-HX for submit@debbugs.gnu.org; Thu, 02 Mar 2023 08:56:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXjQ0-0005B6-Uj for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 08:56:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXjPv-0002cn-4T; Thu, 02 Mar 2023 08:56:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/7aIqH0Hb24G8r+W4Py7D5yM7DeNB4gLXHPAfaByvG8=; b=Zy8VMJKuj+7e F6pFgoOsFQAhLPpIjIl0qRIidDH3dMdRwbthH7PnkVqE283HQW0VZ6jmsVuNoJdO9cKXke8ZT45rQ wCOvZfY1myKKzY28iIVVDfZmift1b2vN+WQ0NjTLXgvuabVQwRnkH0z4ATfvhpEvVYdgbxG9WinFb 64pa4+K0qqzQBTws39oze0pQCut4CEo9eP2ZZndjyw1Gg3cJgJSG9eO+pXd+CqcTRTDaOTmQVrWyd AEbUuDB2V0Tm0i5opxFxOQbLOrJIEB3eqM4fzDwYOVh5Q98tJC8TDYLc1u9/xkdfZULrFAMkkTQJf kSdS8XSk25GmSv8hd6xfbw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXjPu-0003hc-KB; Thu, 02 Mar 2023 08:56:18 -0500 Date: Thu, 02 Mar 2023 15:56:11 +0200 Message-Id: <831qm7dzpg.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87ttz3jnzo.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 02 Mar 2023 14:12:43 +0100) Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61816@debbugs.gnu.org > Date: Thu, 02 Mar 2023 14:12:43 +0100 > > Eli Zaretskii writes: > > >> Date: Sun, 26 Feb 2023 16:33:02 +0100 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Here is a new user option to make DocView, with SVG backend, honor the > >> current theme colors. > > > > I have nothing against the feature, but wouldn't it be better to > > modify DocView to use faces for this, and then themes could override > > those faces? > > Why not but I have two issues with this: > > - we had to set those new faces in every Emacs' themes and also wait > for any theme maker to use them > > - those are really just two colors not real faces as the rendering > is controlled by an external tool anyway You are right, of course. It just feels strange to need to cater to themes in a core package, when the way themes are supposed to customize Emacs exists and can be used in this case as well. Alternatively, maybe themes should have settings for features such as this one? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 10:40:59 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 15:40:59 +0000 Received: from localhost ([127.0.0.1]:58135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXl3D-0004m9-7m for submit@debbugs.gnu.org; Thu, 02 Mar 2023 10:40:59 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:25936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXl3A-0004lz-L4 for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 10:40:57 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=aE4dLoVs d6pDuxdcVBgBamD29W4Ne/RHXProQjJJ2l4=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=tqpJd2rmKIUuHfSfcHAK/gIqPkUxI3 QAfujd9Y6OI/jX+rvCj4VSUhvqI8asL8xqTJBynezROL1GKu5QXyQeCA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=aE4dLoVsd6pDuxdc VBgBamD29W4Ne/RHXProQjJJ2l4=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=eJxxOv5GEa8nNGcIieKq0/ok7jeWxuzBFcPvg6 YXPe9jJkNg0eYw6zJoXfnZawsEaXgpwGOvPlh02nGvsUAtyBNTDr7uVSFJ8HaVNEaGY0S8 qvSnsX9hKRHJjMnmjBYdlKJ5y3xlhwCZt4fhnxWywgIKgSy4iX/jaHRkqnAEwD+EjO2/w3 Bw/0fdu20yag3Y4Mj7rYcSzC97ufJ1qjzuavWJL4OvpKUl09vz8ClXLZKYAwBqmfItB/Il OIjlW1mZH3isfXghSHKkuqRla4spBSkUyj1e2ijViJLb//1ir0AD0iNoJceEYz5+q3O0dw Ew4BpeYcNqEeitRBwVdPWJMw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9d722bca (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 16:40:54 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' In-Reply-To: <831qm7dzpg.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 15:56:11 +0200") References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> Date: Thu, 02 Mar 2023 16:40:53 +0100 Message-ID: <87lekfjh4q.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > You are right, of course. It just feels strange to need to cater to > themes in a core package, when the way themes are supposed to > customize Emacs exists and can be used in this case as well. > > Alternatively, maybe themes should have settings for features such as > this one? Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the official Emacs themes for a start, WDYT? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 10:51:52 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 15:51:52 +0000 Received: from localhost ([127.0.0.1]:58158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlDj-00057R-SD for submit@debbugs.gnu.org; Thu, 02 Mar 2023 10:51:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlDh-00057E-F2 for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 10:51:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlDc-0005jP-0O; Thu, 02 Mar 2023 10:51:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5cKhQcVJxK9w4puZh4etIk8kt9WamiuQPMQ6mgozh7M=; b=NyBDb7B1UA9i 1QNZ0KMzJpaOhtzlyLN9U7SWxBln5xFGiypCxoY6K5GLQE5ga+UErwozhZaWJfFsgR/T/1Mxvs0ii dHgsBSfwDUWDdlqW6whYxDZIsocFytDkKPy+o1g+ixk0L69GbX60ZXizGyO+JKZcGnfdQTLFzEgqq bOd8r0d9G94BRS26pmVAGG0KG+qPcm+HoaA57/OueGTLwPp6r8Ki/YZX/29GDRz2d62mBGiYnzuFS QSn8KriREbh8xnc4xhId8q3ADsmFu6xwPPhQwGxfEjjXDdYjRG+CKMbRyPC4G5ss4v6h0Mg1SGhSe +xhdQp6P1zGpa/JzltrR2A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlDb-0007TF-E4; Thu, 02 Mar 2023 10:51:43 -0500 Date: Thu, 02 Mar 2023 17:51:35 +0200 Message-Id: <83v8jjcfso.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87lekfjh4q.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 02 Mar 2023 16:40:53 +0100) Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61816@debbugs.gnu.org > Date: Thu, 02 Mar 2023 16:40:53 +0100 > > Eli Zaretskii writes: > > [...] > > > You are right, of course. It just feels strange to need to cater to > > themes in a core package, when the way themes are supposed to > > customize Emacs exists and can be used in this case as well. > > > > Alternatively, maybe themes should have settings for features such as > > this one? > > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the > official Emacs themes for a start, WDYT? Isn't that what your original patch does? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 10:52:05 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 15:52:05 +0000 Received: from localhost ([127.0.0.1]:58162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlDx-00058G-6u for submit@debbugs.gnu.org; Thu, 02 Mar 2023 10:52:05 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:14742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlDu-00057i-PJ for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 10:52:03 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=lv351A0B MNGfF6+u1fKJrivVSg0tV09sGnn9AzTmiSA=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Yh1h6ib0ldeEIeS7BbC3uu/DFduKET SxNiZYOA89RJTcDNjkvH5DUjUpiI/khinZHC7Tdxd/VtM8jAoqv36fBg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=lv351A0BMNGfF6+u 1fKJrivVSg0tV09sGnn9AzTmiSA=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Uhw9Z4EqwUMy0dhBWJUPzZ/2qAM9vCcPAVrzvd YCXPqYS/rIqLUrwbSYFTOjYvq8kCCqCeVJck8KCj/SDX4voG0imN2YJGUqX8qO1InCCtG0 HaGAyCoy8fJO11zvFZnx9AJ/I3tIGGDMsPbCTyY9d9fUvPV4xCMmyRIi4WR/GRQDE85GKH kOOIA1BD3KxTHKYTLrCFYKxYEyG64qSpY/bWD2XLcS3wZUDAy2I/pV1GYsSHLxJWiXTXXp 8YXsECvkxWkUDYQlc8/g3w4q/ZRvG3niHeg3RPL9czMvrjbpQCYuJf37qpWlE0M/8ATV9+ Wm7keOviXgKtHZaiW8I6jXtw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 7eca2234 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 16:52:01 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' In-Reply-To: <87lekfjh4q.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Thu, 02 Mar 2023 16:40:53 +0100") References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> Date: Thu, 02 Mar 2023 16:51:59 +0100 Message-ID: <87h6v3jgm8.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud writes: > Eli Zaretskii writes: > > [...] > >> You are right, of course. It just feels strange to need to cater to >> themes in a core package, when the way themes are supposed to >> customize Emacs exists and can be used in this case as well. >> >> Alternatively, maybe themes should have settings for features such as >> this one? > > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the > official Emacs themes for a start, WDYT? ... and in order to be able to use 'custom-theme-set-faces', we could have a 'doc-view-svg-face' (used only for its foreground and background). I'm caching you up slowly =F0=9F=98=85 --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 10:57:21 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 15:57:21 +0000 Received: from localhost ([127.0.0.1]:58171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlJ3-0005G5-H6 for submit@debbugs.gnu.org; Thu, 02 Mar 2023 10:57:21 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:2076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlJ1-0005Fw-3m for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 10:57:19 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ap5oNZJ1 mzJfq/HlZOnAIoVJk3ZOv+Um70zrhDwmvWY=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=7nR5KcB8qCILzZQOv7uFfQkxOICh/O Y2MpoVJrEWf4idy6nG7a9urX2ttALs8go0gijqtrKrtZ+uC45TMgcaCA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ap5oNZJ1mzJfq/Hl ZOnAIoVJk3ZOv+Um70zrhDwmvWY=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=UVTspUR8VBACGOl5Hd+A+CF/jvx8UjW1QofBko uQeuio4ObzwkAmLAQO07fl2VMfu75If1b0JktKDXk1d8GNAPnHuOwQspixkA5SoeURXNFX FOKlcC1uNafttcINzP04Y0nfSEddsIePU7D1qDeOptGmK5d14jHtTucSuf9MIhKQ/2wx6z vo3M0tZ2AXXz4IIbRXuiJatBaJjoLVawhrrPzAV+lz9hPBRAdPCJYGfOAIimGJ2NxgYqPz 9whqovZVcMeOT1snfz+ynKIJoWzdCevnrLc0yM8hZ1GEkHnEoRPVNU6ljS2j5ERl5bSDKu t7H6ZgJQbOFADyTUYJIssHtw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id b921f4de (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 16:57:18 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' In-Reply-To: <83v8jjcfso.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 17:51:35 +0200") References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <83v8jjcfso.fsf@gnu.org> Date: Thu, 02 Mar 2023 16:57:16 +0100 Message-ID: <87cz5rjgdf.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the >> official Emacs themes for a start, WDYT? > > Isn't that what your original patch does? No my original patch just bypasses doc-view-svg-\(fore\|back\)ground and retrieves the default face colors. See my other message: I think that it is the way to go. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 11:32:26 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 16:32:26 +0000 Received: from localhost ([127.0.0.1]:58216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlr0-00069Y-0e for submit@debbugs.gnu.org; Thu, 02 Mar 2023 11:32:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXlqy-00069M-Ch for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 11:32:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlqs-0006kS-FD; Thu, 02 Mar 2023 11:32:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xA6HXXdxzRtx8yP8St65GUE3NEXOQ9hn3E7+5pnosrU=; b=k+Tvg3DYVMw/T45Hx8Zx S0UYgEUFvYfPYtja45MCALg2NtmrPLxihbeuDApzXPn4d1yRd2nYP5887EmCVFF62q/oj7WC3s6rr +uF99+posOTzHntdo/T86cuYcwudCHmLxKi389PTD9XBwPNoGje6LHvEXI2wEn/jgZOAk+g6ETaol Aze9KH13hFFUnVQhKI/0xzVmt0YI4FI2Ltd5AWpE0ymA5syzoOxI6HIhgV2+dYQI2WLBmAHuNFIRF pFpBUyBRfBjoIqsODNNykEWpfIw26vQka3nVEdc7lRW7PHQG4KxLmNnWbFNtPxKKlQb9MwrqrqCuw zenkap+XjPZq6g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlqr-0002CI-B0; Thu, 02 Mar 2023 11:32:17 -0500 Date: Thu, 02 Mar 2023 18:32:09 +0200 Message-Id: <83ttz3cdx2.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87h6v3jgm8.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 02 Mar 2023 16:51:59 +0100) Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61816@debbugs.gnu.org > Date: Thu, 02 Mar 2023 16:51:59 +0100 > > Manuel Giraud writes: > > > Eli Zaretskii writes: > > > > [...] > > > >> You are right, of course. It just feels strange to need to cater to > >> themes in a core package, when the way themes are supposed to > >> customize Emacs exists and can be used in this case as well. > >> > >> Alternatively, maybe themes should have settings for features such as > >> this one? > > > > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the > > official Emacs themes for a start, WDYT? > > ... and in order to be able to use 'custom-theme-set-faces', we could > have a 'doc-view-svg-face' (used only for its foreground and > background). I'm caching you up slowly 😅 Fine by me, that's what I proposed. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 13:20:37 2023 Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 18:20:37 +0000 Received: from localhost ([127.0.0.1]:58354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXnXg-0000gb-KM for submit@debbugs.gnu.org; Thu, 02 Mar 2023 13:20:37 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:21877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXnXd-0000gQ-7J for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 13:20:35 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=tEQ1KOdC HB3fwdsD0PRrqAocP5pOLYc2LCitnsijIzQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=uF9PWlshCra/wq3KmHdklrAkaGL4Yx RVee8ozQzGoFZlf83Vm5ZAfzQ2zqqtKFtGjw+2QZcfwPLJPUKUGjtRCg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=tEQ1KOdCHB3fwdsD 0PRrqAocP5pOLYc2LCitnsijIzQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=0BQOo/13+0YWAXk5m2q6NguQjrnphXUlRes0XV xNdYDbeTnx2YBspfOB0sjdvuvbJ1rrRJ3XYq0qhG3wBBGt4BkugZZ9IjstQLkEgc6qWLhq be4BaPuqv1/Kvkde1KPIPle7aDbRegZQZyDICPVJqwdA3LEWgOdfKzv6DYYFVWW7T/1Vx9 4wer5awfJ/VzWQwW5jpPHqf1A/NGyhLjj/iXMr+udhdqGkUugRf7baD5s4CQ82uDWPq8q7 7kPt/Sz5tY++w4Ojs3CGzWMDzjD8tvvfLyLM/Uc5YXeDWsowJvtE3M5YfGZU56TdPKLlHP 8Cp8D72jHYylt0qgdNt52skg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 5eb2b56c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 19:20:31 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' In-Reply-To: <83ttz3cdx2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 18:32:09 +0200") References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> <83ttz3cdx2.fsf@gnu.org> Date: Thu, 02 Mar 2023 19:20:30 +0100 Message-ID: <875ybjuia9.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61816 Cc: 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > Fine by me, that's what I proposed. Wow, it is cleaner and works even better (no need to change page to update colors). Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-a-face-for-DocView-SVG.patch >From 0f3ff5af9610fbf173f07218d652c1be3477dc14 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 2 Mar 2023 19:16:19 +0100 Subject: [PATCH] Use a face for DocView SVG * lisp/doc-view.el (doc-view-svg-face): New face for SVG images. (doc-view-insert-image): Use it. --- etc/NEWS | 6 ++++++ lisp/doc-view.el | 19 ++++++++----------- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 116b60d8b11..88c3f2f0ef4 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -208,6 +208,12 @@ bound to 'C-c C-d' in 'go-ts-mode'. When this is non-nil, call the 'man' program synchronously rather than asynchronously (which is the default behavior). +** DocView + +--- +*** New face 'doc-view-svg-face'. +This replaces 'doc-view-svg-foreground' and 'doc-view-svg-background'. + * New Modes and Packages in Emacs 30.1 diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 0303fec67a6..b14655fb274 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -236,17 +236,14 @@ doc-view-imenu-flatten :type 'boolean :version "29.1") -(defcustom doc-view-svg-background "white" - "Background color for svg images. +(defface doc-view-svg-face '((t :inherit default)) + "Face used for SVG images. Only background and foreground colors +are used. See `doc-view-mupdf-use-svg'." - :type 'color - :version "29.1") + :version "30.1") -(defcustom doc-view-svg-foreground "black" - "Foreground color for svg images. -See `doc-view-mupdf-use-svg'." - :type 'color - :version "29.1") +(make-obsolete 'doc-view-svg-background 'doc-view-svg-face "30.1") +(make-obsolete 'doc-view-svg-foreground 'doc-view-svg-face "30.1") (defcustom doc-view-ghostscript-options '("-dSAFER" ;; Avoid security problems when rendering files from untrusted @@ -1602,8 +1599,8 @@ doc-view-insert-image (unless (member :transform-smoothing args) (setq args `(,@args :transform-smoothing t))) (when (eq doc-view--image-type 'svg) - (setq args `(,@args :background ,doc-view-svg-background - :foreground ,doc-view-svg-foreground))) + (setq args `(,@args :background ,(face-background 'doc-view-svg-face) + :foreground ,(face-foreground 'doc-view-svg-face)))) (apply #'create-image file doc-view--image-type nil args)))) (slice (doc-view-current-slice)) (img-width (and image (car (image-size image)))) -- 2.39.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 21:28:32 2023 Received: (at 61816) by debbugs.gnu.org; 3 Mar 2023 02:28:32 +0000 Received: from localhost ([127.0.0.1]:59352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXv9r-0002Rs-Q7 for submit@debbugs.gnu.org; Thu, 02 Mar 2023 21:28:32 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:55265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXv9q-0002Rf-4E for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 21:28:30 -0500 Received: by mail-pj1-f68.google.com with SMTP id bo22so1095963pjb.4 for <61816@debbugs.gnu.org>; Thu, 02 Mar 2023 18:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677810504; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rnxm30NUvkihnPSw1f4RCVZm6Fi1t4ZQdmS4dfTGtLE=; b=JWRD8nvTyGTCLbOdt8gMD3vhkR6xlwt5JKM5O3oDm8aCgNp9NkPUxq1Tzq5qErlWTR ZR+Z0fnSmK803Qi9euXhdGa+kLobk1UdN3rVN4CD64SQkYiMDntIH6/QCOJYm/8r52tv ud+7tLzAxy4riRZVRUukMkM+FpFHpPh9XdE2wSjIsEeEzqZoTChW17DFr/UrZRzrekrm OJiuaYix62YXpKfemE5U4QSX4refrRQFh5XTDwp9izwHauq1w4K+Bl3Wj3xrv1gnb27w Bp1umzNnjwDWkiwe5Np09vh78M5YZZwTF/e5OPhjMC3vM+P4+dvvt2PaNcAico9b8S2m fycg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677810504; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Rnxm30NUvkihnPSw1f4RCVZm6Fi1t4ZQdmS4dfTGtLE=; b=lqBPytScCOCLbTjh3CDCLDZEeoI1tdL+9WvHTkgdOib2t4kbS7T5xTxtrhBAhWx2Cw GX4j1VKR6E7a+mFMpyrIGdG2qWU7rkWG+KWVdwjaMqYQKgVFY7rb4DSsy8vmYr8qLigN Zt0DP9tM6coWUerntlWx+xfgbk8I5kBco6uNGy/nvHqyDYe5Lc1R5SrqCPOVzRd3hidh UVwYSqcXH+UhCJ5ijpfzDASTW6iaaPU28n4xIMdJlGLn0WTvjMYtlNkOF80BrKq4k+Gx ryZSztcdy+Ac24QppQs9FHAop11DWOkiAf6FAkj6qQssmZ3ibt9mqBnqXV5ZMwWMxA8d +QBg== X-Gm-Message-State: AO0yUKVFPt5mZ4mxZ+NcV9nGJHJD7sZCXxD/NgkZFpRszlZ9UkMTp+ie ZqDmmOU5CZeH5988iOW7Vfs= X-Google-Smtp-Source: AK7set+mmKJvsfz3WVAx0F+uEL9a0/wpVOrPNjOVqLwgHPaaSXelkkWZnyt0Ji0ifCUY0yjfYVWMYQ== X-Received: by 2002:a17:902:d587:b0:19c:f7f2:6097 with SMTP id k7-20020a170902d58700b0019cf7f26097mr432219plh.37.1677810503944; Thu, 02 Mar 2023 18:28:23 -0800 (PST) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id lg16-20020a170902fb9000b00192a8b35fa3sm329071plb.122.2023.03.02.18.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 18:28:23 -0800 (PST) From: Visuwesh To: Manuel Giraud Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' In-Reply-To: <87h6v3jgm8.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Thu, 02 Mar 2023 16:51:59 +0100") References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> Date: Fri, 03 Mar 2023 07:58:07 +0530 Message-ID: <871qm6po08.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61816 Cc: Eli Zaretskii , 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=AE= =E0=AE=BE=E0=AE=B0=E0=AF=8D=E0=AE=9A=E0=AF=8D 02, 2023] Manuel Giraud via "= Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > Manuel Giraud writes: > >> Eli Zaretskii writes: >> >> [...] >> >>> You are right, of course. It just feels strange to need to cater to >>> themes in a core package, when the way themes are supposed to >>> customize Emacs exists and can be used in this case as well. >>> >>> Alternatively, maybe themes should have settings for features such as >>> this one? >> >> Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the >> official Emacs themes for a start, WDYT? > > ... and in order to be able to use 'custom-theme-set-faces', we could > have a 'doc-view-svg-face' (used only for its foreground and > background). I'm caching you up slowly =F0=9F=98=85 Themes can also use `custom-theme-set-variables' so I did not see a need to introduce a face when I made the patch back then. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 02:31:45 2023 Received: (at 61816) by debbugs.gnu.org; 3 Mar 2023 07:31:45 +0000 Received: from localhost ([127.0.0.1]:59509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXztJ-0002EY-JK for submit@debbugs.gnu.org; Fri, 03 Mar 2023 02:31:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXztH-0002EH-M8 for 61816@debbugs.gnu.org; Fri, 03 Mar 2023 02:31:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXztC-00089K-6U; Fri, 03 Mar 2023 02:31:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lreGGUFGEOAVP3WUniu/TMRN3IVj5zcINNTegOsiyhA=; b=BGIS8dITZizR+lfJlpQ1 +hxi48eDfgxRmFLKLm3QmM+O2CtEiCGNve0teTW43C4O8+r290QP930h9u734Mihhe7wqWWmnvvJw IcpAo8B2mB0ACqQ9NEzbPbrepfb4rhvnsWbJ5aEnuA3VX5jGRDsSykkkKjzCmFx9aZi/FmJb/pi7X 0XcEP8FHT2NaaVh+F8TqR/Ooda45Q4WWose3tqmjoW1hwasF9utb8YdaWXh00Y1W9tcEwGsoij+ew 0jLXGyD3cgRhYZ6lETf6oydmQWqMD8kFRrHD45sltMyu4jBFJD+7GtKc3jCCritWg5DhWu+8evmSr a5l2joj3EHqmKQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXzt4-00023z-Ca; Fri, 03 Mar 2023 02:31:37 -0500 Date: Fri, 03 Mar 2023 09:31:15 +0200 Message-Id: <83fsamcmv0.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <871qm6po08.fsf@gmail.com> (message from Visuwesh on Fri, 03 Mar 2023 07:58:07 +0530) Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> <871qm6po08.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61816 Cc: manuel@ledu-giraud.fr, 61816@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Cc: Eli Zaretskii , 61816@debbugs.gnu.org > Date: Fri, 03 Mar 2023 07:58:07 +0530 > > [வியாழன் மார்ச் 02, 2023] Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > > > Manuel Giraud writes: > > > >> Eli Zaretskii writes: > >> > >> [...] > >> > >>> You are right, of course. It just feels strange to need to cater to > >>> themes in a core package, when the way themes are supposed to > >>> customize Emacs exists and can be used in this case as well. > >>> > >>> Alternatively, maybe themes should have settings for features such as > >>> this one? > >> > >> Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the > >> official Emacs themes for a start, WDYT? > > > > ... and in order to be able to use 'custom-theme-set-faces', we could > > have a 'doc-view-svg-face' (used only for its foreground and > > background). I'm caching you up slowly 😅 > > Themes can also use `custom-theme-set-variables' so I did not see a need > to introduce a face when I made the patch back then. The problem with custom-theme-set-variables is that themes have no clue which variables to customize: there are too many of them, and those that themes should customize don't stand out in any way, do they? Faces are better because themes always pay attention to them. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 09 05:06:35 2023 Received: (at 61816-done) by debbugs.gnu.org; 9 Mar 2023 10:06:35 +0000 Received: from localhost ([127.0.0.1]:50984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paDAR-0007se-7c for submit@debbugs.gnu.org; Thu, 09 Mar 2023 05:06:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paDAP-0007sQ-EQ for 61816-done@debbugs.gnu.org; Thu, 09 Mar 2023 05:06:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paDAJ-000738-QQ; Thu, 09 Mar 2023 05:06:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/9Q4H09SaPetd9wFxymsuVEUg6+d5hgWE/Bc3Ij/M0M=; b=l28WBD6pzdQe nIw0zcWZpDvKJXnjzKcu+9aDxUQ/Yt/R/hd44HPrI9i9PUeoVuPpgdHtgMdBAPu90jxHZfRhQIIhs NaVC1AF0eYkpGr3hv70lBK/MV/x09oQfXcTXuihqFfwpwgdzjMkiqUt9eckYj/QQwWzPmfQjaEp4d mQChng7cqBVhyD7U+Sb9sRuzYHkCxuDa7DLY8z+D8tVVym2N1QnWVvkidRB8Vl6bZ4qLKwHE9hmbL fdHIiLa7fJeMyux4leqmGANMzftbW2T+HqXgMdkG+b57lF+KrNvMr0BOLhFOwqCccaq34DRz2W+yA /JAFbMLwtI4xDLPIqXk5aQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paDAJ-0000ES-9u; Thu, 09 Mar 2023 05:06:27 -0500 Date: Thu, 09 Mar 2023 12:06:28 +0200 Message-Id: <83a60m2q8r.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <875ybjuia9.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 02 Mar 2023 19:20:30 +0100) Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> <83ttz3cdx2.fsf@gnu.org> <875ybjuia9.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61816-done Cc: 61816-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61816@debbugs.gnu.org > Date: Thu, 02 Mar 2023 19:20:30 +0100 > > Eli Zaretskii writes: > > [...] > > > Fine by me, that's what I proposed. > > Wow, it is cleaner and works even better (no need to change page to > update colors). Thanks. Thanks, installed on master. Btw, please in the future try to mention in the log message the bug number, if it's known when you submit the patch. That avoids the need for me to fix the log message manually before pushing. From unknown Mon Aug 18 02:32:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Apr 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator