Subject: Re: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'

From: Eli Zaretskii <[email-masked]>
Date: Thu, 02 Mar 2023 15:56:11 +0200

> From: Manuel Giraud <[email-masked]>
> Cc: [email-masked]
> Date: Thu, 02 Mar 2023 14:12:43 +0100
> 
> Eli Zaretskii <[email-masked]> writes:
> 
> >> Date: Sun, 26 Feb 2023 16:33:02 +0100
> >> From:  Manuel Giraud via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <[email-masked]>
> >> 
> >> Here is a new user option to make DocView, with SVG backend, honor the
> >> current theme colors.
> >
> > I have nothing against the feature, but wouldn't it be better to
> > modify DocView to use faces for this, and then themes could override
> > those faces?
> 
> Why not but I have two issues with this:
> 
>     - we had to set those new faces in every Emacs' themes and also wait
>       for any theme maker to use them
>       
>     - those are really just two colors not real faces as the rendering
>       is controlled by an external tool anyway

You are right, of course.  It just feels strange to need to cater to
themes in a core package, when the way themes are supposed to
customize Emacs exists and can be used in this case as well.

Alternatively, maybe themes should have settings for features such as
this one?