GNU bug report logs - #61801
[PATCH] gnu: opencl-headers, opencl-clhpp and opencl-icd-loader: Update to 2023.02.06

Previous Next

Full log

Message #17 received at 61801 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 61801 <at> debbugs.gnu.org
Subject: Re: [bug#61801] [PATCH] gnu: opencl-headers, opencl-clhpp and
 opencl-icd-loader: Update to 2023.02.06
Date: Sun, 26 Feb 2023 15:07:27 -0800

Are there any guidelines on how the commit messages should be written
in regard to these changes?

I will remove the ruby part from the change.

On Sun, Feb 26, 2023 at 12:40 PM Leo Famulari <leo <at> famulari.name> wrote:
>
> On Sun, Feb 26, 2023 at 11:50:06AM -0800, Andy Tai wrote:
> > There is a comment in the current source requiring the three to be
> > updated in lock step
>
> Okay.
>
> Also, the commit message mentions neither the addition of ruby to the
> dependencies of opencl-clhpp, nor the BUILD_TESTING flag. Did you mean
> to include those changes?
>
> Using diffoscope, I compared the build output with and without ruby, and
> they are identical aside from the store paths, so we should leave ruby
> out, in any case.



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2023 民國112年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.