Subject: bug#61793: closed (Re: [bug#61793] [PATCH] gnu: mruby: Update to 3.2.0.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 14 Mar 2023 10:45:02 +0000

Your bug report

#61793: [PATCH] gnu: mruby: Update to 3.2.0.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
61793: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61793
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#61793] [PATCH] gnu: mruby: Update to 3.2.0.
From: Christopher Baines <[email-masked]>
To: Yovan Naumovski <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Tue, 14 Mar 2023 10:44:01 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Yovan Naumovski via Guix-patches via <[email-masked]> writes:

> Hi,
>
> here's a patch that updates mruby to 3.2.0. I removed two
> substitutions from the 'disable-broken-tests, the tests seem to pass
> without them.
>
> Best regards,
>
> Yovan.
>
> [2. text/x-patch; 0001-gnu-packages-ruby.scm-mruby-Update-to-3.2.0.patch]...

Thanks Yovan, pushed to master as
476e1b270e657a82ef3a8d253d694d07a766cde4.

Chris

Subject: [PATCH] gnu: mruby: Update to 3.2.0.
From: Yovan Naumovski <[email-masked]>
To: [email-masked]
Date: Sat, 25 Feb 2023 22:17:19 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

here's a patch that updates mruby to 3.2.0. I removed two substitutions 
from the 'disable-broken-tests, the tests seem to pass without them.

Best regards,

Yovan.
* gnu/packages/ruby.scm (mruby): Update to 3.2.0.
 [arguments]: Remove unnecessary substitutions in the 'disable-broken-tests
 phase.
 [description]: Update.
---
 gnu/packages/ruby.scm | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 2e8d4038de..8f38389719 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -31,6 +31,7 @@
 ;;; Copyright © 2022 Philip McGrath <[email-masked]>
 ;;; Copyright © 2022 Remco van 't Veer <[email-masked]>
 ;;; Copyright © 2022 Taiju HIGASHI <[email-masked]>
+;;; Copyright © 2023 Yovan Naumovski <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -259,7 +260,7 @@ (define-public ruby ruby-2.7)
 (define-public mruby
   (package
     (name "mruby")
-    (version "2.1.2")
+    (version "3.2.0")
     (source
      (origin
        (method git-fetch)
@@ -269,7 +270,7 @@ (define-public mruby
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "0fhfv8pi7i8jn2vgk2n2rjnbnfa12nhj514v8i4k353n7q4pmkh3"))))
+         "0c0scaqbnywrd9z1z4rnnj345rjc3vbklszm0rc6y6rzx1cxnsij"))))
     (build-system gnu-build-system)
     (arguments
      `(#:test-target "test"
@@ -287,13 +288,9 @@ (define-public mruby
              (substitute* "mrbgems/mruby-io/test/io.rb"
                (("assert\\('IO.popen.+$" m)
                 (string-append m "skip \"Hangs in the Guix build environment\"\n"))
-               (("assert\\('IO#isatty.+$" m)
-                (string-append m "skip \"Disable for Guix; there is no /dev/tty\"\n"))
                ;; This one is really weird.  The *expected* output is all wrong.
                (("assert\\('`cmd`.*" m)
-                (string-append m "skip \"Disable for Guix\"\n"))
-               (("echo foo")
-                (string-append (which "echo") " foo")))
+                (string-append m "skip \"Disable for Guix\"\n")))
              #t))
          ;; There is no install target
          (replace 'install
@@ -311,8 +308,8 @@ (define-public mruby
     (home-page "https://github.com/mruby/mruby")
     (synopsis "Lightweight Ruby")
     (description "mruby is the lightweight implementation of the Ruby
-language.  Its syntax is Ruby 1.9 compatible.  mruby can be linked and
-embedded within your application.")
+language.  Its syntax is Ruby 3.x compatible except for pattern
+matching.  mruby can be linked and embedded within your application.")
     (license license:expat)))
 
 (define-public ruby-commander
-- 
2.39.1