GNU bug report logs - #61789
[PATCH 00/27] Deprecate old-style services.

Previous Next

Full log

Message #11 received at 61789 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 61789 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 02/27] services: base: Deprecate 'login-service' procedure.
Date: Sat, 25 Feb 2023 18:57:48 +0000

* doc/guix.texi (Base Services): Replace with login-service-type.
* gnu/services/base.scm (login-service): Deprecate procedure.
* gnu/system/install.scm (%installation-services): Use login-service-type.
---
 doc/guix.texi          | 12 ++++++------
 gnu/services/base.scm  |  5 +++--
 gnu/system/install.scm |  5 +++--
 3 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 9d5dd495c0..cb0d18ebdc 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -18101,14 +18101,14 @@ Base Services
 host names.
 @end defun
 
-@deffn {Scheme Procedure} login-service @var{config}
-Return a service to run login according to @var{config}, a
-@code{<login-configuration>} object, which specifies the message of the day,
-among other things.
-@end deffn
+@defvar login-service-type
+Type of the service that provides a console login service, whose value
+is a @code{<login-configuration>} object.
+@end defvar
 
 @deftp {Data Type} login-configuration
-This is the data type representing the configuration of login.
+Data type representing the configuration of login, which specifies the
+@acronym{MOTD, message of the day}, among other things.
 
 @table @asis
 
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index c471107883..8dfd92aacf 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -158,7 +158,7 @@ (define-module (gnu services base)
             login-configuration
             login-configuration?
             login-service-type
-            login-service
+            login-service  ; deprecated
 
             agetty-configuration
             agetty-configuration?
@@ -937,7 +937,8 @@ (define login-service-type
                  "Provide a console log-in service as specified by its
 configuration value, a @code{login-configuration} object.")))
 
-(define* (login-service #:optional (config (login-configuration)))
+(define-deprecated (login-service #:optional (config (login-configuration)))
+  login-service-type
   "Return a service configure login according to @var{config}, which specifies
 the message of the day, among other things."
   (service login-service-type config))
diff --git a/gnu/system/install.scm b/gnu/system/install.scm
index b3cf7a1bd8..8c7585f188 100644
--- a/gnu/system/install.scm
+++ b/gnu/system/install.scm
@@ -347,8 +347,9 @@ (define* (%installation-services #:key (system (or (and=>
                      (virtual-terminal "tty1")
                      (login-program (installer-program))))
 
-           (login-service (login-configuration
-                           (motd motd)))
+           (service login-service-type
+                    (login-configuration
+                     (motd motd)))
 
            ;; Documentation.  The manual is in UTF-8, but
            ;; 'console-font-service' sets up Unicode support and loads a font
-- 
2.39.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.