Subject: Re: ‘screen-locker-service’ deprecation

From: Bruno Victal <[email-masked]>
Date: Mon, 6 Mar 2023 14:36:31 +0000

Hi Ludo’,

On 2023-03-03 16:45, Ludovic Courtès wrote:
> Bruno Victal <[email-masked]> skribis:
> 
>> * doc/guix.texi (X Window): Replace 'screen-locker-service' with 'screen-locker-service-type'.
>> Document <screen-locker-configuration>.
>> * gnu/services/desktop.scm (desktop-services-for-system): Use screen-locker-service-type.
>> * gnu/services/xorg.scm: Export accessors for <screen-locker-configuration>.
>> (<screen-locker>): Rename to ...
>> (<screen-locker-configuration>): ... this.
>> (<screen-locker-configuration>)[empty?]: Rename to ...
>> (<screen-locker-configuration>)[allow-empty-password?]: ... this.
>> (screen-locker-pam-services): Update record name.
>> (screen-locker-setuid-programs): Update accessor name.
>> (screen-locker-service): Deprecate procedure.
> 
> Also leaving this one out: there’s a bit too much going on here, and I
> think we should discuss it separately (it’s quite different from the
> old-style service procedures.)

The changes essentially amount to a rename of the configuration record-type (with backward compatibility)
and making explicit what the 'screen-locker-service' procedure does behind the scenes with 'screen-locker-service-type'.

Do you have another plan in mind to split or refactor this change?

Cheers,
Bruno