From unknown Sun Jun 22 04:08:41 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61769] [PATCH 0/1] gnu: u-boot-rock64-rk3328: Fix. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Feb 2023 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61769 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61769@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16772691631063 (code B ref -1); Fri, 24 Feb 2023 20:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2023 20:06:03 +0000 Received: from localhost ([127.0.0.1]:38313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVeKQ-0000H4-Ua for submit@debbugs.gnu.org; Fri, 24 Feb 2023 15:06:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:41502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVeKP-0000Gg-2R for submit@debbugs.gnu.org; Fri, 24 Feb 2023 15:06:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVeKO-0002dr-Lx for guix-patches@gnu.org; Fri, 24 Feb 2023 15:06:00 -0500 Received: from mailout.easymail.ca ([64.68.200.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVeKL-0006X3-JG for guix-patches@gnu.org; Fri, 24 Feb 2023 15:06:00 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 29A3AE8BDF for ; Fri, 24 Feb 2023 20:05:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I4QgFibiRzlX for ; Fri, 24 Feb 2023 20:05:54 +0000 (UTC) Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id D2A5AE8B88 for ; Fri, 24 Feb 2023 20:05:54 +0000 (UTC) From: Simon South Date: Fri, 24 Feb 2023 15:05:51 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This patch fixes a typo in the package definition for u-boot-rock64-rk3328, the default bootloader for ROCK64 computers, that causes the machine to fail to boot. Inadvertently setting the wrong environment variable means the firmware package normally bundled into the bootloader isn't found at build time. In fact the build log[0] notes WARNING: BL31 file bl31.elf NOT found, resulting binary is non-functional U-Boot complains about the missing firmware at boot and the system freezes when attempting to start the kernel. Tested on an actual ROCK64 and the patch appears to work fine. -- Simon South simon@simonsouth.net [0] https://ci.guix.gnu.org/build/350374/log/raw Simon South (1): gnu: u-boot-rock64-rk3328: Fix. gnu/packages/bootloaders.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e615aaca28fd6b797e9b41a71096ebe878c89299 -- 2.39.1 From unknown Sun Jun 22 04:08:41 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61769] [PATCH 1/1] gnu: u-boot-rock64-rk3328: Fix. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Feb 2023 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61769 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61769@debbugs.gnu.org Received: via spool by 61769-submit@debbugs.gnu.org id=B61769.16772692991280 (code B ref 61769); Fri, 24 Feb 2023 20:09:01 +0000 Received: (at 61769) by debbugs.gnu.org; 24 Feb 2023 20:08:19 +0000 Received: from localhost ([127.0.0.1]:38319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVeMd-0000Ka-Em for submit@debbugs.gnu.org; Fri, 24 Feb 2023 15:08:19 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:41196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVeMb-0000KN-Jq for 61769@debbugs.gnu.org; Fri, 24 Feb 2023 15:08:17 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 6A9156883A for <61769@debbugs.gnu.org>; Fri, 24 Feb 2023 20:08:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo09-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo09-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6-7gU_EPA12w for <61769@debbugs.gnu.org>; Fri, 24 Feb 2023 20:08:12 +0000 (UTC) Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id EB9CB68726 for <61769@debbugs.gnu.org>; Fri, 24 Feb 2023 20:08:11 +0000 (UTC) From: Simon South Date: Fri, 24 Feb 2023 15:08:09 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/bootloaders.scm (u-boot-rock64-rk3328)[arguments]: Fix typo. --- gnu/packages/bootloaders.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 9d56efb628..7e839fa859 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -1193,7 +1193,7 @@ (define-public u-boot-rock64-rk3328 #~(modify-phases #$phases (add-after 'unpack 'set-environment (lambda* (#:key native-inputs inputs #:allow-other-keys) - (setenv "BL31 "(search-input-file inputs "bl31.elf")))))))) + (setenv "BL31" (search-input-file inputs "bl31.elf")))))))) (inputs (modify-inputs (package-inputs base) (append arm-trusted-firmware-rk3328)))))) -- 2.39.1 From unknown Sun Jun 22 04:08:41 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simon South Subject: bug#61769: closed (Re: [bug#61769] [PATCH 0/1] gnu: u-boot-rock64-rk3328: Fix.) Message-ID: References: X-Gnu-PR-Message: they-closed 61769 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 61769@debbugs.gnu.org Date: Fri, 24 Feb 2023 20:46:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1677271562-4857-1" This is a multi-part message in MIME format... ------------=_1677271562-4857-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61769: [PATCH 0/1] gnu: u-boot-rock64-rk3328: Fix. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61769@debbugs.gnu.org. --=20 61769: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61769 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1677271562-4857-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61769-done) by debbugs.gnu.org; 24 Feb 2023 20:45:40 +0000 Received: from localhost ([127.0.0.1]:38347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVewl-0001Fb-Um for submit@debbugs.gnu.org; Fri, 24 Feb 2023 15:45:40 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVewk-0001FO-4c for 61769-done@debbugs.gnu.org; Fri, 24 Feb 2023 15:45:38 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B41885C0051; Fri, 24 Feb 2023 15:45:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 24 Feb 2023 15:45:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; t=1677271532; x=1677357932; bh=jrxpQvM9PwRloIXQ480ElC2MOI6DhPvLS1LG5Cog3rw=; b=Ut1lqemCSlIN njbDQ1iaVOa0pdsIhJ3ZCUyGFt0am+fbgaI8pnXt1DxOlrMnet9lpNS0ZIGmQJ/6 BDY2PD/Fc2Z+FcCZusSyPtxmjjLeAihQuF1TeCvfSeGDZWln+tv1q8iU+kofnPqn 6l15ScAJf3O1VgUCgnHHOwRrwHRzKuo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677271532; x=1677357932; bh=jrxpQvM9PwRloIXQ480ElC2MOI6D hPvLS1LG5Cog3rw=; b=Y6LATUl8fung8U5U2HzcDgqMsN/9UDwsX/1hpadAW2dW V1YgKgslZbVjmJu0zuwYJ47LE9eoscsx/1rIBYrvse7ht9LEwmObHx8L2toOgDnu Ax4xcm1M6AxhYhbJ+34sS7w7spaOpwJxESJiq1kjpNxgWHTC8QJlLSZKEVUcwec2 BvTZr6iYTug/Gf44xza9RWSYYSIL8fEatNo4W4z/FBHJXaE6kZDZkXrAslFPQxU3 BKRYVCqnWJz0/nNyuIzJ8c3H85thREcwxwi0nK0FTQz5Y4pnk1a/9o3yXqRkaLg/ PYWCWC7BkKVGRoRvaZy5lGChZlMtoQ3Ex3m9JliYAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekfedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdej leeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Feb 2023 15:45:32 -0500 (EST) Date: Fri, 24 Feb 2023 15:45:29 -0500 From: Leo Famulari To: Simon South Subject: Re: [bug#61769] [PATCH 0/1] gnu: u-boot-rock64-rk3328: Fix. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61769-done Cc: 61769-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Feb 24, 2023 at 03:05:51PM -0500, Simon South wrote: > This patch fixes a typo in the package definition for u-boot-rock64-rk3328, > the default bootloader for ROCK64 computers, that causes the machine to fail > to boot. > > Inadvertently setting the wrong environment variable means the firmware > package normally bundled into the bootloader isn't found at build time. In > fact the build log[0] notes > > WARNING: BL31 file bl31.elf NOT found, resulting binary is non-functional > > U-Boot complains about the missing firmware at boot and the system freezes > when attempting to start the kernel. > > Tested on an actual ROCK64 and the patch appears to work fine. Thanks for the patch and explanation! Pushed as df8b8f0c76388239dac9f2892c97b92e92c92901 ------------=_1677271562-4857-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Feb 2023 20:06:03 +0000 Received: from localhost ([127.0.0.1]:38313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVeKQ-0000H4-Ua for submit@debbugs.gnu.org; Fri, 24 Feb 2023 15:06:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:41502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVeKP-0000Gg-2R for submit@debbugs.gnu.org; Fri, 24 Feb 2023 15:06:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVeKO-0002dr-Lx for guix-patches@gnu.org; Fri, 24 Feb 2023 15:06:00 -0500 Received: from mailout.easymail.ca ([64.68.200.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVeKL-0006X3-JG for guix-patches@gnu.org; Fri, 24 Feb 2023 15:06:00 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 29A3AE8BDF for ; Fri, 24 Feb 2023 20:05:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I4QgFibiRzlX for ; Fri, 24 Feb 2023 20:05:54 +0000 (UTC) Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id D2A5AE8B88 for ; Fri, 24 Feb 2023 20:05:54 +0000 (UTC) From: Simon South To: guix-patches@gnu.org Subject: [PATCH 0/1] gnu: u-boot-rock64-rk3328: Fix. Date: Fri, 24 Feb 2023 15:05:51 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This patch fixes a typo in the package definition for u-boot-rock64-rk3328, the default bootloader for ROCK64 computers, that causes the machine to fail to boot. Inadvertently setting the wrong environment variable means the firmware package normally bundled into the bootloader isn't found at build time. In fact the build log[0] notes WARNING: BL31 file bl31.elf NOT found, resulting binary is non-functional U-Boot complains about the missing firmware at boot and the system freezes when attempting to start the kernel. Tested on an actual ROCK64 and the patch appears to work fine. -- Simon South simon@simonsouth.net [0] https://ci.guix.gnu.org/build/350374/log/raw Simon South (1): gnu: u-boot-rock64-rk3328: Fix. gnu/packages/bootloaders.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e615aaca28fd6b797e9b41a71096ebe878c89299 -- 2.39.1 ------------=_1677271562-4857-1--