From unknown Mon Jun 23 09:37:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61764 <61764@debbugs.gnu.org> To: bug#61764 <61764@debbugs.gnu.org> Subject: Status: 29.0.60; eglot show incomplete inlay hints Reply-To: bug#61764 <61764@debbugs.gnu.org> Date: Mon, 23 Jun 2025 16:37:46 +0000 retitle 61764 29.0.60; eglot show incomplete inlay hints reassign 61764 emacs submitter 61764 Kai Ma severity 61764 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 12:10:43 2023 Received: (at submit) by debbugs.gnu.org; 24 Feb 2023 17:10:43 +0000 Received: from localhost ([127.0.0.1]:38159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVbak-00045x-R2 for submit@debbugs.gnu.org; Fri, 24 Feb 2023 12:10:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:57280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVbai-00045n-5x for submit@debbugs.gnu.org; Fri, 24 Feb 2023 12:10:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVbaa-0000X8-II for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 12:10:32 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVbaW-0001LF-UT for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2023 12:10:30 -0500 Received: by mail-pg1-x541.google.com with SMTP id y19so8015208pgk.5 for ; Fri, 24 Feb 2023 09:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=W/E8iqy+sIi/jpEw3q+F73mQp/gSHBR9n37Bj3ROB6A=; b=FTbPT5VT1piwDK6DsKKEZPJh2Ks5IM2KAI+9b1VV43MCbsAz/Al7a6TMbNTaQKP6uz nu62QLNsi2mzXJ7xDKgqngNbqA9Ab5P0aYxvm65B49/8csTLxQRCWTP9xlJpttRBsdyJ tG4FLFtmbOhy0Pi6GZbESxkaDbgSpDHbN5wm1RJhXzfYIeG8jkuc/5zzyno7fJ2/GAbW C8LU+5aUds/7jrBmvu3x0HRtOZfP1Cfo++q4xCKmHh57z4TQFsxCLyxDhKa6nuF+11hG dXeC9eDO23LYGcJjyCIK/yOnjp/2EeMyYckuUZB5nUOkF5ut8XMhqfd4ulPlhYIzKw5m Gg/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=W/E8iqy+sIi/jpEw3q+F73mQp/gSHBR9n37Bj3ROB6A=; b=v8qanYeYS/YlwE+4dotEktQUPMCVGNwIPx6qLni6G6Dxn8BT40UD4rj3tR77zyQlMT MAUcRX75N1xbR4pKAWPSjfj0E5sN1+r4xxcDmtyd3ldDtfeYvM9S/jGZDIERlJ4evNXc FpUIyrfC+wAPL9DbDpxhSlNHBukRPsYeDiPy75bwTVgboOD8vRDE2IDoR0ExSVgG4gps d0jA8xLvcUCdarDfq6h8uLA2Gi5wIeqTyNxh4E9vx9/JerA93BVMWgfYQshvcBfITJIE bvU8F7EGKAgBA6Q1TZMBBUO/UkZqyB0rliWWg8zX/riECaRv1zcU8XicrVYReZya7/6K xLsg== X-Gm-Message-State: AO0yUKVYBkWwcf3isOGKcbI7NCES9CuqEWPY/zyM3EMOg9uP9vHaX4Ea HlEUT2zWIPw1mxoPiWSrcAGvnGNajaaGrgLe/4s= X-Google-Smtp-Source: AK7set9L6SYVUi//J2wJ51EBrQQ13axaJL3yM2JhufV5FlnUV3GJQdeftPUDEwqmPrhfL0PxVRcMSQ== X-Received: by 2002:aa7:8bd0:0:b0:5cd:d766:8a26 with SMTP id s16-20020aa78bd0000000b005cdd7668a26mr12525899pfd.8.1677258623683; Fri, 24 Feb 2023 09:10:23 -0800 (PST) Received: from Kais-MacBook.local ([134.209.106.31]) by smtp.gmail.com with ESMTPSA id m14-20020aa78a0e000000b005a8ae0c52cfsm10230698pfa.16.2023.02.24.09.10.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 09:10:23 -0800 (PST) From: Kai Ma To: bug-gnu-emacs@gnu.org Subject: 29.0.60; eglot show incomplete inlay hints Date: Sat, 25 Feb 2023 01:10:19 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::541; envelope-from=justksqsf@gmail.com; helo=mail-pg1-x541.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_LOCAL_NOVOWEL=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) The display of some inlay hints are not complete. For example, in a Rust source file: let v = vec![1i32]; The expected display is: let v: Vec = ...; However, the current eglot (commit 55d29c9bacb in branch emacs-29) only shows the semicolon: let v: = ...; I found that the inlay hint returned by rust-analyzer is something like: ([(:value ": ") (:value "Vec" :location ...) (:value "")]) And I can confirm that by making the following change, the inlay hints from rust-analyzer will be displayed correctly. --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3549,7 +3549,7 @@ eglot--update-hints-1 (left-pad (and paddingLeft (not (memq (char-before) '(32 9))))) (right-pad (and paddingRight (not (memq (char-after) '(32 9))))) (text (if (stringp label) - label (plist-get (elt label 0) :value)))) + label (mapconcat (lambda (plist) (plist-get plist :value)) label)))) (overlay-put ov 'before-string (propertize (concat (and left-pad " ") text (and right-pad " ")) According to the LSP spec [1], the intention of this design is to support the use case where a LSP client shows different information for each part. Therefore, I believe this (concatenation) is the correct thing to do, regardless of whether eglot supports hovering. [1] https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#inlayHint Kai From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 02:50:51 2023 Received: (at control) by debbugs.gnu.org; 1 Mar 2023 07:50:52 +0000 Received: from localhost ([127.0.0.1]:52538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXHEh-0007xc-O6 for submit@debbugs.gnu.org; Wed, 01 Mar 2023 02:50:51 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:54861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXHEf-0007xO-FY for control@debbugs.gnu.org; Wed, 01 Mar 2023 02:50:49 -0500 Received: by mail-pj1-f65.google.com with SMTP id bo22so924882pjb.4 for ; Tue, 28 Feb 2023 23:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=4ltK/SGv09q4EUyx27I0C+07KQVzzO9UDRvEmpY/LsE=; b=MRN+ujp/0bnVNhntrKIids2j11i2IpCBSvII3r5bGgza+h0K54lMsqxc2M26zws+bY QBOrMOqxPgdkFc06lpH+5zeSusHu0xYKfYW8wXxjvdPbOe+pbm5Ck44SfEftyyzHPI+B FRStilbB/K6c85sd0ACD6vicCsOFB2PC5ZDVuEElUGzTxiX6LRoez9rVr5B7GMpz8CZy Diqw+MSHHX/D/z1oLmhMQXr4lKCHMOli0FDc3MxUAMp8qI7nAtVNnbxyR1pnl35YvAQd gO6B5v98frJmSDsKM8ZFjjzPQfdsYZKIpRsQiZnis+0UarCrCqJPdEeTkTZUQlnS2Mo9 LfHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ltK/SGv09q4EUyx27I0C+07KQVzzO9UDRvEmpY/LsE=; b=aZsFNsPEovjNq7V6uu+oESBb4N6pxK1ZhYSr6hWGT2V7eiMErM8nH2ohShs2LEbLBQ PwOJCI7Xig+4XZisLcpaQuaWPEhzSHT/2nc1GqLVjCrlfmxsgI6zqhPFEBm+EQcIiyKx vCEcvyvkz0vaSBqWVnUChz5KS8rcMS6aCJvp5zBJB1Ufm2zo/n3h7lN8v5eShzBev//y 8JNq4+sfFnmTC8uTv12FfctTMs0TfZFPugUosjMmF6XF195nqfaFQZRz77ZfyM+4IYDS HbLs1svX9mIFL46YmUAnQWwj4gN/cxUtDAesHwifOY3hKSSlxieLOMUalBYdLASY3xAd kNZQ== X-Gm-Message-State: AO0yUKVwTvH6resdZWuSNjFsgJd+tx1/I1MunttPkjjuAEUDa1yZpdUB 0FLB33ypRXOHJ8hFq5y/qvaGL75E0Bd6t3EKHIk= X-Google-Smtp-Source: AK7set+3oj1HzJjXpmfvI+hQywxpC9s5AW/M8EKi3R3DxaRlaV6dDoKdMWeHJdJ25YSf1AaMxRIpEw== X-Received: by 2002:a17:90b:1c88:b0:234:1d1d:6ae6 with SMTP id oo8-20020a17090b1c8800b002341d1d6ae6mr6285099pjb.1.1677657042812; Tue, 28 Feb 2023 23:50:42 -0800 (PST) Received: from Kais-MacBook.local ([134.209.106.31]) by smtp.gmail.com with ESMTPSA id t12-20020a17090ae50c00b002376d85844dsm7279128pjy.51.2023.02.28.23.50.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 23:50:42 -0800 (PST) Date: Wed, 01 Mar 2023 15:50:38 +0800 Message-Id: To: control@debbugs.gnu.org From: Kai Ma Subject: control message for bug #61764 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) fixed 61764 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 19:27:49 2023 Received: (at 61764-done) by debbugs.gnu.org; 5 Sep 2023 23:27:49 +0000 Received: from localhost ([127.0.0.1]:59783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfSX-00022t-7s for submit@debbugs.gnu.org; Tue, 05 Sep 2023 19:27:49 -0400 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:45510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfSR-00022c-Ta for 61764-done@debbugs.gnu.org; Tue, 05 Sep 2023 19:27:48 -0400 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2ba1e9b1fa9so50749711fa.3 for <61764-done@debbugs.gnu.org>; Tue, 05 Sep 2023 16:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693956457; x=1694561257; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=xMzBhZg20CQAgZ0UkQ3b9koyNNwLrhSDWa+S8PZ+HJI=; b=TyxYCjhcSzNPJYzjTFoM7/gAw/AN20Cdp+YavX/dE51CdjgUucTh6+NjNBkbp0Icbt s6M0drKoEEU3bvcg1VpI9aCVDqcDkIOFbUMF88rND4jMYR1YpHO+W9PKhZMPivQp3rbQ 4FWdb/oNpiXvcxOGJas3givYxgB3i+RoOGsT1jbtuQONiwM/DYrcJ9eTaizUOAELh2dW xLzu4lCIw9zKqsIreg9lT8MZ6xEHVa1PvgHs2HvIgW5W+FAUAkLH1dtLlpGswwmSCqVm iV8dycjLd8l2/VMn1JQG6N8lZAS/2skIkH2eIETli+7vN07P4yLoUfo8vbYlOiIum//w BgwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693956457; x=1694561257; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xMzBhZg20CQAgZ0UkQ3b9koyNNwLrhSDWa+S8PZ+HJI=; b=lVDRtB0duyP0i219cxTOwBleC0wSGobUp5W/Id2gbe0aVwFfQ98SmJfIiarKpbvREE gUUoXFIHKXKKsdooobn4yJ8nUfSQF10ZMloMmt26sVx9Fh/et62rHthtOCdnkx7ARVEG qtjwbwU9cjrIByJ3/1/zLwYl8FObsuAXU+mz8uXp1bvFEUHlbWoqBEMYggeTKyva6IHx xVUSCzR1TLfho5MJv+X943ndyWzGyI49xdmLSwAUAYXWhpnajOobLI423/YmAhM/sVbc ChLdO+7UqX3cPI6c+p8oVpqblSYS4dSQBA/lwQegJbxc3vtWKAU18FUlkZyCI7kmrvUl ZWnA== X-Gm-Message-State: AOJu0YxX+wM59LGjudhCCoxzH0FZoQHGcjub1o3fLaFZ0SxcKRwXSKW4 fXYIwiEpI4OD1LwS1Qto7VmoWkh6lQ0erEn5irA= X-Google-Smtp-Source: AGHT+IH9K4rv7iz/fnMtoZH0C9ye5xlnVwXlNNJNfv1nil5O67LjkkyzhwO+Yv2j0cx/Qd2QJYyLzagCNoE2RY3p0qE= X-Received: by 2002:ac2:58e2:0:b0:500:7e12:c48b with SMTP id v2-20020ac258e2000000b005007e12c48bmr876229lfo.44.1693956456986; Tue, 05 Sep 2023 16:27:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 16:27:36 -0700 From: Stefan Kangas In-Reply-To: (Kai Ma's message of "Wed, 01 Mar 2023 15:50:38 +0800") References: MIME-Version: 1.0 Date: Tue, 5 Sep 2023 16:27:36 -0700 Message-ID: Subject: Re: control message for bug #61764 To: Kai Ma Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61764-done Cc: 61764-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kai Ma writes: > fixed 61764 29.1 > quit I assume that means you can no longer see the issue, so I'm closing this bug. From unknown Mon Jun 23 09:37:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Oct 2023 11:24:31 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator