GNU bug report logs - #6176
[PATCH 1/2] sort: add a --debug option to highlight key extents

Previous Next

Full log

Message #23 received at 6176 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Eric Blake <eblake <at> redhat.com>
Cc: 6176 <at> debbugs.gnu.org, Pádraig Brady <P <at> draigBrady.com>
Subject: Re: bug#6176: [PATCH 2/2] sort: --debug: output data independent
	key	warnings
Date: Wed, 12 May 2010 07:55:47 -0600

[Message part 1 (text/plain, inline)]

On 05/12/2010 07:53 AM, Eric Blake wrote:
> On 05/11/2010 05:39 PM, Pádraig Brady wrote:
>> The attached patch gives warnings about questionable
>> option combinations. For example:
>>
>> $ sort --debug -rb -k1,1n /dev/null
>> ! options `-b' are ignored
>> ! option `-r' only applies to last-resort comparison
> 
> That looks awkward, both when compared to the GCS convention of listing
> the program name rather than !, and in respect to plurality:
> 
> sort: option `-b' is ignored
> sort: option `-r' only applies to last-resort comparison

Or, to put it more concretely,

> +      fprintf (stderr, _("! options `-%s' are ignored\n"), opts);
> +      free (opts);
> +      ugkey.reverse = ugkey_reverse;
> +    }
> +  if (!stable && ugkey.reverse)
> +    fprintf (stderr,
> +             _("! option `-r' only applies to last-resort comparison\n"));

Why are we using fprintf(stderr) instead of error()?

-- 
Eric Blake   eblake <at> redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.