Subject: Re: bug#6176: [PATCH 2/2] sort: --debug: output data independent key warnings

From: Eric Blake <[email-masked]>
Date: Wed, 12 May 2010 07:55:47 -0600

On 05/12/2010 07:53 AM, Eric Blake wrote:
> On 05/11/2010 05:39 PM, Pádraig Brady wrote:
>> The attached patch gives warnings about questionable
>> option combinations. For example:
>>
>> $ sort --debug -rb -k1,1n /dev/null
>> ! options `-b' are ignored
>> ! option `-r' only applies to last-resort comparison
> 
> That looks awkward, both when compared to the GCS convention of listing
> the program name rather than !, and in respect to plurality:
> 
> sort: option `-b' is ignored
> sort: option `-r' only applies to last-resort comparison

Or, to put it more concretely,

> +      fprintf (stderr, _("! options `-%s' are ignored\n"), opts);
> +      free (opts);
> +      ugkey.reverse = ugkey_reverse;
> +    }
> +  if (!stable && ugkey.reverse)
> +    fprintf (stderr,
> +             _("! option `-r' only applies to last-resort comparison\n"));

Why are we using fprintf(stderr) instead of error()?

-- 
Eric Blake   [email-masked]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org