From unknown Mon Jun 23 16:44:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61734 <61734@debbugs.gnu.org> To: bug#61734 <61734@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails Reply-To: bug#61734 <61734@debbugs.gnu.org> Date: Mon, 23 Jun 2025 23:44:26 +0000 retitle 61734 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-= thumbnails reassign 61734 emacs submitter 61734 Manuel Giraud severity 61734 normal tag 61734 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 11:02:37 2023 Received: (at submit) by debbugs.gnu.org; 23 Feb 2023 16:02:38 +0000 Received: from localhost ([127.0.0.1]:35079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVE3J-00016a-86 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 11:02:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:32856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVE3G-00016R-Uj for submit@debbugs.gnu.org; Thu, 23 Feb 2023 11:02:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVE3F-0003kU-P2 for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 11:02:34 -0500 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVE3C-000616-CO for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 11:02:33 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=5gB1BTFK vZwQjnnU5F19ULvZT2uOpAcjAqaRpV+nnCg=; h=date:subject:to:from; d=ledu-giraud.fr; b=nBvenqVN/OjTS0oBYGbSSMavKEVi1bBZbWIdyCCJm68id2hR6+ mtctrV2JOzIuhY1xj/b5tbmkO+/PWhidruCw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=5gB1BTFKvZwQjnnU 5F19ULvZT2uOpAcjAqaRpV+nnCg=; h=date:subject:to:from; d=ledu-giraud.fr; b=IxHUYtRn3481/zbpFHZPay/X9Qx1eWXofnvsD7zD+mqrcpews4 fKoxTaBZxZYWPTrPpVimBhtNteFCbwq2RG0gL+A6hTI+9ax3IafOiNOhkwN8V4Kt5ymsqG zx3eMNZL3AVZyTkwTgorL8mRwWZZPgYmnksv//I+r4jPzC42j49ZrS3TYc9llNj8zXJ7kf JklXM9iWXbDpcre8nlgdV6ZwuH0xIrHm5X4m82hAtTsjPFqO513JvLF9wl3HgKK/B5AFIv 8wuGpSfp83UvNHESUiboMeeWPYVbFwEdVhl/gSllwfYeI4NKYzH0PokdWEUdnGt/KLFwSk SmxdC7VzlsBA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 018d35d4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 23 Feb 2023 17:02:26 +0100 (CET) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails Date: Thu, 23 Feb 2023 17:02:25 +0100 Message-ID: <878rgoid4e.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, Here is a patch to avoid "wrong type error" upon comparision to zero of image-dired--number-of-thumbnails. How to reproduce: - Do not have an existing *image-dired* buffer - Hit 'C-t a' (image-dired-display-thumbs-append) on an image file from Dired --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Defaults-to-zero-for-image-dired-number-of-thumbnail.patch >From c88f74aaa381580c183a8692bc467bfef7cd192b Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 23 Feb 2023 16:42:48 +0100 Subject: [PATCH] Defaults to zero for image-dired--number-of-thumbnails * lisp/image/image-dired.el (image-dired--number-of-thumbnails): Defaults to zero to avoid wrong type error down the line. --- lisp/image/image-dired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 8e2a75a418f..6ecb307ce12 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -546,7 +546,7 @@ image-dired--line-up-with-method (t (image-dired-line-up-dynamic)))) -(defvar-local image-dired--number-of-thumbnails nil) +(defvar-local image-dired--number-of-thumbnails 0) ;;;###autoload (defun image-dired-display-thumbs (&optional arg append do-not-pop) -- 2.39.1 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version 1.17.8) of 2023-02-23 built on computer Repository revision: c88f74aaa381580c183a8692bc467bfef7cd192b Repository branch: mgi/image-dired-fix Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD computer 7.2 GENERIC.MP#1052 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: gnus-dired-mode: t display-time-mode: t display-battery-mode: t server-mode: t shell-dirtrack-mode: t repeat-mode: t desktop-save-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-0.10.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs /home/manuel/.emacs.d/elpa/transient-0.3.7/transient hides /home/manuel/emacs/share/emacs/30.0.50/lisp/transient Features: (shadow sort emacsbug gnus-async gnus-bcklg gnus-cite mail-extr gnus-draft gnus-ml gnus-topic mm-archive url-http url-gw url-cache url-auth utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nsm nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss w3m w3m-hist bookmark-w3m w3m-ems w3m-favicon w3m-image w3m-fb tab-line w3m-proc w3m-util pulse image-file image-converter image-dired-dired image-dired image-dired-tags image-dired-external image-dired-util org-indent vc-dir ewoc vc reveal pascal sh-script executable texinfo texinfo-loaddefs org-element org-persist org-id org-refile avl-tree oc-basic ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi doc-view jka-compr image-mode exif vc-hg conf-mode css-mode treesit smie sgml-mode facemenu imenu eww xdg url-queue mm-url autorevert filenotify vc-git diff-mode bug-reference paredit edmacro gnus-dired time battery exwm-randr xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server modus-operandi-theme modus-themes ytdious mingus libmpdee reporter edebug debug backtrace transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt cl-extra help-mode speedbar ezimage dframe eieio-base pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func org-version org-compat org-macs visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp format-spec slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads view mule-util cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays holiday-loaddefs vc-dispatcher vc-svn appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-aux dired-x dired dired-loaddefs notifications dbus xml repeat easy-mmode desktop frameset osm-autoloads rust-mode-autoloads compat-autoloads ebdb-autoloads magit-autoloads debbugs-autoloads git-commit-autoloads magit-section-autoloads ef-themes-autoloads with-editor-autoloads paredit-autoloads dash-autoloads ytdious-autoloads transmission-autoloads transient-autoloads exwm-autoloads hyperbole-autoloads detached-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 681910 47010) (symbols 48 58183 11) (strings 32 185661 11716) (string-bytes 1 7215305) (vectors 16 108542) (vector-slots 8 2228124 137704) (floats 8 1047 375) (intervals 56 9844 144) (buffers 984 87)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 15:18:03 2023 Received: (at 61734) by debbugs.gnu.org; 23 Feb 2023 20:18:03 +0000 Received: from localhost ([127.0.0.1]:35421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVI2V-00028e-5J for submit@debbugs.gnu.org; Thu, 23 Feb 2023 15:18:03 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:33897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVI2S-00028D-1l for 61734@debbugs.gnu.org; Thu, 23 Feb 2023 15:18:02 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=SIwW0Ayp hb816QUh0omDg77tYk1ha0rwm6Uuw9VfOgk=; h=date:references:in-reply-to: subject:to:from; d=ledu-giraud.fr; b=yI2J2CagiLa57JHG88lMdz0WM5/zX8vu5 yhpTxSXoCakuet2i0eD6dkoxR3myVYm2PrcPJ0AL2PC6Hg8vapQCA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=SIwW0Ayphb816QUh 0omDg77tYk1ha0rwm6Uuw9VfOgk=; h=date:references:in-reply-to:subject: to:from; d=ledu-giraud.fr; b=B/MtHb/p5L14ekRZOn2tvUfAz3esvnLXB9fnjh1dA B09rzRE1l2nK6+ATtxyBdQqTaWgY0tNtoPcwJdwPgybg2R6zvBoJ01UExK/WLXckVS8s3x uG93iILDfd6wQqEhZUkxOC1D0pfaf1Coe7vIq4p4T8EoEKORZcugTi21ZHtJiNEvjMaehT 6+Re1swFU6yIpwoH6+yjxu6OmGvqBwEGbrr0T7QMjFmxvdt2e6Yyk1JTq/2ReLYt64r0aa 0PRihSHXoCTFSOGDqyfWMpQPpjgSnmhmz6vkocyhK/I20GbF9hqgnaaa7kKBXy60nuwK+3 7WEsz8WjjMLE1YxEcWqBA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id bb1ae3ad (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <61734@debbugs.gnu.org>; Thu, 23 Feb 2023 21:17:58 +0100 (CET) From: Manuel Giraud To: 61734@debbugs.gnu.org Subject: Re: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails In-Reply-To: <878rgoid4e.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Thu, 23 Feb 2023 17:02:25 +0100") References: <878rgoid4e.fsf@ledu-giraud.fr> Date: Thu, 23 Feb 2023 21:17:55 +0100 Message-ID: <87zg94gmq4.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61734 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Manuel Giraud writes: > Hi, > > Here is a patch to avoid "wrong type error" upon comparision to zero of > image-dired--number-of-thumbnails. How to reproduce: > > - Do not have an existing *image-dired* buffer > - Hit 'C-t a' (image-dired-display-thumbs-append) on an image file > from Dired Maybe this new version can go in too. It updates the thumbnails counter when removing a thumbnail. What is not updated though is the number of the image which is assign with a text-property at insertion... So it is not complete but an improvement nevertheless. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Defaults-to-zero-for-image-dired-number-of-thumbnail.patch >From 04a3bc1cf9b3c2685c3edba1e0f792d8f28de6b2 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 23 Feb 2023 16:42:48 +0100 Subject: [PATCH] Defaults to zero for image-dired--number-of-thumbnails (bug#61734) * lisp/image/image-dired.el (image-dired--number-of-thumbnails): Defaults to zero to avoid wrong type error down the line. (image-dired-delete-char): Update thumbnails counter upon deletion. --- lisp/image/image-dired.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 8e2a75a418f..2c2968b1b49 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -546,7 +546,7 @@ image-dired--line-up-with-method (t (image-dired-line-up-dynamic)))) -(defvar-local image-dired--number-of-thumbnails nil) +(defvar-local image-dired--number-of-thumbnails 0) ;;;###autoload (defun image-dired-display-thumbs (&optional arg append do-not-pop) @@ -1127,9 +1127,11 @@ image-dired-delete-char "Remove current thumbnail from thumbnail buffer and line up." (interactive nil image-dired-thumbnail-mode) (let ((inhibit-read-only t)) - (delete-char 1)) + (delete-char 1) + (cl-decf image-dired--number-of-thumbnails)) (let ((pos (point))) (image-dired--line-up-with-method) + (image-dired--update-header-line) (goto-char pos))) (defun image-dired-line-up () -- 2.39.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 04:35:46 2023 Received: (at 61734) by debbugs.gnu.org; 24 Feb 2023 09:35:46 +0000 Received: from localhost ([127.0.0.1]:35951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVUUT-0006hQ-M3 for submit@debbugs.gnu.org; Fri, 24 Feb 2023 04:35:46 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:25567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVUUQ-0006hG-Sg for 61734@debbugs.gnu.org; Fri, 24 Feb 2023 04:35:44 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=clgBRd82 2CB62LDuOwWTbN/rF6m+rChFVgbOtrmlesA=; h=date:references:in-reply-to: subject:to:from; d=ledu-giraud.fr; b=13dKZI7NZqL0ZZ3NmYe5GhQ7ZtTQrdRCO KdZnjoFgBoATQHVTFrkYMpoAujRhykonab/CnVupFnTtQ6oKgyYBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=clgBRd822CB62LDu OwWTbN/rF6m+rChFVgbOtrmlesA=; h=date:references:in-reply-to:subject: to:from; d=ledu-giraud.fr; b=IBMHlYd7QshNwljN5pkf7TttS4EfRCvG2hLxEWTJK oCei3FMqTB9PjgZExPLRvhkyXRwNO7Ykf7vTzdQKwBx6mzkSY9J0QkWhD1V69y4W1XHv6N hsQDQt3V8pRam/pb3AhxXec9KkQewoa7RJmvh4VWLD1Wiokb77nKq6eQkyvIv3/1HuorCk 55NJvF8C8CyoPctkiVEP7eBZ9YME981a5nh5ryQwAiMbwA6DKrDNxNsf7aYf1DucGu+eNJ GSz8huGyVwNAksy8YbZsPyZZeyL8Ld+D+YL4Y7nCAJ4VUHxflVL9bI3ZfZRCaJxtNcUoFE OLeg4SzKACmdoycUF3E0g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 7abc9264 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <61734@debbugs.gnu.org>; Fri, 24 Feb 2023 10:35:40 +0100 (CET) From: Manuel Giraud To: 61734@debbugs.gnu.org Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails In-Reply-To: <87zg94gmq4.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Thu, 23 Feb 2023 21:17:55 +0100") References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> Date: Fri, 24 Feb 2023 10:35:38 +0100 Message-ID: <87a6134d91.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61734 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Here is another version that fixes all the "out of sync" counter that I have=E2=80=A6 but maybe it start to grow outside the scope of this bug repo= rt. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fixes-on-image-dired-thumbnails-counter-bug-61734.patch >From 078cff71abc7125558ed492e894aa7d1b487d9bd Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 23 Feb 2023 16:42:48 +0100 Subject: [PATCH] Fixes on image-dired thumbnails counter (bug#61734) * lisp/image/image-dired.el (image-dired--number-of-thumbnails): Defaults to zero to avoid wrong type error down the line. (image-dired-delete-char): Update thumbnails counter upon deletion. (image-dired-insert-thumbnail, image-dired--update-header-line, image-dired-display-thumbs): Remove 'image-number text-property and rely on the (point). --- lisp/image/image-dired.el | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 8e2a75a418f..c33a977e5dc 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -424,11 +424,10 @@ image-dired--get-create-thumbnail-file (file-name-nondirectory thumb-file))) thumb-file)) -(defun image-dired-insert-thumbnail ( file original-file-name - associated-dired-buffer image-number) +(defun image-dired-insert-thumbnail (file original-file-name + associated-dired-buffer) "Insert thumbnail image FILE. -Add text properties ORIGINAL-FILE-NAME, ASSOCIATED-DIRED-BUFFER -and IMAGE-NUMBER." +Add text properties ORIGINAL-FILE-NAME, ASSOCIATED-DIRED-BUFFER." (let (beg end) (setq beg (point)) (image-dired-insert-image @@ -452,7 +451,6 @@ image-dired-insert-thumbnail 'keymap nil 'original-file-name original-file-name 'associated-dired-buffer associated-dired-buffer - 'image-number image-number 'tags (image-dired-list-tags original-file-name) 'mouse-face 'highlight 'comment (image-dired-get-comment original-file-name))))) @@ -546,7 +544,7 @@ image-dired--line-up-with-method (t (image-dired-line-up-dynamic)))) -(defvar-local image-dired--number-of-thumbnails nil) +(defvar-local image-dired--number-of-thumbnails 0) ;;;###autoload (defun image-dired-display-thumbs (&optional arg append do-not-pop) @@ -587,8 +585,8 @@ image-dired-display-thumbs (dolist (file files) (when (string-match-p (image-dired--file-name-regexp) file) (image-dired-insert-thumbnail - (image-dired--get-create-thumbnail-file file) file dired-buf - (cl-incf image-dired--number-of-thumbnails))))) + (image-dired--get-create-thumbnail-file file) file dired-buf) + (cl-incf image-dired--number-of-thumbnails)))) (if (> image-dired--number-of-thumbnails 0) (if do-not-pop (display-buffer buf) @@ -789,7 +787,7 @@ image-dired--update-header-line (let ((file-name (image-dired-original-file-name)) (dired-buf (buffer-name (image-dired-associated-dired-buffer))) (image-count (format "%s/%s" - (get-text-property (point) 'image-number) + (1+ (/ (point) 2)) ;; Why this magical formula? image-dired--number-of-thumbnails)) (props (string-join (get-text-property (point) 'tags) ", ")) (comment (get-text-property (point) 'comment)) @@ -1127,10 +1125,12 @@ image-dired-delete-char "Remove current thumbnail from thumbnail buffer and line up." (interactive nil image-dired-thumbnail-mode) (let ((inhibit-read-only t)) - (delete-char 1)) + (delete-char 1) + (cl-decf image-dired--number-of-thumbnails)) (let ((pos (point))) (image-dired--line-up-with-method) - (goto-char pos))) + (goto-char pos) + (image-dired--update-header-line))) (defun image-dired-line-up () "Line up thumbnails according to `image-dired-thumbs-per-row'. -- 2.39.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 08:20:30 2023 Received: (at 61734) by debbugs.gnu.org; 27 Feb 2023 13:20:30 +0000 Received: from localhost ([127.0.0.1]:46352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWdQc-0000Ky-3P for submit@debbugs.gnu.org; Mon, 27 Feb 2023 08:20:30 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:8515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWdQZ-0000Ko-Fu for 61734@debbugs.gnu.org; Mon, 27 Feb 2023 08:20:29 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=HSI8XEZn d5NoaVCJ/xyMAzWVhPMryfLhGWqmpf5WNxA=; h=date:references:in-reply-to: subject:to:from; d=ledu-giraud.fr; b=VZc42E1cUmIRpu6zKYj44UvGiQjFSevJf B8PvBlx8zG9yTG+XjNzUITqT/rg6hdu/jm9s+EIgGsfN/Me6pCqBA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=HSI8XEZnd5NoaVCJ /xyMAzWVhPMryfLhGWqmpf5WNxA=; h=date:references:in-reply-to:subject: to:from; d=ledu-giraud.fr; b=gsWnIMdP39qnmG5yBvzQTjZW6ojRDJWMlVLfVhjyB oQhJ3V3tWVfOnsfUN6dEG+qR/KwwQhjWiPUW7FxdSRaT4aUrqq7rKXOvK0Fz6fsjZ/pKR9 Wi7cEBb7kqL7k8mBbtuC463YQlweic/AYVuWMF9Oskb1mTftbgN3ZCSipy8p510Pnel+XF /3+vMUZD39NcY0iyTOqevM9g9qj6pQ3estEKDWkbrA8s2qDxjjLdZvUAHcqFr0ZKd4UGrn v213OQb7WEWAdSmi5d+hinNdUBFLPvCC0IngyYCX9qLqrRw4Kviexvx5vqAIncLETsgSB/ u3JKGRh2YgGSug18ZaDcw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 0f15ced3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 27 Feb 2023 14:20:25 +0100 (CET) From: Manuel Giraud To: 61734@debbugs.gnu.org, Eli Zaretskii Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails In-Reply-To: <87a6134d91.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Fri, 24 Feb 2023 10:35:38 +0100") References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> <87a6134d91.fsf@ledu-giraud.fr> Date: Mon, 27 Feb 2023 14:20:24 +0100 Message-ID: <87356rb5yf.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61734 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Did you have a look at this patch? I think that at least the first version should go into 29. Thanks. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 08:59:33 2023 Received: (at 61734) by debbugs.gnu.org; 27 Feb 2023 13:59:33 +0000 Received: from localhost ([127.0.0.1]:46398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWe2P-0001TL-81 for submit@debbugs.gnu.org; Mon, 27 Feb 2023 08:59:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWe2L-0001T4-UT for 61734@debbugs.gnu.org; Mon, 27 Feb 2023 08:59:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWe2F-0006r5-Qu; Mon, 27 Feb 2023 08:59:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hy0bHuO5fTAYq+KKmgAjJ4SsXV7d/X+gcCW0xAkGOqw=; b=jAgK2XMWVjeS L+aJ7/Fyc54EB9T3jAVbZaxzQ8kGQ7hhYD6H8K/ovvFGUqe/Fs2ije1oe32LU7bDFEjB1zuH8SNCI qBF7ZZh4y5SF5AP/szuT1RsUONJHd1kLCe94nPwojjRd5mxJe6dYaXrh2cgMe1L8JyPkkW1szE4o8 sjr2FA6vQrlsFY6dIYSEJheAPvBWWxZDBi2OeSK8cBQda/WnL8/cOp4gs6sRqi5YyBe0ihywL5JOs d97uKJlzOjru+fAQhM4kWjUwHv8mxu/Sc2ljOB6sboPP34CXCPUwJ1+62iyTLTQDn3mH0gn5fCG5c Py62hs+2TR6gzXCldDe8kA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWe1y-0000nx-Ds; Mon, 27 Feb 2023 08:59:21 -0500 Date: Mon, 27 Feb 2023 15:59:13 +0200 Message-Id: <83zg8zgqfi.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87356rb5yf.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 27 Feb 2023 14:20:24 +0100) Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> <87a6134d91.fsf@ledu-giraud.fr> <87356rb5yf.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61734 Cc: 61734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Date: Mon, 27 Feb 2023 14:20:24 +0100 > > Hi Eli, > > Did you have a look at this patch? I think that at least the first > version should go into 29. Thanks. I only ever keep the last version, and it's certainly not for emacs-29. What do you want to install on emacs-29, and what problem(s) is that supposed to fix? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 11:20:16 2023 Received: (at 61734) by debbugs.gnu.org; 27 Feb 2023 16:20:16 +0000 Received: from localhost ([127.0.0.1]:48649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgEa-0004iT-7c for submit@debbugs.gnu.org; Mon, 27 Feb 2023 11:20:16 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:13903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgEW-0004iI-K3 for 61734@debbugs.gnu.org; Mon, 27 Feb 2023 11:20:14 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=yLqzm2wC wXSwiZtKzAXcmrkezkQY4sLcf8Xxi/6FmeM=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=3PmZTWd74MGuWJm0YGcPWdVIbsXCc6 Jz6SuyeME2kLhkJP6xTkEnOuw+CDUnn3uKGlvEH7vmYQ+Eu5J2oPMSBw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=yLqzm2wCwXSwiZtK zAXcmrkezkQY4sLcf8Xxi/6FmeM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=f1m/KvJemyF53cxBaJs1/IeQOgyegOOBzp1N5K lylwUppnVJomJNQ3SlwUL43+oQZbs0YkDzkjLsZchUrQcT3etDyxVRum9JQZo8BbwjWF3N UNgSiWHEVljAwK+bZM7iE+EXzdy6JzY/66rrYJwKVbUY6l7BYhM7He8sKWVhzQ8rPaUYKU Q9MVHZX9imah86kZZjRVP5l8W181nmjeXmSLb7kvg7l+DKA3/+ybIEILxQurmV8X1/tSx6 TQdvAMlU50Qp7OdBt3kUI8kPLzaiKnY09VfGGg/eYzTNDb1l4+TTuPEEg9cjOXvD6F/dSG XD50C1oi9BCb4WYs6/QtktdA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id fcef0c27 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 27 Feb 2023 17:20:10 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails In-Reply-To: <83zg8zgqfi.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Feb 2023 15:59:13 +0200") References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> <87a6134d91.fsf@ledu-giraud.fr> <87356rb5yf.fsf@ledu-giraud.fr> <83zg8zgqfi.fsf@gnu.org> Date: Mon, 27 Feb 2023 17:20:10 +0100 Message-ID: <87y1oj9j2d.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61734 Cc: 61734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > I only ever keep the last version, and it's certainly not for > emacs-29. Ok, sorry. So here is the first version. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Defaults-to-zero-for-image-dired-number-of-thumbnail.patch >>From c88f74aaa381580c183a8692bc467bfef7cd192b Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 23 Feb 2023 16:42:48 +0100 Subject: [PATCH] Defaults to zero for image-dired--number-of-thumbnails * lisp/image/image-dired.el (image-dired--number-of-thumbnails): Defaults to zero to avoid wrong type error down the line. --- lisp/image/image-dired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 8e2a75a418f..6ecb307ce12 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -546,7 +546,7 @@ image-dired--line-up-with-method (t (image-dired-line-up-dynamic)))) -(defvar-local image-dired--number-of-thumbnails nil) +(defvar-local image-dired--number-of-thumbnails 0) ;;;###autoload (defun image-dired-display-thumbs (&optional arg append do-not-pop) -- 2.39.1 --=-=-= Content-Type: text/plain > What do you want to install on emacs-29, and what problem(s) is that > supposed to fix? This fixes a "wrong type error" when comparing image-dired--number-of-thumbnails to zero. Here is a recipe to make it happen: - Do not have an existing *image-dired* buffer - Hit 'C-t a' (image-dired-display-thumbs-append) on an image file from Dired And you're right that the rest of the patch should not go into emacs-29. -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 08:26:55 2023 Received: (at 61734) by debbugs.gnu.org; 28 Feb 2023 13:26:56 +0000 Received: from localhost ([127.0.0.1]:49935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX00N-0007tb-J1 for submit@debbugs.gnu.org; Tue, 28 Feb 2023 08:26:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX00L-0007tM-Tz for 61734@debbugs.gnu.org; Tue, 28 Feb 2023 08:26:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX00G-0005bY-3n; Tue, 28 Feb 2023 08:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=F5+IOHex547zyMh6WNPaFMMiMIOBj03tw55HTlLt74o=; b=bXeVOkt9NxK+ hrcV+o7pEqTu0uo99EQEfWk9C7b2iiqEFSBLYZFRO6ApUKPuIrUm1XTmSuRgzpOfMRXa0NZYqMpnA rWv351Iqnsq9pPnkEdijNPX5x8t/IdmhYeUrt6AOy55PpSsiODMM87Nhn0055nOex9l8A7NWefsTq +tv78ovgzVo8C/3l6MIUW2HCzQk1j1l5PgY3mieMTvFmLyDYucgJUU2eSsE0rrVpT4gcIDANyYOhJ NOieyQg1uwOeV/cCaZCzP/HvRQ8dkggsrA6slt3wUQBmbxeW0HWrxXznWKFfoclfWZTzte19HisFW GKVH5aXHWKRRTrBil6+s/A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX008-000469-Q3; Tue, 28 Feb 2023 08:26:46 -0500 Date: Tue, 28 Feb 2023 15:26:51 +0200 Message-Id: <83cz5thqec.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87y1oj9j2d.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 27 Feb 2023 17:20:10 +0100) Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> <87a6134d91.fsf@ledu-giraud.fr> <87356rb5yf.fsf@ledu-giraud.fr> <83zg8zgqfi.fsf@gnu.org> <87y1oj9j2d.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61734 Cc: 61734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61734@debbugs.gnu.org > Date: Mon, 27 Feb 2023 17:20:10 +0100 > > > I only ever keep the last version, and it's certainly not for > > emacs-29. > > Ok, sorry. So here is the first version. Thanks, installed on the emacs-29 branch. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 08:31:24 2023 Received: (at 61734) by debbugs.gnu.org; 28 Feb 2023 13:31:24 +0000 Received: from localhost ([127.0.0.1]:49939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX04i-00082e-8u for submit@debbugs.gnu.org; Tue, 28 Feb 2023 08:31:24 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:45095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX04f-00082R-Iw for 61734@debbugs.gnu.org; Tue, 28 Feb 2023 08:31:22 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ofrL21RL QUxINsdZ6e9DcgFPWe4n2urvGYVWuPo+j4E=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Ez26hFTzPvYJZqbsGiDzORwTJEsGko nKRMsrfu9UQV2uqswIap/Ewc/1sR+cMY2PZKt/t1lsDf7QfGA1Gs9CDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ofrL21RLQUxINsdZ 6e9DcgFPWe4n2urvGYVWuPo+j4E=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=QYMX7+CccpCA8G4jEY3cuuIPv6RD9Wj2LfrovT guNe6wA3PteUej+zsnu4I3bbV86nlDXa6+DGVs2JvXyrZOv5VGLYbnd7G8gYHT28a0Kbka dICRwiXlI/zGsygwTAvi6h8XvPjMKP9O/zF5Qvo14Z2I7NcrU3N4u/h5vK2Y4CrU5N0l7u 1Hy4aJA2+lU5TuOqq7zwoMa5HqoHwwobHP8DkUr0qGA3uRDfctj0Ojivh+AGGlgb/lkdwD +0T+PJfQotuprtA4WYhRnsJa/rgC4LZG/ayCULKAeXtn11tlDF1IsSwSprV8PNvPGj8xLF tmO7kmwGdx8jfQURHwfyeV7Q== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id bc099082 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 28 Feb 2023 14:31:19 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails In-Reply-To: <83cz5thqec.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Feb 2023 15:26:51 +0200") References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> <87a6134d91.fsf@ledu-giraud.fr> <87356rb5yf.fsf@ledu-giraud.fr> <83zg8zgqfi.fsf@gnu.org> <87y1oj9j2d.fsf@ledu-giraud.fr> <83cz5thqec.fsf@gnu.org> Date: Tue, 28 Feb 2023 14:31:18 +0100 Message-ID: <87edq9gbmh.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61734 Cc: 61734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > Thanks, installed on the emacs-29 branch. Thanks. You can close this bug report if you want and I'll make another one for the other part of the patch (for main branch). -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 09:24:39 2023 Received: (at 61734-done) by debbugs.gnu.org; 28 Feb 2023 14:24:40 +0000 Received: from localhost ([127.0.0.1]:49998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX0uF-00017b-LU for submit@debbugs.gnu.org; Tue, 28 Feb 2023 09:24:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX0uD-00017P-Qe for 61734-done@debbugs.gnu.org; Tue, 28 Feb 2023 09:24:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX0u6-0003j6-KS; Tue, 28 Feb 2023 09:24:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WrbjpT9gsRFVOSRG9MnRgie2qBMny4kHPbLSPEdr5Xs=; b=dzEdffjRB3BR TFjD4rw75cRAYvWkG4omwTsSGWBU5HsiC5T2r257kRJt/JCQ+s8VLEfIFF7f0K/rfa2ALA7ZY9Zx6 b7QTaZkeuwzfAsPHYTB7wp7hOVu5Jo4F1XA9h3nzLJdHByTRJSGThUkOiIPDuV371tRqkOlP1/36O Df2fPGwYOgyEOkQDpVwOF5P4ClQIZzYxa4ATaMNKrLvf5cqYsr72tfq6fQnuOAN09BOUgFh2RHNG7 IgYJG1pf4cAIf+N3OLCqmgBKPCKDrJrrra8xHihoWlxkABYufY81vSuf66DJXVMxI1VfMwagX8mHE ZHibasLOKR72p4SGoTpWqA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX0tG-0001kL-ML; Tue, 28 Feb 2023 09:23:49 -0500 Date: Tue, 28 Feb 2023 16:23:49 +0200 Message-Id: <835yblhnre.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87edq9gbmh.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 28 Feb 2023 14:31:18 +0100) Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> <87a6134d91.fsf@ledu-giraud.fr> <87356rb5yf.fsf@ledu-giraud.fr> <83zg8zgqfi.fsf@gnu.org> <87y1oj9j2d.fsf@ledu-giraud.fr> <83cz5thqec.fsf@gnu.org> <87edq9gbmh.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61734-done Cc: 61734-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61734@debbugs.gnu.org > Date: Tue, 28 Feb 2023 14:31:18 +0100 > > Eli Zaretskii writes: > > > Thanks, installed on the emacs-29 branch. > > Thanks. You can close this bug report if you want and I'll make another > one for the other part of the patch (for main branch). Done. From unknown Mon Jun 23 16:44:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 Mar 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator