GNU bug report logs - #61724
[PATCH 1/3] gnu: Add nlohmann-json.

Previous Next

Full log

Message #17 received at 61724 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: jgart <jgart <at> dismail.de>, 61724 <at> debbugs.gnu.org
Cc: control <at> debbugs.gnu.org
Subject: Re: [PATCH 1/3] gnu: Add nlohmann-json.
Date: Thu, 23 Feb 2023 18:57:14 +0100

merge 61672 61724
thanks

Hi jgart,

Am Donnerstag, dem 23.02.2023 um 06:11 +0100 schrieb jgart:
> * gnu/packages/cpp.scm (nlohmann-json): New variable.
> ---
>  gnu/packages/cpp.scm | 98 +++++++++++++++++-------------------------
> --
>  1 file changed, 37 insertions(+), 61 deletions(-)
> 
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index ed6ae69198..7091459d97 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -22,7 +22,7 @@
>  ;;; Copyright © 2021 Nicolò Balzarotti <nicolo <at> nixo.xyz>
>  ;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
>  ;;; Copyright © 2021 Nikolay Korotkiy <sikmir <at> disroot.org>
> -;;; Copyright © 2021 jgart <jgart <at> dismail.de>
> +;;; Copyright © 2021, 2023 jgart <jgart <at> dismail.de>
>  ;;; Copyright © 2021 Julien Lepiller <julien <at> lepiller.eu>
>  ;;; Copyright © 2021 Disseminate Dissent
> <disseminatedissent <at> protonmail.com>
>  ;;; Copyright © 2022 Efraim Flashner <efraim <at> flashner.co.il>
> @@ -595,74 +595,50 @@ (define-public json-dto
>  data transfer object.")
>      (license license:bsd-3)))
>  
> -(define-public json-modern-cxx
> +(define-public nlohmann-json
>    (package
> -    (name "json-modern-cxx")
> -    (version "3.10.5")
> -    (home-page "https://github.com/nlohmann/json")
> +    (name "nlohmann-json")
> +    (version "3.11.2")
Perform one logical change at a time:
1. Updating is a logical change.
2. Renaming and adjusting dependant packages is a logical change.
When adding a deprecated alias, it should be done in the same commit as
the rename (2).

The order of commits between (1) and (2) doesn't matter.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.