From unknown Thu Jun 19 14:17:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61707: Remove function-alias-p NOERROR argument Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2023 13:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61707@debbugs.gnu.org Cc: Eli Zaretskii X-Debbugs-Original-To: Emacs Bug Report Received: via spool by submit@debbugs.gnu.org id=B.167707346911223 (code B ref -1); Wed, 22 Feb 2023 13:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Feb 2023 13:44:29 +0000 Received: from localhost ([127.0.0.1]:58348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpQ5-0002ux-2u for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:44:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:45380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpQ3-0002uq-GN for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:44:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUpQ3-0003VB-A0 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 08:44:27 -0500 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUpQ1-0000Pw-Ot; Wed, 22 Feb 2023 08:44:27 -0500 Received: by mail-lf1-x12c.google.com with SMTP id w27so10128040lfu.4; Wed, 22 Feb 2023 05:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=yajodm+RZuu96VoYt5OhYaBpV3T8jbVpg3HvAEVWPYo=; b=O//DQLZugIX4PreCRJApbboZ+YUh/LTbllRdj2wjQkemK9g2u51P/ypFdD+Z/1fCtx weMhgtjhL1eBebVS/Rx2ybdBfNuov7l2JbROyTTtzvotQ58IKu7+Im5gP/9FL91MBsbG Jz/MKOqvbSyPjOR3NbF0OBJD5+/P6WLIXqd7TE7qy8Fq2eTjywYU9Uf+vjiYbELlnfKP z3GsPnbaOU4TDu2vUXKGSly5JDSViUjHbsRWuBnfXSRvhI+bUGGWXme/cvyRS9HJbfTB yGMqnc8PvWU8/Vxi1LxMf9VXf2vfHAQj/1DxgWT7K6UKQ6yf4KVRIk0HzMCh3OlA84G8 uipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yajodm+RZuu96VoYt5OhYaBpV3T8jbVpg3HvAEVWPYo=; b=BgcngFiqQNgbUodi2nfMcXlz5MYagJ/UKLxk96IAYK/XqFZXy9KIv6UTq3T/5M8112 8kQrmEwbZt1xVSPdO2Dw8pdm63w9NjDlcPgkCUI0Zaj1UcEaCKmetcmI1tue0YegjMOZ lvZYKAq99OcmaIhADkJXsOYxLkxC4t5j/pypX483eoxVImGnPtD5XGJYSjpdH+y9P7bd 2+Mn65lM84RehveF8wEUMZ4o9LeuynQUjFlU1TNPg9Ox9BdYWkg+0FN6yYbW60xqK6uB MvT3l+8t/XuPTvF3+cRKuw4Fpn0kDVc95t7gpqxyeW4EadOYyZMsP7i2x6NK8aukxRcm pzHw== X-Gm-Message-State: AO0yUKWBXVSFZFD0JvOV1qF4KUWl7rlalq5CfXw8aOvCiUTuCAChLurQ IoThyERTMGeYqpRxbm/Rrcgr7BMvprM= X-Google-Smtp-Source: AK7set/rJ0miiCsyZ3pJMplSeYTuSMSkgbXE3kTDwjAXQG7L7Z1bxDTGIKbCTVZNI32ai3QVSroQ+g== X-Received: by 2002:ac2:5298:0:b0:4b5:87da:8b35 with SMTP id q24-20020ac25298000000b004b587da8b35mr2518033lfm.61.1677073462577; Wed, 22 Feb 2023 05:44:22 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id u8-20020ac251c8000000b004cc9042c9cfsm810022lfm.158.2023.02.22.05.44.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Feb 2023 05:44:22 -0800 (PST) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Message-Id: <38B56FC3-6215-46A4-9E6C-B1F38E1C1144@gmail.com> Date: Wed, 22 Feb 2023 14:44:21 +0100 X-Mailer: Apple Mail (2.3654.120.0.1.14) Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii `function-alias-p` is new in Emacs 29, and takes an optional NOERROR = argument which has become entirely useless in Emacs 30 where it is only = present for compatibility. Given that the NOERROR argument is not very useful in Emacs 29 either, = what about removing it in that version as well? After all, rather silly = to introduce something that's known to go away the next release. Proposed patch attached. --Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE Content-Disposition: attachment; filename=0001-Remove-function-alias-p-noerror-argument.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Remove-function-alias-p-noerror-argument.patch" Content-Transfer-Encoding: quoted-printable =46rom=205ae6be9543f2ea72db303a611bd9a97c6a0df974=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Tue,=2021=20Feb=202023=2015:18:53=20+0100=0A= Subject:=20[PATCH]=20Remove=20function-alias-p=20noerror=20argument=0A=0A= The=20`noerror`=20argument=20isn't=20actually=20needed,=20and=20since=20= it's=20already=0Abeen=20made=20obsolete=20in=20Emacs=2030=20there=20is=20= no=20point=20in=20adding=20it=20in=20the=0Afirst=20place.=0A=0A*=20= doc/lispref/functions.texi=20(Defining=20Functions):=20Update=20manual.=0A= *=20lisp/help-fns.el=20(help-fns--analyze-function):=20Remove=20only=20= use.=0A*=20lisp/subr.el=20(function-alias-p):=20Remove=20argument.=0A*=20= test/lisp/help-fns-tests.el=20(help-fns--analyze-function-recursive):=0A= *=20test/lisp/subr-tests.el=20(test-alias-p):=20Adapt=20tests.=0A---=0A=20= doc/lispref/functions.texi=20=20|=206=20++----=0A=20lisp/help-fns.el=20=20= =20=20=20=20=20=20=20=20=20=20|=203=20++-=0A=20lisp/subr.el=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20|=208=20+++-----=0A=20= test/lisp/help-fns-tests.el=20|=202=20+-=0A=20test/lisp/subr-tests.el=20=20= =20=20=20|=204=20+---=0A=205=20files=20changed,=209=20insertions(+),=20= 14=20deletions(-)=0A=0Adiff=20--git=20a/doc/lispref/functions.texi=20= b/doc/lispref/functions.texi=0Aindex=20f5572e447d3..3351cadf431=20100644=0A= ---=20a/doc/lispref/functions.texi=0A+++=20b/doc/lispref/functions.texi=0A= @@=20-739,7=20+739,7=20@@=20Defining=20Functions=0A=20records.=20=20= @xref{Function=20Cells}.=0A=20@end=20defun=0A=20=0A-@defun=20= function-alias-p=20object=20&optional=20noerror=0A+@defun=20= function-alias-p=20object=0A=20Checks=20whether=20@var{object}=20is=20a=20= function=20alias.=20=20If=20it=20is,=20it=20returns=0A=20a=20list=20of=20= symbols=20representing=20the=20function=20alias=20chain,=20else=0A=20= @code{nil}.=20=20For=20instance,=20if=20@code{a}=20is=20an=20alias=20for=20= @code{b},=20and=0A@@=20-750,9=20+750,7=20@@=20Defining=20Functions=0A=20=20= =20=20=20@result{}=20(b=20c)=0A=20@end=20example=0A=20=0A-If=20there's=20= a=20loop=20in=20the=20definitions,=20an=20error=20will=20be=20signaled.=20= =20If=0A-@var{noerror}=20is=20non-@code{nil},=20the=20non-looping=20= parts=20of=20the=20chain=20is=0A-returned=20instead.=0A+If=20there's=20a=20= loop=20in=20the=20definitions,=20an=20error=20will=20be=20signaled.=0A=20= @end=20defun=0A=20=0A=20=20=20You=20cannot=20create=20a=20new=20= primitive=20function=20with=20@code{defun}=20or=0Adiff=20--git=20= a/lisp/help-fns.el=20b/lisp/help-fns.el=0Aindex=20= a81051cee03..0d6ae7501ec=20100644=0A---=20a/lisp/help-fns.el=0A+++=20= b/lisp/help-fns.el=0A@@=20-996,7=20+996,8=20@@=20= help-fns--analyze-function=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(symbol-name=20function)))))))=0A=20=09=20(real-def=20= (cond=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ((and=20aliased=20(not=20(subrp=20def)))=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(car=20(function-alias-p=20= real-function=20t)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(car=20(ignore-error=20cyclic-function-indirection=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (function-alias-p=20real-function))))=0A=20=09=09=20=20=20=20((subrp=20= def)=20(intern=20(subr-name=20def)))=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(t=20def))))=0A=20=0Adiff=20--git=20= a/lisp/subr.el=20b/lisp/subr.el=0Aindex=20a0a22072a18..fb9ee2e7192=20= 100644=0A---=20a/lisp/subr.el=0A+++=20b/lisp/subr.el=0A@@=20-6962,12=20= +6962,12=20@@=20with-delayed-message=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (lambda=20()=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20,@body)))=0A=20=0A= -(defun=20function-alias-p=20(func=20&optional=20noerror)=0A+(defun=20= function-alias-p=20(func)=0A=20=20=20"Return=20nil=20if=20FUNC=20is=20= not=20a=20function=20alias.=0A=20If=20FUNC=20is=20a=20function=20alias,=20= return=20the=20function=20alias=20chain.=0A=20=0A=20If=20the=20function=20= alias=20chain=20contains=20loops,=20an=20error=20will=20be=0A-signaled.=20= =20If=20NOERROR,=20the=20non-loop=20parts=20of=20the=20chain=20is=20= returned."=0A+signaled."=0A=20=20=20(declare=20(side-effect-free=20t))=0A= =20=20=20(let=20((chain=20nil)=0A=20=20=20=20=20=20=20=20=20(orig-func=20= func))=0A@@=20-6978,9=20+6978,7=20@@=20function-alias-p=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(symbolp=20func))=0A=20=20=20= =20=20=20=20=20=20=20(when=20(or=20(memq=20func=20chain)=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(eq=20func=20orig-func))=0A= -=20=20=20=20=20=20=20=20=20=20=20(if=20noerror=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(throw=20'loop=20chain)=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20(signal=20'cyclic-function-indirection=20(list=20= orig-func))))=0A+=20=20=20=20=20=20=20=20=20=20=20(signal=20= 'cyclic-function-indirection=20(list=20orig-func)))=0A=20=20=20=20=20=20=20= =20=20=20(push=20func=20chain))=0A=20=20=20=20=20=20=20=20chain))))=0A=20= =0Adiff=20--git=20a/test/lisp/help-fns-tests.el=20= b/test/lisp/help-fns-tests.el=0Aindex=204d715cde1d5..85ddab47479=20= 100644=0A---=20a/test/lisp/help-fns-tests.el=0A+++=20= b/test/lisp/help-fns-tests.el=0A@@=20-185,6=20+185,6=20@@=20= help-fns--analyze-function-recursive=0A=20=20=20;;=20Make=20a=20loop=20= and=20see=20that=20it=20doesn't=20infloop.=0A=20=20=20(defalias=20= 'help-fns--b=20'help-fns--a)=0A=20=20=20(should=20(equal=20= (help-fns--analyze-function=20'help-fns--a)=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20'(help-fns--a=20help-fns--b=20t=20= help-fns--b))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= '(help-fns--a=20help-fns--b=20t=20nil))))=0A=20=0A=20;;;=20= help-fns-tests.el=20ends=20here=0Adiff=20--git=20= a/test/lisp/subr-tests.el=20b/test/lisp/subr-tests.el=0Aindex=20= 1abd3be4ea1..37f4277f962=20100644=0A---=20a/test/lisp/subr-tests.el=0A= +++=20b/test/lisp/subr-tests.el=0A@@=20-1059,9=20+1059,7=20@@=20= test-alias-p=0A=20=0A=20=20=20(defalias=20'subr-tests--d=20= 'subr-tests--e)=0A=20=20=20(defalias=20'subr-tests--e=20'subr-tests--d)=0A= -=20=20(should-error=20(function-alias-p=20'subr-tests--d))=0A-=20=20= (should=20(equal=20(function-alias-p=20'subr-tests--d=20t)=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20'(subr-tests--e))))=0A+=20=20= (should-error=20(function-alias-p=20'subr-tests--d)))=0A=20=0A=20= (ert-deftest=20test-readablep=20()=0A=20=20=20(should=20(readablep=20= "foo"))=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE-- From unknown Thu Jun 19 14:17:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61707: Remove function-alias-p NOERROR argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2023 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Lars Ingebrigtsen Cc: 61707@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167707518814296 (code B ref -1); Wed, 22 Feb 2023 14:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Feb 2023 14:13:08 +0000 Received: from localhost ([127.0.0.1]:58402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpro-0003iW-BN for submit@debbugs.gnu.org; Wed, 22 Feb 2023 09:13:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:45552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUprm-0003iO-0u for submit@debbugs.gnu.org; Wed, 22 Feb 2023 09:13:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUprl-0005eK-QI for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 09:13:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUprl-0007Dp-DH; Wed, 22 Feb 2023 09:13:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=R40oD4DGmdvdp6LuhHeRxz5Bon/NVCUW5ZGOfhxCutA=; b=cq0XDC6NRHjb0JjgnUYO hPtLcvwX6OydLfJ0TFR6t9zFiwXmq82F3NPvbOKk4vQtMAUFuyKe9dsvXEHdkQcmOa8n2wzATN6Of 8xzdlJdT5ehylFG5A3zlLH0Q6KOVUC4ZcjmZk6o0ynrSdKU2dj/z1VQQsBIur+qxJHe/MF0kEtFa0 eVmE3tH6xJohypFLLgh72iTSPoCKX+0t1wFkOzuFDly3pxuCnSpxJ4oMdvd6lz8dPgxiO9Llxbcu1 zvd/dCzLNN86lqmPVxkLee6pWl3+vSBJQbwiGmlS6JyeGi2bMBkqWcvyYg1/LMICl2F8LAfgjeG/M IHd1yTFaHUUN4g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUprk-00051L-Rw; Wed, 22 Feb 2023 09:13:05 -0500 Date: Wed, 22 Feb 2023 16:13:18 +0200 Message-Id: <83zg95rdoh.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <38B56FC3-6215-46A4-9E6C-B1F38E1C1144@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 22 Feb 2023 14:44:21 +0100) References: <38B56FC3-6215-46A4-9E6C-B1F38E1C1144@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 22 Feb 2023 14:44:21 +0100 > Cc: Eli Zaretskii > > `function-alias-p` is new in Emacs 29, and takes an optional NOERROR argument which has become entirely useless in Emacs 30 where it is only present for compatibility. > > Given that the NOERROR argument is not very useful in Emacs 29 either, what about removing it in that version as well? After all, rather silly to introduce something that's known to go away the next release. > > Proposed patch attached. Lars added this function, so it would be prudent to ask him. My opinion is that it's too late for such changes: this function is with us for more than a year, so I guess we will have to live with optional argument even if it's useless in Emacs 30 and later. From unknown Thu Jun 19 14:17:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61707: Remove function-alias-p NOERROR argument Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2023 15:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: mattias.engdegard@gmail.com, 61707@debbugs.gnu.org X-Debbugs-Original-Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167707958523078 (code B ref -1); Wed, 22 Feb 2023 15:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Feb 2023 15:26:25 +0000 Received: from localhost ([127.0.0.1]:60088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUr0j-00060A-GI for submit@debbugs.gnu.org; Wed, 22 Feb 2023 10:26:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:60226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUr0h-0005zz-Ug for submit@debbugs.gnu.org; Wed, 22 Feb 2023 10:26:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUr0b-0002gI-JS for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 10:26:17 -0500 Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUr0a-0005Iu-2G; Wed, 22 Feb 2023 10:26:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a2LhmtoHTjWna1LH3GYzovuCMzAEcpr3uSkmY6+tR3U=; b=n/W2ykyEzpRNHrZaSP9oSZapqg Iwsg8rgBiNcuz3I5ZkS8mDbDFJWbgW/D9+E//Y7fBKcZtCGQKAxDgbwAfvc8rDu3q2BrCXIvn5N1M kZwaR+/hvXZX1E3Kz39xpu+vaVWs7wMKpk/pDbqFTXiZsJ20E42QAIHDUhWPfLg5FS0s=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUr0R-0003si-TG; Wed, 22 Feb 2023 16:26:10 +0100 From: Lars Ingebrigtsen In-Reply-To: <83zg95rdoh.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Feb 2023 16:13:18 +0200") References: <38B56FC3-6215-46A4-9E6C-B1F38E1C1144@gmail.com> <83zg95rdoh.fsf@gnu.org> Date: Wed, 22 Feb 2023 16:26:07 +0100 Message-ID: <87ilft3enk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Lars added this function, so it would be prudent to ask him. > > My opinion is that it's too late for such changes: this function is > with us for more than a year, so I guess we will have to live w [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Eli Zaretskii writes: > Lars added this function, so it would be prudent to ask him. > > My opinion is that it's too late for such changes: this function is > with us for more than a year, so I guess we will have to live with > optional argument even if it's useless in Emacs 30 and later. I agree with Eli. (The optional argument has been made obsolete in Emacs 30, so it can be removed in Emacs 33-ish.) From unknown Thu Jun 19 14:17:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Subject: bug#61707: closed (Re: Remove function-alias-p NOERROR argument) Message-ID: References: <35306114-2899-4C32-8678-B51B4B2A64F4@gmail.com> <38B56FC3-6215-46A4-9E6C-B1F38E1C1144@gmail.com> X-Gnu-PR-Message: they-closed 61707 X-Gnu-PR-Package: emacs Reply-To: 61707@debbugs.gnu.org Date: Wed, 22 Feb 2023 16:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1677084242-31250-1" This is a multi-part message in MIME format... ------------=_1677084242-31250-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61707: Remove function-alias-p NOERROR argument which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61707@debbugs.gnu.org. --=20 61707: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61707 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1677084242-31250-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61707-done) by debbugs.gnu.org; 22 Feb 2023 16:43:49 +0000 Received: from localhost ([127.0.0.1]:60207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUsDd-00087S-JT for submit@debbugs.gnu.org; Wed, 22 Feb 2023 11:43:49 -0500 Received: from mail-lf1-f49.google.com ([209.85.167.49]:43779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUsDb-00087D-4t for 61707-done@debbugs.gnu.org; Wed, 22 Feb 2023 11:43:48 -0500 Received: by mail-lf1-f49.google.com with SMTP id r27so8726720lfe.10 for <61707-done@debbugs.gnu.org>; Wed, 22 Feb 2023 08:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=9uFLgWv+RqbxvjbPqxG8fJXin2okxpJS3NYKa8Dlh+M=; b=hVrEojkVizp+DaiScAGp38V+Gl+FmwBFTDrGOlGDLoU5Bm8Kfx1BjNrNZkhS3x06KL 8wHCyZHf4PaDqeyEX6lYkki59EX5YK/nGDEuHG0yUQ9cC5vwMT/7H5OYExRQ2j5Jkc3v oJNqES6JPIXdc8bOw7KkhiAe59yArL0evsu1Vo+rn7YKHL7FplE5kyLoj2fKcOA2JolE dmMPwedflT19lEhMkV2FgO5gOnpTwUR2jqbc1TGrRMWoDPHO+netgsx3fY/z5U+vRDAu qQhOd2iNFSOoh7O4KQaUmr1m58WhTRn5pb0+1aYJV7Sry1z+CXRNXQHbI+WZ9/yJR9+W 6DbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9uFLgWv+RqbxvjbPqxG8fJXin2okxpJS3NYKa8Dlh+M=; b=o4koDTUtzxnjfGVALrU8eFS33s4oXkHdnGRVWJdesN1poi5jVFo1hUdaQExJm8snrm W0xeAsBbmXTZ8Co31HbJbcq41muEoeZFZXeM7FK26l3j0HqXA/TpDgpsjDhFOo9P67S2 RBb+Hf9zpUvp0kIth1+YLKcdOmRLudadp9U+jlCVCnHk9VwMGjeelh81+J7LHcPKLGYq kPfF/uWFGw+S3zcqryQZl7qQ/N7Xhqf0dU3nbsJJGOicsufATNT6obbD0SFK4Upr9vpt 8zLK+OlS20SGDquPIicM7gzFXvMtGiF+fo92hhJpQsOnMD+ns1TjjbIlO+YgoeNj12a6 FTvg== X-Gm-Message-State: AO0yUKUUYzyBBYMz/s2mcyTYuM0USs+TJh4tfGtn/lciLbvk/QoLOXPK R3e1wzNKIt1W6chRJiG/tPQ= X-Google-Smtp-Source: AK7set8usOO7REbCTbAyUJRy1UMnyCet7xsxr0QOGmpu1++e1ErR8n84L6WfQ2uPNM6MwXDP6YCHwA== X-Received: by 2002:ac2:5282:0:b0:4d8:8273:ec with SMTP id q2-20020ac25282000000b004d8827300ecmr3308875lfm.20.1677084220704; Wed, 22 Feb 2023 08:43:40 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id j3-20020ac25503000000b004dc4c5149cfsm379147lfk.134.2023.02.22.08.43.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Feb 2023 08:43:40 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Subject: Re: Remove function-alias-p NOERROR argument From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83zg95rdoh.fsf@gnu.org> Date: Wed, 22 Feb 2023 17:43:39 +0100 Content-Transfer-Encoding: 7bit Message-Id: <35306114-2899-4C32-8678-B51B4B2A64F4@gmail.com> References: <38B56FC3-6215-46A4-9E6C-B1F38E1C1144@gmail.com> <83zg95rdoh.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.14) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61707-done Cc: Lars Ingebrigtsen , 61707-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 22 feb. 2023 kl. 15.13 skrev Eli Zaretskii : > My opinion is that it's too late for such changes Reasonable people may disagree, but I won't insist. Closing bug. ------------=_1677084242-31250-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Feb 2023 13:44:29 +0000 Received: from localhost ([127.0.0.1]:58348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpQ5-0002ux-2u for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:44:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:45380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpQ3-0002uq-GN for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:44:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUpQ3-0003VB-A0 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 08:44:27 -0500 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUpQ1-0000Pw-Ot; Wed, 22 Feb 2023 08:44:27 -0500 Received: by mail-lf1-x12c.google.com with SMTP id w27so10128040lfu.4; Wed, 22 Feb 2023 05:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=yajodm+RZuu96VoYt5OhYaBpV3T8jbVpg3HvAEVWPYo=; b=O//DQLZugIX4PreCRJApbboZ+YUh/LTbllRdj2wjQkemK9g2u51P/ypFdD+Z/1fCtx weMhgtjhL1eBebVS/Rx2ybdBfNuov7l2JbROyTTtzvotQ58IKu7+Im5gP/9FL91MBsbG Jz/MKOqvbSyPjOR3NbF0OBJD5+/P6WLIXqd7TE7qy8Fq2eTjywYU9Uf+vjiYbELlnfKP z3GsPnbaOU4TDu2vUXKGSly5JDSViUjHbsRWuBnfXSRvhI+bUGGWXme/cvyRS9HJbfTB yGMqnc8PvWU8/Vxi1LxMf9VXf2vfHAQj/1DxgWT7K6UKQ6yf4KVRIk0HzMCh3OlA84G8 uipQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yajodm+RZuu96VoYt5OhYaBpV3T8jbVpg3HvAEVWPYo=; b=BgcngFiqQNgbUodi2nfMcXlz5MYagJ/UKLxk96IAYK/XqFZXy9KIv6UTq3T/5M8112 8kQrmEwbZt1xVSPdO2Dw8pdm63w9NjDlcPgkCUI0Zaj1UcEaCKmetcmI1tue0YegjMOZ lvZYKAq99OcmaIhADkJXsOYxLkxC4t5j/pypX483eoxVImGnPtD5XGJYSjpdH+y9P7bd 2+Mn65lM84RehveF8wEUMZ4o9LeuynQUjFlU1TNPg9Ox9BdYWkg+0FN6yYbW60xqK6uB MvT3l+8t/XuPTvF3+cRKuw4Fpn0kDVc95t7gpqxyeW4EadOYyZMsP7i2x6NK8aukxRcm pzHw== X-Gm-Message-State: AO0yUKWBXVSFZFD0JvOV1qF4KUWl7rlalq5CfXw8aOvCiUTuCAChLurQ IoThyERTMGeYqpRxbm/Rrcgr7BMvprM= X-Google-Smtp-Source: AK7set/rJ0miiCsyZ3pJMplSeYTuSMSkgbXE3kTDwjAXQG7L7Z1bxDTGIKbCTVZNI32ai3QVSroQ+g== X-Received: by 2002:ac2:5298:0:b0:4b5:87da:8b35 with SMTP id q24-20020ac25298000000b004b587da8b35mr2518033lfm.61.1677073462577; Wed, 22 Feb 2023 05:44:22 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id u8-20020ac251c8000000b004cc9042c9cfsm810022lfm.158.2023.02.22.05.44.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Feb 2023 05:44:22 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Subject: Remove function-alias-p NOERROR argument Message-Id: <38B56FC3-6215-46A4-9E6C-B1F38E1C1144@gmail.com> Date: Wed, 22 Feb 2023 14:44:21 +0100 To: Emacs Bug Report X-Mailer: Apple Mail (2.3654.120.0.1.14) Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii `function-alias-p` is new in Emacs 29, and takes an optional NOERROR = argument which has become entirely useless in Emacs 30 where it is only = present for compatibility. Given that the NOERROR argument is not very useful in Emacs 29 either, = what about removing it in that version as well? After all, rather silly = to introduce something that's known to go away the next release. Proposed patch attached. --Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE Content-Disposition: attachment; filename=0001-Remove-function-alias-p-noerror-argument.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Remove-function-alias-p-noerror-argument.patch" Content-Transfer-Encoding: quoted-printable =46rom=205ae6be9543f2ea72db303a611bd9a97c6a0df974=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Tue,=2021=20Feb=202023=2015:18:53=20+0100=0A= Subject:=20[PATCH]=20Remove=20function-alias-p=20noerror=20argument=0A=0A= The=20`noerror`=20argument=20isn't=20actually=20needed,=20and=20since=20= it's=20already=0Abeen=20made=20obsolete=20in=20Emacs=2030=20there=20is=20= no=20point=20in=20adding=20it=20in=20the=0Afirst=20place.=0A=0A*=20= doc/lispref/functions.texi=20(Defining=20Functions):=20Update=20manual.=0A= *=20lisp/help-fns.el=20(help-fns--analyze-function):=20Remove=20only=20= use.=0A*=20lisp/subr.el=20(function-alias-p):=20Remove=20argument.=0A*=20= test/lisp/help-fns-tests.el=20(help-fns--analyze-function-recursive):=0A= *=20test/lisp/subr-tests.el=20(test-alias-p):=20Adapt=20tests.=0A---=0A=20= doc/lispref/functions.texi=20=20|=206=20++----=0A=20lisp/help-fns.el=20=20= =20=20=20=20=20=20=20=20=20=20|=203=20++-=0A=20lisp/subr.el=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20|=208=20+++-----=0A=20= test/lisp/help-fns-tests.el=20|=202=20+-=0A=20test/lisp/subr-tests.el=20=20= =20=20=20|=204=20+---=0A=205=20files=20changed,=209=20insertions(+),=20= 14=20deletions(-)=0A=0Adiff=20--git=20a/doc/lispref/functions.texi=20= b/doc/lispref/functions.texi=0Aindex=20f5572e447d3..3351cadf431=20100644=0A= ---=20a/doc/lispref/functions.texi=0A+++=20b/doc/lispref/functions.texi=0A= @@=20-739,7=20+739,7=20@@=20Defining=20Functions=0A=20records.=20=20= @xref{Function=20Cells}.=0A=20@end=20defun=0A=20=0A-@defun=20= function-alias-p=20object=20&optional=20noerror=0A+@defun=20= function-alias-p=20object=0A=20Checks=20whether=20@var{object}=20is=20a=20= function=20alias.=20=20If=20it=20is,=20it=20returns=0A=20a=20list=20of=20= symbols=20representing=20the=20function=20alias=20chain,=20else=0A=20= @code{nil}.=20=20For=20instance,=20if=20@code{a}=20is=20an=20alias=20for=20= @code{b},=20and=0A@@=20-750,9=20+750,7=20@@=20Defining=20Functions=0A=20=20= =20=20=20@result{}=20(b=20c)=0A=20@end=20example=0A=20=0A-If=20there's=20= a=20loop=20in=20the=20definitions,=20an=20error=20will=20be=20signaled.=20= =20If=0A-@var{noerror}=20is=20non-@code{nil},=20the=20non-looping=20= parts=20of=20the=20chain=20is=0A-returned=20instead.=0A+If=20there's=20a=20= loop=20in=20the=20definitions,=20an=20error=20will=20be=20signaled.=0A=20= @end=20defun=0A=20=0A=20=20=20You=20cannot=20create=20a=20new=20= primitive=20function=20with=20@code{defun}=20or=0Adiff=20--git=20= a/lisp/help-fns.el=20b/lisp/help-fns.el=0Aindex=20= a81051cee03..0d6ae7501ec=20100644=0A---=20a/lisp/help-fns.el=0A+++=20= b/lisp/help-fns.el=0A@@=20-996,7=20+996,8=20@@=20= help-fns--analyze-function=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(symbol-name=20function)))))))=0A=20=09=20(real-def=20= (cond=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ((and=20aliased=20(not=20(subrp=20def)))=0A-=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(car=20(function-alias-p=20= real-function=20t)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(car=20(ignore-error=20cyclic-function-indirection=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (function-alias-p=20real-function))))=0A=20=09=09=20=20=20=20((subrp=20= def)=20(intern=20(subr-name=20def)))=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(t=20def))))=0A=20=0Adiff=20--git=20= a/lisp/subr.el=20b/lisp/subr.el=0Aindex=20a0a22072a18..fb9ee2e7192=20= 100644=0A---=20a/lisp/subr.el=0A+++=20b/lisp/subr.el=0A@@=20-6962,12=20= +6962,12=20@@=20with-delayed-message=0A=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (lambda=20()=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20,@body)))=0A=20=0A= -(defun=20function-alias-p=20(func=20&optional=20noerror)=0A+(defun=20= function-alias-p=20(func)=0A=20=20=20"Return=20nil=20if=20FUNC=20is=20= not=20a=20function=20alias.=0A=20If=20FUNC=20is=20a=20function=20alias,=20= return=20the=20function=20alias=20chain.=0A=20=0A=20If=20the=20function=20= alias=20chain=20contains=20loops,=20an=20error=20will=20be=0A-signaled.=20= =20If=20NOERROR,=20the=20non-loop=20parts=20of=20the=20chain=20is=20= returned."=0A+signaled."=0A=20=20=20(declare=20(side-effect-free=20t))=0A= =20=20=20(let=20((chain=20nil)=0A=20=20=20=20=20=20=20=20=20(orig-func=20= func))=0A@@=20-6978,9=20+6978,7=20@@=20function-alias-p=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(symbolp=20func))=0A=20=20=20= =20=20=20=20=20=20=20(when=20(or=20(memq=20func=20chain)=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(eq=20func=20orig-func))=0A= -=20=20=20=20=20=20=20=20=20=20=20(if=20noerror=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20(throw=20'loop=20chain)=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20(signal=20'cyclic-function-indirection=20(list=20= orig-func))))=0A+=20=20=20=20=20=20=20=20=20=20=20(signal=20= 'cyclic-function-indirection=20(list=20orig-func)))=0A=20=20=20=20=20=20=20= =20=20=20(push=20func=20chain))=0A=20=20=20=20=20=20=20=20chain))))=0A=20= =0Adiff=20--git=20a/test/lisp/help-fns-tests.el=20= b/test/lisp/help-fns-tests.el=0Aindex=204d715cde1d5..85ddab47479=20= 100644=0A---=20a/test/lisp/help-fns-tests.el=0A+++=20= b/test/lisp/help-fns-tests.el=0A@@=20-185,6=20+185,6=20@@=20= help-fns--analyze-function-recursive=0A=20=20=20;;=20Make=20a=20loop=20= and=20see=20that=20it=20doesn't=20infloop.=0A=20=20=20(defalias=20= 'help-fns--b=20'help-fns--a)=0A=20=20=20(should=20(equal=20= (help-fns--analyze-function=20'help-fns--a)=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20'(help-fns--a=20help-fns--b=20t=20= help-fns--b))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= '(help-fns--a=20help-fns--b=20t=20nil))))=0A=20=0A=20;;;=20= help-fns-tests.el=20ends=20here=0Adiff=20--git=20= a/test/lisp/subr-tests.el=20b/test/lisp/subr-tests.el=0Aindex=20= 1abd3be4ea1..37f4277f962=20100644=0A---=20a/test/lisp/subr-tests.el=0A= +++=20b/test/lisp/subr-tests.el=0A@@=20-1059,9=20+1059,7=20@@=20= test-alias-p=0A=20=0A=20=20=20(defalias=20'subr-tests--d=20= 'subr-tests--e)=0A=20=20=20(defalias=20'subr-tests--e=20'subr-tests--d)=0A= -=20=20(should-error=20(function-alias-p=20'subr-tests--d))=0A-=20=20= (should=20(equal=20(function-alias-p=20'subr-tests--d=20t)=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20'(subr-tests--e))))=0A+=20=20= (should-error=20(function-alias-p=20'subr-tests--d)))=0A=20=0A=20= (ert-deftest=20test-readablep=20()=0A=20=20=20(should=20(readablep=20= "foo"))=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_2A5A4418-8628-404E-A1D4-ED2B96C259FE-- ------------=_1677084242-31250-1--