From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 07:22:23 2023 Received: (at submit) by debbugs.gnu.org; 22 Feb 2023 12:22:23 +0000 Received: from localhost ([127.0.0.1]:58191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUo8c-0006jw-VP for submit@debbugs.gnu.org; Wed, 22 Feb 2023 07:22:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:39784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUo8a-0006jo-AR for submit@debbugs.gnu.org; Wed, 22 Feb 2023 07:22:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUo8Z-0000Gy-AA for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 07:22:19 -0500 Received: from sonic303-48.consmr.mail.ne1.yahoo.com ([66.163.188.174]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUo8W-0007XC-Al for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 07:22:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677068532; bh=bhwgdvhcptjg6hnrjl7qpmlwdXrMm6vvOssNT/FK1O4=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=UENIK1dccx/ZeEAkQlNMpaSVWcqKNaL99uwkt4agju8jtJZ5LWVQuSFK341WTcd9Jq3igTULI5869GQs4qJLjIhKEJ7n2WhlE4K+XvOSJxzL4TBbuaBGMWnOxIE0ojUgKi9i4Nsz9S9oDnrYxPJC8TuEisWaZIv4q6ZEi6ka9QEtsQrjl1+p07ZdfI8liTXTREWg3Xu8EWfVU8z6iQ15DWhsMWsYr3H5bKxkCPKpPKixYAys5S4lzHtF0XaOnuotOXDCgQM2Mi2boDIL0zWXVJrhhUCx+rr1yrmvEzx0EednJhyJHm6/CkK9e1KFn2skF+KfppEluo3uspMxMk0U9A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677068532; bh=CzLpweOHWc5PR11zrqznd3FS3zUZuf+jv/mSx1LPl33=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=DnoDutPwSRMZe5sOTzT5WTK0ZA6/FxqEAyZ6a3qZA/pNf5Sah2GXYOx8TUATHF4CBju5d7iw+TSh7YoLq1aVuRY5f7g1Kj6WnGzJXVosww5eTBC+CQMs36w9j/Jwh0qP/Zh131/Pky5EBMrS9AptI7eKfYymSkkcTInNq6ClGrSy2M4ApTdZwzdpSnwpGRz86wJ/NpS6JrUbwpXy5VodwpyDP6o1Iep2u/x3lf5nQsp1J/EHBhAKP76cVAVTkKqKiSWi0uzYHC5yg5974hONHf3MYd2/VmCq/J7Y5qqJ0PWB5wHULS4xnhf7Rfrhym+9vvqzJhiBxMLy8o6nSc4gdg== X-YMail-OSG: 5zry4poVM1nzsmAbXOyqGACXZ1DtRgrgWSDBx_hwRt38rFPqQJJUEYzBD4GQ8h0 GWJfSJa9AuKOBfM.bwcnKc2hQxvzbHHZ.IHxB74PrVa0E1awgBGxpjSbay5EpOiQxOnH7pAUC19P V.j8CzBpX_BelFKrnmNvFN6vNCcWKnxc5RrExEAafgPrcw.St7C7wxAX0H9Z4kUUvYY0DKmaprBr WhcdQDFI.Y5Fxajn4cSXbZ7Es4xxmO_usDMVv8A4WCPD_LHdf1oWp.knfIVyz3wkxLZrkxGS82lD IPzB_c8gKs6j77sFl4usL_Jr_MeuR5CFyyfu7iseGxH22HWP7JQuY..Lty.OaFiyNm2eXwzpGW9G 0Mk5m70JrUml4PYASV6MkyITR4foBDeELf4VA6E_fEu.6HxJlHGzUamgfjNOS67A_UKP91UEy3NE b.v9CqLQd2Enw80FQakoC7TW5V_Xc9j3wY9R2bbMBusP1iFfntadyuu8QM8rF.dnYYIA7YLeP_yO XfPNLAdqBd0UrXFX5LivKkVqdgv98rIbgnxHCmeCgfTE7oXu2UWWY6j6Kg.wRYl05RbCUahwmuSp cblaaXqzw3rmSTaVw1P0.lnSNDLCPqhrUOl5.YklI77b3.72NzXjyr6.OzhBUIZk1AEZLBuQgzeq VHJ3Z1IBo1V7hoVr9Vqnv5VlgM32oCiN_6yMlXjtuHgwpuEtsqS7bCLMM.iSVMfYv8V.8UWDRzEM bDb3wmWTLRPvO4ueOt7bbxOLlvb10excNTFIlKT9daoRndqJFAzY4EKkXGMD.h8A5iA36_vcHjrz c06Cr5m.WnuO2ijOt794sZRCIQl_DgLWXZ1oSlrxJ0PiUlDru2EoRpn1axPbPGux1HIJFlE3.Fd9 WD3vtaJJOPFi4ppbDqi.sAxQ6ECn0G9sYOdKBa1w743gc6r7Czg8x6bo5A0IbL_oO4_5HrQ.FbP6 992z2dnnf6AMv0rtvx6umRFnZnKExoOdZ3bU0GFEGyJW.SLGLG4QWF0qDJjRYy1MCHoZUhYbV5HX kfkxO2ZGMvqHsHblqPFMZdCgutJGvfkY2FyIOz4A4T_eDWXYrgG5SS6pz_4pqqP1TsbCZ2A1ex0s hosYpl6Tk2UGkjZy38CiYetVz0Fstdn9aeQP8kx_MTEmH6824OkNEtpZ4faAWdr2GSdOZOCe_V5h hQSCjRx0CBRoZ7HdpJWXGHm.c8SyDdrLqowUPXgjpjaJTN9p1elhB3h.Ke_U857mrtHZfc6qbGk6 MDaSETckLB3Zq4OcXzTbmXYVIYT0FolvBQKZtF_LAPuEsuJKJCs.a42dHHqH45Oi_Aj6ajnhE3cm hqOXoeM9TQZhH9k9a0G6Vz8Y1ZZjIk9smm1W.h6NWn2LFiABJpH.OVfH3gp77x6gbfI4nXdyWjRW _YUcCXT9Z2mOAojojrY9TxznDkWelHvUnQPh2ku39IPrINatEzRtV6Ir0UFAYUAjSMNsSbjnqmAc qou8JKEiRZr64MxUlJANAp6xpSF.GORfPPsWPIGFGaExTePWskOQq_iC3O1sJMfTkx9IsUvJah_p CC4dgdTv3zjyBXgLZkxvRqBkAPqNp8CIqwqN7EMSSQF5lJFVkEWmpVAi27BTir3zNXTdGPZqXrhw IUvfTOU.x7X7sE8qN_JULhQEAqKAU39o8PAWFAe43CHpOyIhJyYVHeFaLz9zI80M9m6.wQjo74LS 8Q.WpY1SAaI7QXYlEC0gSwXD3JN7YgZmk0b22yBGweededqM96a9lvApGYqizD_8YUE_DPu_6jxW Uh2VhYaataZtnFcGcwLTHWl_EIywD0SF7BOzfaBK.H9Qqf64BQjW70dG.rqQZ4EFlvHCiopQVPCQ dxsw7d8hRyhjuzX.saxsc7MKzbiPzKJyvpZW2_pN1483ea3q19fBqE_lhShR9VhLYqAylQb7yYSu QKe3PQ1vC7u.6QOhTYrGBlYTX4hLPdUKGh_6J4AIgejdaIhyY.yrvt2z0LvXWMU5cIS0ybxtF44Y 5JG0QQA2IhAN4KH6L7HjzZvJCKi7T7jMIwuOZGrGwnQ.pSBl2xwgIZH2uSp46yj8t_rKbfiT2T8C G4TXL7X0_sc36G3c8dHpz5fohrYPvGzASl5vE5W9Fcw1CTq6I8GXvC2RCKUOEw7w505Kohvh64Yv 1SfD1gEA2sd9zsFVYS6VE9.EJGoX_bl_giYilFuPhaU2SvMIDHKpjIBqviIvsdHcv72v3miDprDe v91.h0sPxjdeYXCfgraNC02vP2DugtG6XR0O9Mggl3MdjbOK_W76m6qGZS8ZpOGjS5YXpZ7A- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Wed, 22 Feb 2023 12:22:12 +0000 Received: by hermes--production-sg3-9fc5746c8-qs9hb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1a505333ec2cc49eeda28a5e9e9b9fa6; Wed, 22 Feb 2023 12:20:09 +0000 (UTC) From: Po Lu To: bug-gnu-emacs@gnu.org Subject: 29.0.60; Crash in get_narrowed_begv Date: Wed, 22 Feb 2023 20:20:02 +0800 Message-ID: <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 4738 Received-SPF: pass client-ip=66.163.188.174; envelope-from=luangruo@yahoo.com; helo=sonic303-48.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) I just got the following crash: #0 0x00007f43164b0e7c in __pthread_kill_implementation () at /lib64/libc.so.6 #1 0x00007f4316460aa6 in raise () at /lib64/libc.so.6 #2 0x000000000041dd7d in terminate_due_to_signal (sig=sig@entry=8, backtrace_limit=backtrace_limit@entry=40) at emacs.c:464 #3 0x000000000041e244 in handle_fatal_signal (sig=sig@entry=8) at sysdep.c:1783 #4 0x000000000055f118 in deliver_thread_signal (sig=8, handler=0x41e239 ) at sysdep.c:1775 #5 0x000000000055f1f9 in deliver_fatal_thread_signal (sig=) at sysdep.c:1795 #6 0x00007f4316460b50 in () at /lib64/libc.so.6 #7 0x0000000000453617 in get_narrowed_begv (w=, pos=13523) at xdisp.c:3519 #8 0x0000000000456ee5 in reseat (it=0x7ffc4e7ed560, pos=..., force_p=) at xdisp.c:7468 #9 0x00000000004574fb in init_iterator (it=, w=, charpos=, bytepos=, row=, base_face_id=) at xdisp.c:3488 #10 0x000000000045cac2 in start_display (it=it@entry=0x7ffc4e7ed560, w=w@entry=0xef69700, pos=...) at xdisp.c:3595 #11 0x000000000046bc16 in try_window (window=window@entry=0xef69705, pos=..., flags=flags@entry=1) at xdisp.c:20561 #12 0x000000000048abb8 in redisplay_window (window=, just_this_one_p=) at xdisp.c:19953 #13 0x000000000048d65b in redisplay_window_0 (window=window@entry=0xef69705) at xdisp.c:17439 #14 0x00000000005cac14 in internal_condition_case_1 (bfun=bfun@entry=0x48d630 , arg=arg@entry=0xef69705, handlers=, hfun=hfun@entry=0x444e20 ) at eval.c:1498 #15 0x0000000000442254 in redisplay_windows (window=0xef69705) at xdisp.c:17409 #16 0x0000000000442275 in redisplay_windows (window=0x5649ac75) at xdisp.c:17403 #17 0x00000000004755db in redisplay_internal () at xdisp.c:16863 #18 0x000000000054ef03 in read_char (commandflag=1, map=0x20219f93, prev_event=0x0, used_mouse_menu=0x7ffc4e7f2bcb, end_time=0x0) at keyboard.c:2627 #19 0x0000000000551bc5 in read_key_sequence (keybuf=, prompt=0x0, dont_downcase_last=, can_return_switch_frame=true, fix_current_buffer=true, prevent_redisplay=false) at keyboard.c:10074 #20 0x0000000000553a67 in command_loop_1 () at keyboard.c:1376 #21 0x00000000005cab87 in internal_condition_case (bfun=bfun@entry=0x5538c0 , handlers=handlers@entry=0x90, hfun=hfun@entry=0x547210 ) at eval.c:1474 #22 0x000000000053fc4a in command_loop_2 (handlers=handlers@entry=0x90) at keyboard.c:1125 #23 0x00000000005caae1 in internal_catch (tag=tag@entry=0xff30, func=func@entry=0x53fc30 , arg=arg@entry=0x90) at eval.c:1197 #24 0x000000000053fbef in command_loop () at keyboard.c:1103 #25 0x0000000000546dc1 in recursive_edit_1 () at keyboard.c:712 #26 0x000000000054713e in Frecursive_edit () at keyboard.c:795 #27 0x00000000004264c2 in main (argc=, argv=) at emacs.c:2529 The cause is an arithmetic trap in get_narrowed_begv: return max ((pos / len - 1) * len, BEGV); where len is 0. The window was previously being resized, and has a pixel width of 24. In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu) of 2022-12-24 built on trinity Repository revision: 0e39ad6fa56d50b4710157f0b6f396e492da0dfb Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12101099 System Description: Fedora Linux 37 (Workstation Edition) Configured using: 'configure --with-native-compilation --with-x-toolkit=no --without-cairo --without-tree-sitter' Configured features: ACL DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB Important settings: value of $LANG: en_GB.utf8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix Major mode: Messages Minor modes in effect: electric-pair-mode: t desktop-save-mode: t global-telega-mnz-mode: t telega-root-auto-fill-mode: t telega-active-locations-mode: t telega-patrons-mode: t display-time-mode: t shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t lost-selection-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 07:48:07 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 12:48:07 +0000 Received: from localhost ([127.0.0.1]:58233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUoXX-0001LI-Cu for submit@debbugs.gnu.org; Wed, 22 Feb 2023 07:48:07 -0500 Received: from heytings.org ([95.142.160.155]:39800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUoXU-0001Ks-DA for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 07:48:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677070082; bh=L7OwG2oXjQWsJ8DWH8ne7rPdQthVrSMY/cOfxnGKpL4=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=oZlkDOJb3K8ZzsEEDV2maVI248Vfa3qhqxqvpYr7joKloKLM7TOOoUbrA9YMC0PaV 1o6/9ALP0rb2gnzt/LDgj6Gkljd/mjBcG9eaZE5oJCWOcWeXagR2Cnj4ArzvnBP30u 1oZUyKien2dofedCEfUZpKGLQBP9fXRoezrBdzBWzqI2VqFCsTmaV9/zgmk9nq9d6e pcssKzS+eecw1VyaQaRHTkD6M6cEzrANndExOddSNoBRXltcbTRVloCgKagg+O1sYh wfTM224J/xK535o2VFPv0EOuxEkjtBgPWpehVXu8CLzCdYvzu+JLLajPq1EDgcqUlK bmcCjhgiHXLjQ== Date: Wed, 22 Feb 2023 12:48:02 +0000 From: Gregory Heytings To: Po Lu Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> Message-ID: References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > The cause is an arithmetic trap in get_narrowed_begv: > > return max ((pos / len - 1) * len, BEGV); > > where len is 0. The window was previously being resized, and has a > pixel width of 24. > How can len possibly be 0 at that point? It is (in short) window_body_width (w, WINDOW_BODY_IN_CANONICAL_CHARS) * window_body_height (w, WINDOW_BODY_IN_CANONICAL_CHARS). We could add a condition in get_narrowed_len to return 1 when the result is 0, but it could be a bug somewhere else (can a window body have a zero width and/or height?), in which case it would be better to fix the bug there. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 07:57:38 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 12:57:38 +0000 Received: from localhost ([127.0.0.1]:58243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUogj-0001cL-Mf for submit@debbugs.gnu.org; Wed, 22 Feb 2023 07:57:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUogg-0001c5-Ul for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 07:57:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUogb-000620-JL; Wed, 22 Feb 2023 07:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oW8Gb9AZqZZ5WFSzka+qHYSBfGffg1QeJ7UPOnjC3Rw=; b=pL7OdOCpphJK rTCK29NYBoeLGhAe1oTfd0IzeELmNvQU4oDuqNr+LhoRntRxQX+JuOknRUkq92HvjJOcFqDlAPN/X g7EKHp5KdofLmd86sT8BVrB8NunNCTz0LUpsQr2iJjfBWrOidM+EOKzMYTWUBm3HiF2RVqddo2efv DlsdC8R+Cd6f/M3MS3mZPSDWq9g5590C57EtjyrNbak4MNA7Z9H5Bfz1Rj8ceWur/EFTYrjjRaSAu tLH5FZgRCerp4uep93XckUgKnL2RDILfJTx0myThdshFDo94H0RYWnAVB5Z2LN32+UL1l8K9w6Fkj /fjWxY+bSxNZjJpy5VzBFw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUoga-0007aK-Vd; Wed, 22 Feb 2023 07:57:29 -0500 Date: Wed, 22 Feb 2023 14:57:42 +0200 Message-Id: <83edqhsvqx.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> (bug-gnu-emacs@gnu.org) Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61704 Cc: 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 22 Feb 2023 20:20:02 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > The cause is an arithmetic trap in get_narrowed_begv: > > return max ((pos / len - 1) * len, BEGV); > > where len is 0. The window was previously being resized, and has a > pixel width of 24. How do you get such windows? I thought we never allowed windows that are so small. Anyway, I installed a possible fix on the emacs-29 branch, please see if it solves this. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 07:59:44 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 12:59:44 +0000 Received: from localhost ([127.0.0.1]:58248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUoim-0001ft-7l for submit@debbugs.gnu.org; Wed, 22 Feb 2023 07:59:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUoil-0001ff-1r for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 07:59:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUoif-0007Bd-Qh; Wed, 22 Feb 2023 07:59:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6z8v/tQOSYPlOhVds/oFCFArkrBztkiipM4ddJchwXE=; b=Qad6PDUsQwp7 m2dHSmiPHvUK/k1USh/JktBxLyiZtC7jGxayaYJRrcIxuuM3bBW9ayU+Dz555puWsZi/5KO8mfrDI 49irXyUFYEzFVCBsgz+OHRs6Jtuj16fYxgqVO7DdVJoTN1iHsrJIftEwDCPosmppZqVkcOc0A66MD pCx0MegKLilDQgO5cf+R5au3a+ctq24uojy6+6I0AJmFialUG9wRPrJWwvWcWQzJbDTyFbfztgQO6 yCA1IZTPEgQeCgNWKQdZqayvWYh7uMxE6youeOc/J+ocjqdlb2neVP9cPajMAt418i4ZLrAsgbbWr tXqFl1z+jwYI7UZM1voodg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUoif-0002Sx-6u; Wed, 22 Feb 2023 07:59:37 -0500 Date: Wed, 22 Feb 2023 14:59:51 +0200 Message-Id: <83cz61svnc.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: (message from Gregory Heytings on Wed, 22 Feb 2023 12:48:02 +0000) Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61704 Cc: luangruo@yahoo.com, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 61704@debbugs.gnu.org > Date: Wed, 22 Feb 2023 12:48:02 +0000 > From: Gregory Heytings > > > > The cause is an arithmetic trap in get_narrowed_begv: > > > > return max ((pos / len - 1) * len, BEGV); > > > > where len is 0. The window was previously being resized, and has a > > pixel width of 24. > > > > How can len possibly be 0 at that point? It is (in short) > window_body_width (w, WINDOW_BODY_IN_CANONICAL_CHARS) * window_body_height > (w, WINDOW_BODY_IN_CANONICAL_CHARS). We could add a condition in > get_narrowed_len to return 1 when the result is 0, but it could be a bug > somewhere else (can a window body have a zero width and/or height?), in > which case it would be better to fix the bug there. I agree that we should understand how this happened (and asked a similar question), but I installed a defensive protection anyway. It cannot do any harm. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:17:31 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 13:17:31 +0000 Received: from localhost ([127.0.0.1]:58276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUozy-0002AV-Ng for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:17:30 -0500 Received: from heytings.org ([95.142.160.155]:39866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUozw-0002AN-Ne for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 08:17:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677071847; bh=r53jAQ6jDMPRDM4UbXsrI0n4HJXqeQxwhohvPx68ob0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=XBcqJyUG/o9ecSMClo+gFgyUlGmA2z7x0UEoSVgXE6OIX7VRd3Q9hz+TAX/Wxu204 +FNwF1SbBK3xJUEn22dG4Ucuk+cLWbmRyDavS5mqP2LRJC+qDF8PYSUFNayXb6KNPH Hii8nGoUficu8mzZ39qot1GvfpJb8h1rtxXt9M60RXD/OWZ6TOQOy4AUtrh14W9EgO V6nP1sCLnkiH4X2zOSo5yHhrCCSRZ06RXNTGqYQujXyxWQEnK3wHC4ICxOYL8tR+Wb gh0Xg1yyTs6X0frMuKyuhyDjqq+xpnBN0to/gwdVEwIXCy+1txzFqaIv3b3mTtbysn 15zECDV5EAnyg== Date: Wed, 22 Feb 2023 13:17:27 +0000 From: Gregory Heytings To: Eli Zaretskii Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <83cz61svnc.fsf@gnu.org> Message-ID: References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: luangruo@yahoo.com, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> How can len possibly be 0 at that point? It is (in short) >> window_body_width (w, WINDOW_BODY_IN_CANONICAL_CHARS) * >> window_body_height (w, WINDOW_BODY_IN_CANONICAL_CHARS). We could add a >> condition in get_narrowed_len to return 1 when the result is 0, but it >> could be a bug somewhere else (can a window body have a zero width >> and/or height?), in which case it would be better to fix the bug there. > > I agree that we should understand how this happened (and asked a similar > question), but I installed a defensive protection anyway. It cannot do > any harm. > Okay. Let's hope this will not hide another real bug. I found a way to get such small windows: set window-min-width, window-min-height, window-safe-min-width and window-safe-min-heigth to 0. Of course doing that ignores the fact that the docstring of the window-safe-min-* variables say that "Anything less might crash Emacs", and that their values are 2 (width) and 1 (height). Which makes me wonder why these variables can be changed / exist. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:18:51 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 13:18:51 +0000 Received: from localhost ([127.0.0.1]:58281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp1H-0002CX-4w for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:18:51 -0500 Received: from sonic303-48.consmr.mail.ne1.yahoo.com ([66.163.188.174]:37679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp1E-0002CK-Lh for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 08:18:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677071922; bh=1qk1lzI0ONLpHfgHGSNmhDJgtlS98rdRTIVk4ovg204=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=pKiscYEGoY1dBcUP3aMvyOTn0103CSusl9yf2x8U1QyCoRiJb2MkAbwD2NluiRnWLYh0YW2y4tf15SVnLZtfjRQ9JIOBkqwLLyKhqq72hCHOS0QqFCE9X+hCLMmne0iFokZ4y6mQGEvMEYy5IZ9d0D+82Rsf60n6MwTGYASHcK9nz6kJMF4Ld0LKb0HXQwZUFDK/UQw55Y32/oXQjIqe4wXXxREh0sMewJAvYE8jst4KFB1YfyUpao2XmuC6WXFjqVy0pxWvqxLkvEwtYZAR5gJCo/pImCW/3MjktwqMN+yWBg3XqzlNhAKYSeIFRGuBSIlY9QZhoX0ppsGPBFwVwA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677071922; bh=agtuvQ+By3ZgeiuoaG3Agjqsmnsf67dmg9eNwVcOeCT=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=fA5eyeKJFRhY23KqpaqiEoYpU6tODymska70Ytf5nW8te4dfjWyC8EpA9t+V8LNBZhKmhiKdwNv/Ns9t6sG423VCKE0eFrrZs9F5JWR1vkcZUwKHVyjNA2wZG8sglKrJz5vP1pueovbLysm7BTEUdPicaI8I+5lHZNTGArd5z1Z9NSsp/gT8uuoaYnI1WLLeGizK8Mp2irvJpJXtJUOzZBr1PoJw54IdDKhv2tn4gwCW2MihQiThF37PaTDm/vZvtOwn5KGGkQJGXtDZU4phytdrXl+4yXcjslQu4ij8UssOka2CD0Y6evhCHXZJPMEX0/4n4QEGivkcRmMhkWvKtg== X-YMail-OSG: eBR_FN8VM1kILaAwgooxLrZ0uI.lxVRmOlJd9pDLL6jfhLFjk6S0sNnoBeZJws6 M2m_iB4p5L7pxetkz8uxaHk3g_hmuvlLcn7Li16G_hsWOsX3eX.X_3WthxL6AbPex0RZ9IsduGO6 0czBhESNhOchQA.CDNv3dHY1PbeUQb1N6w8I3vugfMfstnZDIiRQKAqggYPK_dpYTStYBNkG_9xL nQ5vBswXQw1rIce2pkrmL0_dOBUZ3PYlv7aPLL7Le1A3RX7a2nSeh.uJcJ7AEWCPXhUc8WsvYCyG lisLd2RGM9YGJZPWs1DIx0rMiRIUjNEN.YEdgL8fhSHHT4w2tmkxx6klpQ5SUKfudPMWRfn91kX8 vWPzIJeaxBhsPnoo8oG8ORla4jm28QBYc6X8Oflu.yZkdtAbApPx1XU._wLbsmCrJH_jzrkcxS68 7hLRvDCP5.5uc3RMVtdSiOitVn9SNvjemjoIMkiMS4xZUzWLZngX1p6V9KsrgH2DVH_QFNKi8ubV 5B3cu4AbPG5vDIjF5p71AhgiUmUOcRs2VmYllsK8m0e6cW5_G0GuNG96QwKiaet1pftWOpPPDXNO .Tqn6I.iahwgRCZ7CQc1G5kx3YGO9l4tY2W4H0t5dzCv64KayzD4Z_54MN5OkYJdBsPibsJMN6D7 uTmyPpjUvxjijRd7b6TpaPutDYPDHAleBwXodOCr8abeVVw6IToGyxOYg_oJkZGt9S4QNnPmygpY PlMBM8cMGBDLkc0IkTkuV0IChUjvDLmnFAyymRnimx2HlSujrsubg8ESLQmRUPnwwYcr7kcX5ioL xIr.dP8oOqchPG6ZVKqUaP1Izd2SwlGizozSgYutJFlhe6K7uQWjLoHH9_51jS7aq1oYZFtrVk4O e8kC2iSsW2Md6qn0stLVk88hFTCmkglCaVe1dVLYQCbGO5GgyIc.U7j8Vuc9sByC8Lfnn56qzil6 .3.wvKBuSIJprDWqy0Ji15sPifl79fDcMqd77JDIGBFNorzjc4pUCFK9syX1Ugiqn_IdjU.0YSfZ SwIj3Z6xGmgkbQk5w5HC8gbTGKPwPgnHvGlTnKcIPxEEe4guibu7InpvPsLhjyFlrTVW56ITcfnN uHUNPx_sEuZmCQQrZWM95gfx6J6IgKxfb0SKhCemg9jqKtLfHjUGNOLCJFW0VFHm8i5nacutra8N .RTqufKpangdTM7y1j0JzXhrWf9RGR5t83rN6iq8aiUZ_lCQpmEy3x.l7U6hjdHphCBQheo1ZvZ7 ubtwdaxbPPhRSB.RoxY8c1DfcQA_hqFbB4Y4CMYB6Jq5FoExtED.GW9c4YXwQGeZKQNi4PeY0hex nyNjYC4Xeo0K8STbvNhAZwjVhdjfyYCZGNNbt.IYqZA5vjnBr648CtWCJ2Laxc9TD7vLn2eMLQaP z0xCBW9sKeJ7i4sXK1cTzkNRJf.HO9DNoqEIWIhFmA0JDr2dLR.sO89rP17pDSz_VJwZDKQ_WjbI JvaiSJ4ipXLnVc32NuCI7OAJ8c.w_xzTNMGkw2ABC9KG8f2x8YbMDVnNXCmZECdFAJd39y_d3gkw PSITFsyQuPZ.DTK3Nk2CbpqP2MLUAAeV7DM0MlggZ4SI.nfxesX.Ify7X7T.eTosRLl4eU5WM4ae Dt6eTvkZwCa1nxz3EujAWHOC_w1iVpBxF.QV3DsUNZ.uDGaW2uuz58fb56IGJHWTlVDtveGwPICi PTeyg4xJwGdsrD8LZpOFMUf35lxWOWh3YRRtKuDiW5oF.lb.JRx8cKmVjXY.JCapoQo7aiaE.6Kk 2zzRrAxPO009YdPCGMFZwr1sX9kuixyvEyNaAxKwVamYbxab6pT07V43zY.DkoPLTaQl39QPwDEm 2ceSKGv1gUBrXWss3NSWUq.KEsHo3ssCci7pCPJignzckDC.y1WiOx.EfIK2KYlgIBeFxFoYutBn tnFiUE1QTJ_1D_kNy0FJNsLVV8uC1lgcuRY3Q.VTi3.fwlM_GOOXUzmG7kdfp.H4A8vJLDUqDTnU 2GJX6v5gLuribmP.3fXaqTHqlll43H6UT35IMYHdhHhVhjmqYwXpid93H_eMXKjCjoB8NIepizwK fjRDHfdC8nJAzUcilNEJaaU1aFvdQDohh8RiNU6wJPb0adh.HPGcqKC7zZEX.VQSbWJdNVELdggf QES0BOv.rDZool5leZC3f5JUsG0FvxgdVLLk08YqrhoDI86484kGsBETYTQef9gzv4vlNIRhaOxM GesCt0Ku0TD8a0mPAmPQHa5Obbc1RXTR604F7ADwjbrwXUVti0XvS9CrC2waRzrNraSQ.7JZJz1b Q8gs6o1nz X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Wed, 22 Feb 2023 13:18:42 +0000 Received: by hermes--production-sg3-9fc5746c8-pz6sb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4cd3d3ddf6a1bf0d8f406b50b11d69c7; Wed, 22 Feb 2023 13:16:37 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <83cz61svnc.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Feb 2023 14:59:51 +0200") References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> Date: Wed, 22 Feb 2023 21:16:31 +0800 Message-ID: <87zg95on68.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 994 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: Gregory Heytings , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> How can len possibly be 0 at that point? It is (in short) Because the pixel width of W is less than its frame's column width. The division performed window_body_width is truncating, i.e: 24 / 25 = 0 and I suspect the actual width being divded at that point is less than w->pixel_width, since that window had fringes. >> window_body_width (w, WINDOW_BODY_IN_CANONICAL_CHARS) * window_body_height >> (w, WINDOW_BODY_IN_CANONICAL_CHARS). We could add a condition in >> get_narrowed_len to return 1 when the result is 0, but it could be a bug >> somewhere else (can a window body have a zero width and/or height?), in >> which case it would be better to fix the bug there. > > I agree that we should understand how this happened (and asked a > similar question), but I installed a defensive protection anyway. It > cannot do any harm. I did say that this happened while resizing the window. It was being displayed in an ediff-created frame. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:26:06 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 13:26:06 +0000 Received: from localhost ([127.0.0.1]:58306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp8H-0002PS-PM for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:26:06 -0500 Received: from sonic302-48.consmr.mail.ne1.yahoo.com ([66.163.186.174]:32874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp8F-0002Ox-EK for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 08:26:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677072357; bh=M/eU2YtljLvpSdf2rAPyg70s2pIcTYV0HuhUJf+25Rg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=clPT307WeartCXJhpyc52NyRgtBvAu7Jq9BXaQv8zj7Vqo1PmIJjJF4DLcHD39wl91qpsUIaa3qc0GOKy+X/WWM9SE4NkiT8hUdYScRUySiVbr+WCKuM4oI2G4RdxqU9/B3Blvd5kA0Qw3P1KZXIsuhmkWbhJTuCsf+TsG/N46aEfTayZ2hF0JahdAkGJa3JolTqbH3KNwZuAAuTSf/JfkstNqn9eR8ziHsz6xk3+xq4elpRtGLD0wWDLzF8itW48O11Zi1UuLSL0j/aWCSyFYr57lO1bfSUsXNUJ1gO/VgXEGoc8NKTEeZU6qKIc9KFRlKdwzPMdcSC8WmK+pnhYQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677072357; bh=6q8JQ209t6kE4H5HB110g5XH0dTIDj81XLC8eE4C0tf=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=pw+f5XvyT0TyDRt6gUB5pCawXjCXeeIM50A7Lb4B+UGRQCElz88A6mbhFSwTkR1xPCplqKYlapXi2D89NIjMAdyDx/AEQG1hm6aKgqjxV0soD0YLonI47SKFJbPpokXUb1UMNcPFfhNxoce9/VJp7jDq+VjsvWtgcEvVKGaVBzP3rMxhSOxbo2+wwCMPedOkHKcpbKz9iFMhrdJhJK/Q1pR55V/43pS+dPaZCIc51O0ydiKTplGxblofAnGClBkAOjDYG4XFuGEcjMYxkuPkZUq362xg0arkICKfmLFhfwool4p9a1avhXUC1A4lKAV/otAvH6JjSYk4yJorxEVOHg== X-YMail-OSG: UwTNTBMVM1nSyf6aMSAxGw8LoeTh7SVvUsLE0G1xtzUht4_25x_.dnLBEKkaZuM jeY80Zj1KUiceUf8YbC5JOlKCv9LyT4jkZRy2KkNivIsk2eD.9J0vLVbbeFTGqVD6xmRVqe8Fr.t p2SNwnICrUfWPjcef98Us5KTOX6e8Afj37ja2YvRce.ZbMoZgblAz2b5MtCCY7c7HeJF2zclep37 sz1QqfeXZ6ko1CQHZmHUj_KazfwcnkB36k1FY_qk34abdbaUExUydeSKkduIB006_0cAnskcEtkQ gw5WD7bUnULGbusZ3uJOYLeO1N9mW7TLWTS6V33Ky9NiVjDBquGhVsf4sL_e_OBcVcovx349dxBA fyyfPsor3kFwYJm3s3OE0SZzMeo8rt3603nTbGGvY1D7XOKi9pqpEzHxc7AgG3otrbF2NVKuK6J8 MoRj9f9G9YZJFhbbtLgw.ROLxjIQBNB6GlBXJDI5Ir5KD9hRPizcUbtDZ4tbXtovGV994JtHUfrA yeTFedCkOXznXOxZqVH_XGwDml5eI0XgFEB1.d3aggbrdHg86k2gKMQBFvcvvQ7o5jDsm1ws8ZwT nZlMvP49Tc.gDuaESZpXSuKM5ezIrir2DmREJdhHfzMb8sev_Q6m04s4mrHF.bugdxBR0T5TXtKp mYs1n_Z1u1VJ_eYi8ZllelqzJnXyoPp0AuvEWLOBDuPo_Vep4p9lDLohtL7BZhDvdIE509gZMkUU Nh7GWseXv6ddC5H0lMUVDr3qLG.HgJ2ui3XU8q3zrfUt0mZ0IMBXQ143BWDQtSOTh1wUElJNAxaI 5SvKRRhOlTQqf74yOAbakMJs9uKIOsFTYE48qMy.RuiKSsN6XlTPt.ObbRT91GATicGqDm8Ms_a1 FYGOFfUqJD5E_PIHXspzZIgNmpGi17oKcpeOnwb749hVucdpYohvbfkM2EDZMu.ys3buUnac2P_K XcuL4.gw5NGQbhRD0FqqInB8MV66ppwKAggUYVzeMwMEusc343zdLU4qCANQ9VBVMGcTdS6.fWCw Dn3qieE_pBFRnMws66F7JQhhJJqhPyz2XQGC84OQpZ8.j7afu8aGuLiTCPVQIIQ5jHsPpM9maNXW nTUoy7WjhaVkSG45R5rRp._26xH8Fwp1Gf9pxAhRAzkwnHZtO4HYaU13SVNXQhH058ISyVzd_0hu LbxzwaSRD8fwnljDlIVJxyDMc9cs3XOcxemCNsU24UU3Ffocnh9Dst0U.oawP_s_llpK1L6gOL3I Y28oC6AltbUu70ls5BGGcaLtkLsxz7CMPchcMWxx_am9CLg2w5hWcbn7cWgPNqCqrgK0CjcPreZ2 QEUigzpGOI33zcaHjqdtWRq8BLUUl6jw0j8FISCs3qUQIkWuDQtmU5zph0dJS6tr.kUbKhxXwYAY xk2Lz8gWmieDzdONI1PK8BD3M_TEhsNsrWwAXTWBbuaUJ4pS3dMmykowN2IttJDfZWuI.RHOwfxk QIqfCoLBwzzZig_80n_J9DbVL8iIbvb.G_wbkkkdcOY1kGoPLB6GTit2KipxksqGCCfsALcXSO39 VSfBUe6NERZ.i_o3kHoA65ioo2gDXmJ87_WBIuejdk7P7hvs0yrDzhMjuqhIE0tBO_9mWC_tNmw2 JrwobgwjWBZ8mNNcGHJWp1RKAyoeT5wH44B17on0BkLxvSLjzMS2MHWqcjnNDMY_CLoFJnf29Dly Che1PNzfC3XPDnINpE4aOlYr4Y7ziVQfS_EuAZrudktraQv9GL7652o_bz7Hs5QDvDm.EBB7ETiN .DH1lfu8OAbc6As9rKF5hvLVjF6l8wDtSQA2bV6.daHlpUxEZ0zpmU8lqfpfGmjMG2GIFWzCmNkH fwh6OhuuNAR4ASR6xFD1m27wxVQtNs9kh4BkFpyz30N1InOT3hZczUVEIAW_Le9ptkmYgVK7BvOM kvqopuCxk0NCiyTfzC.SAbgrUK40sgc4Xico.yoe.u7_477WEW7PjNaEKPrFJinhdh.cAlfFHAHh 2rokMOGCvozrHIFnqkeykDTQDvL1J9OqY2Hy2yuWO3rHFBgsfC3kO_dHJ0o5LP8uvEHZwchTazMP apnWFuFyPq7cBrvzXET9hkMeCo317DI7kZYGmDuMW26psAEHO1IbofgHfz4zvDMVkjWZQid87wh2 .aFKE1ZyuMow0lPEv_VHa7zg0fKPS7Rxg8vMr8sAW.P1EmRqqB1aRxog06oKDP6u70bJGsCXrlr9 gBxAT1E949ZzPQrROQrYMQAtgoErX63j_ch44fQrWFaaoAtQ29UybX7iLchoDCGKWAg.d159.zuE Lfg1THeQ3EA-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Wed, 22 Feb 2023 13:25:57 +0000 Received: by hermes--production-sg3-9fc5746c8-8hlql (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 30f70ec542f6b23f28b3b18b23515c76; Wed, 22 Feb 2023 13:23:54 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <83edqhsvqx.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 22 Feb 2023 14:57:42 +0200") References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83edqhsvqx.fsf@gnu.org> Date: Wed, 22 Feb 2023 21:23:43 +0800 Message-ID: <87v8jtomu8.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 411 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > How do you get such windows? I thought we never allowed windows that > are so small. I tried resizing an ediff frame. > Anyway, I installed a possible fix on the emacs-29 branch, please see > if it solves this. We'll have to wait another 30 days to find out, I guess, because that was my uptime up to this point. Resizing the ediff popup no longer crashes. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:40:46 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 13:40:46 +0000 Received: from localhost ([127.0.0.1]:58335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpMT-0002ok-QT for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:40:46 -0500 Received: from heytings.org ([95.142.160.155]:39924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpMR-0002oa-8p for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 08:40:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677073242; bh=8xbVIBupYd9YMMPddl3njkFY3YAmTl769paEAGVT8oQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=p5FLBJblBMdwT9BibsOnl/6ZlTweHcUi9VYNI5CYtV49R6UKS/kXWVFUHpJzTZlkw WI85mf7pKLTHENuZDA8iUkDHy/x48Urhd8n+7AqQvbEADnXJfm/CqG28imwQx7otN3 1XyhYi86fHk6VILF3YPHmSZ3hNKIIB6A/OeEZW7/ryHOXc2VXqMp48t67iBSQl9JyM JEHfxqD0fTjm4x2mcCj98ewFenIpj+Hnvd2WYUovJsse3D67NgfxHXJwMc+kdYGW1i B3QJ+BlUqyRnhSVFBl6p8Ec9kcsaSuWiD08I9Xjg4dUajIW4UCLaBajeF6NDNa9IuY O7dbXZNm7KLTg== Date: Wed, 22 Feb 2023 13:40:41 +0000 From: Gregory Heytings To: Po Lu Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <87zg95on68.fsf@yahoo.com> Message-ID: References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <87zg95on68.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> How can len possibly be 0 at that point? It is (in short) > > Because the pixel width of W is less than its frame's column width. The > division performed window_body_width is truncating, i.e: > > 24 / 25 = 0 > > and I suspect the actual width being divded at that point is less than > w->pixel_width, since that window had fringes. > In that case it's a bug in window_body_width I guess, which should do /* Don't return a non-positive value. */ return max (width / denom, 1); > > I did say that this happened while resizing the window. It was being > displayed in an ediff-created frame. > You mean, the ediff popup control frame? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:44:18 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 13:44:18 +0000 Received: from localhost ([127.0.0.1]:58345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpPt-0002uZ-Mp for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:44:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpPr-0002uM-OM for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 08:44:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUpPm-0000Np-7v; Wed, 22 Feb 2023 08:44:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5TS2SgFshSA3BzsV9ofnHZ7Ynz7Cxa2dlvbj4wZ9yoo=; b=htI+efzAOFYA Apkl1fPgvQcAbKd+IUrp13sregZWNvSTFy2EwwKf66Hjgcc7ySgmgtnSy+pmSXRZInMXXyp/4ox30 oWu1x3sdkTQJBoMYG7cV5t844RYJGGqUATs2CH8V2Ng/1QmL3YNbAWpIZGRu2EXhiaGISNVjeeLoL Qu2zMHNr2WqyZQaqUl4Ga1R8sbLbfBpUNuO/dmfyJehpNhtKTmihus+jE/sCYaHSHbI/Y7fJLy0eH zhU7B875rFamkYHB1vxPjL0Zf98u/NXtzwG5yfKb/o2z62fdGgvlNN2Rt5bO2gly44CDeDBySt4du eb7ecE+RGvx3o3tCqeei5w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUpPl-0004hi-Mi; Wed, 22 Feb 2023 08:44:10 -0500 Date: Wed, 22 Feb 2023 15:44:23 +0200 Message-Id: <834jrdstl4.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings , martin rudalics In-Reply-To: (message from Gregory Heytings on Wed, 22 Feb 2023 13:17:27 +0000) Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61704 Cc: luangruo@yahoo.com, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 22 Feb 2023 13:17:27 +0000 > From: Gregory Heytings > cc: luangruo@yahoo.com, 61704@debbugs.gnu.org > > > >> How can len possibly be 0 at that point? It is (in short) > >> window_body_width (w, WINDOW_BODY_IN_CANONICAL_CHARS) * > >> window_body_height (w, WINDOW_BODY_IN_CANONICAL_CHARS). We could add a > >> condition in get_narrowed_len to return 1 when the result is 0, but it > >> could be a bug somewhere else (can a window body have a zero width > >> and/or height?), in which case it would be better to fix the bug there. > > > > I agree that we should understand how this happened (and asked a similar > > question), but I installed a defensive protection anyway. It cannot do > > any harm. > > > > Okay. Let's hope this will not hide another real bug. > > I found a way to get such small windows: set window-min-width, > window-min-height, window-safe-min-width and window-safe-min-heigth to 0. > Of course doing that ignores the fact that the docstring of the > window-safe-min-* variables say that "Anything less might crash Emacs", > and that their values are 2 (width) and 1 (height). Which makes me wonder > why these variables can be changed / exist. Maybe Martin (CC'ed) can answer that. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:46:58 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 13:46:59 +0000 Received: from localhost ([127.0.0.1]:58365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpSU-0002zl-LJ for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:46:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpST-0002zY-Lj for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 08:46:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUpSO-0001OZ-5g; Wed, 22 Feb 2023 08:46:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AjRHoGY2yd+1QjY1xPLViB0u1FmMJh0KCX9C4dIrXac=; b=HkfD+5tHC5zk +B/QVfWBBd2Rk6A96RuAy1ML0I/KAjKjQMrQ/+NjGqmpnca23USN+o13OEEv7wzOehtIv63V50amK ZAFq3C1mNK+SXkBUKuHb2tREePMYgTwhKuMbj1x+Fcn4gglWSVXlzcRQKeO1MkO8mIoCpuxbAq24G 3UqvTSyZMmlbEmmoZx1hOTxWyc1+O/dJKI8JW0Jc/AMBabQRTsI+4b8siozHMtwHBGVzWv7C25HXp c974PjoEqGdfonBC3KgBaE4qHI04x0nbLMM51Z6ffEHhyNimH9VPKbzzZ5vRQusoho5nQNgxN9S1d OEtsb7aQ9WKPJl2XM/e4EQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUpSN-00051c-IQ; Wed, 22 Feb 2023 08:46:51 -0500 Date: Wed, 22 Feb 2023 15:47:05 +0200 Message-Id: <83356xstgm.fsf@gnu.org> From: Eli Zaretskii To: Gregory Heytings In-Reply-To: (message from Gregory Heytings on Wed, 22 Feb 2023 13:40:41 +0000) Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <87zg95on68.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61704 Cc: luangruo@yahoo.com, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 22 Feb 2023 13:40:41 +0000 > From: Gregory Heytings > cc: Eli Zaretskii , 61704@debbugs.gnu.org > > > >>> How can len possibly be 0 at that point? It is (in short) > > > > Because the pixel width of W is less than its frame's column width. The > > division performed window_body_width is truncating, i.e: > > > > 24 / 25 = 0 > > > > and I suspect the actual width being divded at that point is less than > > w->pixel_width, since that window had fringes. > > > > In that case it's a bug in window_body_width I guess, which should do > > /* Don't return a non-positive value. */ > return max (width / denom, 1); I won't object to that, if Martin agrees. But the protection I installed should IMO remain there, just in case. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 09:14:31 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 14:14:31 +0000 Received: from localhost ([127.0.0.1]:58407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpt8-0003kd-Pl for submit@debbugs.gnu.org; Wed, 22 Feb 2023 09:14:30 -0500 Received: from sonic313-35.consmr.mail.ne1.yahoo.com ([66.163.185.58]:40057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpt4-0003kP-V6 for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 09:14:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677075260; bh=2CPxsFLo+gJYcSw+vFjXYeeAt6opC9Y95LcdDQMydAc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=mC5MktgtBG+vVAE0TSyaDi+JQSi2j8A45cEMJ11RSuYVgTv8dqMVXXnNMRFA1suHHT3rTllWOBHbRaFbZzMOzAbYBbgcN4a4BIuwfNgw3Qr+8fIS/DKYeT3kZHCPXKCB8YhAEnlNps9Y0UduWrKeu+jXqIF6zU62OkdWpLD4T7x1a8l6CtiTVMMeP6artrzZLybEhKpcImsJiz51HSSRGVEz0cYwHoYIcBstOwbekmWp4skqzgmMd4F9E2GlV2F1zozVPwWnORCibMZrcLVvicFBM6eTKYsylzlj7DqSGQKZj+yXL/FWI6nyKwXKAX11YCbwX07WQ2nJxKTLjxjsZg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677075260; bh=dRBNWuUQ2Gwvzj+9gNoC+F4uNuUz0qz/nJMrbPRfM5D=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Lmq9U037wfUVxFiRdHkFIXxQN+3/+Qk5I/Wl48ULQEh296v+fWY6g2BbAgUJR8ensvwbMajIeOL8rT7IqDhB/QVgi6JBomr5NCkjvFFre35rURYFEojNbEgwYuvwHiaqSZR0kxzmnqdoYjOJQYsfWpnQSsrEzG20RKzjpaCX4FPnPAI5yVGhj1MfDPo21B4ULlJcAkB0/CtqpfPtsYGO1qcR4GcINs0FidhbtDpqu3uSnLabTiiXdsTATLWiFJpT2/nOzfYeucvCBrh4l/qnRgFB3fs0zdS/voVvYQFqQhM4Vkw40SZ0SRo4Y0aRLhNUYLGZZ8dUyNiG1dFIeejeSQ== X-YMail-OSG: kogGf.AVM1ktJTqKsWVedDX_Frjn14.akOIgwsFd_u6uzcMFCyFDqZtdO53.AAF _9vVZa5dNA90.4fredHAonrd3B._A4J6FlM5ptfoTPMLmgp9thf5HIpNusF7ugKy.iIcKY9rzb3Z QqZuEB4CNyvLd3o68Xi2mTBXnZvE47iN2CTJ6FrUK4dkmopH7ca2O8upeNvwQumkqH2cLlD7fisL Z8Dr6EINk6Bs0vNSYXsOswLvGIE1mUkyGf2Pe4O2BBbM44DhQNzCWmM2..0b3gzSbDMMO44hNGXI JOswCUm13hC0tF_W58jw0pC7ymV_iGwqOn5DvqWLv1PgfknoYmkhTTCfzBIqMAvHj7R23p5KV5_x 17zgXdQ.w14yZs9K_pwJyWxBF_CpUsJ9madZSaNiC.4bqVZawUgJqqsxzOkEaU1ym1xQNcgknfek 96TJ97cI7gN7m_zwYbqWDhnfZ1Nr1a0Xswc.QaRBf2EEtUY7koGzivdW4rEBKyRnAOVX4fjq1W0L 3OBiuatoSflvo8MVn0BqvvthTe4KXz6wwkLuIn1arwjGoZCTsdFNgyYSPKn6rhBAKlTNHdnUUjdN 50Vq6opfuAt6g5dZ2fHvmdDSKzvLuUFStvA7ira2.Kp6ojDTP4XeDRFJqPUoeK64Ya306RUPrDO9 tmiGwsUJx2ZLKPCPnI2AjGJBSkeoC9J1_iQdo0hDQwT4NRB0V4KOF7s142GFjLW17R9UDRFIBHDZ XoaErHGgYJVnm_SgXAsBYwZFFNkBorv69KS4coOIAQ0U.pQgbHzOBEyD37_7lfTlmoRQquvmTlxq bk4Poc9AhT7KNBOWoXR2OGPM163okCSTUVUktMpZRSv57ZQmnm7J.4n2PKEyTwfyMgIcP4HaclXe MMvxUhkwZgFlJbV5PoxWzPAe17XOtXUlQkI5z_zW1RLIofrVEfFElS4Ns_YVvecLGnSKVXo2Y6ca Ozioy4CP4vvg0CcLiVKaWBdF4IgmwH.bNMhz3WNk4AMpufNhl5GM4l5dnXS.6_7xWamcXXZgRE1x aKoqGBjFehDyaxftj2JYJsVjRQYdYMBxU603LpdSq8.hpro.M1qOt3DTMaNS53dz9HWbqKUkSIF6 GITayIY_0.8A4JUVpSJBMQl6Xcs_rFtJqQy8WGJX2apiMrPbHoemHb7j10_osuf6C7_YocZUeuty xo3wAs8QSqMEogFbXZi_ie2W_Rjc1vkIQxUaqHR5jnOmsFoVK4MP9.UBCKEcULm57zw22uOtYqls YSndGQj71lgO68Rdklwe65E8CkZjVCBRZVEkJbV7kAxwcu6sj.dVCsM0Y.csox7hSUDGrMayDyr8 Cnr531faRFHBWxg_5vP7SGt0K3PZaBTZaqR_x6MsLqvsxsKGveaKPZkv_AcNEJxFYGMebYk6lNDa O2wZ9.r75ZHIaJYxVRqEW7iCoMdZfctQKWgPo_0uhJYiro_zdqraHLWfS3w.O05EI_o5v2BXx_dk jNi4proQtwbNO_nf12Dnzc3Tc_7uJFJatt7E_QBp657nHmXEltPDqjZ2tTEvL8jj9fBv2EEzHXNe gqr8lb1I9r51JisTMphXboDzGJ_D22pKlGixk8zAcliNbklXnH6A6D_5tXZnv56H4zoekI13CHzU 0uSGvkwBqNfXWIcjH.ZG0sIx6OJqQYJMM_nP54fjWs0OVDrXYw_PJKRV5QsZRXxWcfsIKEVmtncO W8W4Wy3zcJo.CNtfhQV0AtLx2VKN6nYjqhwI_Xt_ssAJtjr3IHsvYbvPkaW3.y43zIqUWyFlVBRP wX1bFk3z9p0xjY54_tZqiYU48TQTvSP7SpnojJx6tcgpyDI7WFvRDUMZV.9lbeOnOcp2m_rvWzRa haLqbX10ABOEpD_sXZg61CFkqCwRd8FuEke0EVpQU13sxHaI5IsCg6f5x.wiVzWJ4fihpPsu9_TW Fr6xEGQCavEnzY0qDeEDMOaH005u40rtzVQ_G1TF08izwnIb8MjYtVHcybqpmbo2eQxKd0KZ1W55 tOzGHgvCK8kBP_PK672sYuJ8gbVVHvmcoqfmi09nikVhpbmFdszk1qSP7IJa3ZUYcVh4xCIh4Ej7 GvTIoBWRTP1S1oaWxxvD6FQXPiB4MZoh9YeLYE_DTNjLvGGcf9c2HlY0KJMaDdfYiPRTJlG7ZJut KmjyxrspZCMVQU.qRX9W0354ye80sBKJ7qyfJbzbKaHHIfcgJxsLqO8JbBSSgf5.TVeJ4g7TiGy2 lajgG__tjpz4.fojzDtg6S53eJ2OSdcYCRdpWGfyXD5WFEGPopy27cfgwMF31y27RUUUWPWEWHqQ 2ntIcYUC249gi X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Wed, 22 Feb 2023 14:14:20 +0000 Received: by hermes--production-sg3-9fc5746c8-r2vxw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1b2af696b9d80233eef051816912f641; Wed, 22 Feb 2023 14:12:18 +0000 (UTC) From: Po Lu To: Gregory Heytings Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: (Gregory Heytings's message of "Wed, 22 Feb 2023 13:40:41 +0000") References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <87zg95on68.fsf@yahoo.com> Date: Wed, 22 Feb 2023 22:12:11 +0800 Message-ID: <87k009oklg.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 114 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gregory Heytings writes: > You mean, the ediff popup control frame? Yes, that's correct. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 09:18:42 2023 Received: (at 61704) by debbugs.gnu.org; 22 Feb 2023 14:18:42 +0000 Received: from localhost ([127.0.0.1]:58411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpxC-0003r2-C2 for submit@debbugs.gnu.org; Wed, 22 Feb 2023 09:18:42 -0500 Received: from heytings.org ([95.142.160.155]:40008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpx8-0003qr-W3 for 61704@debbugs.gnu.org; Wed, 22 Feb 2023 09:18:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677075517; bh=zArTK24S/voLar9CBpwCIK+ZFbY5MCyMN25Vf6RaG1E=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=jKAOelk36unv5PYcvSUDYCTcxHmcRI/U4ukxLcb3+NVQMzp/MOeSxWpK1rjg6uc/u Bvy0gXU14eWwS+W9eMbWLDlFK+LPAjCDwy9TuWvDDnKYFN0mCNNjAfqwNn+uWnbssK S1hpR8EZczcDgjBtlUOLfCPvK31ya9ljDGoG5kuUImKaqxo054TCvoHaHEcwTi8qe+ GxjIdOVhpreQYTj31VvGtjAfqakWaruJAiUpzJtYGuR+9Gy8vTcU0d+k2IQklyCNG5 1haTwyorl4XECRI/dkQneTQ4V4jS63IZd/xLNTZrHuMIrSme+F3kZtHGUlZRP++wSp OvwZO8xtVDdsg== Date: Wed, 22 Feb 2023 14:18:37 +0000 From: Gregory Heytings To: Po Lu Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <87k009oklg.fsf@yahoo.com> Message-ID: References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <87zg95on68.fsf@yahoo.com> <87k009oklg.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> You mean, the ediff popup control frame? > > Yes, that's correct. > Then I'm even more puzzled. That code is not executed in that frame, it is only executed in buffers with long lines. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 04:34:01 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 09:34:01 +0000 Received: from localhost ([127.0.0.1]:32960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV7zD-00023u-P3 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 04:34:01 -0500 Received: from mout.gmx.net ([212.227.17.21]:47605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV7z8-00023X-72 for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 04:33:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1677144826; i=rudalics@gmx.at; bh=zjQcl6mYOc1LERae560BmN0wqTciUbVZeDjsNSIDjzw=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=t/9Rz1YDh9Wwc3nC199fYhPyGK+9DboWGeK8BCKd+48sjHkG8wgeaxbparNNdv011 PQhxMNut9ekbhmwwwZGP2Rb4fTAAE8M9jZfVPEw3GYb7gjRt4k1PQrnO71/63tJz09 b8DAKzuWGv2jCBKWejKZwC2yxmaADET7FnP2rHoEP0emo2vLrJX9XdCfzAIcZUTxjx uURaBrrLl0XZiqn10KmDJxJdKxE8GbHRWjTOFCKI5UstbhMbul4j/iUWanq1WFX3pV klUYAWigtDya7bbM0iX24bE7ya4QBXgUI8qy+OowpNpLBBWINyNhU6LqI+dDjgqboG EFI0F82pcYqKg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.97.165]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MAOJP-1pNfzF0VJL-00BuXX; Thu, 23 Feb 2023 10:33:46 +0100 Message-ID: Date: Thu, 23 Feb 2023 10:33:42 +0100 MIME-Version: 1.0 Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv Content-Language: en-US To: Eli Zaretskii , Gregory Heytings References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> From: martin rudalics In-Reply-To: <834jrdstl4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:MecRWw6MoS9xusq8yDsq4kJK7qRsjvcZdc3J7Fx8+RkCbtOYvPp hkL0jjSWBx5327xkvsE4txCwQ8ZmKpTJvxfA3PiC9h5+j7iYtyL045Jll+3187x5Feo2DZH kj3jOXKsaGhwFt3e1d6Yv//JsgO554U3PhpeLzaiQTWZOMxBMSldeoDOvZTuTGKl9XXDLmS 23Q+aYW7H0aS286U+P38g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0XgvR+SdkQg=;oKdznyrDMXh+l+0TG76UWu2/5NP 3jujerMcF0Jaax4GXQqW6Mmf4aTzReU3WeB/dzk67WY11JqimsW/hp8rt4jMq+w+codlAAXH0 lsS4LeztOfqDV3aDGIbqyGpCiYAR+WJ3sq00d/tKnpJU3YwDrOcgYUiG/uXTDEcsRFrpBBxfG GQtiOls/+QSyvHfrd7vlbf9FcXGgsQ+dh67gF8oM4Pno8LpYJr/d+/huMC0dT1UyeF1cz+Tm8 rTtsZ+Z2bpYJDGOMK3TGfepyrJmASzzWiO9ITn7qMA6pvR8uvKNrE3XnTeIid5nQETkv+/nXi aUoGiR6H6GtBpDf7FG/kOqk9lg+WFBmNtYJg/46oH24KcrOpWKOTW//nm4yEe0kAjLNl/HVo9 j3woHzXU5PJz0T9UjCDShR6/P6nBdC4UL/8m7D+ZdSi7qMUoNPlMuZz6leQAmYdnET1ifVCsu vEYBEMH/zoIUuLHqDfnzIAssSXgstyzsJN1DfwqEX0bqpc6oItDJb9R7KeFmCG9n68DxH74v3 AuDPMMKsfBHCx08Kk+iBj8Xm4OHxJGzO/Ay3jUcCkfVCAC6NYIpRVABO9Tkggx0L6KZJLFem7 C+JusWCMlEbkB+D/mzDU1B0RCp6LsHfLk7UYxN4gbR5vy4mThVS4CFjl5umzhQVnB3jOnsidV WSZj/4aiG3NZGdT9+/B3iuDk8d1gc6k1alvWcocz9V78a1o3N7zhuDqsykw/xqIOwJ1ur2yuN bCsdK+EBMt+LpjuouDCjyr56MkRxcN0JwKUrV3hjkkx92+PGAnWw0UlcujmaPIdVGnZNaSgsY YlidjGcZno5zk/8BtF2dAIzrX6VlFKaCEAR1PBf92e3HkWz8E5bxs/ag94Ypy8SSJS4pSbHV6 qWoJKvA8ttYtJaOr8N18Ca2AyC8O2GfEdZqcYtruTUfBshRc/NSnMoQJERQ+RhlMwS11Y+sC+ LyMBurIKSgHv9p7GRd8JRlnWbXY= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61704 Cc: luangruo@yahoo.com, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I found a way to get such small windows: set window-min-width, >> window-min-height, window-safe-min-width and window-safe-min-heigth to 0. >> Of course doing that ignores the fact that the docstring of the >> window-safe-min-* variables say that "Anything less might crash Emacs", >> and that their values are 2 (width) and 1 (height). Which makes me wonder >> why these variables can be changed / exist. > > Maybe Martin (CC'ed) can answer that. I don't recall the details - if memory doesn't deceive me, the "Anything less might crash Emacs" phrase was coined by Kim, albeit in a different context. These variables exist and can be changed because at the time they were implemented, there was no real consensus as to which sizes could really crash Emacs. The window code itself does not care and the redisplay code is nowhere explicit about it. Nowadays these variables are a bad idea because they count (1) lines and columns and (2) represent total window sizes. (1) is hampered by the fact that we now remap faces (do we know whether the return value of 'window-safe-min-pixel-height' is meaningful in such case?) and (2) is hampered by the presence of window decorations whose sizes are more and more undetermined so we have to apply brute force measures like /* Don't return a negative value. */ return max (height / denom, 0); which appear amateurish (aren't we able to calculate 'height' correctly in the first place?). But the real problem here seems that resize_frame_windows has to do what frame resizing wants and (as _might_ happen with Po's ediff control frame) there's no guarantee that 'height' is really greater than zero (or one) there. So OT1H we really should set proper minimum size hints for the WM to avoid that resize_frame_windows has to deal with frame sizes it intrinsically cannot handle and OTOH the redisplay engine should be able to handle zero window sizes to avoid crashes the window code cannot prevent. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 04:38:15 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 09:38:15 +0000 Received: from localhost ([127.0.0.1]:32974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV83L-0002Av-I1 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 04:38:15 -0500 Received: from sonic316-22.consmr.mail.ne1.yahoo.com ([66.163.187.148]:37740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV83K-0002Ah-0K for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 04:38:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677145088; bh=wBp6kHEB/oHPpz72TkZMwca6RWwSfamBWtqKCvgZtiQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=eiO8yUczdE24Ov7S7y6PpQRYHAtIwQ/ODUAQoxfTC28Yz7Z93o1vey/8cFy+Rj49xxqY5Aps27yQ4vTdTocQ1C0CM5N6nnLIEu8XF/uNdM9cwq80jADIGHk4koop5ov3JIhahChIOIPq7VDIx2mi/GCJwW7QfXt3dSsO0WchmLXvQsbiqP1Hplxtc01wyH8ttX/sw5bhLLtVfeyq2SZEznXyedEy6Q+vDebCpPNZCmtGsyG8czpM0X2+4rolZRC90prrKugCam7SdaqpmL0p0Pf1FlHlBDkQqYqZd65OhAPV+f/Ionb0aBmqxPFm/EjtIHWt7RfZyDJSjevODDiVDg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677145088; bh=7CWdVdh5tcV4lpy/e+rrp7yVDnBE87GDratbUyWIAGn=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=eet+qHzTaUFRh2NNIsPR2bpCtLQAOgizcAj2I2JjfOPbTAMx52XbR6wC2ygJMtAYz81+X+l0pSs85WJxfqgDfZBMX58io6BW3h6Al55wGtOKqpiaeqBGIRKQ+/i4BhZK4R5CcAovKKuAeIY2oLOWNhEmCH/JIFYZwXz0lpva9ShhRiuUCAz9BIRS6zyFNp8uLr0HhDG0R51R0Y/uEQspWbz84YoZZYrtORPnY99o2r31C0xlwBxYFrD9uXWgjIEn3sWWchlqRWL8O/ffUpkeiYPIHia1N1EySZfAaHEUHvv0t5zzFXbiwCEdDX0WgEQtYpVBAgAJFT/h6Qo4eYRflg== X-YMail-OSG: .uEz0qYVM1kJgOGU3mhtfBXZCz0Q.riHboOyk7eG7jgTZ3rUAjcePrqBOKXSdyu qg6zkclWSue_TTH9k8AD3BSqMQgnN1sdk9wtGbXCq_EzQ2NVNQw8TbgL5ZCnBL8dyVrGjR.o22L2 3Vtf0apz4LCQB_SB7aXoYzBWT2J825CaMcP6bnSLH.wzJx4sfmTaeXZyPKErlgyeZyAnZC.ZByYS sMgILHcEtwqV5iq02YA9T.wHnWOrrtBiabPapFCOYU1McrcZxMVt322JJb2wf93gTLeHqtiBKw1k S7Dw8RgvxXB01mna2M4jxDQ1vSG1odqty5fBZXtEc5JC7199NteeGleH6YZuCA6fvY213KQVCZiP RSA7j_pbjoqwre4xtXP6E.X4u9bQaYMN3DF8dcfShi9h9x.mXsrHoZxByZwjDSw96Dn.fS.v.fmk KRHZWK9KCk3tVF8bME9Jl2BE4dadwYYccvoyIP4kQjLDA4k5w1dKgKlsQtG2XVKw.XaU4g3mQ5eb pFnc8FltanwRp8sVyxRW4OjpXzaAAXh0G9.nIbXqrFn35qQVuxp3osMoi94Fk9XqWEtcxUSpE9Wx 9W7l.2RPZLQpoeFXTHnTvuMGImPKvjIYWfI5pRaCrTayMeBeQl2UsIGL6zXiN8uwjji3OuZU6ypi xqbCarSkLl7NBlOO9gP3MCE5s.3zAtfBzFEnzAtrX8Psk86yHUqahBLpz4SqFTSnlRUkBU8qeX7k 9QooHkaRXOQ.7uOxdOYXKmSpjKl1xYx_Oj3gakIBlfUo9lgWQeAwUaXemuZ0qLCuskJXqEFVj7sV 3FuYmUKAImefRO95LUqXj3w9.uMBIZ_n5.pIpORQIrHHRFafye1w5.jvsI1Wl_XBXn8RVJzPcIH5 aiLbC8JvoJRU9m6PwjV1eMv_mQ7ilaXtiD2TJhruUjh6PY7g8iuG5lVq942crreWYWh8hqLbTpqt cd0EuQXW4E1eQX7EyGWgBB0nNrJ_qPLTiIVpYZss7g7eIDxmYeBZtY57M99J5dlZrSIAvBiKZ2BF WdqVFYnFXaY9FTqgLozZc8qYr0zF2Obr4kmaV0bv68rjBtONb4_cAP_pna9UqMu5wnFERWLUju4s 6S0mgoAgXZ764KZP6hFJp6RD1PgopFQRYYuvh_xQ3rvWX96oaD6CKF1SwkmI.a7I_BbQ2mMnVNyn GT6oVpTQ7wVgFmuC9pArsx1oqpzrTpnFV8Cl.txGZlER2jLZOg2izfk7rd7KhNQUm9MYe4gT1Vzk eCwl7lo6WWMFI5M1OR5R67AlWruk7HNfa6oWdWzTEVkrY6Kl_9iHSTLdpKKZFP2qBwx6zKB1ZX5Q spwhkYxRmIcXS8vSeQhz1OlGkY3ZniB8J7Ck_rEy6jXd8wBloOjtHZCU3D_NILhrBBSdsd3oB6gz cn3cDER2edup.k0JjDBNaDElN43bJyAPshKeCmw4I9fc1JmbU3P42KT0ZXUAgSDA_MkjstBtpF3r 46knHDI_xM0i.xmsnvgVGRQsROentnfvIM86Y9YEx8FDXLcbnZPBPY9oLS5LGtaeC9vUyT1wcTMB gLrSxZWNwBKAcVsIz478irXbttg5VNg8WDAfodnv8RXUjtgRY7ZL37RnqAhcUw5gXlt9baeuJmNw ya25kR2QP9905FBiYuFRnlgiXFuobHgEILkVsZ020ZEpzUwVCSG2o1WSwKlG8oOcskRQ8xCXQ2Ju .uPqPrEz63c7uydBixSU7zWpF6XgDvm3s62kzbc11DWklREqKS9ux5UAcj_Nh5yGvZLABOnBlLBf vTfgDS2x7EwOlJBQlGk1tLzhYAxdKrMe4DzonxibONDnGaZGDQ6Z2lKs0gVji09ZhbPjd82Hfhi8 hLQRMSLXGUxCQzt6ZUGIHdYcmso9xemnJLPLsEU.39if871nWr2qnnzBAPkfZJBH2S10918o6HmR 5YLk2mMf75cdjscGj2ZgHBywHqwbCRG017K.qp.8JedseTTZxavkbaJwpslahafs7gogmKPNc2zx Zy7xdKU70Z31np_wQsMNs7igFfufNp8Ba9zEzciMd8NLUjbqRPDlVj3vZyYxkgm.cKBWvpPa6zvv cyiB8aA_7DMEVP2.KGednIqANMqhwECYgfbz3sI2SDchLvz73SByRaIJRqv6sNEP3nIYq6KzlPbR UTEe3stPP0RjswsE2FigTku8fmmAIbU0AHESXZZE8N4JJIpn5l1wsAYOD5kjThkZOuVSnap88LjV YOpLvrw270yDl81XS6QZm5zW1QDlW429MygcCMhiYHcjKdwJ.b7DBZMY5.oVeEA88aPrM X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Thu, 23 Feb 2023 09:38:08 +0000 Received: by hermes--production-sg3-9fc5746c8-pz6sb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d26a5df00a0e75023b88e62fcaa9f417; Thu, 23 Feb 2023 09:38:01 +0000 (UTC) From: Po Lu To: martin rudalics Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: (martin rudalics's message of "Thu, 23 Feb 2023 10:33:42 +0100") References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> Date: Thu, 23 Feb 2023 17:37:48 +0800 Message-ID: <87bklkoh77.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 593 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , Gregory Heytings , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: > So OT1H we really should set proper minimum size hints for the WM to > avoid that resize_frame_windows has to deal with frame sizes it > intrinsically cannot handle Now this is not possible, as the window manager (or any X client, for that matter) has free reign to do whatever it wants with another client's window. Unless of course X server security policy prevents it. > and OTOH the redisplay engine should be able to handle zero window > sizes to avoid crashes the window code cannot prevent. This is the only reasonable approach under X. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 04:47:07 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 09:47:07 +0000 Received: from localhost ([127.0.0.1]:32989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV8Bv-0002Pt-52 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 04:47:07 -0500 Received: from mout.gmx.net ([212.227.17.20]:34457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV8Bs-0002PO-PF for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 04:47:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1677145617; i=rudalics@gmx.at; bh=3lXOTKR/VL7SAIP3O2/+/SvW+GMRMV2R2K6sIk0OLv0=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=BF4XUGBX8PFs5XLAFkJ3/EraGWtqsNXAJLR+BeAO9E+CXGSWu4r+75oMy66Xgkya9 Ct5/K9Snt/XNl6yEvZs6avMN4UAvI0oMzGJqiRTWMJh6wSFwBTEho4yls2ssljPaEk F8TAFBT/Owlla9cR3Qb2IZ67CLtRHq1wh5NT8lN7wXtyLWpqIDmU6dLk9Jl3Xd6Zge Fnl0fOnzR+jx104Kvdb0UEvivPnyxa5x7gEFlDeEDqltJ8mZPETRS3Z+67BHC1k1Px SzkPW1hnKzNTu2REi16hrRk7Ku5bL6Th2oT+7Oj1STx80AdBVmt+2Ii/W24l44JuIA W3OBN/zRPxSEw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.97.165]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MhlKy-1oredM44NE-00dqxH; Thu, 23 Feb 2023 10:46:57 +0100 Message-ID: <4eb8c0f7-558a-db4d-1989-afba973c2327@gmx.at> Date: Thu, 23 Feb 2023 10:46:56 +0100 MIME-Version: 1.0 Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv Content-Language: en-US To: Po Lu References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> From: martin rudalics In-Reply-To: <87bklkoh77.fsf@yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:V/WbgTWl770xiLJC9a7sDQ93xE6OEGxuTYug69K3IyPIM86IlCv 5aDkDRhkSqimLy6HToDabtjwQg3rMfxDu6lASbaBowKroCXc2Ry306ZzrIqZFDcH3vn/dVP vAKHWJVZzQbRC+SwGtI800idRAOIUFVeKvNO2wmTqj/MKGu22N0c3mWzarMqixuz5oCoJ/D f8q6tdfYukF2uGvZf+rXA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:uiFcR60a3rg=;0Iqaj21DuRCvlVd2VivWVEvZYhb jiT9Gtj/oCJ1JU/SR5+NM468BN0c+SAlLAi5GIuV3TCGlI32rb8S4iHoOM/fT5HsG/lZrJDp8 lpJOvn6BdZn1EBNgKv+G5Qocus+Mg7v/p5Q9k6VDnyRv66x5erXsrYhTAV/MKT8Yfn2lP3DV2 NfftaUelwvPsjfcplb9NAGPkxg5WtDaP3Qtx24HPriqDw0Zd+lTvmxOMmeXVdN3COx2QWNG2J SF6bMs19vli+/uaaJGlCRXAwzN5wofQtgqB1wq/52oHLZlH02P6AjLAdr6SI2M30N31B4Y9fn BeIVN+JFD/qRNYmCahPxwnPE8n6FPQXGOtxg8sV/30/txmPNZwfHWISAqde8/6UJ4y++JFKit YJsKaS1q5m5O3LT0HLzUZn8HGCu/TrcIYKkOIO098sz/XHn/rq1FdOl3gF8yjeVtVVuGpJJE2 mrZikoTS6recTAqk8TNCxpWXEMNPq7H9s7psqw4bvI4SjqVrnArbGVRYQ8aB8S8sz30d6+yRH 7i53RcmALRx9W+3eVjC1XeqilCKqG0fKBj9LFmpLxGXv0JglVBCub/MPb6Woa2nXJDsXo62k6 OU9X9HuU44VX568OEC+EtMYK0zPU2QtkG6FZOIE0obJMJnwzSt4C8+y1xs9rLfePb2TMPFqpt 9Ex60GyztfsePVFeDYu1ecZlQPUXcLmAOo/S7O/tGenpgEL3VzD0ZDF+rpdt8Yoi8lHjbH1+l 4Q+Vv5/gx9NnBx7vamWVPaJVjtBazVGO2z6JJZ8zeEJtPqJmKuRr+VugjdFB37fyPBvMMMLXS q2RcUn5E9j/VwqzJxGjSZpotKFVdGqqFVahOVAVHTuPw0iytZAN1vHD70nyHbLXPRHovKrtib Va8Il8sJwnLLo2+Mdw47keZATp73zzg3LdkJEDDqYF3hUiOuCqB4eF3BARQO7dMwTkjwRJGXi XiL2UMgtm81NUQeSyKD0L6Moekg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , Gregory Heytings , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> So OT1H we really should set proper minimum size hints for the WM to >> avoid that resize_frame_windows has to deal with frame sizes it >> intrinsically cannot handle > > Now this is not possible, as the window manager (or any X client, for > that matter) has free reign to do whatever it wants with another > client's window. Unless of course X server security policy prevents it. If a window manager ignores our size hints, a user is free to choose one which doesn't. xfwm here respectfully honors the size hints it gets from Firefox or Thunderbird. Windows respects minimum size constraints just as well, BTW. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 05:44:06 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 10:44:06 +0000 Received: from localhost ([127.0.0.1]:33098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV954-0006VZ-B9 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 05:44:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV952-0006Uz-MG for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 05:44:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV94x-0007xP-39; Thu, 23 Feb 2023 05:43:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mp8t++u2ftK4NlMgSatpWC9I92BDT9txWFs82qC4pGo=; b=GKDkbeP70VWD KcjjECUlEg0W90ja1lQUDC6OhnZ9cnVSbbQN6asRpqcAsimt0y+GiipVv30DxwfRG6mf2N8spebyg 9Ly7/cZu2GjiZGwVfY+62P0dRuNm8FwF3gQbdRCINleGXd7EVqhoYwVg0QV/nsJur7oQObdGj2l8M RE4LHPEhl7o4ebTInIyCxF3owLYtH0d8mZ+9Go7MjF6HzkOL7WdVQdAXPN/I2NQIQUjtuhh/h1WCt ctiw587C2loP1R5DCrDIhnbaUu/WkmOtnlN2PjzXC28wwyXTkdKfL0hPOUB6Y85s+GvsS0Q7OzvX5 0n1KbpGEGWg1Vlrgsele2Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV94w-0002gg-Cj; Thu, 23 Feb 2023 05:43:58 -0500 Date: Thu, 23 Feb 2023 12:44:14 +0200 Message-Id: <83bklkr79d.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: (message from martin rudalics on Thu, 23 Feb 2023 10:33:42 +0100) Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61704 Cc: luangruo@yahoo.com, gregory@heytings.org, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 23 Feb 2023 10:33:42 +0100 > Cc: luangruo@yahoo.com, 61704@debbugs.gnu.org > From: martin rudalics > > So OT1H we really should set proper minimum size hints for the WM to > avoid that resize_frame_windows has to deal with frame sizes it > intrinsically cannot handle and OTOH the redisplay engine should be able > to handle zero window sizes to avoid crashes the window code cannot > prevent. As a stopgap, how about adding something to the doc strings regarding the minimum "safe" values for these "min" variables? Can you suggest such values? They don't have to be the _absolute_ minima, just safe ones. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 05:52:02 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 10:52:02 +0000 Received: from localhost ([127.0.0.1]:33103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV9Ck-0006ma-9K for submit@debbugs.gnu.org; Thu, 23 Feb 2023 05:52:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV9Ci-0006m2-KC for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 05:52:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV9Cc-0003l0-Qb; Thu, 23 Feb 2023 05:51:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MIcTef9BkfnvN5CA4+dfvRKgYdp/Aex64Mt6sOHoJTk=; b=acgVCbftOLTQ VTvX/z12O8itwmluOlWCHE/HB3uD1ONrUnrXu9jLj2aAQI7JJ88muoU2C3nYBlbac1DZqpBm4sDOa NNNkfHABfPb9I51f24MjuGC6tVcCmkAiYcxsxnf3jIjbZu/Di09J+Nd972yRRBb1unHEKBr66iAx3 nGfJy4Eg58X++K5fCbvTWcbIUZHvccO0ZIfxp9GVDG+4Wj9ugGZoJkpwsMzVqX4RW2//DzQ7+JUXe UQQa6/Wp4OKCXgRpBnB4VoiEmeyq0C9ukt11MLvsnte0RmDP0BfVeOAiVCTtrpYAjSnJnYGOPovQj aLgsziyeG10gADCiNu7NUA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV9CL-0003T2-KU; Thu, 23 Feb 2023 05:51:48 -0500 Date: Thu, 23 Feb 2023 12:51:35 +0200 Message-Id: <838rgor6x4.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87bklkoh77.fsf@yahoo.com> (message from Po Lu on Thu, 23 Feb 2023 17:37:48 +0800) Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61704 Cc: rudalics@gmx.at, gregory@heytings.org, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: Eli Zaretskii , Gregory Heytings , > 61704@debbugs.gnu.org > Date: Thu, 23 Feb 2023 17:37:48 +0800 > > martin rudalics writes: > > > and OTOH the redisplay engine should be able to handle zero window > > sizes to avoid crashes the window code cannot prevent. > > This is the only reasonable approach under X. Patches are welcome where this is still not the case. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 05:54:29 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 10:54:29 +0000 Received: from localhost ([127.0.0.1]:33121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV9F7-0006rD-F2 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 05:54:29 -0500 Received: from heytings.org ([95.142.160.155]:41224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV9F5-0006qv-LO for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 05:54:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677149666; bh=ZWts5Q8D8JRlxzD1msp1SAwDqyUgTCP0PxVvZP1D8PU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=pcQ8HKRJjFrERDfgHra8ua/3APTIhlbZdKBXA0O/1Y2N863OmPLRUHWWrMFkoiG7v pI0rFfccIwql4peEbxCWtoUK0AN4k98fSzDUMHhpZzmUu6VxYRqFNT7IalNeBAOHQW fqY2kgFAlhSEup8VrYZE6dARm87tgcQGxqE/8iRlh0VQ1Ps33ssIvQ9l/4RGX1rH3w JH/NiaRHoJNV3locaRYzydJbK24ayfVCnh9BA6DinxozwNlAkEoyTFqEDRJ4OvVKGF ew/t0+86YeJ2sMY7giyq7DBD9RsLPjVk1DnEZZGng4OLs2Egs1P6H0lU1Yy9klwOgG xCqLZZR6f0dTQ== Date: Thu, 23 Feb 2023 10:54:25 +0000 From: Gregory Heytings To: Po Lu Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <87bklkoh77.fsf@yahoo.com> Message-ID: <96b742a05d29fcf9a7d7@heytings.org> References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: martin rudalics , Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> and OTOH the redisplay engine should be able to handle zero window >> sizes to avoid crashes the window code cannot prevent. > > This is the only reasonable approach under X. > I maintain that the bug is (was) most probably not in get_narrowed_*. I just built Emacs with the GTK, Lucid and no toolkits, I disabled everything (tool-bar, menu-bar, scroll-bar, fringe-mode 0), and even with that, after resizing the Emacs frame until it is literally a single pixel on screen, I'm not able to get (under emacs -Q) a window width or a height equal to 0 there. The smallest values I get are width = 2 and height = 1. That, the fact that this code has been there for a half year without a single reported crash (if resizing a window is enough to trigger such a crash, that would surely have happened already), and the fact that get_narrowed_* is not executed at all in the ediff control frame, means that there is a bug somewhere else. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 08:08:23 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 13:08:23 +0000 Received: from localhost ([127.0.0.1]:33349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBKg-0004Vt-Rc for submit@debbugs.gnu.org; Thu, 23 Feb 2023 08:08:23 -0500 Received: from sonic315-20.consmr.mail.ne1.yahoo.com ([66.163.190.146]:34813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBKf-0004Vg-BW for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 08:08:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677157695; bh=KEbE8hbIYiS8VvUyh7xiEGS9ZXVhsYTwYxiDmlHBGFE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=kGIlj09LVaBdK8BOowuoS3eg1BKKOrG/OxBku955r3HznqHOOfePKENWrp1V7Mh70K3pO9YhIieBdspHUzxVhN4rx5RWSM1cqXJzzOmXH95xJngNoGeCSpupKZfjfbSBE6yCH5HNd6tXh+OlD30UwBjYEhm5K/niORlhkWdfohd8daanfq35LnmA88KjdSzKUdC1AcHD7VQo2evlJU6AovlJ/ZBS3Zz31SoQX6SRUJ4g6L0pVkTqOwX/sJIszxTgrJEZPqnMOh59HBum6aTMV0JtwREcMb5PZv8F/qxfT+meOpZKkBVsW/4LyGyaBftqQpHKzATo/lKyPmnz12RQwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677157695; bh=hcbjkc1kExDcwo7rqGtpaeF1OrGiFp2Kp3sUxbTLgml=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XfR8pltMkzpJqOwlrGPfG4Xp/Q0IsWDnNmC6bwux//ULRzRnTi/1rDsEst2y58rzfUiwXdmG5Oo2iFWklX/NntUilT1yhx26LGKCLRTCgblJBLcQOGv+vcXsE9fA+vRuff7gjphJhr2EPf0oyTNqEtuAEJph00wLL0VQ8riP1TOiXqX/Xf2QV/RVdHZkLa4LpCoft4fzA/QUauVYqk2CVxJ7ZJquYdRtFxcmMba/VlwnnWKL5zf2vhtLYasZ52Jw87YBGuQay2F08fXyHiD9SsYmtmQ1KThaRRl6H2gDkJORYqn3xAMpZrcbsQaSaTahAsKTuK84wdyPeb29/p+T0w== X-YMail-OSG: 5ZHy.fMVM1mNh8tBtZ_L6U.YqTCaEre6NZaTVOGnmi.7Q9V8n8mWhvmlkaOB4lX n_aQE4F9dOihrWmBVGGC0w_f0VdZ91nT6UYOUPqDBnwFIpF2rGtIWlpLH6JOYj4xw5k9utAlpzzz S6Yg4aKruJ7nhSOMAQXe_xlPdatk47iEOiFUeSTW4aovZEW_Gr0fDtaNkCZ4hjL1Dd26nv_eRmwV o2uReu9RWOdhzQdDyQuXQkFyzZgldtnQ77bKRjV4MfeiP9t5PAt.A9J5ZfxOfUBxzXEYA3Tj2Emo X.fhdnV.fMXfXIfJb6qvg518lrBIPbpCjKUeWIM8uctxHWYY0ws7KqgwvXI4lM4hD5dteQTbBcpu XePC3cQzLRuBxqrt3R2WZJ9QMkjY1QbBdVer3kvDRRpqVCIiFAC_FhYicuZoImT_FGr.u3iTBjf. 67CKiCkMHBCtfWkFih.XwbjJ81xpiSmSUx6MAqXcfKkYKwe1_Otw.dph8d64M_L1B4LFlF9g6D8c PRjoXIHhz0OqLK20aqI7p9tdah.S2.RdEXTmETns5mpoutbIXDbIU_gXFBraKiFwpziMjxpZaYi7 Tbn6.UJGC_i7UaK6TdvOCj2yfM2C7BZ4mA3iUuYif2H01nmcizDdOLz35bU6VWC21JTmkPp8N7nn WKk2HQQIat0vcYo2d0v9osw5NiCEpUhwwRhdiMCiUbokt.Larvz9s5Zfry0z8MefVtPmgL0UqjEY djGm8qrSVy7056nJRUaL3KCgu0CWBFK0QcUwyOL.Ju2dpRPE5XzLefVnloqw_E4tWGnMFZ99bGSW JqKaiDEigiiHNGvW67U5DsKSleV6jvLbb.lKoqvG4v3IAwVkPj9lMHrd1YKPdsG6p.egp86BXK4V P7S5_._lJtpLBh5kQxwkqEdrbd08ZaMSy.cbC_vhkRMYJKBniECCpRSdgW7vExGyEr.QwIdJVrt9 zbEUf4ayGAuJUQzvmyDPp1uXwq9JnQls2HUZe.lb.7599IXkOP59k4cXIMRzPN6Gbazsqz6T5e5i XxlG5aHbii7xTxVnnw7yxa_xbq7RJioP_Lvc4vTM7LfyBfnkLBiQo1qiN6lBGnr4j3pzNRtrMV7h yToU8jhbedRCrd3tXMJ03OJ.Uo91veWQu82eHIs9nMapYvEeAYiyry6tCgt8eslXSFodg40Um9sU x8wUsngz6pEipMHy.oFpiHQbQCIsrzs2.LUKp_DsBFQ9NnH3Vw3mnqLJm_UmmQQdKnG.sFV4MJ1h F4SMsAlhGJ8kEpCOcytb5F9rUdbi_P50kd5Qr21zQDfPEuZ5cxwD3FZaXRgAEfq6uPMUTFmErVho EQVF40l85UBUKU6yg2xUqFmgg81Eyp_EictBUKDYZZERdn0xKG9S.BOscJjNIM1wW2yRbznzvv0F DB_1CbOE_2Hwd.6T2NR_6umlv95fliBL5onof5U035p2TT3kEM8MVxRfc4TmZRtozDULpEX4ttzI klHiidriORkU2SlqmgjGKtsY6MWwZmlgUoCDKBfElOUfyDsPykXdGoWrORqBE_bDF6tx7PLyDgFo NwOYiR4Y1URDZrXEIPzuzjmc8ttgbmxZVNgNvP2UnR_fFKuoqOLuJKQK61nwF4vzfBb2zZGLZ6BK qL5L.E9mNayFxd5quJaIg9uHlU0mSAvgmhVc4aoFLwH6lHP.PQdPGevKCYxh0Z7_1BkP2YHQz_dG SI2Cy2Wvn.gfrAdUvuf0eEsDxZ0czhrOvt2ASjduDnZLtT1mGiD7jEKyecVJBCvkWnzY6d0UP0yx 56IFO3iQ4XX0ngdxS1x2yN3o1a7A22WeWbZgenpkkrnl8qwOFbP2Z84Kpt4RUU9IYm5eL48X3ogF VlWAADM_cCWlKMKCA37Vh3yQuPlxK8wDpTMQQDGPdECn8Pe7i7QfKjdST4aPFTrhBQZeHIZ0nItS NxoK4XHhL11swU46x0ludC1McKlSUzEwqNcbh0_klZqkA86C_US5f0r92GV0xKPOMCNGDYLHpWSP QRz9EXz8_pN79mdnq_PYO1Kt2raZHE.R44OQsPwyYu1DyNs16._rTKN7CVBx7JFXsMq_YQ73Qizq Sn4see.P1rr6aNpjtfwQ1KBrzABJcA.Elytsr4pL4x9f7vjz1bVx9yM2wkpS.led9A8G1rngC64m 4bsBdHLuSEW2qdob6md_a_LuHpiflV60W1icj86XJmwa_p.jrX5OO4Lt_kTNfTqcdMnhHC3Mu8dd OxoPR96LB3v8poef3bEgZ8Uusa1UfSN5iIIhOWMMWiKF9PDsetFSsiapyEG59tYFisYp_tykDEw- - X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Thu, 23 Feb 2023 13:08:15 +0000 Received: by hermes--production-sg3-9fc5746c8-r2vxw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fcdb28e61f91f2edefe677ea49cb53f0; Thu, 23 Feb 2023 13:08:10 +0000 (UTC) From: Po Lu To: martin rudalics Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <4eb8c0f7-558a-db4d-1989-afba973c2327@gmx.at> (martin rudalics's message of "Thu, 23 Feb 2023 10:46:56 +0100") References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <4eb8c0f7-558a-db4d-1989-afba973c2327@gmx.at> Date: Thu, 23 Feb 2023 21:07:57 +0800 Message-ID: <874jrc7cnm.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 973 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , Gregory Heytings , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: >>> So OT1H we really should set proper minimum size hints for the WM to >>> avoid that resize_frame_windows has to deal with frame sizes it >>> intrinsically cannot handle >> >> Now this is not possible, as the window manager (or any X client, for >> that matter) has free reign to do whatever it wants with another >> client's window. Unless of course X server security policy prevents it. > > If a window manager ignores our size hints, a user is free to choose one > which doesn't. xfwm here respectfully honors the size hints it gets > from Firefox or Thunderbird. Windows respects minimum size constraints > just as well, BTW. > > martin The problem here is that Emacs should not crash, no matter what some other X client, such as the WM, does. X programs are traditionally expected to not crash when run under a window manager that leaves features unimplemented, but to provide some kind of graceful fallback instead. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 08:09:25 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 13:09:25 +0000 Received: from localhost ([127.0.0.1]:33354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBLg-0004Xf-7P for submit@debbugs.gnu.org; Thu, 23 Feb 2023 08:09:25 -0500 Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:46861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBLe-0004XP-AD for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 08:09:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677157755; bh=DiwxQxPImybYUHYZIvbiLhUfqA6rweYNxYo9z9bJL6I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=LfFRKd/j7nXIESSO7EE6N2oNsGDKVPyNFyJqFRI/geHAwcXj0nxDukQy9+WIr2deKKeIOO4mZfVK+6+1hgIwMxR4PNvLMxpgKsJ/moPpNVOMEN5vJAWdhMUlieji3LO1X6u5BkIskIKSFZLL98L1ppc+1ahNFnuF5L6ttzzrYCZw75w1dtki4/SLioRHs5DcR+bgVr8Mq5ldnkkXWUs703uK2RPVJrv+5lsURLAReFreKNdiOMzLlETn+v+Ls51sApm0+sR9bRaIMOTvFFy6yFOCr2dEn3nASuQw44xircjXjQeVlp+5iW/XKR7KEErN86ot9QfpXPtuLNqU3Dn6/Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677157755; bh=25ed/tupcThqfg3/q6byqiDkdFYTdetqAyomkHRQdf0=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=HNxvgQRhmHwxRyGH37zYOIPSFZ/OYQ0MEsV/+0Qt35WVEIAsMdiwaVPliqKR+SEcSg4EPW87hYZmh9Koy73TJCyGy0ijoBqPHWfA+FPs/XTp91jYY2IY8b9rElT+jAiSsAm2mVkYhIOTV0HPffwWnyG31alhNMJcF5KaqbmLEj5DzN45f8fE3hMdaZlVhz+Nvqg8TxTbWPpcNtbMm72LujWrbbHpeViXFBE1ruZNO/59KQU2q8h0KEECKRzULG4463RKaj8a5k96PkX7oEw69IqEIZoY/Yb6VqGSnygFa+HkPhBQZQj0F6EfU5Lr1pMizbW3Ir24xxvVb2T1Pt3eWA== X-YMail-OSG: S2kBwJwVM1mdcZG16KJahLQLm4lzMcNreiAcoyn5JMRgibCkoc8ZAWR.VqxdB5G NjF5JlxcTGeX.FMjzlLmvgyHtSfBtLr9_vsZoQ_fOIeB48_UAD5suv3NRcf.cyNn1lPTaGZaRc9L sDy76yZ4pg.sn.mUewp6KRLPrAWpII4m.ECO6k0z7Qaypplix389sR0zOF1q0XvMGKTjDCBP1ypF fGThTeVsTamezavaee9M56P24b9llWFrb3asOjK6book3w.4lfwGsbiE4wd_0o0zNFDHfH7WLTgj .jHvW4D72Bjzwlxj0Jb0y9EIlQmXgzBcEcKP_4ehXIUsotohIbtYCo_FMn7qHUkEylt80yETC1jC ByRJ5EWZ6y6tdvNMR9nNRO0jEHJ3TOwC3JQmZjMWJts4XHvwBLjCaRGvl4x02tu7BECOzlv1N9Qb CVBCsXo50Ad5HQix5UYPbEZJv.dTXEN0qz43AiN1KxXJ3fj5E1zgaWiZHyTNGoLZYRbGx6O2_lh. qKpDQg_eIiQU_tXlbds_Dne14d9qn3GQQkF3VsiipEe3CYkczsmlrEBr8NkTdzN6Elx4T1Aj93tn H631iccApkwtAmfuqGQ4CguQkK2hIDOaqlgyZ50pKFqswyzBtVgTjrEioOEpWtn9YrIBN09mIiVS d_dCDi_jxIletiZ7jeoBIl3rn3lnj3nJB1UmXqiFM06utjwtfWzv274J96gxOyGiSvC1pt7KjFti tk38LmzYs.3EkFMNA_O9sWGC.i.jipBtCTgObT4rtndYvYxzPYIr2kVjDpCsvCHVfcyGXInYJmzT c3mtupoUYzEy0gw3Grv36s7Esj2SvZrYZI9U7ow.Gnc8tRbdn5Bc6Xj_XPYyAa1YWIpw9j1hB7UD qgr3q9DPYt95vB9ys0dEAGFlol3Sw4piqLganN9Xe5Jiw2jQouWpNLTy_4E7SSfKPj8sHjIAcb1u 1IsrOKGFWG2V2wwdZTT3nkx4FL0_J0a3BPypXMH6AFXvzBciDO1jNQP_Nf4Pep0r.n7R_4zGwXCj 5rx6jYQZHO0AMZmppOrlZqoSJOGKUlTwPmiLiZcaOyBzICNk.6673IHfOv7U_w6p_qx5S5ikjNVe JgOArhoiz_zB0o7xrPapxTWolRNGBgGlAdtTTnbUFRrGDsLnGo4XlNeEAtljdck2gG66PIt3Tpvn qS0KJTaJ_hGbsZSLjvCegs1N3QLt1kgr4foRuqP1mmLG4pJ6pynpgGDhoohrAkF4_9uz7jFuhDtB 96I1QtQIgUZ4z5UuXAq7rUyQlWlD1IeYM0_w3yvJ62hVukyGUQ8ODZGjIrKLFIv7DBe.mIzSIsF4 jKZxU77pz52LfD7tjvguYcM1_7KLKg_cmX7RSZH7sy4M.Anp2qS5F0R5d26ma_i7EVHnEmTlBayq VRBTUdZuEuJlj0F46PxRc5LVK54TY1b5J9aZ45OCIBRegrTc5IFXM.KiJR2IgP1UaNX_ivRQh0xV UvjkBUGMqBawOa2cGiKshCj7.pXmyHxmMUHeRMXBTNmj8Vd_0pNb6j47nwEXKtg4NBv8whz7ZJR4 imt7SfjYzEov9OMpaMUsmqm_oj1FU9t3HsYD9uAJ0cZl7ByalkfXygZscIsH0F0zlsjFpenHdJKx 9SQlcuAF73EqzxPQFN32p6nbhwv0KkLbO7sEHdGdu2oZb_YgTLG2DB8pGICEg1k94CoA2bKFQUXg N6D7C3NVlqZJiWK4Z6FsK4VsuRVyTQR6KPjtgGtZYVNamea.g.P_gk90A7wjk1OURYU0iTl3HgCH 6s_Ky1K4pZjCWqlFpVBVGZNlEmz.sxheIh0YjnsrIxt0D64xJViFbrJHfCmuy2OXfeCzojWa4pfg AcUv_pcSnn49__q5IxMS0wTiZDCTytRDc1wu8YgfQRZE3OtOlmiN4.xqYO1ZFfCPYkpGGge0dnJY sgjEYXu3Ln69xRM5ZKMNDOwvGSxCkNQ8O21_8HoK4HTZg_zArEuqvUc.xwPSI9luM2smZQRClXHN tW7DFVw6cyGnipkJfm0n7VRmzty87mmEH5Tu3e3Bnouh7ImrdGJjv0IFrA8vBoqr0Xx65K.FaG4k gsyuOtlbHSC5p9x4ebQd2nMWdkgcfkhBiuj9k95_oxECcqCx855zM3zL3f.uJiioKbqFFyU5A7HG Hr3ys2kjw9loFmNwmH3T62uysNIrDYgMqR7GeA0w2guZkKS4z_iiqprJI8qg.DFglph7MuHqKoyX IXlMLlMasfLrB30e4Yn7URDSojI6Ryrj5veWf7obM95dcW4pXRQcQGsKLXVZf8lZp X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Thu, 23 Feb 2023 13:09:15 +0000 Received: by hermes--production-sg3-9fc5746c8-qs9hb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 699f00f77bb1c0407f747db968a8bf6b; Thu, 23 Feb 2023 13:09:08 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <838rgor6x4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 Feb 2023 12:51:35 +0200") References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <838rgor6x4.fsf@gnu.org> Date: Thu, 23 Feb 2023 21:08:48 +0800 Message-ID: <87zg945y1r.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 557 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: rudalics@gmx.at, gregory@heytings.org, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Po Lu >> Cc: Eli Zaretskii , Gregory Heytings , >> 61704@debbugs.gnu.org >> Date: Thu, 23 Feb 2023 17:37:48 +0800 >> >> martin rudalics writes: >> >> > and OTOH the redisplay engine should be able to handle zero window >> > sizes to avoid crashes the window code cannot prevent. >> >> This is the only reasonable approach under X. > > Patches are welcome where this is still not the case. Yes, I'm still alert for more crashes. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 08:12:12 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 13:12:12 +0000 Received: from localhost ([127.0.0.1]:33362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBOO-0004c8-DK for submit@debbugs.gnu.org; Thu, 23 Feb 2023 08:12:12 -0500 Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:42294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBON-0004bv-0h for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 08:12:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677157925; bh=cevhYzW6XwdqrCRvq8VHVorgqpvcdRSwTPWBDWADmVI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=NAdk+AQCBiAy2LEzit+vWBM+uspkw6NajUKiedkF1UV7EfmQEIrh3t14YfHC15gXRM03o/Qs+4XKPEg9C/uBJnvdP0Hn7A6D1FMjU0DGnKuQyfxksW2rQq7s+8RowWzHhSSAfoUloZZ6a2eUm1q/MEVSZIwm6VB4fjYNKILmDvV9hb8wlb7/IIoYd7lzY7G+aDaIK0yel0wCi3eiJa4kaHn/3498L+UnPn/91t+9J2upIRhDrV6NrbORAxFb+UcLuUCWK2cFO9YPjXJZKjQk4ZXl0Y+/mUfUD9ebQS1VobnB4wYulwyB4W1YKNCUNY48n/s2PZpDXmsRHDBpIJu96Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1677157925; bh=Y5yhEJsedCvpU3nYn9eohLoTxCrslu/JQb2n66aRhvo=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rFdlMjTUXSq2gWkgOZEMTkPkJ3++8WC0Z2Uc0rSZJOZ7hf63x8SbRWrBKgA2sKaBdQDB7vVzXSkrYB+HUmc7zlTM0IqeOaFURvS9agqcl+6g/Wt1Zl6PG5ZmlvdTrjaxigg7nbNYNKd/EPptAMGCiYnCNsWaiV+EXxAWDsSqebVrJWOIUCZHleTeJNXUOd2WdJF3Dz6R1Phfso46puonL0Gh5QsQMzTBsYgWQBF2Kt8faTP9E1lGNcXZrtzTBzxjo0zIXicvaDnanuNcnbo1+C+lghktkELKrC6pLZ+qJfT4WWfdwpChpD3PP3IwxyNXoOzkKOP84fKbcO92myxJ2A== X-YMail-OSG: GCZavC4VM1nrykXqIMLCEMBigqUdbJ.6oZsr0fUu3bAj3rx3TDXlm1Y2Dj85629 9VNoDDwkWQ3I4MXjsPu4ST3KmFFBTh_sYCnir42V7YOOefyh3S7zjiD6Og8ynFFOD2ukjeDKGJlN oEqWANWv0NeFhB.EWR1m2U3BpLCtvWhjqY9Stl8bdSJW2pKA8X1l118NxF576Fvcb2G40l_OudAB _o72KNv3YViQrAad6auD18B9IU8wB5x7ip0R7gZZ6tK10XGt2.ulqfJgivxxxHkt5QdpO7CNN2VB YsTpoxV7Q3b95pLmT4IR_oIJur1BEOABFoOC5fsGepNAkAwuNFyE8CvbI4MSOpZd4GL4mDLThV35 ERZ7N2TMhPVfjojD5Yxbn1NLSL_zJGdasGksZPGtj7Qhb1r5jNXy7yKdag7dYB5dVSvwXRDdlsT2 WfZY.RyySWdzryiuhm2.TCQOG51PeJa.ELySlyszG_DdEZuaRshe_zaLFjjSSBLJ3IEHdapaBrM2 XsUKAZvQGdtWqkPdNPBtIhfceFgvoPi9AxPWvPptvyz6GgyE43RZCd4qvN43EfaUhS_W3y9zFFlT PR4MzYYPDArfcdNFx_rR2uf4V5kQCzSYgIZiO1X0p3YxT7muMo4As08Hb0XcG.j2UWxKvRAp0II. 1io4ryiICl4mrzIJ.HHCqL00kvqRZp6056C16jKanDBBZcl456pB.1P_Y.R2wwg9LLJ2Qli1LTSg Qy5sBOUZn9zLdbFcrfa861rJ6E33IFdmBn9XHDSc9HXiqNTXXjIOYMd7cIAp_fwUbYT6WbQlaDdQ woKCNbE02Ave.nxUbDqPKQX1jfPjIwIljYS6qO9ymaKRs2ua6RcQZ.izJNyRoLPuMjnKZNxyeLrD _IVwGqU2iopxy6QyVMfKNNoqgjulZtnEerE5xSfzyUBeRekO_eWjuRgvo_y6ClYnAj.msRUOhANA 6uoLzT2UhYIe0iWwIlT0i9B5F45B2F8aIONkzrq2QU_DNKQi4aQmr6JAOHl2ED8NiPbDi_ls88j_ Gubl03_PKdeRKUdyGJRssAML5LJTrqgU0Y2X7yttQUCiX.UWwfPp9ajT4OBvAwRnkPhUYc_0.CcY QEriJRbRKcxbM4yTSuy23HbNyHba0U1DyUyZbEAsJtUThGchsItlYqSWA3oQzF6aaBiumPQrQjNm AYj3GTESGgpSmZ4X.k5Gzc5ZLWiAEQlCT20G0u1JeWrGyGpaU.edX0AaUvo3nid69OU1SZqufRJn d9BjfUBSSs72RSM0udB_vgOgBm6F2PJB34AkbG.Lixmb.EnhCqvZNpYKyqWQpeHu5tcfk6kEz5Jg dZzSLHp3buaL0dhc7HYOOsn2y7jtHEz8sGaH3qvp119vCEbDr9wdxBHKjr_hHdFx5LdPb.VJCF2p GBCM4La8Rb6yv0ugioN.nzqFbHsnzrLkzr8DBtjXCwsgqE5JUgWPAhdtdDUSMRR1NV9Il64IpvMP 1vPl6_qqJrfTqWv.dM1FHBHL1lpYdAxSeUV644cvV3neRL1LgMjFdT_8oXy1zW6FWUCNVvev1Xs3 Rborf7kubts2wlD4G60hs8HaduPIFA4ySoavWmaRV1Kd6CSQd_gJGOa1m4x50rOl9Sf5EdXF3uk_ cDtBoSt9e4XxccJYVu8RpIAzRb0JieiwlwcLaO6c4aDleRGEhCyWTbqThvEXxcQQFdGuaM3enfUs htDG1I0NvF3l5oMvl4RHTZnzz3zX_TZjZ1ufC9sQG0GykbA_.PwL194fNLUvHrFvMrHoarSvDOaA WE5YMo6WSyI5b7TsuQtpj8YZm7DCnRvHtERq.JBIZnFsxrcYXBV4uIvj86JH2wEGJ1OHw2j3XjO2 SBVydXupR5H31ZjHi.5LKycAMC9TZPE_yAYIsVJM_aVJn35zlrT_D749.XrakLpGR471FYArA_i1 5ulFQopiyUprO85NAeoLkiBF5o6uPinT2IczpKmkaq2sZhM8oGiXf2pGDOS2C6r.X4YSIfLVIjCr Wc1PYvgXfi.7kxTEBZBKCcKtZPsgnhbQVm_RMwEvOeDu7hHSzezcC4TZNhdXcggLHEpzJAz1S_ei ozcjQXvufa1hvxZpzMPiff.0Nb_yFPCfgjLfE.GFghRrPGZcVT4SD0_2wXnuqwEePFI2foZxeEjP 9ssX4M5zKUZCpDyYEr_xV3RaE0afyO3WQCl2xB0L23FAOPQEfquav7Ru2wIgKaoqXGK.qkxPRKnd QmSrMDKmS4KrddL1ug37fDCrlngoPtgnw6ywYoSCL01yOG5Mqxsn.fikNGjgdoX6QbA-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Thu, 23 Feb 2023 13:12:05 +0000 Received: by hermes--production-sg3-9fc5746c8-z7rbd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 624c88f9ae74c816d72f9b76ebbedeef; Thu, 23 Feb 2023 13:12:00 +0000 (UTC) From: Po Lu To: Gregory Heytings Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <96b742a05d29fcf9a7d7@heytings.org> (Gregory Heytings's message of "Thu, 23 Feb 2023 10:54:25 +0000") References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <96b742a05d29fcf9a7d7@heytings.org> Date: Thu, 23 Feb 2023 21:11:43 +0800 Message-ID: <87v8js5xww.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1130 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: martin rudalics , Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gregory Heytings writes: > I maintain that the bug is (was) most probably not in get_narrowed_*. > I just built Emacs with the GTK, Lucid and no toolkits, I disabled > everything (tool-bar, menu-bar, scroll-bar, fringe-mode 0), and even > with that, after resizing the Emacs frame until it is literally a > single pixel on screen, I'm not able to get (under emacs -Q) a window > width or a height equal to 0 there. The smallest values I get are > width = 2 and height = 1. What if you send a ConfigureNotify event with x, y, width, height all set to 0, and with a frame font set larger than the font in the ediff control window? Or some ridiculous value like (CARD16) -1? > That, the fact that this code has been there for a half year without a > single reported crash (if resizing a window is enough to trigger such > a crash, that would surely have happened already), and the fact that > get_narrowed_* is not executed at all in the ediff control frame, > means that there is a bug somewhere else. Feel free to try to find that other bug, but I can't, since this bug now seems to be fixed. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 08:23:07 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 13:23:07 +0000 Received: from localhost ([127.0.0.1]:33390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBYw-0004uJ-Ul for submit@debbugs.gnu.org; Thu, 23 Feb 2023 08:23:07 -0500 Received: from heytings.org ([95.142.160.155]:41412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBYu-0004uA-LK for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 08:23:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677158583; bh=ZxwmAsau76K9Q2YrhaC9d7NgZK5moU7P7DQaMnePSKo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=kOYbvhHj8G6S4U5CZB70V+uEe3wGOGC0KtyyqQmqvIhBeW+L10txTSMRiPa+FWByW rE53nlq9srNmAouzDOI3TJO7i24x/JIOYFcipvHK6XmBkxdouglIW7Fd6Kn8LYX95I pQYVThcVvA+MuoP3YJk9SQb7QjIzpPC9iil4PjxYlO4oBMrpzcH2p4pmvrcE8FZxhs +6J44mHcG4Btfwtcpi0MD0IrwP/+QORdyF29DRcX3UQuMa40rB1O4nczcEj5ozwE5a 17tjOfKSXSxOrM+SnNpiFIQlqs/j0gG8nbLkGupCXDkmgvIGuFJ4ftMNxN36Bf740C apou0YVXswz8Q== Date: Thu, 23 Feb 2023 13:23:03 +0000 From: Gregory Heytings To: Po Lu Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: <87v8js5xww.fsf@yahoo.com> Message-ID: <96b742a05d7fa4e927c6@heytings.org> References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <96b742a05d29fcf9a7d7@heytings.org> <87v8js5xww.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: martin rudalics , Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > What if you send a ConfigureNotify event with x, y, width, height all > set to 0, and with a frame font set larger than the font in the ediff > control window? Or some ridiculous value like (CARD16) -1? > I don't know, I'll try if I have time for that. But once again: that code is not run in the ediff control window. Not at all. It is only run when displaying buffers in which (long-line-optimizations-p) is non-nil. > > Feel free to try to find that other bug, but I can't, since this bug now > seems to be fixed. > It is not fixed, it is circumvented. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 10:27:43 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 15:27:43 +0000 Received: from localhost ([127.0.0.1]:34987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDVX-000069-JG for submit@debbugs.gnu.org; Thu, 23 Feb 2023 10:27:43 -0500 Received: from mout.gmx.net ([212.227.17.21]:57777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDVU-00005h-9i for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 10:27:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1677166052; i=rudalics@gmx.at; bh=pxiRrj635N2NM0fci3mkiMwpc6G4285fLsRslFHJpjY=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=WH/6w4XA6ZmEPbpqzN2SlBGblefw4NjjnWrLojK84uCGSt0FMH3yTI7H9HzjrQmkj Lmxo+ofvejbWn3aDTzmdVErLHYD9y+Q2Q5MYE6q6MNyhf8XIcOCSvJbtiqnJPoytvh uY3w0C0j76TW9+mc72kw1lfGnnYL/rNjUNrUA+E89F9/NkcOLFe89PXVqvt8PU7W0p Tf3830FiN9nqYOA1XZ4fTt3AECr3DShp4oudzhCCT53eaPzvaYKKud0vHUBdeKrooQ +NOauck/hgCBvYiAyumoFDLre7qCa9FUQOa4Ys9ppbHgdWGD4l0gTZmg3xGi2gvXID 7evqDOW6u/pzQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.97.165]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MHXBp-1pHnEb0HGD-00DYG5; Thu, 23 Feb 2023 16:27:32 +0100 Message-ID: <1f216d21-eb0d-7e77-2d61-492382368f92@gmx.at> Date: Thu, 23 Feb 2023 16:27:28 +0100 MIME-Version: 1.0 Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv Content-Language: en-US To: Eli Zaretskii References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <83bklkr79d.fsf@gnu.org> From: martin rudalics In-Reply-To: <83bklkr79d.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:NzM+VS4w2iHQONgPPys0djg9RVszIIpb/7ZNTv0NRCSvjvbyzDI GvVFnGwpaRqXykh9ghkrp5I1gGhYHsfCePRVw8ylzY1KbASFPI+63EynM4k19P8nUNyv5Jn EMd35bTfF/RGl4Jl9Dmif3Vp8EUqlaMGIEwQXuNrzSdvdJ3jFNBxJEMSTeeC0BPgdCX0jUW RkJ+vu+agh61F/XK3odEA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:w9q76lE3O7U=;MzCdfI7YSBoP+ogmQVgkB4u2Dzy NRNTdIikSPtfRt5jXodNohpbVHkVxPEs7cgPLkpJnXRF3WOkLeEKac0Qt0aVicAWJ+XZiPmvW 1Rxpu1e4OwZ5l33oXDJwZFXIeTSfsP2y/rxvl+8vkjaE0EeI9ukCLU1Kmz8BgIzR3nghTHRc5 ze1/GXu7+AqNPm6b2j/k3/psCtzauCMVK6AJ9o+T0gTMj4GjYW4mq+dcEH2Hbt8FUFxW+MAx8 op2EgaZArLHOsgYy8HZ88c58wHO8GGxHqKOvtmaDlsSmFcmVyDUmoScgyV/HqWLsllXvm7rKv SN2EWXGaTYgsDBIUWv1MWke9QadmbwrG6gnQuXJRKzb3frawEKeE2lJDV84P5CpsZvS0J3BBy flUaXXbYgQ4AJ2fKRHeC4qLXD0wqphckGZgX8y1jSr9MpKyK75NWJTAbj8ni9N2aeV6R4tpIT xhjo3EgYjxWbYiqPwPxZ+alVnfZnGPWI+AEFarL/kiql4gwbj/e5xFhkI2JGvQaNk55FvMHoQ N+zdTj126TMX4JJsjDxm0Lwr+ayTxrlwPy7X6AWx9kWsGbLs5uaFicDwHMwxUNUynOfxgoxpV KyU3mkizIJNxpNYnP5cFKq9mNxsGuryw/prZhn83PuLcvXbMIJqPxZ1NpdoMo5ofodG+3zE5F 5GrPiOIusiygUphClYfMOEPXMDdWONZBZ4hgsx6DXgG2yBmiMdt2GQv4NCh+RRW0U1YOrB6FG cPHBrBm/rkeEKinhHJR/THqF9zi4jpf2lJuEyPIQdeFTcsF0ey585UjxXwqbkq+N4MCKRzfdX 8m3Ti0iHDQMvC+7yBAFXcyJVPNEIkg7OGB8CrPypx7o0TzS1jITyQwTv4tQEAKZKJSZDNQn6X YV2MqlQbimXh1paL95o9tEMGJpZra+pncru/ozDg0+u40wXIRaYkR+YHyrzP10kJxzmdrZVj3 nexncaof85BYc7dhMwbRMWDcWBs= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61704 Cc: luangruo@yahoo.com, gregory@heytings.org, 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > As a stopgap, how about adding something to the doc strings regarding > the minimum "safe" values for these "min" variables? Can you suggest > such values? They don't have to be the _absolute_ minima, just safe > ones. There are no such values. These are Lisp constants and code or user customizations that set their values or bind them are invalid. Unfortunately, our tools are not strong enough to prevent that. And a doc-string that says This variable may be risky if used as a file-local variable. is misleading at the very least. Maybe we should emphasize in the documentations the fact that these are constants. These constants are here so that after we experience a crash with their specified values, we can fix the code without having to update all their occurrences. And they serve in the documentation to say that the values of the options 'window-min-width' and 'window-min-height' cannot be effectively less. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 10:28:28 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 15:28:28 +0000 Received: from localhost ([127.0.0.1]:34995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDWF-00008D-TN for submit@debbugs.gnu.org; Thu, 23 Feb 2023 10:28:28 -0500 Received: from mout.gmx.net ([212.227.17.21]:37187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDWD-00007s-Qw for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 10:28:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1677166098; i=rudalics@gmx.at; bh=3wp09UQsAcMGAHoid8mHKyBIK90IIXr6mB6iHi9s/JM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=PYIenEchogOsJzskZCxWEeWlqLodRMRY4fxE6vHtQYFC90DViptmUyIzTyZ3RqnGz Qrz8F3Pfz7SMtBBt+t1Kd/skuqn108ncjKl/BG//jBfmdhoIuZ7y1Zv4U71nJL45Yp lGQ1Dtw0Zs3p1UexBunXYbzhPAxc/YJLaiGbu041SSJcQCB9xTvb7x/mmkHrFZmKOi 5ihkc5DZML4c//cbSNM5gZw1xyHmi6vE5ykP5It9IsV5TXaatf4A6ejv/MSNH3dnWO NtPt57ksT9IMjfrJxHV4OUQou9tZVJwQTwP0s7vRi4XToyhfvZDa/hD/OelGQ0vjwv ifvCv3ISCPckg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.97.165]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M6Udt-1pSljv2EKP-006u8p; Thu, 23 Feb 2023 16:28:18 +0100 Message-ID: Date: Thu, 23 Feb 2023 16:28:17 +0100 MIME-Version: 1.0 Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv Content-Language: en-US To: Gregory Heytings , Po Lu References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <96b742a05d29fcf9a7d7@heytings.org> From: martin rudalics In-Reply-To: <96b742a05d29fcf9a7d7@heytings.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:sd4S0IghHmzcWu0jZdY1AC3vThlb5QcA8GaWLtzhMyjAuHCqGfw bnoh7D3Djg3yPjHFmfRQSDqMlZLqU5dUmZHN+nERLGokp/8aFYI+1aBtgRZYjhpGR+2Hw+i DJ+ZLPoD9DGRU5LKWM7y4TDAO5SXUz4Ji/nc1JEMRW2Zm5TSWoQclv9wKqu9IjB2f2J0PhI th0+ZafI+w3Nq4Uh5xIfw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:oXGPWaLxNns=;oBMy89ayn3WqX6WqN7u1uwDj6ja 9hHmHtrezZbKob/hnm6dWGTJeJrrLENdEZnyzTDXpCrlzZgoUQ/76TS96/0OztxYT+rZm9Gpm /32B5t4TRh73TTtUbIHUItTbpOfTjuXto0n8DQ9W4AFL0C3HetLCRLGREW9Two87HsrYQrlMT m8x9PxrzNOcIgJudqfOR1W0q9A/pQgOBQxL8pLTaCT4fFC/iK35vUvEirshNFgmL64wHnwxib GhQ8IsI16ZLnt6CSD6hTWaVSnAQqkKcXZl1leOGgIf4VQRySMLabPiwMl7e2GEscpts4B523F 3l3fYbxtMVOWatkurEu/m9UXhxkS/rHmS+0hLicJnE0ckKzwWFVHHC5VB0mwNhIKxRn9vq1zd gS486Y/VZS/KXnBrKqGfij+P2d84kEfOVGUZZFfgqXEMhWku/iAJTBRlWwJPHs9GRLpxlCKMb XgkWbLFv0xZsMhkwb1JjsyYHZK3lIELeA55LbmJruKQ8UDaWkwO2W8BuUDTBmta/Zi6xUC4xn pn8+cUMN5r0mY/yXTBRfPsOD+YXH6FfOaahOjrZ4FpRsvjuRI0zIb66oa7lN8WqLwSP899Z2x CpowXz7yyyCnnpq7aUc6uYyhFRtRdpKEBJ9CCMydb42aagQfWy9mSIiIxq0TJQ+bVqlDtNKdn NG/41dvxBPWxOqr/LZG8X+XN3Vur72KTk+xP1xE6AKABLxGRADVoIFk7hZNr6K1SruQQ3sl4G 7+OrlpfvpO+6P8XDUQcOXmGU1KDVbpY5fsCCAH/AThzElVC1COQ0rQI+66tacbiIjIY5zAdW8 JDtd4eHczfUJGsoi5EsNdkvn7d+xsq5EMdxJd7VTF4GJ9RecBZV073QjChRunrM3HMP3erGbs F/Iwb7GUFJBpKnqa5P0R3HEwcQ0dNN6fFphv/dHgcfVQRAkVhkxzuJ+MzxEgJtBzA/wz3vZWD DlcILV+5bNkQs3g9/qWVQir/pjc= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I maintain that the bug is (was) most probably not in get_narrowed_*. > I just built Emacs with the GTK, Lucid and no toolkits, I disabled > everything (tool-bar, menu-bar, scroll-bar, fringe-mode 0), and even > with that, after resizing the Emacs frame until it is literally a > single pixel on screen, I'm not able to get (under emacs -Q) a window > width or a height equal to 0 there. The smallest values I get are > width = 2 and height = 1. What you listed above is not likely to affect the height of a window - it's the header, mode and tab lines that count more. > That, the fact that this code has been there for a half year without a > single reported crash (if resizing a window is enough to trigger such > a crash, that would surely have happened already), and the fact that > get_narrowed_* is not executed at all in the ediff control frame, > means that there is a bug somewhere else. Don't worry. What Po Lu saw is something I've seen in different forms much earlier. Small frames can be a problem for redisplay. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 10:28:43 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 15:28:43 +0000 Received: from localhost ([127.0.0.1]:35000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDWU-00008l-NN for submit@debbugs.gnu.org; Thu, 23 Feb 2023 10:28:42 -0500 Received: from mout.gmx.net ([212.227.17.21]:47673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDWS-00008Y-E7 for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 10:28:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1677166113; i=rudalics@gmx.at; bh=Icn675Po6TkpwaPaQqWSRd3GDshzqcFz0b8Al0hfwi4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=nf1T/iBLhfuOzaZHGORPLaG1hzkZnLpcjIP6wFLtS/VIbT1ZtWa5pgIP94u++d+3k QQc48zdcx4zj7hxZ4PvE1EE2NRRz1KdpNMwfaI5djW0uyU97y8IhTm5c0mwgQFMjsS AtbfTL8lxEOmIqxq4fR91Anta65Tv6ERpmO0LKHN+RdEFfsAWLNu1AMTKWYRFaP6Fa TcmAbwuH+SkJ++a+QGnxncBeJUkVo0g1ELYXfEtKptGBg21J1jqeDtl7+Qg/0nEjjE lWzgIA9N5I9N3z/ktOSHBSW2eyfTAXutK5jmyLDajK+UY3fTz7tiWdjt03ntFaZ2zY dcHTkpIEefaYA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.97.165]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MHXBp-1pHnNo0Jer-00DYBA; Thu, 23 Feb 2023 16:28:33 +0100 Message-ID: Date: Thu, 23 Feb 2023 16:28:32 +0100 MIME-Version: 1.0 Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv Content-Language: en-US To: Po Lu References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <4eb8c0f7-558a-db4d-1989-afba973c2327@gmx.at> <874jrc7cnm.fsf@yahoo.com> From: martin rudalics In-Reply-To: <874jrc7cnm.fsf@yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:uXwaDbl/FInJrDFBeWBvFFkn3ib/WGELePc/YgQJJqWr6orqjHJ dnv1RLHiqg26yNxVUmaIbfxzBH1kMuq9KK67ddGPi12Yh2Ml5ehih0ydscmmbDJF19zI3z1 1gitXrRbt5EtapV7mpoClp0R1iJH1SovVBECsHjuFtn2cPd1cm8GXvfr41DK/swhytu58Z9 6t8eLUDc+93EmlFxKzaTQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8CUk+j+yIn0=;bkNT8twYLrskFx84d8cn+70couk zlKGPbNy/7hgcu56QaPUvbGuUBulaMCgQENFEZxakzD+3p+yH+LDHYcj5xD0gpy9H7IAZo7EL LGup/cyOPeSC6nXXdPSROPX6qkQkGLPS/FqRsl+YIth64K8B3OljtSTdoudsajpfKynSKjsr5 kwKiMCYOGJFbS/DtTosS7f+9i/sv8uBWm/YFSZu0diKpMeXCEVw/5Rovm6iB6jGDf8+GN2kki X0UwThdp4kuHkfbZ8NgkWEIYkxeOERYEtq7KPkCwLfyYdKDIoSgoahAoquiTpuCdRRIwnZ4cK ZI7pqt3T+h0CzAw+bM9qpGxZ9GxhUAXZE65QXA/s+WnKZlU0CmC4DBcRxvihNQiQNAG39kbKy W4JX/LBwE64axzf36cVMTauK8M/5uCfk7W0T0+RNfXJrC0GrSYo0qWCefDzxWy6czwt78bC80 WxYEhagHT/BKjhNXOfmNJD5OcThMs2Nm03Y/MV2fxrnoARvX5GNYIiTqCz72w3VMKuT/JB+3s jdydHD0MzGiqeywnhuxvqvHsh22AeRzZEZdBicq2uE6bwyyT6VpBM309h5J9988wQ7cUNr1vf 7Xe9tHDe60I7wbxjBnWnRRG0o3JBQQk6xXXmOXTxc4AgEHcy5HwUL9XXQINV61mvhfMJ3N1Ng BhSYtNLHWCYIXeEWgDOOV48E3d+WPM/WMPcYeubdq1JIh4/ijntvLhP1gtV0hgbVeO27XURAY hiwAqf+deD3DQBCCRv12hd+Y5Qho6K1k8SxdNumSWkx5jRy0A9Gy6jqJJ+Tb3mgfrKdE+wLed /kPKqV3ezeerlnPdXOH+rCpOWESfYKxDKb4/IzjfT8eNGJolDmW7Al1YBpHNaFm9t+8BKf57v RdVEpO1OHGLZJls1S2mj0sauxDlQm5XEVAASIhfFbhT6lr6FblIPZEpGB1z/byRy+IaJ94mCE WwHYeneBRk0F/I5lCDrPvogaHEI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61704 Cc: Eli Zaretskii , Gregory Heytings , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Which BTW is not entirely trivial to do. > The problem here is that Emacs should not crash, no matter what some > other X client, such as the WM, does. Right. Even if we have no proof that frame resizing is the culprit here. > X programs are traditionally expected to not crash when run under a > window manager that leaves features unimplemented, but to provide some > kind of graceful fallback instead. Right again. And that's why I said that > and OTOH the redisplay engine should be able to handle zero window > sizes to avoid crashes the window code cannot prevent. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 10:54:43 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 15:54:43 +0000 Received: from localhost ([127.0.0.1]:35050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDvf-0000sI-CZ for submit@debbugs.gnu.org; Thu, 23 Feb 2023 10:54:43 -0500 Received: from heytings.org ([95.142.160.155]:41624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVDvc-0000s9-S9 for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 10:54:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677167679; bh=dd5nZyaRkqxAF0kRY9dB80Av/p8MWePrF5TL0yCuMFs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=5gddqj4apvayKUQM4Nqa1n74+kfaeVyC74jJd93aIInrTpFypBecFZRo0KIYvvjdm 8fzUHSdiuDuvSvIAb3dGIrsHllHetyPZ1ku0JiG12T5qIfVVENPZPobwhOgq6Ugsqv PJXfdkvp4/XC/R4tcA6R3u8ndrj7e6G7f+nNIQsKz6vpGRYlC48mAED22/YutW87vh AmnmvJsVSo+8ShbC+EIruy1XGH+PXd+6BfeNbnCln9gCoWrMpFHA2knZC9cdBqVVGL tRENn4URo5iuQMEr8bzGfnh/imwKnUp8OqieBJD3n4Ha+kswdq1aJwaPtpHB9zQyXb rfJ8ekFDXWNqw== Date: Thu, 23 Feb 2023 15:54:39 +0000 From: Gregory Heytings To: martin rudalics Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv In-Reply-To: Message-ID: <96b742a05d89e5dd1aab@heytings.org> References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <96b742a05d29fcf9a7d7@heytings.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61704 Cc: Po Lu , Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I maintain that the bug is (was) most probably not in get_narrowed_*. I >> just built Emacs with the GTK, Lucid and no toolkits, I disabled >> everything (tool-bar, menu-bar, scroll-bar, fringe-mode 0), and even >> with that, after resizing the Emacs frame until it is literally a >> single pixel on screen, I'm not able to get (under emacs -Q) a window >> width or a height equal to 0 there. The smallest values I get are >> width = 2 and height = 1. > > What you listed above is not likely to affect the height of a window - > it's the header, mode and tab lines that count more. > Yes, I disabled all this to make sure the frame (and therefore the windows on the frame) would become as small as possible. I tested this with emacs -Q, with several windows on the frame displaying a buffer in which (long-line-optimizations-p) is non-nil, without any header line or tab line. Perhaps I should have tried to disable the mode-line. Let's see... M-: (setq mode-line-format nil) RET No, still no way to get a zero height or width. Increasing or decreasing the font size in the buffer also has no effect, I can't get a zero height or width. > > Don't worry. What Po Lu saw is something I've seen in different forms > much earlier. Small frames can be a problem for redisplay. > Indeed. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 12:42:02 2023 Received: (at 61704) by debbugs.gnu.org; 23 Feb 2023 17:42:02 +0000 Received: from localhost ([127.0.0.1]:35214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVFbV-0003qu-T7 for submit@debbugs.gnu.org; Thu, 23 Feb 2023 12:42:02 -0500 Received: from mout.gmx.net ([212.227.17.21]:33187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVFbT-0003qT-QM for 61704@debbugs.gnu.org; Thu, 23 Feb 2023 12:42:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1677174111; i=rudalics@gmx.at; bh=C0li2idATQDrAeb3Bwswut4e35twF0ZCbqzs3OXFS+o=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=GjFvjo9nKzn0UJ3ZmU86Z/ARq0uOOg9/USEb6dibE2I4cVEiL7OZErPS1wXHaPgGq YkCJ7edfoHHpGD6Bo9G5SqQuHHwh4FJdSp4YFKWno9y/rqx4rWe2YlskAJN+lWK+LR xums7mRPQtQLUO8VuHZxnCU2cfJJuJybd1zcU9FH5u/aoMXN5RPxtmcgAjxuMKoXcS uQ84C2byDA42lAh5S2Ir/bwGY5PYBjxVG4EHIIFwPfdziGe224THqzMdUzKYDKo8Ao leh4RDLFLzMw9bNz7V/pFCt0hcdM284TiEIQSD6Z2Li6M3xwmABT08XsFnoPbgRthh U3yfgI5UWjPqA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.102] ([212.95.5.124]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiTt-1p5iN806Dl-00TzRO; Thu, 23 Feb 2023 18:41:51 +0100 Message-ID: <779e4fd9-559b-df38-adc6-50930cf3a09f@gmx.at> Date: Thu, 23 Feb 2023 18:41:47 +0100 MIME-Version: 1.0 Subject: Re: bug#61704: 29.0.60; Crash in get_narrowed_begv Content-Language: en-US To: Gregory Heytings References: <874jrdq4ct.fsf.ref@po-lus-librem-15.mail-host-address-is-not-set> <874jrdq4ct.fsf@po-lus-librem-15.mail-host-address-is-not-set> <83cz61svnc.fsf@gnu.org> <834jrdstl4.fsf@gnu.org> <87bklkoh77.fsf@yahoo.com> <96b742a05d29fcf9a7d7@heytings.org> <96b742a05d89e5dd1aab@heytings.org> From: martin rudalics In-Reply-To: <96b742a05d89e5dd1aab@heytings.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:lKac8w+RyaWFwFyE1rFZaxXXDbtFpmnzEtTVyTFJLX17yrk5g76 FBe7/Nij7fQeztqj+HlXGF43N8ODej0ItpV7xefFOY4O71S/YC800DOUwWHqr451VepiUyE oH5vAeDBh+wcNiZoU5pr7Vdqp65hjvihL8Ta5Mmi8ncubLFkpgU+Db8CZ0HzDGgIUf1rGnj VxgPjVBS+TFQ/RltAlfdQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Bp36nZ/Xj8g=;nuLULev/BC0aIH1sZZq3431v4ry gIv6x0j2GrjMpIIRuyka1svto0VvoscD+mlKAm6yfjprl2eX4N0liQFJrVxIeZIpqcXd1zpH7 DjYT6QB22HHJ8Ivq3ud9PV5CDXDFwCN5T1zrR7GfgIPf54jRbT8SsvyO9kG4f+21GsmBtOzsQ 2Uv7Ya0HFr1a5gnYC2vMK8Utj2LNU6fw5/Si9Fwnju61BgWCmZ2XBRnl8cDl2PvRbcm9vO8D0 vfCF3MZmbuGeJ7X9ePY85GZneB+q+nSAYr0mvpegJP3PsiGkibpfRbL0BX0HAUuB4iS9P7oSl vxI6pTmW8SCTSRrjw5sCXmdCgdZNsdtbug5Lc0CIg+0YI5bybgDc1EYdo2YfHGzcSSzvolooH rEJ228EhEIJxMPpZHPc9gZssjc3h1vWJMKPq80UhlCgTBi+Ypr2BoTaM1OTQoul/hqil2fIKS cAwlTVtEXefcSmvAIZIla7b9EzBK2I8y7FeZfhanrFH4wC0QNkxOHwIFgqUqVftIaKPMe2W+t N67E3xgdZSmXiZTI+I0HFM56kZ26BPSBH+4ikz7QHG8ytsl3CQUciVqfJlXkqEPx/bGRs4YbL NROVcC+6Ojk7pLYdilGnsoQrTWVkEnpjMaIDhA2A6PeFCn+6mfPzOiLZFlUT3eabvKipJI1Wu PAq56AiJTwgXFSd3ZcbDobJZFtIFltSJFzeh6hRm94uUdQOl3CTA+MsSBe86LoqA2XVRrDP2r EarOwcTn65Ndfy0Bvp6KCy2W03eIU76dti4ZvdLaRJd/MY/WizFd0W9KDfTuEq3JZZsDATQI5 7SQvWQEaLOuLiTbC9Vt12S8+jTKOupETfhArQHFo/i0GqgbcQ6GP3FI8IpN/UIQQM+EbrmjQL nI7Edq8m806aoAycO7+UAeU2yf2Ta0IMz0JBt7bPrDNjVapINjaqFdXH6GZ7JTofWMmfJIfT9 4prQuB0Q0xt2JF8tKDvo4XP/fVY= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61704 Cc: Po Lu , Eli Zaretskii , 61704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Yes, I disabled all this to make sure the frame (and therefore the windows on the frame) would become as small as possible. I tested this with emacs -Q, with several windows on the frame displaying a buffer in which (long-line-optimizations-p) is non-nil, without any header line or tab line. > > Perhaps I should have tried to disable the mode-line. Let's see... > > M-: (setq mode-line-format nil) RET > > No, still no way to get a zero height or width. Increasing or decreasing the font size in the buffer also has no effect, I can't get a zero height or width. Disabling mode lines means you're working in the wrong direction. Frame resizing always tries to make windows at least one line high and two columns wide. You have to make a small window and make its mode lines tall. Then you have a chance to crash redisplay with macros like WINDOW_BOX_HEIGHT_NO_MODE_LINE and WINDOW_BOX_TEXT_HEIGHT that subtract mode line heights from a window's total height. martin