From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 23:55:19 2023 Received: (at submit) by debbugs.gnu.org; 22 Feb 2023 04:55:19 +0000 Received: from localhost ([127.0.0.1]:57720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUh9y-0000sH-N4 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 23:55:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:53714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUdmC-0003qM-76 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 20:18:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUdmB-0001sa-Aw for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 20:18:31 -0500 Received: from mx0b-00256a01.pphosted.com ([67.231.153.242]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUdm8-0004L4-E1 for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 20:18:31 -0500 Received: from pps.filterd (m0119691.ppops.net [127.0.0.1]) by mx0b-00256a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31LLmdkd037661 for ; Tue, 21 Feb 2023 20:18:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nyu.edu; h=from : to : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=20180315; bh=rfk3WhTy4s0Naa6XA1CKvBzkdH11lGaCPYeSE8i+Sts=; b=BRmwylkx8kfPhE2rGKmHxtvex7Erti7M6I7SkXRLaab0st7Iykg8nQq+5Sj55jG0sbpg VatGIwayvkE9lF2FoYxj/zeZbHX14jKZuUJ0Dj3QRmqfOr87K4auHkLrzUexMNz8f56s 5+XdKz1OJiP4YQJcUx0FSDvCVTTr3mx1Avfxc4oa69xYJQBI60cyozztgkkVdOhj/SGh Pc3vLjxx8YglpaN/Hq5hVn2uTum/SwzK2MFdm6DNvU/cPR0dwyT76MPkVr6yAkoQQVZf uLG9xmLs5+UkhqEmYa8DimQO0j0itC2YLCBylorRnfsw157kt1Rk9nPbSKlaRnmthGLO IA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0b-00256a01.pphosted.com (PPS) with ESMTPS id 3nw15bntvb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 21 Feb 2023 20:18:22 -0500 Received: by mail-pg1-f199.google.com with SMTP id 10-20020a63030a000000b004fb64e929f2so2263757pgd.7 for ; Tue, 21 Feb 2023 17:18:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rfk3WhTy4s0Naa6XA1CKvBzkdH11lGaCPYeSE8i+Sts=; b=Z3b4omWdQL4btvwKuVxPcqULRp/dH5SK+avRYKyIkQoa8nvfOV7bUJy6or8E+rRQYp OgIB+8jqK3R4D3fXIUpu8UKy0hIn0t8BfgiiiQ1rjhgpnAer9RzN6WmmL/xdoalvOo/H 0aVQhfy/xTAfSIFQ/fUhwIprn7yc1D3VK6CXd+w8xWuu75rsVKWgXi4+Ufbihkl3U+/z qJ7UwEQ6t26fjH9LU1WkwuHFI6/2ru2aJSyYBLGBVKjHWnlGAarS75HH7wsyyuGeuQwa MiiWmuHXe9vN5VemOGXHOR1FBoqy9VCrXZcdSZ+vFJfXo8CdFyCpRKgTYw789OqZa71Z CSXQ== X-Gm-Message-State: AO0yUKUV+Z8kWwtCp7K8krXDjrqwqMSdmrdBm2DtfhSY9cW/uBk0fewW AvZER+QHaIXF9/Dr5T2jK9nOv723YhC/h9VQeEhhBYi7hTjg7rSGNJEiLcepMFLTtykVisNJ6TD FLSossC40ecx6AKc7bYs= X-Received: by 2002:a17:903:41d1:b0:19a:a2d8:f252 with SMTP id u17-20020a17090341d100b0019aa2d8f252mr9024505ple.27.1677028700937; Tue, 21 Feb 2023 17:18:20 -0800 (PST) X-Google-Smtp-Source: AK7set8arHQEEGoxE2dWOTiuz5jEQj4bgMmjPLQpm3X7Qpj6Aoy28OtF3TJ31fom2695KdW8RXlsmw== X-Received: by 2002:a17:903:41d1:b0:19a:a2d8:f252 with SMTP id u17-20020a17090341d100b0019aa2d8f252mr9024485ple.27.1677028700477; Tue, 21 Feb 2023 17:18:20 -0800 (PST) Received: from localhost ([164.152.142.89]) by smtp.gmail.com with ESMTPSA id ij8-20020a170902ab4800b0019607aeda8bsm4128440plb.73.2023.02.21.17.18.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 17:18:20 -0800 (PST) From: Josh Moller-Mara To: bug-gnu-emacs@gnu.org Subject: 30.0.50; insert-kbd-macro fails for named macro but not last macro Date: Tue, 21 Feb 2023 17:18:16 -0800 Message-ID: <87wn4amraf.fsf@cns.nyu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 7kSgWuMEIxr3awvjkXJrfXIsGLXcKxsg X-Proofpoint-GUID: 7kSgWuMEIxr3awvjkXJrfXIsGLXcKxsg X-Orig-IP: 209.85.215.199 X-Proofpoint-Spam-Details: rule=outbound_bp_notspam policy=outbound_bp score=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1011 mlxscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302220007 Received-SPF: softfail client-ip=67.231.153.242; envelope-from=jmm1211@nyu.edu; helo=mx0b-00256a01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 21 Feb 2023 23:55:10 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Using =E2=80=9CM-x insert-kbd-macro=E2=80=9D can insert an incorrect kmacro= form for a named macro, while still correctly inserting the =E2=80=9Clast-kbd-macro=E2= =80=9D. To see this, we=E2=80=99ll define a macro that simply inserts the HTML stri= ng =E2=80=9Chello=E2=80=9D (press F3, type the previous string, then pr= ess F4). We=E2=80=99ll name this macro =E2=80=9Cbold-hello=E2=80=9D using =E2=80=9CC= -x C-k n=E2=80=9D. Inserting the definition to the last macro (using =E2=80=9CM-x insert-kbd-m= acro=E2=80=9D and leaving the prompt blank) returns: (setq last-kbd-macro (kmacro "< b > H e l l o < / b >")) Inserting the definition to =E2=80=9Cbold-hello=E2=80=9D (using =E2=80=9CM-= x insert-kbd-macro=E2=80=9D and typing =E2=80=9Cbold-hello=E2=80=9D at the prompt) returns: (defalias 'bold-hello (kmacro " H e l l o < / b >")) Notice the difference in =E2=80=9C< b >=E2=80=9D vs =E2=80=9C=E2=80=9D. = The =E2=80=9Cbold-hello=E2=80=9D command doesn=E2=80=99t work, printing the message: =E2=80=9CAfter 0 kbd macro iterations: Keyboard macro terminated by a comma= nd ringing the bell=E2=80=9D I think this may have to do with the use of =E2=80=9Ckey-parse=E2=80=9D in = =E2=80=9Ckmacro=E2=80=9D (see =E2=80=9C(find-function 'kmacro)=E2=80=9D). (key-parse "hello") returns =E2=80=9C[b 104 101 108 108 111 60 47 98 62]=E2=80=9D but (macro--string-to-vector "hello") returns =E2=80=9C[60 98 62 104 101 108 108 111 60 47 98 62]=E2=80=9D The latter form is used in =E2=80=9Cinsert-kbd-macro=E2=80=9D when inserting =E2=80=9Clast-kbd-macro=E2=80=9D. You can also quickly replicate the issue by evaluating the following form: (progn (setq last-kbd-macro "hello") (kmacro-name-last-macro 'bold-hello) (let ((temp-buffer (generate-new-buffer "*macros*"))) (with-current-buffer temp-buffer (insert-kbd-macro (intern "")) (insert-kbd-macro 'bold-hello)) (display-buffer temp-buffer))) In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.16.0) Repository revision: 2c7e87c73a90effab66fa7c783855199880315d3 Repository branch: master System Description: NixOS 22.11 (Raccoon) Configured using: 'configure --prefix=3D/nix/store/bdg6d4gm3ma2hja63hbxwrkaap04j2c6-emacs-pgtk-20230217= .0 --disable-build-details --with-modules --with-pgtk --with-native-compilation' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 04:21:14 2023 Received: (at 61700) by debbugs.gnu.org; 23 Feb 2023 09:21:14 +0000 Received: from localhost ([127.0.0.1]:32943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV7mr-0001jm-Rn for submit@debbugs.gnu.org; Thu, 23 Feb 2023 04:21:14 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:40753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pV7mq-0001jX-TT for 61700@debbugs.gnu.org; Thu, 23 Feb 2023 04:21:13 -0500 Received: by mail-wm1-f42.google.com with SMTP id az11-20020a05600c600b00b003dc4fd6e61dso9390432wmb.5 for <61700@debbugs.gnu.org>; Thu, 23 Feb 2023 01:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=94Mtaaz4LCdCVuBIw2kjVzKhSgypkIO3FQHUlf2o+hg=; b=Ti/6RZUVUGVpVfkq7k4voXUCUf5436r8d3ki1GZFwwm4d9K7ujSFnXPHuALeRO1JFg ydkX7R7dhKoVan5Bj8KH7QTFxOkOJ6wHW1Dwh07iuEBthaa85rsRke76A5qrCjJL0e4S JLwbGgNJ8lcFuusf10zkJWDyLagTASyy5Ss9w9C066BYmRFQlqJjdG1vDzsQkWOpOtXc cZlCcchkxLf6nnNfuxBa+GdqIWwnC2RVS3GUhQp7C7YdvSg5yz3YW0NbblVlpjiqi+bR +z2P6SlMrmz9ZmUiM5lP1w49fDVlW7VooAMjn41PZMTZeDiC6vrUFdAk0RgVVWGOmF8A 1h1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=94Mtaaz4LCdCVuBIw2kjVzKhSgypkIO3FQHUlf2o+hg=; b=vDlhm3DZJOFbm8A+AIUbc/RLERrd0iVBLG5oY0QIalovI4xZ3lUXCn1Sf+LiXb0gmj SHnhs5D+3Q3Uy2rUPbK2Upy7o8F/Qtgb5IbYp/9ZqGlDIvjrQ/pcrdsTnWbG4eZL59oJ tEnoMMbfVTd86cXXJECvToSjHNqh9EcbKdngNAOoK5ms21yG21Ktthlh/77FYp+VbBA6 KMQIwQPrCNlqSPWs2NJXjg6Z4Ich0jQxWBIOwXmnU/RPVykE6mwVFTTVrAjM1+tBRNHo 0mFOYZUYJ0MROq9vQ8sq2eqlGjmlYesRyA69OO6BVSKMYg1jaJTacGXm0oJdQpGA2Q88 7vvQ== X-Gm-Message-State: AO0yUKWUbgAiY1Ym9NJrAoxGdeKsloTsiocNg5DqxO5eq1oJDnIETrAb TF40ATPMArox3AeV2ux92rU= X-Google-Smtp-Source: AK7set+8vfTNwYpAESVDl526CQFcAfF3Aqo0RUXSFY0daVF5VuOcdu0awFrZocXbDBsX5EajRoIF2w== X-Received: by 2002:a05:600c:4495:b0:3dc:5a7c:f8ad with SMTP id e21-20020a05600c449500b003dc5a7cf8admr3336016wmo.21.1677144066515; Thu, 23 Feb 2023 01:21:06 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id j8-20020a5d6048000000b002c553e061fdsm12075846wrt.112.2023.02.23.01.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 01:21:05 -0800 (PST) From: Robert Pluim To: Josh Moller-Mara Subject: Re: bug#61700: 30.0.50; insert-kbd-macro fails for named macro but not last macro In-Reply-To: <87wn4amraf.fsf@cns.nyu.edu> (Josh Moller-Mara's message of "Tue, 21 Feb 2023 17:18:16 -0800") References: <87wn4amraf.fsf@cns.nyu.edu> Date: Thu, 23 Feb 2023 10:21:05 +0100 Message-ID: <87wn4891q6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61700 Cc: 61700@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 21 Feb 2023 17:18:16 -0800, Josh Moller-Mara said: Josh> Using =E2=80=9CM-x insert-kbd-macro=E2=80=9D can insert an incorr= ect kmacro form for a Josh> named macro, while still correctly inserting the =E2=80=9Clast-kb= d-macro=E2=80=9D. Josh> To see this, we=E2=80=99ll define a macro that simply inserts the= HTML string Josh> =E2=80=9Chello=E2=80=9D (press F3, type the previous strin= g, then press F4). Josh> We=E2=80=99ll name this macro =E2=80=9Cbold-hello=E2=80=9D using = =E2=80=9CC-x C-k n=E2=80=9D. Josh> Inserting the definition to the last macro (using =E2=80=9CM-x in= sert-kbd-macro=E2=80=9D Josh> and leaving the prompt blank) returns: Josh> (setq last-kbd-macro Josh> (kmacro "< b > H e l l o < / b >")) Josh> Inserting the definition to =E2=80=9Cbold-hello=E2=80=9D (using = =E2=80=9CM-x insert-kbd-macro=E2=80=9D Josh> and typing =E2=80=9Cbold-hello=E2=80=9D at the prompt) returns: Josh> (defalias 'bold-hello Josh> (kmacro " H e l l o < / b >")) Josh> Notice the difference in =E2=80=9C< b >=E2=80=9D vs =E2=80=9C= =E2=80=9D. The =E2=80=9Cbold-hello=E2=80=9D command Josh> doesn=E2=80=99t work, printing the message: Josh> =E2=80=9CAfter 0 kbd macro iterations: Keyboard macro terminated = by a command ringing the bell=E2=80=9D Josh> I think this may have to do with the use of =E2=80=9Ckey-parse=E2= =80=9D in =E2=80=9Ckmacro=E2=80=9D (see Josh> =E2=80=9C(find-function 'kmacro)=E2=80=9D). Josh> (key-parse "hello") returns Josh> =E2=80=9C[b 104 101 108 108 111 60 47 98 62]=E2=80=9D Josh> but Josh> (macro--string-to-vector "hello") returns Josh> =E2=80=9C[60 98 62 104 101 108 108 111 60 47 98 62]=E2=80=9D Josh> The latter form is used in =E2=80=9Cinsert-kbd-macro=E2=80=9D whe= n inserting Josh> =E2=80=9Clast-kbd-macro=E2=80=9D. This fails in emacs-29 as well. Stefan, you rewrote this code to use oclosures, any ideas? I guess we could just use macro--string-to-vector in both cases, but you=CA=BCre the expert here :-) Josh> You can also quickly replicate the issue by evaluating the follow= ing Josh> form: Josh> (progn Josh> (setq last-kbd-macro "hello") Josh> (kmacro-name-last-macro 'bold-hello) Josh> (let ((temp-buffer (generate-new-buffer "*macros*"))) Josh> (with-current-buffer temp-buffer Josh> (insert-kbd-macro (intern "")) Josh> (insert-kbd-macro 'bold-hello)) Josh> (display-buffer temp-buffer))) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 07:59:51 2023 Received: (at 61700) by debbugs.gnu.org; 23 Feb 2023 12:59:51 +0000 Received: from localhost ([127.0.0.1]:33328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBCQ-0004HP-Qt for submit@debbugs.gnu.org; Thu, 23 Feb 2023 07:59:51 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:38562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVBCO-0004HB-Lg for 61700@debbugs.gnu.org; Thu, 23 Feb 2023 07:59:49 -0500 Received: by mail-wr1-f48.google.com with SMTP id i11so4448885wrp.5 for <61700@debbugs.gnu.org>; Thu, 23 Feb 2023 04:59:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NM2yzZASDyajNvJxq4VWz1aw+Bm0x+FnZBkV+991hXc=; b=DXD75RI+VfxJDMqpq7zq3NgIYHKJ0UgSKbzagsoRi1AI1NmY/P0jOREm3dKocfJ3Lq OfzFOIIth4Y5XzZIwRq6j6fshhe1i9KB6eSL1bfqSfuOy4tuZqA/RbsBNPHOHDQB31wP jv1jSC1mK59IdXpsWxNejEQxQzYA/PkK4lBME59RekpYXd0mMYpFqYLgQu5cVe92YNDu 5Ws3ro7X4D05fWy8+0RW34oVyk1QKkeNuVRVWIEB1hIoc8IkGqlsdfn8AVZRoiMOF0/r fyY7q2NK8FwwzTmYewbXeR8n5SG3W61iEVUxZr/JrbzqbSyWVSROxPFmLKxjjBwgSnBX HP9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NM2yzZASDyajNvJxq4VWz1aw+Bm0x+FnZBkV+991hXc=; b=pWoiJ6zVLgtWG3EVy+mGkxRjPo36Oi2K4sbr14oZoaxU0BqqRR/WI8BNCB9s49gRP4 xpRaOrPQ8vGheTpGXYI2z38eRBK4CvQ/YWqzoKkYGxuWtgiOnE08wCp2BpJJdlGA3f9I ovljgpQ1QenDxXVOOeNESOQUVZVNL7+ZRbw+HqE4TbzHol88+3jKXzQYIRoTvvQYhnvm jp8eRjaBP+maue+5UbFjKWsPHqc/7giDrzw8J6PlDVMcHsQ8eSGF/Lz2DtQ6rSihdMcl 7JIoDi8G34q07+c7DBUbmJ2gngmYctl9mvrPOPRmzWkKbnNWyzV/D7cMwRy+GG/EEdRC 6OiQ== X-Gm-Message-State: AO0yUKV+vMs32TpO/d9ZAYibsXlVw2AcZ9ooFCbcAhShXSgnEeMtDeI+ /9rcmRqCGZprF4Qqemp0yf4= X-Google-Smtp-Source: AK7set+9K/Da4fxjDBHijtDxE+yRN8gBEFih8uK9KL2zdiX0uuL1dKHMrdJxEKmJImQ/OoCSVJwssQ== X-Received: by 2002:a5d:6150:0:b0:2c5:63df:1171 with SMTP id y16-20020a5d6150000000b002c563df1171mr11384883wrt.19.1677157182349; Thu, 23 Feb 2023 04:59:42 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id r13-20020adfdc8d000000b002c557f82e27sm8406645wrj.99.2023.02.23.04.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 04:59:41 -0800 (PST) From: Robert Pluim To: Josh Moller-Mara Subject: Re: bug#61700: 30.0.50; insert-kbd-macro fails for named macro but not last macro In-Reply-To: <87wn4891q6.fsf@gmail.com> (Robert Pluim's message of "Thu, 23 Feb 2023 10:21:05 +0100") References: <87wn4amraf.fsf@cns.nyu.edu> <87wn4891q6.fsf@gmail.com> Date: Thu, 23 Feb 2023 13:59:40 +0100 Message-ID: <87r0ug8rlv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61700 Cc: 61700@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 23 Feb 2023 10:21:05 +0100, Robert Pluim s= aid: Robert> This fails in emacs-29 as well. Stefan, you rewrote this code to Robert> use oclosures, any ideas? I guess we could just use Robert> macro--string-to-vector in both cases, but you=CA=BCre the expe= rt here :-) The following passes 'make bootstrap' and 'make check'. I=CA=BCve probably committed a heinous crime by autoloading an internal function, but that seemed cleaner than "(require 'macros)" in two places. Robert --=20 diff --git c/lisp/kmacro.el i/lisp/kmacro.el index 94d8794bd23..411f981d47b 100644 --- c/lisp/kmacro.el +++ i/lisp/kmacro.el @@ -380,7 +380,10 @@ kmacro-view-item-no (defun kmacro-ring-head () "Return pseudo head element in macro ring." (and last-kbd-macro - (kmacro last-kbd-macro kmacro-counter kmacro-counter-format-start))) + (kmacro (if (stringp last-kbd-macro) + (macro--string-to-vector last-kbd-macro) + last-kbd-macro) + kmacro-counter kmacro-counter-format-start))) =20 =20 (defun kmacro-push-ring (&optional elt) @@ -841,8 +844,6 @@ kmacro-lambda-form (setq mac (nth 0 mac))) (when (stringp mac) ;; `kmacro' interprets a string according to `key-parse'. - (require 'macros) - (declare-function macro--string-to-vector "macros") (setq mac (macro--string-to-vector mac))) (kmacro mac counter format))) =20 diff --git c/lisp/macros.el i/lisp/macros.el index 59c7796551f..e00aedc82b0 100644 --- c/lisp/macros.el +++ i/lisp/macros.el @@ -46,6 +46,7 @@ macros--insert-vector-macro " ") ?\])) =20 +;;;###autoload (defun macro--string-to-vector (str) "Convert an old-style string key sequence to the vector form." (let ((vec (string-to-vector str))) diff --git c/test/lisp/kmacro-tests.el i/test/lisp/kmacro-tests.el index 551fd8b60fc..a325220e8d9 100644 --- c/test/lisp/kmacro-tests.el +++ i/test/lisp/kmacro-tests.el @@ -614,6 +614,20 @@ kmacro-tests-name-last-macro-bind-and-rebind (kmacro-tests-should-insert "bb" (kmacro-tests-simulate-command '(kmacro-tests-symbol-for-test)))) =20 +;; Bug#61700 inserting named macro when the definition contains things +;; that `key-parse' thinks are named keys +(kmacro-tests-deftest kmacro-tests-name-last-macro-key-parse-syntax () + "Name last macro can rebind a symbol it binds." + ;; Make sure our symbol is unbound. + (when (fboundp 'kmacro-tests-symbol-for-test) + (fmakunbound 'kmacro-tests-symbol-for-test)) + (setplist 'kmacro-tests-symbol-for-test nil) + (kmacro-tests-define-macro " hello ") + (kmacro-name-last-macro 'kmacro-tests-symbol-for-test) + ;; Now run the function bound to the symbol. + (kmacro-tests-should-insert " hello " + (kmacro-tests-simulate-command '(kmacro-tests-symbol-for-test)))) + (kmacro-tests-deftest kmacro-tests-store-in-register () "Macro can be stored in and retrieved from a register." (use-local-map kmacro-tests-keymap) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 11:00:52 2023 Received: (at 61700) by debbugs.gnu.org; 23 Feb 2023 16:00:52 +0000 Received: from localhost ([127.0.0.1]:35072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVE1c-00013X-GO for submit@debbugs.gnu.org; Thu, 23 Feb 2023 11:00:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVE1a-00013J-Cj for 61700@debbugs.gnu.org; Thu, 23 Feb 2023 11:00:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVE1T-0005gM-Op; Thu, 23 Feb 2023 11:00:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XEagxzi9caI955P1G3+WWYIiCQjIica8ubwh2DBkpq4=; b=h95TFThMZStwk+o0Iskn sSrFkslHbJS4s1OFqLTKXJvkG4SWFEgLRjkx7m8/rvsuQjGk/q3WkAvWWQGu6iI/B3jGB9kAFDW/8 iOY3083rxXQZbe34oPaW8Mfq2d+Fnx0LFYMR/9C+v9KE4/AMdn8f4s53Dh2kuLDJQ8RHxRFi3waTa LSnVtFnkuqCYsXCldoUFfRcMILDaa8TmH9ZMtiYeQ0lyYvEqyOuWSo2TxH11Ziibt+D6cyt0q07jZ etN4o4Ki/1YUbY8SZxoQUGwXrZm+CzX5giOkqoftA2sLQ2VwbvgOQ5BpJqS1awZzn4dLMTAZMMjkB TXa7nEjZxLZIUA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVE1T-00062x-3k; Thu, 23 Feb 2023 11:00:43 -0500 Date: Thu, 23 Feb 2023 18:00:39 +0200 Message-Id: <83r0ugpe1k.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87r0ug8rlv.fsf@gmail.com> (message from Robert Pluim on Thu, 23 Feb 2023 13:59:40 +0100) Subject: Re: bug#61700: 30.0.50; insert-kbd-macro fails for named macro but not last macro References: <87wn4amraf.fsf@cns.nyu.edu> <87wn4891q6.fsf@gmail.com> <87r0ug8rlv.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61700 Cc: 61700@debbugs.gnu.org, jmm@cns.nyu.edu, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 61700@debbugs.gnu.org, Stefan Monnier > From: Robert Pluim > Date: Thu, 23 Feb 2023 13:59:40 +0100 > > Iʼve probably committed a heinous crime by autoloading an internal > function, but that seemed cleaner than "(require 'macros)" in two > places. Why not use an explicit autoload form in kmacro.el and kmacro-tests.el instead? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 11:30:17 2023 Received: (at 61700) by debbugs.gnu.org; 23 Feb 2023 16:30:17 +0000 Received: from localhost ([127.0.0.1]:35119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVEU5-0001o6-0I for submit@debbugs.gnu.org; Thu, 23 Feb 2023 11:30:17 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:39542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVEU3-0001nr-Iu for 61700@debbugs.gnu.org; Thu, 23 Feb 2023 11:30:16 -0500 Received: by mail-wr1-f43.google.com with SMTP id r7so10972818wrz.6 for <61700@debbugs.gnu.org>; Thu, 23 Feb 2023 08:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fayGXEPgJI9xVb4o1Oo9KMEqJ6KNzz0vt/xZwqj62JQ=; b=h5hQmsxRNd1ZR4KIw6OzinpX2KgWp2O/6v3u9gF7YXCq/8v6cWtLjZDJ07rNIt/BlS Q/nxDdnpefNZweQOae14hryRDCPAZ44Fgpmg/WqFQYm7P8CarQViKAlnBImV2P28vmdj lPSehuDt+XpN2mLaoqhs9DybpJ7wM/xE1Pqf2qDNO7l5BNjjw0lImFUYMLbqLCRkvigh XNi+a6Iu0wkX8ZrVd+nvEY24kTZ36iQJjJsJm9l5YQKqmysNSsevgB9k7fR0GmhO27Rg WmAMnxYuyffpZBeB90pHfnwLt+oer36dbjSTd8HKkRAMsHavEHSd6D8a0XJAWsNSmjsc BOcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fayGXEPgJI9xVb4o1Oo9KMEqJ6KNzz0vt/xZwqj62JQ=; b=xwydTEQsm5hg6pujTbCzPz4zBp9s4YT7xjNGVtctYej42AiYB9jYNl6jT3I0x9xdQd aCWcds3zChOtQazbWFkZz7a8SyKxgwAmk41AUDSXJPYZyy2QPK0Il1ZtBh+2VACyB49m Vr3hMhQwar/RnLIuNLNcyBJpWxKPAtmnalcpx0ICNA6c4iuOUuFLLjQZHEg9RBZSPsFD NkjPA52Wpy4Rj2SlTN08JJ0on/pMP2+VNocFf0TUmNrsMwu0QzM8boShLhjJTLNiIRFC XLUPxq+aeg60ntNl/+6i9UViDYih7Zv8o4xwzI5tRkChlOFhcLCdc9udWIcv14vDpsFw Q7Ig== X-Gm-Message-State: AO0yUKUYhpfjopvqvho30dGmYVI6e2fu4dDmfQ3nbzY3CtbjHRFNLegd Q0XcDn4F8IKbDBlVQE/VIFM= X-Google-Smtp-Source: AK7set8Np1ze7nthagZy2EDjpyUGrEYsY41PhNYV9xsbtgGRrTv4ZwIHURE+cRoFWD34NOWXY09Xuw== X-Received: by 2002:a5d:4dce:0:b0:2c4:503:7afc with SMTP id f14-20020a5d4dce000000b002c405037afcmr12141598wru.7.1677169809407; Thu, 23 Feb 2023 08:30:09 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id o11-20020a05600c510b00b003e1f2e43a1csm12576059wms.48.2023.02.23.08.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 08:30:08 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#61700: 30.0.50; insert-kbd-macro fails for named macro but not last macro In-Reply-To: <83r0ugpe1k.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 Feb 2023 18:00:39 +0200") References: <87wn4amraf.fsf@cns.nyu.edu> <87wn4891q6.fsf@gmail.com> <87r0ug8rlv.fsf@gmail.com> <83r0ugpe1k.fsf@gnu.org> Date: Thu, 23 Feb 2023 17:30:07 +0100 Message-ID: <875ybs8hv4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61700 Cc: 61700@debbugs.gnu.org, jmm@cns.nyu.edu, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 23 Feb 2023 18:00:39 +0200, Eli Zaretskii said: >> Cc: 61700@debbugs.gnu.org, Stefan Monnier >> From: Robert Pluim >> Date: Thu, 23 Feb 2023 13:59:40 +0100 >>=20 >> I=CA=BCve probably committed a heinous crime by autoloading an inter= nal >> function, but that seemed cleaner than "(require 'macros)" in two >> places. Eli> Why not use an explicit autoload form in kmacro.el and kmacro-test= s.el Eli> instead? Sure, that works as well (although I don=CA=BCt understand why kmacro-tests would need an autoload if there=CA=BCs one in kmacro.el). Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 11:44:19 2023 Received: (at 61700) by debbugs.gnu.org; 23 Feb 2023 16:44:19 +0000 Received: from localhost ([127.0.0.1]:35152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVEhf-0002BG-9a for submit@debbugs.gnu.org; Thu, 23 Feb 2023 11:44:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVEhd-0002B3-On for 61700@debbugs.gnu.org; Thu, 23 Feb 2023 11:44:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVEhX-0002vO-5E; Thu, 23 Feb 2023 11:44:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=v3uimUg53IswwlFuC8rVSE/f9IaMKUFXMHKTI4Y/59g=; b=YdUNgOcwJmliUX2K20P0 Qjskr3cE6E1w5fAc4s9jMoL/HIxN+qahLGHf0lrC/A1x4OK8QJ60Rfggc5vvoYj8vyhJGWJq9pc42 3TZz6iRdATBJ66/k7ZYzzhhPQD1htfLDhdmItpOXH9BTTfn65rfLL0k3PUrYzlH7ff/3ZhWCtFaQR xov8UVQrSKQ/YVKMbHTPUQKCUHud4bvfLTACexvwQgx8azjv/T9eX72iOgMIuGW3trjStUrW1qbm7 oDDWoM2nd7Bo/RBN0o4FvyYNecl4NMN9aGzQFq0+LKKZ0Ml0shgfrg6PGp3ljkdi8P5q/Kmzv/4XP bsyNggXBBtvu1g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVEhW-0005yn-Dx; Thu, 23 Feb 2023 11:44:10 -0500 Date: Thu, 23 Feb 2023 18:44:08 +0200 Message-Id: <83mt54pc13.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <875ybs8hv4.fsf@gmail.com> (message from Robert Pluim on Thu, 23 Feb 2023 17:30:07 +0100) Subject: Re: bug#61700: 30.0.50; insert-kbd-macro fails for named macro but not last macro References: <87wn4amraf.fsf@cns.nyu.edu> <87wn4891q6.fsf@gmail.com> <87r0ug8rlv.fsf@gmail.com> <83r0ugpe1k.fsf@gnu.org> <875ybs8hv4.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61700 Cc: 61700@debbugs.gnu.org, jmm@cns.nyu.edu, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: jmm@cns.nyu.edu, 61700@debbugs.gnu.org, monnier@iro.umontreal.ca > Date: Thu, 23 Feb 2023 17:30:07 +0100 > > >>>>> On Thu, 23 Feb 2023 18:00:39 +0200, Eli Zaretskii said: > > >> Cc: 61700@debbugs.gnu.org, Stefan Monnier > >> From: Robert Pluim > >> Date: Thu, 23 Feb 2023 13:59:40 +0100 > >> > >> Iʼve probably committed a heinous crime by autoloading an internal > >> function, but that seemed cleaner than "(require 'macros)" in two > >> places. > > Eli> Why not use an explicit autoload form in kmacro.el and kmacro-tests.el > Eli> instead? > > Sure, that works as well (although I donʼt understand why kmacro-tests > would need an autoload if thereʼs one in kmacro.el). Maybe it doesn't I just assumed it might. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 13:29:10 2023 Received: (at 61700) by debbugs.gnu.org; 23 Feb 2023 18:29:10 +0000 Received: from localhost ([127.0.0.1]:35285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVGL8-0007aL-2t for submit@debbugs.gnu.org; Thu, 23 Feb 2023 13:29:10 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVGL6-0007a8-8Q for 61700@debbugs.gnu.org; Thu, 23 Feb 2023 13:29:08 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7E2E81000C3; Thu, 23 Feb 2023 13:29:02 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A708B1000BC; Thu, 23 Feb 2023 13:29:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1677176940; bh=qEWYN6qPTjHs/woUaq19TtGKNNedi5mgK49Z/VU0nKQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CDY5s1peQXeVGpE86sNhWgeAGQw356QMRJfC+lz9DVLATdPNNCmd0ONSLNZZ+DvYJ AOdG64pWK7rD68n0ryLQLwrsyW1C+fRuDfW9Vm6O2lLYecqPvK5S+OowcJDfCFUg1o d1i2ogDkPRMAug6LRFAOVVwwX3MfANksk2jvEpkk7DF8UayHpLeWS+5MECpjtTAJFM 7XvYiOfbGtD5afZaGbCHyB12oRXeGz16Dlp34ClPapfBSjMYyzOk1GAW36ZWYIGyUu 14mrbpZqtdcKWcnbnAeB2oC2SW3JP3irxPrJKNg1GDxNsgDB0pvNU1oi3y4yCgLBtq llz+s93WRJ/fQ== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 73E8A123243; Thu, 23 Feb 2023 13:29:00 -0500 (EST) From: Stefan Monnier To: Robert Pluim Subject: Re: bug#61700: 30.0.50; insert-kbd-macro fails for named macro but not last macro In-Reply-To: <87r0ug8rlv.fsf@gmail.com> (Robert Pluim's message of "Thu, 23 Feb 2023 13:59:40 +0100") Message-ID: References: <87wn4amraf.fsf@cns.nyu.edu> <87wn4891q6.fsf@gmail.com> <87r0ug8rlv.fsf@gmail.com> Date: Thu, 23 Feb 2023 13:28:58 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61700 Cc: 61700@debbugs.gnu.org, Josh Moller-Mara X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The following passes 'make bootstrap' and 'make check'. Looks right to me, thank you. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 05:44:46 2023 Received: (at 61700) by debbugs.gnu.org; 24 Feb 2023 10:44:46 +0000 Received: from localhost ([127.0.0.1]:36020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVVZE-0008UK-Ke for submit@debbugs.gnu.org; Fri, 24 Feb 2023 05:44:46 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:42969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVVZC-0008Tz-OD; Fri, 24 Feb 2023 05:44:43 -0500 Received: by mail-wr1-f44.google.com with SMTP id j2so13269977wrh.9; Fri, 24 Feb 2023 02:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=I0Kek+CfbMkPHl+i7GnhcqxtJmYBjppTj/6H9LfyLRg=; b=X7KSiSDdzfHsOzeTcm14UmbLN/klMduhnVxCDLQkVZjdI+QkgCbcBzcEECR/7uCNKS XuvWdKacBXATTuIVJxq3Fbj9EkCATzPYOGHnl9yeeZmx9BtItLzELscw5vdx9pF+1kpQ 5JRuPu5khKbIJ8AZlh26oci7QnjghCouDXlMNwOQBCZrnj51A72994ycWNO8isBnyUyp eVUzEIPBsTXVXDbIdbxGnASLvVCxjZYyr1yTnzdB2E9WUH4ImiEXcXFuyu8s9e4eIgdM S18V4v1H2AmLsFq3DWP09PNoaApOtLfuPhjxy0ikLPtAgqi1i2M1lnnmq6W6R+Ry6z5g vEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I0Kek+CfbMkPHl+i7GnhcqxtJmYBjppTj/6H9LfyLRg=; b=wvhDHf54aibWtGDNwX2AcFIcOvV96FLEAz3Y2gsWjtb0ekKRQfrUvG9GPcC1nD009e LLc2xtp7Juf6VvwG18ULQSubwCSXPFaCQyTHJgraednFv+sXvEYKge82JGQH8fYQwuN7 5lnDzcSGbxdieuvPEK59K4cXFgQr7mQmYPWDZ9i1eOj+20/FQNAC77E0g4l4wYF03faR a3UH6QjzVaM2vqHno/gbPWHAiRRFPtTKy20z3rs81thRM9b/J1v6oFAGTbfl6CQsRcrm b1sGiZJzwgejPPDNiOFvDj83yGE+APXIAorGcNbZryYkBMhPUEkjvGZ2lT+A3jhFyN5r gfdQ== X-Gm-Message-State: AO0yUKUa2PToxSMlAszBnKt2mxaRY9yEs/+cDSWz4K/gHW0K19l4VTwp rJK0L4cmWSjFTVHTkE5jQmusWLUOiPk= X-Google-Smtp-Source: AK7set+5wEUcyDGGZO3pkXZ/BpcrPQa472MWpPNWnDWEM6LvGLEi5ElXu4EtM122ciM9weJlmY+r5g== X-Received: by 2002:adf:ee8c:0:b0:2c7:c49:e881 with SMTP id b12-20020adfee8c000000b002c70c49e881mr7782817wro.20.1677235476544; Fri, 24 Feb 2023 02:44:36 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id w23-20020a1cf617000000b003dc5b59ed7asm2378143wmc.11.2023.02.24.02.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 02:44:35 -0800 (PST) From: Robert Pluim To: Stefan Monnier Subject: Re: bug#61700: 30.0.50; insert-kbd-macro fails for named macro but not last macro In-Reply-To: (Stefan Monnier's message of "Thu, 23 Feb 2023 13:28:58 -0500") References: <87wn4amraf.fsf@cns.nyu.edu> <87wn4891q6.fsf@gmail.com> <87r0ug8rlv.fsf@gmail.com> Date: Fri, 24 Feb 2023 11:44:35 +0100 Message-ID: <87v8jr7370.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61700 Cc: 61700@debbugs.gnu.org, Josh Moller-Mara X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 61700 fixed close 61700 29.1 quit >>>>> On Thu, 23 Feb 2023 13:28:58 -0500, Stefan Monnier said: >> The following passes 'make bootstrap' and 'make check'. Stefan> Looks right to me, thank you. Closing. Committed as 573d9675fd7 Robert -- From unknown Thu Jun 19 14:06:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 24 Mar 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator