From unknown Sat Jun 21 12:17:01 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61686] [PATCH] gnu: Add dropwatch. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: me@tobias.gr, guix-patches@gnu.org Resent-Date: Tue, 21 Feb 2023 19:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61686@debbugs.gnu.org Cc: Bruno Victal , me@tobias.gr X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: me@tobias.gr Received: via spool by submit@debbugs.gnu.org id=B.167700721910974 (code B ref -1); Tue, 21 Feb 2023 19:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Feb 2023 19:20:19 +0000 Received: from localhost ([127.0.0.1]:57272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUYBV-0002qu-7U for submit@debbugs.gnu.org; Tue, 21 Feb 2023 14:20:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:60550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUYBR-0002qh-35 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 14:20:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUYBQ-0003UT-N7 for guix-patches@gnu.org; Tue, 21 Feb 2023 14:20:12 -0500 Received: from smtpm1.myservices.hosting ([185.26.105.232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUYBO-0004aw-AA for guix-patches@gnu.org; Tue, 21 Feb 2023 14:20:12 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm1.myservices.hosting (Postfix) with ESMTP id ED6CA20283 for ; Tue, 21 Feb 2023 20:20:06 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 9F1BE8009E; Tue, 21 Feb 2023 20:20:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IFwg5dyl_sOt; Tue, 21 Feb 2023 20:20:04 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 2D7CC8009D; Tue, 21 Feb 2023 20:20:04 +0100 (CET) From: Bruno Victal Date: Tue, 21 Feb 2023 19:19:55 +0000 Message-Id: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 tags: patch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.105.232; envelope-from=mirai@makinata.eu; helo=smtpm1.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/networking.scm (dropwatch): New variable. --- Note: the kernel option NET_DROP_MONITOR must be set for this package to work. The upstream sources use SPDX (though they're not completely REUSE compliant) $ reuse lint # MISSING LICENSES 'GPL-2.0-or-later' found in: * Makefile.am * autogen.sh * configure.ac * doc/Makefile.am * src/Makefile.am * src/dwdump.c * src/lookup.c * src/lookup.h * src/lookup_bfd.c * src/lookup_kas.c * src/main.c * src/net_dropmon.h # MISSING COPYRIGHT AND LICENSING INFORMATION The following files have no copyright and licensing information: * .travis.yml * README.md * doc/dropwatch.1 * doc/dwdump.1 * spec/dropwatch.spec * tests/Makefile.am * tests/rundropwatch.sh The following files have no copyright information: * autogen.sh * configure.ac * doc/Makefile.am * src/Makefile.am * src/dwdump.c * src/net_dropmon.h # SUMMARY * Bad licenses: * Deprecated licenses: * Licenses without file extension: * Missing licenses: GPL-2.0-or-later * Unused licenses: * Used licenses: GPL-2.0-or-later * Read errors: 0 * Files with copyright information: 6 / 19 * Files with license information: 12 / 19 Unfortunately, your project is not compliant with version 3.0 of the REUSE Specification :-( gnu/packages/networking.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 44e2de5f08..daac734535 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -56,6 +56,7 @@ ;;; Copyright © 2022 Reza Alizadeh Majd ;;; Copyright © 2022 Nicolas Graves ;;; Copyright © 2023 Andreas Enge +;;; Copyright © 2023 Bruno Victal ;;; ;;; This file is part of GNU Guix. ;;; @@ -4619,3 +4620,30 @@ (define-public vnstat that vnStat won't actually be sniffing any traffic and also ensures light use of system resources regardless of network traffic rate.") (license license:gpl2+))) + +(define-public dropwatch + (package + (name "dropwatch") + (version "1.5.4") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/nhorman/dropwatch.git") + (commit (string-append "v" version)))) + (sha256 + (base32 + "1r653y7bx763fpxl1vrflx8bzcrbds98zk4z7yhfikjngrqn1f2d")))) + (build-system gnu-build-system) + ;; XXX: bfd support isn't finished. + ;; https://github.com/nhorman/dropwatch/issues/76#issuecomment-1328345444 + (arguments + (list #:configure-flags #~(list "--without-bfd"))) + (native-inputs (list autoconf automake pkg-config)) + (inputs (list libnl libpcap readline)) + (home-page "https://github.com/nhorman/dropwatch") + (synopsis "Kernel dropped packet monitor") + (description + "dropwatch is an interactive utility for monitoring and +recording packets that are dropped by the kernel. It provides the commands +@command{dropwatch} and @command{dwdump}.") + (license license:gpl2+))) -- 2.39.1 From unknown Sat Jun 21 12:17:01 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61686] [PATCH] gnu: Add dropwatch. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Feb 2023 10:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: me@tobias.gr, 61686@debbugs.gnu.org Received: via spool by 61686-submit@debbugs.gnu.org id=B61686.167723551032748 (code B ref 61686); Fri, 24 Feb 2023 10:46:01 +0000 Received: (at 61686) by debbugs.gnu.org; 24 Feb 2023 10:45:10 +0000 Received: from localhost ([127.0.0.1]:36027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVVZd-0008W7-MS for submit@debbugs.gnu.org; Fri, 24 Feb 2023 05:45:10 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:47089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVVZa-0008Ul-Uv for 61686@debbugs.gnu.org; Fri, 24 Feb 2023 05:45:07 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 6202C24000D; Fri, 24 Feb 2023 10:44:57 +0000 (UTC) From: Nicolas Goaziou References: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> Date: Fri, 24 Feb 2023 11:44:50 +0100 In-Reply-To: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> (Bruno Victal's message of "Tue, 21 Feb 2023 19:19:55 +0000") Message-ID: <87cz5znxzx.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Bruno Victal writes: > * gnu/packages/networking.scm (dropwatch): New variable. Thanks. > --- > Note: the kernel option NET_DROP_MONITOR must be set for this package > to work. Do you think it is worth mentioning in the description? AFAICT, Guix does not set this option by default. > +(define-public dropwatch > + (package > + (name "dropwatch") > + (version "1.5.4") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/nhorman/dropwatch.git") You can drop the ".git" suffix here. > + (commit (string-append "v" version)))) You also need to add (file-name (git-file-name name version)) for proper naming in the store. > + (sha256 > + (base32 > + "1r653y7bx763fpxl1vrflx8bzcrbds98zk4z7yhfikjngrqn1f2d"))= )) > + (build-system gnu-build-system) > + ;; XXX: bfd support isn't finished. > + ;; https://github.com/nhorman/dropwatch/issues/76#issuecomment-13283= 45444 > + (arguments > + (list #:configure-flags #~(list "--without-bfd"))) > + (native-inputs (list autoconf automake pkg-config)) > + (inputs (list libnl libpcap readline)) > + (home-page "https://github.com/nhorman/dropwatch") > + (synopsis "Kernel dropped packet monitor") > + (description > + "dropwatch is an interactive utility for monitoring and Nicpick: dropwatch =E2=80=94> Dropwatch > +recording packets that are dropped by the kernel. It provides the comman= ds You need separate sentences with two spaces, per Texinfo syntax. > +@command{dropwatch} and @command{dwdump}.") > + (license license:gpl2+))) Regards, --=20 Nicolas Goaziou From unknown Sat Jun 21 12:17:01 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61686] [PATCH] gnu: Add dropwatch. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Feb 2023 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: me@tobias.gr, 61686@debbugs.gnu.org Received: via spool by 61686-submit@debbugs.gnu.org id=B61686.16773529229948 (code B ref 61686); Sat, 25 Feb 2023 19:23:02 +0000 Received: (at 61686) by debbugs.gnu.org; 25 Feb 2023 19:22:02 +0000 Received: from localhost ([127.0.0.1]:41560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW07O-0002aD-6Y for submit@debbugs.gnu.org; Sat, 25 Feb 2023 14:22:02 -0500 Received: from smtpm8.myservices.hosting ([185.26.105.209]:50422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW07N-0002Zy-8K for 61686@debbugs.gnu.org; Sat, 25 Feb 2023 14:22:01 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm8.myservices.hosting (Postfix) with ESMTP id 9E86520D4F; Sat, 25 Feb 2023 20:21:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 4954080098; Sat, 25 Feb 2023 20:21:59 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1t5DPYZcAbVR; Sat, 25 Feb 2023 20:21:59 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id CCF0880079; Sat, 25 Feb 2023 20:21:58 +0100 (CET) Message-ID: <6ae388b3-fea8-2b3e-d32c-da1119d090a7@makinata.eu> Date: Sat, 25 Feb 2023 19:21:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> <87cz5znxzx.fsf@nicolasgoaziou.fr> From: Bruno Victal In-Reply-To: <87cz5znxzx.fsf@nicolasgoaziou.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi Nicolas, On 2023-02-24 10:44, Nicolas Goaziou wrote: >> Note: the kernel option NET_DROP_MONITOR must be set for this package >> to work. > > Do you think it is worth mentioning in the description? AFAICT, Guix > does not set this option by default. With e701f67246680c81dd111cf7136b936bf7d8718b, this is now set by default. >> +(define-public dropwatch >> + (package >> + (name "dropwatch") >> + (version "1.5.4") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/nhorman/dropwatch.git") > > You can drop the ".git" suffix here. Is there a reason for dropping the suffix for GitHub? AFAIK it "works" but it's not the same url that they give out for cloning. >> + (commit (string-append "v" version)))) > > You also need to add > > (file-name (git-file-name name version)) > > for proper naming in the store. Is this always required? I assumed the default if unspecified was "good enough" and that snippet was used for repositories with problematic names. >> + (home-page "https://github.com/nhorman/dropwatch") >> + (synopsis "Kernel dropped packet monitor") >> + (description >> + "dropwatch is an interactive utility for monitoring and > > Nicpick: dropwatch —> Dropwatch Noted. > >> +recording packets that are dropped by the kernel. It provides the commands > > You need separate sentences with two spaces, per Texinfo syntax. This is actually not strictly necessary for strings embedded in scm files. The texinfo extractor is smart enough to automatically space the strings for us here. You can verify this behavior with 'guix search dropwatch' and see that it automatically inserts two spaces correctly. Cheers, Bruno From unknown Sat Jun 21 12:17:01 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61686] [PATCH] gnu: Add dropwatch. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Feb 2023 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 61686@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 61686-submit@debbugs.gnu.org id=B61686.167735530813969 (code B ref 61686); Sat, 25 Feb 2023 20:02:01 +0000 Received: (at 61686) by debbugs.gnu.org; 25 Feb 2023 20:01:48 +0000 Received: from localhost ([127.0.0.1]:41598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW0jr-0003dE-Kv for submit@debbugs.gnu.org; Sat, 25 Feb 2023 15:01:47 -0500 Received: from tobias.gr ([80.241.217.52]:48722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW0jp-0003d5-Qh for 61686@debbugs.gnu.org; Sat, 25 Feb 2023 15:01:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=dZrz+kSBV6YkR QnPhT4EX50DJn1xPUs7NErNtlqoU7o=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=LvEy5uWmiyLMSzTytvQMZJtE6aVHp2kCQZMa3miy9 S7vdTMS2na+GrztE0T6rk/sjtGv7jXILvtAKap5hqOPSQYGSvYtUO8UnoW+cxHlCH4GKGA LjBpqqQrzu1leHXf8LY65uJQpj5jKr0VcHIwjF/R6P0guy9vSETLOXwikV2wOctaoEdnyc SwEScg8n5EHG6agD6nJq2fVTxqvOY/5xOY+ZDvvWNc5IYTf7L2i8hWJ6sbTT4ZM5b19QG/ nbOb+p7Mtlwb0L+WAnmiBXGxz7Sng0lUbC07xHel0R3l5JORs/5SxMmQzLbvOo9wz0hvqI RgzwlmyAVU8VAdhcWvdIA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id ae0a7614; Sat, 25 Feb 2023 20:01:41 +0000 (UTC) MIME-Version: 1.0 Date: Sat, 25 Feb 2023 21:01:41 +0100 From: Tobias Geerinckx-Rice In-Reply-To: <6ae388b3-fea8-2b3e-d32c-da1119d090a7@makinata.eu> References: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> <87cz5znxzx.fsf@nicolasgoaziou.fr> <6ae388b3-fea8-2b3e-d32c-da1119d090a7@makinata.eu> Message-ID: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Bruno, On 2023-02-25 20:21, Bruno Victal wrote: >> Do you think it is worth mentioning in the description? AFAICT, Guix >> does not set this option by default. > > With e701f67246680c81dd111cf7136b936bf7d8718b, this is now set by > default. …on all architectures: it was inconsistently built-in on ARM, and missing from x86. It's now modular everywhere. \o/ To my pleasant surprise, it's automatically loaded when I start dropwatch as a regular user. \o/ > Is there a reason for dropping the suffix for GitHub? AFAIK it "works" > but it's not the same url that they give out for cloning. It works, no quotes. No technical reason to drop it, but many people do, perhaps so it matches the ‘home page’ many GitHubbed projects now lack. It's also provably shorter. If you feel strongly about keeping it, there's precedent in Guix. It's just very rare (2.2%). Consistency has its charms. >> You also need to add >> >> (file-name (git-file-name name version)) >> >> for proper naming in the store. > > Is this always required? Yes, for git checkouts. > I assumed the default if unspecified was "good enough" and > that snippet was used for repositories with problematic names. Nope. It'll clone & build fine, but please set a meaningful name for humans instead of: /gnu/store/ja3blcdqia00k15vpayfc9kzsjijfpw0-git-checkout Which is also a bonus footgun when someone inexperienced tries to update the package without changing the hash, because there's no version+commit information in the name. >>> + (home-page "https://github.com/nhorman/dropwatch") >>> + (synopsis "Kernel dropped packet monitor") ‘Monitor [for] dropped network packets’, or ‘Monitor [for] network packets dropped by the kernel’, maybe? The above (RedHat) version just doesn't parse naturally for me. >> You need separate sentences with two spaces, per Texinfo syntax. > > This is actually not strictly necessary Still. Kind regards, T G-R Sent from a Web browser. Excuse or enjoy my brevity. From unknown Sat Jun 21 12:17:01 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61686] [PATCH v2] gnu: Add dropwatch. References: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> In-Reply-To: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Feb 2023 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61686@debbugs.gnu.org Cc: Bruno Victal Received: via spool by 61686-submit@debbugs.gnu.org id=B61686.167735851519757 (code B ref 61686); Sat, 25 Feb 2023 20:56:01 +0000 Received: (at 61686) by debbugs.gnu.org; 25 Feb 2023 20:55:15 +0000 Received: from localhost ([127.0.0.1]:41710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW1Zb-00058b-GE for submit@debbugs.gnu.org; Sat, 25 Feb 2023 15:55:15 -0500 Received: from smtpm1.myservices.hosting ([185.26.105.232]:37632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW1ZW-00058N-DN for 61686@debbugs.gnu.org; Sat, 25 Feb 2023 15:55:14 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm1.myservices.hosting (Postfix) with ESMTP id F0B7C208FC for <61686@debbugs.gnu.org>; Sat, 25 Feb 2023 21:55:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 8455E80098; Sat, 25 Feb 2023 21:55:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vGPufwExGd3R; Sat, 25 Feb 2023 21:55:05 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id CAF9580097; Sat, 25 Feb 2023 21:55:04 +0100 (CET) From: Bruno Victal Date: Sat, 25 Feb 2023 20:55:02 +0000 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/networking.scm (dropwatch): New variable. --- gnu/packages/networking.scm | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index b5e8afc728..ede0b37bec 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -56,6 +56,7 @@ ;;; Copyright © 2022 Reza Alizadeh Majd ;;; Copyright © 2022 Nicolas Graves ;;; Copyright © 2023 Andreas Enge +;;; Copyright © 2023 Bruno Victal ;;; ;;; This file is part of GNU Guix. ;;; @@ -4619,3 +4620,31 @@ (define-public vnstat that vnStat won't actually be sniffing any traffic and also ensures light use of system resources regardless of network traffic rate.") (license license:gpl2+))) + +(define-public dropwatch + (package + (name "dropwatch") + (version "1.5.4") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/nhorman/dropwatch.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1r653y7bx763fpxl1vrflx8bzcrbds98zk4z7yhfikjngrqn1f2d")))) + (build-system gnu-build-system) + ;; XXX: bfd support isn't finished. + ;; https://github.com/nhorman/dropwatch/issues/76#issuecomment-1328345444 + (arguments + (list #:configure-flags #~(list "--without-bfd"))) + (native-inputs (list autoconf automake pkg-config)) + (inputs (list libnl libpcap readline)) + (home-page "https://github.com/nhorman/dropwatch") + (synopsis "Monitor for network packets dropped by the kernel") + (description + "Dropwatch is an interactive utility for monitoring and +recording packets that are dropped by the kernel. It provides the commands +@command{dropwatch} and @command{dwdump}.") + (license license:gpl2+))) -- 2.39.1 From unknown Sat Jun 21 12:17:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bruno Victal Subject: bug#61686: closed (Re: bug#61686: [PATCH] gnu: Add dropwatch.) Message-ID: References: <8735649wxg.fsf_-_@gnu.org> <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> X-Gnu-PR-Message: they-closed 61686 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 61686@debbugs.gnu.org Date: Thu, 16 Mar 2023 22:04:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1679004242-31063-1" This is a multi-part message in MIME format... ------------=_1679004242-31063-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61686: [PATCH] gnu: Add dropwatch. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61686@debbugs.gnu.org. --=20 61686: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61686 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1679004242-31063-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61686-done) by debbugs.gnu.org; 16 Mar 2023 22:03:03 +0000 Received: from localhost ([127.0.0.1]:43256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcvgc-00083O-Qh for submit@debbugs.gnu.org; Thu, 16 Mar 2023 18:03:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcvga-00082u-Si for 61686-done@debbugs.gnu.org; Thu, 16 Mar 2023 18:03:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcvgV-0004iB-2g; Thu, 16 Mar 2023 18:02:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rKPeCxmxmdEUMiwcw2hNJJtZlMhdDr0uslEn9HammII=; b=F/BAgwgWmOnbwQI4kTnS MZ6f9ZhUyyc4Qq4AaLdlfgUF9nFaMwqymztHlRNoroZ8QpP5BEslBr9+sygv4AIWZPJ5Q7Xo6d32U aCfusvQIXYx6jigfUiywzOutWOZZ0IwjfbXAJ3cRtDiWzfQYbBfyI5DvH6VcL53BAPNr8JR/LddF8 tVT8gRTJtY1VHCjgMJK2sqW0F+dPCtHW/cXTg0Dgr92Y95HSOdRCYT9zwmbN6T7kURtLQqDxCvlJY g/+EVQcysA8rNqmjqwswEkbBLgREXwOloCDP+MrDooz730/bsyI9eOebJDJxDpMaE9SJkWKI33MG8 Z1ABZnOL5GDf8Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcvgU-0007Bk-5p; Thu, 16 Mar 2023 18:02:54 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Bruno Victal Subject: Re: bug#61686: [PATCH] gnu: Add dropwatch. References: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> Date: Thu, 16 Mar 2023 23:02:51 +0100 In-Reply-To: (Bruno Victal's message of "Sat, 25 Feb 2023 20:55:02 +0000") Message-ID: <8735649wxg.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61686-done Cc: 61686-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Bruno Victal skribis: > * gnu/packages/networking.scm (dropwatch): New variable. Applied, thanks! ------------=_1679004242-31063-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Feb 2023 19:20:19 +0000 Received: from localhost ([127.0.0.1]:57272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUYBV-0002qu-7U for submit@debbugs.gnu.org; Tue, 21 Feb 2023 14:20:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:60550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUYBR-0002qh-35 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 14:20:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUYBQ-0003UT-N7 for guix-patches@gnu.org; Tue, 21 Feb 2023 14:20:12 -0500 Received: from smtpm1.myservices.hosting ([185.26.105.232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUYBO-0004aw-AA for guix-patches@gnu.org; Tue, 21 Feb 2023 14:20:12 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm1.myservices.hosting (Postfix) with ESMTP id ED6CA20283 for ; Tue, 21 Feb 2023 20:20:06 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 9F1BE8009E; Tue, 21 Feb 2023 20:20:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IFwg5dyl_sOt; Tue, 21 Feb 2023 20:20:04 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 2D7CC8009D; Tue, 21 Feb 2023 20:20:04 +0100 (CET) From: Bruno Victal To: guix-patches@gnu.org Subject: [PATCH] gnu: Add dropwatch. Date: Tue, 21 Feb 2023 19:19:55 +0000 Message-Id: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 tags: patch X-Debbugs-CC: me@tobias.gr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.105.232; envelope-from=mirai@makinata.eu; helo=smtpm1.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/networking.scm (dropwatch): New variable. --- Note: the kernel option NET_DROP_MONITOR must be set for this package to work. The upstream sources use SPDX (though they're not completely REUSE compliant) $ reuse lint # MISSING LICENSES 'GPL-2.0-or-later' found in: * Makefile.am * autogen.sh * configure.ac * doc/Makefile.am * src/Makefile.am * src/dwdump.c * src/lookup.c * src/lookup.h * src/lookup_bfd.c * src/lookup_kas.c * src/main.c * src/net_dropmon.h # MISSING COPYRIGHT AND LICENSING INFORMATION The following files have no copyright and licensing information: * .travis.yml * README.md * doc/dropwatch.1 * doc/dwdump.1 * spec/dropwatch.spec * tests/Makefile.am * tests/rundropwatch.sh The following files have no copyright information: * autogen.sh * configure.ac * doc/Makefile.am * src/Makefile.am * src/dwdump.c * src/net_dropmon.h # SUMMARY * Bad licenses: * Deprecated licenses: * Licenses without file extension: * Missing licenses: GPL-2.0-or-later * Unused licenses: * Used licenses: GPL-2.0-or-later * Read errors: 0 * Files with copyright information: 6 / 19 * Files with license information: 12 / 19 Unfortunately, your project is not compliant with version 3.0 of the REUSE Specification :-( gnu/packages/networking.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm index 44e2de5f08..daac734535 100644 --- a/gnu/packages/networking.scm +++ b/gnu/packages/networking.scm @@ -56,6 +56,7 @@ ;;; Copyright © 2022 Reza Alizadeh Majd ;;; Copyright © 2022 Nicolas Graves ;;; Copyright © 2023 Andreas Enge +;;; Copyright © 2023 Bruno Victal ;;; ;;; This file is part of GNU Guix. ;;; @@ -4619,3 +4620,30 @@ (define-public vnstat that vnStat won't actually be sniffing any traffic and also ensures light use of system resources regardless of network traffic rate.") (license license:gpl2+))) + +(define-public dropwatch + (package + (name "dropwatch") + (version "1.5.4") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/nhorman/dropwatch.git") + (commit (string-append "v" version)))) + (sha256 + (base32 + "1r653y7bx763fpxl1vrflx8bzcrbds98zk4z7yhfikjngrqn1f2d")))) + (build-system gnu-build-system) + ;; XXX: bfd support isn't finished. + ;; https://github.com/nhorman/dropwatch/issues/76#issuecomment-1328345444 + (arguments + (list #:configure-flags #~(list "--without-bfd"))) + (native-inputs (list autoconf automake pkg-config)) + (inputs (list libnl libpcap readline)) + (home-page "https://github.com/nhorman/dropwatch") + (synopsis "Kernel dropped packet monitor") + (description + "dropwatch is an interactive utility for monitoring and +recording packets that are dropped by the kernel. It provides the commands +@command{dropwatch} and @command{dwdump}.") + (license license:gpl2+))) -- 2.39.1 ------------=_1679004242-31063-1--