From unknown Fri Jun 13 10:18:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61684 <61684@debbugs.gnu.org> To: bug#61684 <61684@debbugs.gnu.org> Subject: Status: can't compose 'with-patch' with 'with-source' Reply-To: bug#61684 <61684@debbugs.gnu.org> Date: Fri, 13 Jun 2025 17:18:15 +0000 retitle 61684 can't compose 'with-patch' with 'with-source' reassign 61684 guix submitter 61684 Maxim Cournoyer severity 61684 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 13:08:51 2023 Received: (at submit) by debbugs.gnu.org; 21 Feb 2023 18:08:51 +0000 Received: from localhost ([127.0.0.1]:57217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUX4N-00017I-DT for submit@debbugs.gnu.org; Tue, 21 Feb 2023 13:08:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:58198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUX4I-000177-Ls for submit@debbugs.gnu.org; Tue, 21 Feb 2023 13:08:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUX4I-0003kL-GF for bug-guix@gnu.org; Tue, 21 Feb 2023 13:08:46 -0500 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUX4H-0000Bm-3h for bug-guix@gnu.org; Tue, 21 Feb 2023 13:08:46 -0500 Received: by mail-qt1-x82a.google.com with SMTP id fp16so5158995qtb.10 for ; Tue, 21 Feb 2023 10:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=A6JVPx31d8S4JrHnG4wzpWlORQkG4Mj8sGX/eE7wRgg=; b=FV3bKvCIWivj1JXZ98sjjBzag9/y6In64S9A7JCAaiTQok6OAct5nborcmwHykGE6z N91+FEVEwWSMbQTRktH460oM8bvJHyDXEubdBVym1J7Jmm2UcQBDDC2L501PREUpKzeU 2gTCgTsMNXJLPKTB7uSUKKx888Fsrcfa8yEDF60/lxeWuTzZ/Ar4sljh/iBT9jCT7a8n KXr7OE12Qd1n0V5Yc0Osy5CGfHPgNImKDUiIqn4h7erM/UCHliw7ieI0SNcsgQ3PbUw8 MGOCqIo0thZJbYQhPqTEK+o13/Z3XAae6FwpRXJwb8nRD4Nm0qykoMnJG5CPeE+hdovC K2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A6JVPx31d8S4JrHnG4wzpWlORQkG4Mj8sGX/eE7wRgg=; b=r2/3etADg79UcEx4THvMfMdmvy3335XlKl7B/CEQ5pNx2R2TkBoNaNlBIZelY3n03w XcmA+Qvhuseczw4HFfVc4j4QdvtyNz052ZqhNU5JWHOwli5wgzGDlfIr9OC76Viak3e7 RRFR0V/0T2YUUVVLQcrMWg+iuVMkY1Jk402aLOdqhTTKCu0RyOQOlLIhGOSMy57hDih/ nMeDxCU5FgSk0S4ruFv0w812FQpdkxDWxgmSAHCY7T6FqntYCOp4oKCV02gjV8iqHunM B2MgpuQVcOO5EwwH04r4kRQ33Z56brUdeP8TyG1sZZsvX8F1zbmEei2tVCwIhxvqA3pg ntDA== X-Gm-Message-State: AO0yUKUBmZ4sMgnQjVzE1gm6JTj9e9pYf3iofzDmzp9Q7Oojl9AqB24s zxmExBy0X022bqI6m4uLSsjh5l9XwzcInw== X-Google-Smtp-Source: AK7set8VCnqNSSua/Ongj3UfoI2VyhZxZn7VSqiJrN9odQQtsZM6+zKhaxA+g6yYhdmSZDi/MhNZqw== X-Received: by 2002:ac8:7d0f:0:b0:3ab:2a7f:83e4 with SMTP id g15-20020ac87d0f000000b003ab2a7f83e4mr25514328qtb.35.1677002923909; Tue, 21 Feb 2023 10:08:43 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id r18-20020ac83b52000000b003bd119dd615sm573756qtf.97.2023.02.21.10.08.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 10:08:42 -0800 (PST) From: Maxim Cournoyer To: bug-guix Subject: can't compose 'with-patch' with 'with-source' Date: Tue, 21 Feb 2023 13:08:41 -0500 Message-ID: <87mt56gac6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::82a; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, Given 'with-source' discards any patch from the original source, I thought I could at least add them back via 'with-patch', but it appears this does not work: --8<---------------cut here---------------start------------->8--- scheme@(gnu packages jami)> (options->transformation `((with-source . "libjami@20230220.0=/home/maxim/src/jami/jami-20230220.0.tar.gz") (with-patch . ,(string-append "libjami=" (search-patch "jami-disable-integration-tests.patch"))))) $6 = # scheme@(gnu packages jami)> ($6 libjami) $7 = # scheme@(gnu packages jami)> (package-source $7) $8 = #< uri: "/home/maxim/src/jami/jami-20230220.0.tar.gz" recursive?: #t> scheme@(gnu packages jami)> --8<---------------cut here---------------end--------------->8--- The downloaded-file resulting package source has lost the patch, and no error got produced, leaving the user to discover this limitation by themselves. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 15:16:23 2023 Received: (at 61684) by debbugs.gnu.org; 21 Feb 2023 20:16:23 +0000 Received: from localhost ([127.0.0.1]:57284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUZ3m-0004Ld-IY for submit@debbugs.gnu.org; Tue, 21 Feb 2023 15:16:22 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:34629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUZ3h-0004LM-BV for 61684@debbugs.gnu.org; Tue, 21 Feb 2023 15:16:21 -0500 Received: by mail-wr1-f44.google.com with SMTP id c12so5722343wrw.1 for <61684@debbugs.gnu.org>; Tue, 21 Feb 2023 12:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677010571; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=nYy2xuwPrsvs2KWnLQqwhVo9Etux7cu/DHOdLrx4nls=; b=SVw7vSne5XdnikUr2g6G18vu1Ufqf0rhuUJD92EZGovrD2Ks7Il3KgvijbFo/sS6K8 QFqtsTdaSicLD1FME7LM0a/fluivJ8PRNKd3Nh/QAXtbmWmzmqUP5LxYKwb15HD6MZpv bA+Yx0R/6rg8AFBuT2AaWWSBj+HunStmWb/rE8aHL4RbkAvc/jmo9FjV+OBvwWrod2HA ocjksWxfpkHjkP872JuQdgAoX76+0Ng5efb/fGDp5eDThYWxXw/ErmIgSjDbFXXPIJvP h2MXVeAEmVvHesJBvJ4J6505zUTWEG/59T32BmkFeflY3iiNrUEmaLpnbUeGKwtndNjI O/qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677010571; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nYy2xuwPrsvs2KWnLQqwhVo9Etux7cu/DHOdLrx4nls=; b=mwQKZio8gr+EmivJJnD/pY/YKRfSLILpDlAoIVfsBM+5547086G3gH+r19J6mckIgm JViCafkO1WRr9Pi5JRneL8SgmdAm9/dJEQZ5Tr4SEPdLWhnFwq2ooA+bo5oGOuJSgSzP AQ4YpxbIcgtc7i8EN7o+p0I45e4OFNcq9qyzUptec3lnulLtvfEqLgjlhKonvxOASYaK fCLpzsjwlsQJBwBnhSsCI0zKlJ6mc9u9h2QEwxZscdvAWoeXOlONPOTPHn64+X8jceUW IqpzUNNbJJkqb67OD9w58phCCQe3Bfcgb0HdRbONFakMlJoapTb+27a7A+l2EhKteJyX SXCA== X-Gm-Message-State: AO0yUKVPpVglCadtEFMmNQybuIZVlqXQ+bk7T5pjBwMLA1CYH6ZpHRb4 cxFuPF2sQVKX4xcfFjNsHk5/aIMbuZ0= X-Google-Smtp-Source: AK7set+72Q7Iz5WH9K37Fi/H1MDN0vNp/m4bZml8aUVaCQumA1F3p7wj/plcK07u4PZRqGu0fsrOdw== X-Received: by 2002:adf:fb45:0:b0:2c4:80a:e842 with SMTP id c5-20020adffb45000000b002c4080ae842mr4084384wrs.3.1677010571156; Tue, 21 Feb 2023 12:16:11 -0800 (PST) Received: from lili ([88.126.110.68]) by smtp.gmail.com with ESMTPSA id k9-20020a5d6289000000b002c56af32e8csm4392185wru.35.2023.02.21.12.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 12:16:10 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer , 61684@debbugs.gnu.org Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' In-Reply-To: <87mt56gac6.fsf@gmail.com> References: <87mt56gac6.fsf@gmail.com> Date: Tue, 21 Feb 2023 20:05:32 +0100 Message-ID: <86sfeyvnyb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Tue, 21 Feb 2023 at 13:08, Maxim Cournoyer wrote: > Given 'with-source' discards any patch from the original source, I thought > I could at least add them back via 'with-patch', but it appears this > does not work: I remember some headaches with this thread [1]. :-) 1: > > --8<---------------cut here---------------start------------->8--- > scheme@(gnu packages jami)> (options->transformation > `((with-source . "libjami@20230220.0=/home/maxim/src/jami/jami-20230220.0.tar.gz") > (with-patch . ,(string-append > "libjami=" (search-patch > "jami-disable-integration-tests.patch"))))) > $6 = # > scheme@(gnu packages jami)> ($6 libjami) > $7 = # > scheme@(gnu packages jami)> (package-source $7) > $8 = #< uri: "/home/maxim/src/jami/jami-20230220.0.tar.gz" recursive?: #t> > scheme@(gnu packages jami)> > --8<---------------cut here---------------end--------------->8--- > > The downloaded-file resulting package source has lost the patch, and no > error got produced, leaving the user to discover this limitation by > themselves. Well, it is probably unrelated because I guess the transformation makes sense here but indeed you can have bad surprise if the transformation does not make sense and then silently ignored. Well, I have never finished my attempt to raise more information about the transformation because the code about the transformation is hard to follow, from my point of view. Anyway! Thanks for having open this ticket. :-) Maybe with-source and with-patch are the first incremental change. ;-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 09:08:58 2023 Received: (at 61684) by debbugs.gnu.org; 23 Feb 2023 14:08:58 +0000 Received: from localhost ([127.0.0.1]:33446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVCHJ-00066s-Fy for submit@debbugs.gnu.org; Thu, 23 Feb 2023 09:08:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVCHI-00066e-8A for 61684@debbugs.gnu.org; Thu, 23 Feb 2023 09:08:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVCHD-0007Vu-1p; Thu, 23 Feb 2023 09:08:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5p0ajXHisnitoNjesBYu6nmsUB/ZBXBWTQ8E9e8+97o=; b=Ju4/03ztd74l92KyuL3H JYeEPLRMTE9tuWIIWdJitDio2nFOEniMchuvu7FnIQSJXZo5hNltK4/StTz49yOilXMTP5HiojVYe m2/ypj6qW/jhB9YYPe+dtwy0pHfWYXSORXX2ImjbkHcjwndOzs8cfwgU1E98JS1Jr3olqQjuHQkp+ YzVtZ5ii6hypwRMrVMCXBKbAReA4XwbTmy3vr9TW8xekrRC/J11W5i9y+ZhCWi4jvTALy0ptRSCNy qPYJ59pPQDoBZNRR8iBxbiKwsTE1lSCxWOFHrzE+bmjuTOZRlxsPDncVebKqN2JtXK4EDVmV18py1 +vMCyWhyfGh3uw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVCHC-0007Jg-IX; Thu, 23 Feb 2023 09:08:50 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> Date: Thu, 23 Feb 2023 15:08:48 +0100 In-Reply-To: <87mt56gac6.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 21 Feb 2023 13:08:41 -0500") Message-ID: <871qmg79u7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, Maxim Cournoyer skribis: > Given 'with-source' discards any patch from the original source, I thought > I could at least add them back via 'with-patch', but it appears this > does not work: > > scheme@(gnu packages jami)> (options->transformation=20 > `((with-source . "libjami@20230220.0=3D/home= /maxim/src/jami/jami-20230220.0.tar.gz") > (with-patch . ,(string-append=20 > "libjami=3D" (search-patch= =20 > "jami-disable-= integration-tests.patch"))))) > $6 =3D # > scheme@(gnu packages jami)> ($6 libjami) > $7 =3D # > scheme@(gnu packages jami)> (package-source $7) > $8 =3D #< uri: "/home/maxim/src/jami/jami-20230220.0.tar= .gz" recursive?: #t> > scheme@(gnu packages jami)> > > The downloaded-file resulting package source has lost the patch, and no > error got produced, leaving the user to discover this limitation by > themselves. The order of options matters; in this case, you need to do it the other way around: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (options->transformation '((with-patch . "jami=3D/tmp/= t.patch") (with-source . "jami=3Dhttp://example.org/foo.tar.gz"))) $18 =3D # scheme@(guile-user)> ($18 jami) $19 =3D # scheme@(guile-user)> (package-source $19) $20 =3D #< name: "jami-20230206.0-source" gexp: # guile: #f options: (#:local-build= ? #t)> --8<---------------cut here---------------end--------------->8--- The bit comes from the =E2=80=98with-patch=E2=80=99 transfo= rmation, to apply the patch to the . If you do it the other way around, the effect of =E2=80=98with-patch=E2=80= =99 is canceled by that of =E2=80=98with-source=E2=80=99, which does not preserve = patches. So strictly speaking, both options had an effect, but they were contradictory. Note that ordering is =E2=80=9Cspecified=E2=80=9D, notably with the test ad= ded in 0f024554e63a49e20c2a7a67e928073c266bf5c5 (this is crucial for our HPC users, who routinely combine a whole bunch of options; you have no idea how far they go once you give them the tool :-)). I don=E2=80=99t think the manual explicitly states it though. HTH, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 17:27:51 2023 Received: (at 61684) by debbugs.gnu.org; 23 Feb 2023 22:27:51 +0000 Received: from localhost ([127.0.0.1]:35521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVK47-0005W7-GK for submit@debbugs.gnu.org; Thu, 23 Feb 2023 17:27:51 -0500 Received: from mail-qv1-f44.google.com ([209.85.219.44]:45727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVK44-0005Vq-UR for 61684@debbugs.gnu.org; Thu, 23 Feb 2023 17:27:50 -0500 Received: by mail-qv1-f44.google.com with SMTP id bo10so11537759qvb.12 for <61684@debbugs.gnu.org>; Thu, 23 Feb 2023 14:27:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=5DmKzi+WF9tN/yZoU+u0OP+6ukHMHsypAMA9Fd+VF+M=; b=OG/JPB5ilpQ7zKXaqmdAW5ph+cM+AwT8q+/RA7tXZ+b4w8wwsd2MadRbjzBGtsBb/5 4pHVfIbh0X3oKBSwfXEX1Gi6GV9/nKJ/rNMhAvdX5IulWyoTyRQ/glva31d62xDuZ+HJ 23dk1TJAwymEfFOX9Fqoeag7033T9QJG+9u30+Om45UqwdTF5LIce0mZy1nDnsYiRh7d g5HYXgJBSq4TC9CSFBW0Y6cVdNTqXAQf63MDxGzPlGdlfMS6ukIRPpdYslbKLjWz5Ehd +6Z3oVMjvcnZ0xE9hdu5WQWoOvvp99q2E4gDh1tATN68RyJ9dWaYPsW5sbM23hKPeBJB M/FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5DmKzi+WF9tN/yZoU+u0OP+6ukHMHsypAMA9Fd+VF+M=; b=0JMfU/Zypv9nZaU07V6cB6ilekKAj1BqAkHd6PZOFbyvCuwXY2ByW4lO2CPYpi4/Fa K8w64pxOTBFtezvqdjpQg6IOIBUWD1sVjhaKTUp/IoUsAXRr9i2T1xkrgi1sLwqXqRe/ Btnv8a7kU+EcLddsa66/oP4Q5iVWC1d+UZpl9WCrX5tDwE2ytzQbidItCEBYxOsLZwMj mlB0+YH0tb9YaT8e6Se0PuejtQgzgt13HrF0r08pgKxc1bd8IXZ53LwiMb0MPee/ECg5 nMwE3PgmUmwcUmp/hANV61tb8eoJrGe+U9U63hJ7WfaSls84plDxX6yMc0oGhqrA6yDJ PUJQ== X-Gm-Message-State: AO0yUKXTkraUcRI26dG3V/dJeiFBIjtjOeTHzi/5OtQ6tqYMJ827fKIy rkkpCJIC+ze7zAxj4wJC/Ta2ehGdLV2JoA== X-Google-Smtp-Source: AK7set/xLsvcgPgb/AkcIGZToQS8nMbwJts8gdLRleOla00CAAGx9wDpF4r8iUEsUY6oYlqG5EA3ZQ== X-Received: by 2002:a05:6214:20e9:b0:56e:99f2:1bb0 with SMTP id 9-20020a05621420e900b0056e99f21bb0mr23642841qvk.48.1677191263234; Thu, 23 Feb 2023 14:27:43 -0800 (PST) Received: from hurd (dsl-10-129-1.b2b2c.ca. [72.10.129.1]) by smtp.gmail.com with ESMTPSA id s128-20020a374586000000b007426b8eed51sm543024qka.118.2023.02.23.14.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 14:27:42 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> Date: Thu, 23 Feb 2023 17:27:41 -0500 In-Reply-To: <871qmg79u7.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 23 Feb 2023 15:08:48 +0100") Message-ID: <87356whvaa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> Given 'with-source' discards any patch from the original source, I thoug= ht >> I could at least add them back via 'with-patch', but it appears this >> does not work: >> >> scheme@(gnu packages jami)> (options->transformation=20 >> `((with-source . "libjami@20230220.0=3D/hom= e/maxim/src/jami/jami-20230220.0.tar.gz") >> (with-patch . ,(string-append=20 >> "libjami=3D" (search-patc= h=20 >> "jami-disable= -integration-tests.patch"))))) >> $6 =3D # >> scheme@(gnu packages jami)> ($6 libjami) >> $7 =3D # >> scheme@(gnu packages jami)> (package-source $7) >> $8 =3D #< uri: "/home/maxim/src/jami/jami-20230220.0.ta= r.gz" recursive?: #t> >> scheme@(gnu packages jami)> >> >> The downloaded-file resulting package source has lost the patch, and no >> error got produced, leaving the user to discover this limitation by >> themselves. > > The order of options matters; in this case, you need to do it the other > way around: > > scheme@(guile-user)> (options->transformation '((with-patch . "jami=3D/tm= p/t.patch") > (with-source . "jami=3Dhttp://example.org/foo.tar.gz"))) > $18 =3D # > scheme@(guile-user)> ($18 jami) > $19 =3D # > scheme@(guile-user)> (package-source $19) > $20 =3D #< name: "jami-20230206.0-source" gexp: # guile: #f options: (#:local-bui= ld? #t)> > > The bit comes from the =E2=80=98with-patch=E2=80=99 trans= formation, to > apply the patch to the . > > If you do it the other way around, the effect of =E2=80=98with-patch=E2= =80=99 is > canceled by that of =E2=80=98with-source=E2=80=99, which does not preserv= e patches. So > strictly speaking, both options had an effect, but they were > contradictory. Hm. That seems sub-optimal; it seems to me that ideally, the transformations would be additive, so that users would not need to care about the ordering. Or perhaps, alternatively, we could enforce such ordering at the implementation level (sorting the transformations in the order that is required). > Note that ordering is =E2=80=9Cspecified=E2=80=9D, notably with the test = added in > 0f024554e63a49e20c2a7a67e928073c266bf5c5 (this is crucial for our HPC > users, who routinely combine a whole bunch of options; you have no idea > how far they go once you give them the tool :-)). I don=E2=80=99t think = the > manual explicitly states it though. It doesn't seem to be, indeed. But I wish we wouldn't need to (see my above suggestions/ideas). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 07:10:07 2023 Received: (at 61684) by debbugs.gnu.org; 24 Feb 2023 12:10:07 +0000 Received: from localhost ([127.0.0.1]:36192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVWtr-0007SN-EA for submit@debbugs.gnu.org; Fri, 24 Feb 2023 07:10:07 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:52786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVWtl-0007RI-IG for 61684@debbugs.gnu.org; Fri, 24 Feb 2023 07:10:02 -0500 Received: by mail-wm1-f53.google.com with SMTP id j3so9293695wms.2 for <61684@debbugs.gnu.org>; Fri, 24 Feb 2023 04:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677240596; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mi9oO2zAEhNb8lEo+AgoZDlZPaZXVzOL1MUzFWlXB18=; b=U5GPbIAxTB8m+dt/4VQTU43b2YyzCIjpX8D6uc0f4zYh29KRSpp+Pwwa30GzzfMAnH mI2aoBnatFzth33TpMUuqWKOVj5O1JAd26Ltf69ZTSRtPs1G+OGQ6wbjc4xamnOgOims Jq76ii+DABil8zUT10evAR2OktPSDgeE796c5yKrhh6RbERh0cGzGiNwvnqiXdUfEM1W z8Qc0dzquD7JRZ9IbZf3LpSLArtqLkjs0naZKzuMGNA6lMM192zKDhA+FjwAJtQbt9nz +ty09rJbz5+7iAvLD/luTR6KnJz5CR2apSyIgLV89HYtsm4vM8hfH/nXAStS0etTRew/ l8pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677240596; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mi9oO2zAEhNb8lEo+AgoZDlZPaZXVzOL1MUzFWlXB18=; b=ww/2WQAg4ThUrE+a6kFz1dYkT0XnYaVkFvBSJ+L3eVKvVNcK5eQ83HDcK0cbyzQkFt u6V49BwzGCXza5jTfIxqCSvzg7kGcRQVWBuhHTycGmBc9Y3yRclu8BJ//41JpoWrhpk1 UEqpWp2m24kZcIBnEFUPHrAI/7eFieyLj6QYoyV0CJ7k2MvlMINdoO0KoE5YinZVlMQO jUpiM2oX9BefUhx1vsKJGuM3Zx5PTNKoJoA+ZHwKbLgXqQ9YdGxYjVPGdD3DR6Q2ktXW CYN83jpf0BpoG3l9Tj84sruParA5zmJqNN6ydEs4+fDlLIjCAkyItoPzGUSH6IJqfN+P +1Nw== X-Gm-Message-State: AO0yUKVBMzDTi52ZWFF+u5Mxj1f5yWsyPVMB9j2RfsYfKEGbAWQsnSYj ojLJOFFcfpzFNxzQcUNba++VGtYjoG0= X-Google-Smtp-Source: AK7set+FAuDxFUne0uOZBVLmFMBawHLv815tLkhUoC7S+x6cEHyU3nPQgsoiTGYxHkTqXOmHg/gssA== X-Received: by 2002:a7b:ce89:0:b0:3e1:bfc:f57b with SMTP id q9-20020a7bce89000000b003e10bfcf57bmr11830954wmj.2.1677240595802; Fri, 24 Feb 2023 04:09:55 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id y22-20020a1c4b16000000b003db01178b62sm2523555wma.40.2023.02.24.04.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 04:09:55 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' In-Reply-To: <87356whvaa.fsf@gmail.com> References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> Date: Fri, 24 Feb 2023 13:02:00 +0100 Message-ID: <875ybrmfuv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On jeu., 23 f=C3=A9vr. 2023 at 17:27, Maxim Cournoyer wrote: > Hm. That seems sub-optimal; it seems to me that ideally, the > transformations would be additive, so that users would not need to care > about the ordering. Or perhaps, alternatively, we could enforce such > ordering at the implementation level (sorting the transformations in the > order that is required). >From my point of view (and what I tried stopping in the middle :-)) is to report if the transformation makes sense or not. For instance, with-patch with-source makes sense contrary to with-source with-patch and it would already be an improvement to report that the latter transformation does not make sense instead of silently does nothing or raises some weird errors. Well, I am not convinced that enforce the ordering is a good thing because as Ludo said, some HPC user exploits this control of ordering to generate complex transformations. To me, the fix is: 1. document the ordering bits 2. check if the ordering =E2=80=9Cmakes sense=E2=80=9C and raises if not. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 08:21:10 2023 Received: (at 61684) by debbugs.gnu.org; 24 Feb 2023 13:21:10 +0000 Received: from localhost ([127.0.0.1]:36289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVY0c-0005hU-0B for submit@debbugs.gnu.org; Fri, 24 Feb 2023 08:21:10 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:43563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVY0a-0005hI-3z for 61684@debbugs.gnu.org; Fri, 24 Feb 2023 08:21:08 -0500 Received: by mail-qt1-f176.google.com with SMTP id cf14so4186290qtb.10 for <61684@debbugs.gnu.org>; Fri, 24 Feb 2023 05:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ACacFfWOv8dfQsCc7GpzAhHEx5VFP51GZBsRAtBKTuI=; b=JMXd7600ZDhNCnRqc4IjLnC8fLdYpO9Wb+d6LLbCWwT6X3N++rHFk0QKQKkOQvCr7q oQXSTy2lSTXfopDCFLw7JaxAM6yCVnrxdFVy2IoaGY+eb4Z5KpJHYJ8m9S/4zzzpg6B8 TSaeiQAE9VWODMBrNX90VAg/e6on2rECGwZKvTCLa/vWxegpptKpZBVlH+rjQhI2/5/j 1mr6WvEtGojz7hw55IkRgKHXnPxL9EjxbD5asBEX6TO6nFTNii3lNLtxYITKmWLukaxx SMymj6C9tw/OlHIZAnOirLmlp9W3rxiZjHYorqOQRPdEUDQsIfrOSTBsULvu15KD+HBF Arkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ACacFfWOv8dfQsCc7GpzAhHEx5VFP51GZBsRAtBKTuI=; b=vV5oihR1R1zczvXU7X0uxpjQRK4b2L7I/x0a9iG7IghNO18cAYkmtefDfF3nJFSiHT 2tRswduGknr8q6iUxUR/aleOg/Onxg/rbVAtFWT/wOYyWDh7S8CzJAQi9U2pNAQkAcrZ rDRacnTwzT+Bkg7MrPq5A1ZPdbwv6248l3PwDv4AzlbWMf6+NwIL+ojXDidMmvjqUDfw ByoZOCixJ/f2bWChGpwYOGFnV09GlEHIVLMa4AiIspDTSIK+xS/NuHfris9rd6F2Vk+y r51I0GuanJl/JrJA4k6H5Bg7mHxd9apPr3Z0d4zSVIsiMkASYuvjfum9lWGNAgqEsCRR DZQQ== X-Gm-Message-State: AO0yUKWfzh1mPDCS3x7D50XZljhxTzGo4eh61wPj8Zz2ihCHmU1iNmqb 78kpay3p44wWOK2SRFh2BZxNJ61YlxX3iA== X-Google-Smtp-Source: AK7set+/U8/lxgvGds1G2ecwrP7ASMYeNpW7n/nCsgDNJjf/v1lvO3+QXnruaLb7uL490OG7jjaiTQ== X-Received: by 2002:a05:622a:138d:b0:3b6:3ad0:5470 with SMTP id o13-20020a05622a138d00b003b63ad05470mr26578540qtk.31.1677244862332; Fri, 24 Feb 2023 05:21:02 -0800 (PST) Received: from hurd (dsl-141-27.b2b2c.ca. [66.158.141.27]) by smtp.gmail.com with ESMTPSA id 138-20020a370890000000b00741e27ecb37sm6754830qki.74.2023.02.24.05.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 05:21:01 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> Date: Fri, 24 Feb 2023 08:21:00 -0500 In-Reply-To: <875ybrmfuv.fsf@gmail.com> (Simon Tournier's message of "Fri, 24 Feb 2023 13:02:00 +0100") Message-ID: <87h6vbgpxf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Simon Tournier writes: > Hi, > > On jeu., 23 f=C3=A9vr. 2023 at 17:27, Maxim Cournoyer wrote: > >> Hm. That seems sub-optimal; it seems to me that ideally, the >> transformations would be additive, so that users would not need to care >> about the ordering. Or perhaps, alternatively, we could enforce such >> ordering at the implementation level (sorting the transformations in the >> order that is required). > > From my point of view (and what I tried stopping in the middle :-)) is > to report if the transformation makes sense or not. For instance, > > with-patch > with-source > > makes sense contrary to > > with-source > with-patch > > and it would already be an improvement to report that the latter > transformation does not make sense instead of silently does nothing or > raises some weird errors. > > Well, I am not convinced that enforce the ordering is a good thing > because as Ludo said, some HPC user exploits this control of ordering to > generate complex transformations. Could we gather more information about that use case? It needs to be clear if we are to constrain the design (solution) by it. > To me, the fix is: > > 1. document the ordering bits > 2. check if the ordering =E2=80=9Cmakes sense=E2=80=9C and raises if not. If the use case above (the one where transformation order matters and are useful) is expounded and appears reasonable, then yes, that seems like a good solution. Such a use case could appear in a complex example next to the documentation that explains the ordering "rules". --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 08:43:15 2023 Received: (at 61684) by debbugs.gnu.org; 24 Feb 2023 13:43:15 +0000 Received: from localhost ([127.0.0.1]:36316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVYLy-0006Ha-Ou for submit@debbugs.gnu.org; Fri, 24 Feb 2023 08:43:15 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:45894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVYLw-0006HL-RM for 61684@debbugs.gnu.org; Fri, 24 Feb 2023 08:43:13 -0500 Received: by mail-wr1-f52.google.com with SMTP id p8so14087422wrt.12 for <61684@debbugs.gnu.org>; Fri, 24 Feb 2023 05:43:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677246187; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4XE0sdsPUE4AClfUvWOUz31I9vY4BwtlpECi9zq0ggM=; b=E+HlEsZ54CaGhDIlwvbx5GJmW/r+WHYneHebqRR9zU4XQ+tGnGq8mEtM8FAGAc0xAG XxJbvvv45swv+LDWDv1i11W8B7zM3ZKDR2GO7oZZnUUBDXPMgtGeGc31Fr30vGRut9JS yaN5UZXbUShy4Iq8pZV/Oq1izAu71zg09SSWTn5aVVh9N9WjND3IwmoVeha8l6grRtEQ GVaEOqy4yvB39zNweJJRLkLF8bofdnGR6bS3JGgqSvzhYLqsFrHhGvRBYWyOvUDTfIuw BFvryZd6i9C+GFc+RCBwYdiXmcQWdeIu7/5kpsDFagb9oNxaDiiavh8yJZsVpDRpJKAF a5EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677246187; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4XE0sdsPUE4AClfUvWOUz31I9vY4BwtlpECi9zq0ggM=; b=DN99BKmBRokoIFJdeMgKsixslM8mJXtJzQTljLfIsSmO1A8qXCXovVJrbTWz3j9Eo/ oua0XKE0jNWpYV2O6QzZit/DFhwx+KMdMEKGGLGe0RF3ZzB4EHS3IJfXA8dGv27K0WjJ mUe4EQERR1tHNTDyRAdh2JtItZR+iIRdlam0V2jj+Hdhcn1WUvBO3S6A0vYp0jfPllDR IXt8+SKAUHGXivTxqhzOvTaM+Kq0WwaXy+eRsN/sta+bWk92pSJxoMrUCxfHhE2+1p6b DNvv/1zxIrRS4mF1R5/tyblP3JZLBEwV03dw/ZI/6Y6WcapaWP0NWWo1vXG3aWRc11Ng KwUg== X-Gm-Message-State: AO0yUKVxtHuJ+Jx8iTBKhpR5eAiOakt9aUfnkPhLgyxzPouCoJ1f41Pt eFh+VxjLhIF+0vfTsltLMt6OpYFts44= X-Google-Smtp-Source: AK7set8MSKpT5YoG0kJhBPAxJ866leznSJHOVQFtMaY3mX1h9VJzuZ8eqcCvGFE4hkwGGTvyKeEXJQ== X-Received: by 2002:adf:fd87:0:b0:2c6:e8cc:e165 with SMTP id d7-20020adffd87000000b002c6e8cce165mr10977834wrr.7.1677246186865; Fri, 24 Feb 2023 05:43:06 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id b17-20020a5d6351000000b002c70a68111asm7564561wrw.83.2023.02.24.05.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 05:43:06 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' In-Reply-To: <87h6vbgpxf.fsf@gmail.com> References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <87h6vbgpxf.fsf@gmail.com> Date: Fri, 24 Feb 2023 14:43:03 +0100 Message-ID: <87y1onkwm0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On ven., 24 f=C3=A9vr. 2023 at 08:21, Maxim Cournoyer wrote: >> Well, I am not convinced that enforce the ordering is a good thing >> because as Ludo said, some HPC user exploits this control of ordering to >> generate complex transformations. > > Could we gather more information about that use case? It needs to be > clear if we are to constrain the design (solution) by it. Well, I do not have the details. Just to mention two presentations [1,2] exposing how transformations help for them. 1: 2: There they intensively uses transformations. For instance, p.4 of [2] it reads, guix environment --pure --with-input=3Dpastix-5=3Dpastix-5-mkl \ --with-input=3Dmumps-scotch-openmpi=3Dmumps-mkl-scotch-openmpi \ --with-input=3Dopenblas=3Dmkl --with-git-url=3Dgcvb=3D$HOME/src/gcv= b \ --with-commit=3Dgcvb=3D40d88ba241db4c71ac3e1fe8024fba4d906f45b1 \ --preserve=3D^SLURM --ad-hoc bash coreutils inetutils findutils \ grep sed bc openssh python python-psutil gcvb scab slurm@19 openmpi For this specific example, the order may or not matter. The point is that HPC folks are intensively using transformations and, since the order currently matters, enforcing one specific order could break their workflow, and even could make impossible what is currently possible. Quoting Ludo, (this is crucial for our H= PC users, who routinely combine a whole bunch of options; you have no = idea how far they go once you give them the tool :-)) and I agree with =C2=AB you have no idea how far they go once you give them the tool :-)) =C2=BB. For what my opinion is worth. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 08:52:48 2023 Received: (at 61684) by debbugs.gnu.org; 24 Feb 2023 13:52:48 +0000 Received: from localhost ([127.0.0.1]:36345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVYVE-0006bt-0F for submit@debbugs.gnu.org; Fri, 24 Feb 2023 08:52:48 -0500 Received: from mail-qt1-f170.google.com ([209.85.160.170]:37710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVYVC-0006bf-Bk for 61684@debbugs.gnu.org; Fri, 24 Feb 2023 08:52:46 -0500 Received: by mail-qt1-f170.google.com with SMTP id r5so4670013qtp.4 for <61684@debbugs.gnu.org>; Fri, 24 Feb 2023 05:52:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=q1t92TCc2ciDA/JvDEdjRhMF9QHKRL8Z+OHZgQvl2yU=; b=lDEGf4/RDqe+Tv/AYpwuPugYPoL52cuxUQO3tNIz9ydxnF2Y/tG1nsfMOgX8kVozV+ XjFJaHIVIMp2RExZjzrRV0D5DstpuAaTaO62stq3JQcWklOpxWOpcb5kQHYsgZn9EUK6 +W8/Xi4pdNvcz1dPmVHnKLe9V2lKRSpS8ud/4Y6dgQSTiHltA+6uoMJLk/e2cx9Lv35w niLhH1cW4QIQJUoAftvjpxSuQc7yA3fPMfUtsl3AGJi+eUdq2H9DY0JKGU+JBU+H3Snz cWvhCQNUO0TcHdkrGE/uZIvuONJFvgVuTUVJi7nXIYhHR1zWav8pvqMbUc/+2n2MWTZf kSOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=q1t92TCc2ciDA/JvDEdjRhMF9QHKRL8Z+OHZgQvl2yU=; b=qzSyMiXcfDGhk5ezrwt+s/RLHxDM5DRBWY7AtiKFxdMz+w4xV04gxpTPaEbd/750tI S3jcilnu6ekT3riN6NVx1sTsottXgsZX7qIxL3H0ohqev+NfAZu8gGbyg64yHUgxFYLr Pc5RVsAh1sFR0qwFvHsiW27K19EB7RqFSe5xvzJFg1bKpElQR1ST6BXfhBd/u8q8jhSj cuMYMYNGJbgLTj/PuauOSWPLkH1Yqo+SIIhppLMJxzCgQUXxFojW74mp2Y4MA+XEXsK6 aIUZDLK7FSg/zZJTwY6KAiU+8zV76Aklc94HuxtCNnzTU66ZUkInVqZWO6rJaGG+Sdgk +IsA== X-Gm-Message-State: AO0yUKV65NmjUyZWFVVjCzFIW0LH0EsE7hrqFKWBJsqcyZBBxo0kl41u c3Hs1bM5QJOPFVM/2HKGAZp763PpQpv8vw== X-Google-Smtp-Source: AK7set+M+Nc9q+0wqMIX4r3M1hJYIIA6R1ZrmdVOag/Ahym8SrpGyQtt67qBBYfd55vhW+hx8jH0dw== X-Received: by 2002:a05:622a:108:b0:3b8:6a92:c8d6 with SMTP id u8-20020a05622a010800b003b86a92c8d6mr27813876qtw.60.1677246760601; Fri, 24 Feb 2023 05:52:40 -0800 (PST) Received: from hurd (dsl-141-27.b2b2c.ca. [66.158.141.27]) by smtp.gmail.com with ESMTPSA id n206-20020a3740d7000000b007425dade624sm2417583qka.41.2023.02.24.05.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 05:52:40 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <87h6vbgpxf.fsf@gmail.com> <87y1onkwm0.fsf@gmail.com> Date: Fri, 24 Feb 2023 08:52:39 -0500 In-Reply-To: <87y1onkwm0.fsf@gmail.com> (Simon Tournier's message of "Fri, 24 Feb 2023 14:43:03 +0100") Message-ID: <87cz5zgogo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, Simon Tournier writes: > Hi Maxim, > > On ven., 24 f=C3=A9vr. 2023 at 08:21, Maxim Cournoyer wrote: > >>> Well, I am not convinced that enforce the ordering is a good thing >>> because as Ludo said, some HPC user exploits this control of ordering to >>> generate complex transformations. >> >> Could we gather more information about that use case? It needs to be >> clear if we are to constrain the design (solution) by it. > > Well, I do not have the details. Just to mention two presentations > [1,2] exposing how transformations help for them. > > 1: > 2: > > There they intensively uses transformations. For instance, p.4 of [2] > it reads, > > guix environment --pure --with-input=3Dpastix-5=3Dpastix-5-mkl \ > --with-input=3Dmumps-scotch-openmpi=3Dmumps-mkl-scotch-openmpi \ > --with-input=3Dopenblas=3Dmkl --with-git-url=3Dgcvb=3D$HOME/src/g= cvb \ > --with-commit=3Dgcvb=3D40d88ba241db4c71ac3e1fe8024fba4d906f45b1 \ > --preserve=3D^SLURM --ad-hoc bash coreutils inetutils findutils \ > grep sed bc openssh python python-psutil gcvb scab slurm@19 openm= pi > > For this specific example, the order may or not matter. The point is > that HPC folks are intensively using transformations and, since the > order currently matters, enforcing one specific order could break their > workflow, and even could make impossible what is currently possible. I'd argue that in the above case, the order doesn't or shouldn't matter. The user clearly intended for them to be additive. > Quoting Ludo, > > (this is crucial for our= HPC > users, who routinely combine a whole bunch of options; you have n= o idea > how far they go once you give them the tool :-)) > > > > and I agree with =C2=AB you have no idea how far they go once you give th= em > the tool :-)) =C2=BB. It seems a bit hypothetical at this point, so I wouldn't want to cripple the design by it. Sure, users will find by experimentation how to accomplish something, perhaps twisting it in odd ways to, but in my opinion if the API was consistent it'd be much easier for everyone to accomplish what they are after. *If* a valid use case of the current quirky behavior is discovered, we could consider adding a '--order-sensitive' option or similar to restore that behavior, I just don't think it should be the default. > For what my opinion is worth. :-) Thanks for sharing it! --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 08:59:29 2023 Received: (at 61684) by debbugs.gnu.org; 24 Feb 2023 13:59:29 +0000 Received: from localhost ([127.0.0.1]:36358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVYbg-0006m8-JH for submit@debbugs.gnu.org; Fri, 24 Feb 2023 08:59:29 -0500 Received: from mail-qt1-f171.google.com ([209.85.160.171]:47024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVYbe-0006lw-Tb for 61684@debbugs.gnu.org; Fri, 24 Feb 2023 08:59:27 -0500 Received: by mail-qt1-f171.google.com with SMTP id c19so4119275qtn.13 for <61684@debbugs.gnu.org>; Fri, 24 Feb 2023 05:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=cW1kDcM9FnQppBFRKi3LH4srgJKmdBpX3Jc6bKkyY5E=; b=RAypA9Wkaji42QMq9CUfV2HVTN8GeZ7lwMDG6H6x8xkghvmP4iA3HfniwBfAKX4JHl UUaLsdFvM+hAAIga680vKdnHqvTjTUHYbH0V4gtgDuCbxERX2eWjzdu7gujRntfCyCCM sIX5zLVKa2r5UxCdRda0ti4s2LeScaQJfs9IGWYmNkHSBHSxSsX9OztFozbIZDtmba74 flCwe1SyXysQSckTXpxIE5eh67yUPRNAcwj2VlaqlVk8/rZ3fWM2hVhB5AKuc1a5qbss GH1prqgSttHtU3XYIeMQKiv95Arb16rXK2sCZDE/bPwn3veBdF5mvHYtDv7OiwJ5jmf9 Z1SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cW1kDcM9FnQppBFRKi3LH4srgJKmdBpX3Jc6bKkyY5E=; b=mB0VbICTwcubyhLghUGKpQvCdt1bmIE5R4aY7hBQFCbpZFLv41+xEwAn90FJW4DjUX L0RgmPWdQnrsguoAHXZCCu6fNLyGuVQECYxdmiyEhYoZo9E/PGjSnaKwnHmck44zgzLJ /F/MR3ti0nEamFP+3gwy9J6vKsL0Pa7PgXXfV8iJ/tOhdt2kB62spsoCgJTwyHtVgQcD 2za7+hhtDI1iPI8heqoh9UHyz/fBoLdUQ/puilB8ueUo+6sRVVu62KjaV3v9OuK5yuiu xjhrpKZxYkl525gcS0B3wQqApJ+M/115JWyBzJbiFyuiWWebfQ9nj9ISuJ9MAov3lBbq +u6A== X-Gm-Message-State: AO0yUKU5IW67pcjCk3J1DZQMrMuUbdH8+BDFYy7G6HC9UN8Grd0TrhHR SC1ZiskCbdMLFFE0IgAW7WH9PYckurpIOg== X-Google-Smtp-Source: AK7set9DVUrn/fw0sB+HHAN0LSb4Mbgs9Dd3C+NBdpd1aM6qVZvSwI+Fi8Ke2mLW5YRkQShfRUCXRQ== X-Received: by 2002:a05:622a:389:b0:3bd:1835:b00f with SMTP id j9-20020a05622a038900b003bd1835b00fmr26681548qtx.20.1677247160991; Fri, 24 Feb 2023 05:59:20 -0800 (PST) Received: from hurd (dsl-141-27.b2b2c.ca. [66.158.141.27]) by smtp.gmail.com with ESMTPSA id o186-20020a375ac3000000b0073b45004754sm3877889qkb.34.2023.02.24.05.59.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Feb 2023 05:59:20 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> Date: Fri, 24 Feb 2023 08:59:19 -0500 In-Reply-To: <871qmg79u7.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 23 Feb 2023 15:08:48 +0100") Message-ID: <877cw7go5k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> Given 'with-source' discards any patch from the original source, I thoug= ht >> I could at least add them back via 'with-patch', but it appears this >> does not work: >> >> scheme@(gnu packages jami)> (options->transformation >> `((with-source . "libjami@20230220.0=3D/hom= e/maxim/src/jami/jami-20230220.0.tar.gz") >> (with-patch . ,(string-append >> "libjami=3D" (search-patch >> "jami-disable= -integration-tests.patch"))))) >> $6 =3D # >> scheme@(gnu packages jami)> ($6 libjami) >> $7 =3D # >> scheme@(gnu packages jami)> (package-source $7) >> $8 =3D #< uri: "/home/maxim/src/jami/jami-20230220.0.ta= r.gz" recursive?: #t> >> scheme@(gnu packages jami)> >> >> The downloaded-file resulting package source has lost the patch, and no >> error got produced, leaving the user to discover this limitation by >> themselves. > > The order of options matters; in this case, you need to do it the other > way around: > > scheme@(guile-user)> (options->transformation '((with-patch . "jami=3D/tm= p/t.patch") > (with-source . "jami=3Dhttp://example.org/foo.tar.gz"))) > $18 =3D # > scheme@(guile-user)> ($18 jami) > $19 =3D # > scheme@(guile-user)> (package-source $19) > $20 =3D #< name: "jami-20230206.0-source" gexp: # guile: #f options: (#:local-bui= ld? #t)> > > The bit comes from the =E2=80=98with-patch=E2=80=99 trans= formation, to > apply the patch to the . I tried to do that, like so: --8<---------------cut here---------------start------------->8--- (define (with-latest-sources name) (options->transformation ;; XXX: The ordering is important; with-patch must appear before ;; with-source, otherwise it is silently discarded. `(,@(if (string=3D? name "libjami") `((with-patch . ,(string-append name "=3D" (search-patch "jami-disable-integration-tests.patch"))) (with-patch . ,(string-append name "=3D" (search-patch "jami-libjami-headers-search.patch")))) '()) (with-source . ,(format #f "~a@~a=3D~a" name %release-version %release-file-name))))) (define libjami/latest ((with-latest-sources "libjami") libjami)) --8<---------------cut here---------------end--------------->8--- Unfortunately the source derivation fails because it attempts to apply a patch (a single one?) to a tarball: --8<---------------cut here---------------start------------->8--- (begin (use-modules (guix build utils)) (setenv "PATH" "/gnu/store/mp0syh29rjknflaiv0hkpdlb2mjk0rlx-patch-2.7.6/b= in") (copy-recursively "/gnu/store/ig8awlxbzrasp9p4f9vq8fqcidrma5qj-jami-20230= 224.0.tar.gz" ((@ (guile) getenv) "out")) (chdir ((@ (guile) getenv) "out")) (for-each (lambda (patch) (invoke "patch" "-p1" "--batch" "-i" patch)) (quote ("/gnu/store/iq7hd3f9kr2kvz7lvnygq51yxp85gxbn-jami-libjami-headers-sear= ch.patch")))) --8<---------------cut here---------------end--------------->8--- My expectation of the source rewriting options is that it should end up with something like what I'd write manually, e.g. an origin with an appropriate fetch method and its patches field populated, etc., so that it'd work the same. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 08:04:43 2023 Received: (at 61684) by debbugs.gnu.org; 25 Feb 2023 13:04:43 +0000 Received: from localhost ([127.0.0.1]:39326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVuEF-0006dn-47 for submit@debbugs.gnu.org; Sat, 25 Feb 2023 08:04:43 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:37532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVuEC-0006dR-Tf for 61684@debbugs.gnu.org; Sat, 25 Feb 2023 08:04:42 -0500 Received: by mail-wm1-f54.google.com with SMTP id j19-20020a05600c1c1300b003e9b564fae9so4147364wms.2 for <61684@debbugs.gnu.org>; Sat, 25 Feb 2023 05:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677330275; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ofl0hbLifHJAw85wB+ndBQtkk9Izt49FvU5fXbGZXm0=; b=lACjT6RvOpcKcnuts0zpjGLnkZhpbQsdRo0yrtHhIGAhDueoLcYTjvSAmS++WB99uf y5Xj0mxA7WBFZ9MllGd8eGJ4tGKhH4sPcczzNcqxYYRVcnyKH2E1zlhnQheFggtu62T6 Ia92bQvQRk/J4zMPdFlInG9Im2V3qhHydEUNYDehON2CNeibRdgp22DjXsTO4xJvMaiP MWPuRIbRZsgsLhnuU/1FQ2A6Nr4Ckw57582LdmTqlM5lne6372S4pC5cPsgNNt5Zmq5d Fernq6RQMIhjrA6DrfTxTr7BBmDx2YLPDddZ+QrF0hcadan7Mdo53ntmUl8Kp56WZ2to ECeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677330275; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ofl0hbLifHJAw85wB+ndBQtkk9Izt49FvU5fXbGZXm0=; b=gJJ3aC0fQHAsVeLDZmsk+F7uUCQhv1JccCKFGKUW1/U0ek4EEnkb/lyOBQiIe89X0O d5tALvsDIYodCqa7SB0ongomas3ewvO4b7kU84xJ2frZOXxfVgq/bQN3CC96ug59Ooqh x/+G3uw877T3wRPoJy7RoEMzAQI9+hAuRA5FTJjuYWIWTNZA1C6Ar0qZTwvP1QOwcmSP +m8iDtKn4E1ZZmzVyTK3Wt+XVqKx7SZ1xa9bb81nMUP4uvdxhVi8Hvso/MI0I6iNLRMI p39XMpd7PfcuIh+AoZKdDycgxB0uKs14FNtCwk448WlGKTfJ+WAQI3MDWcu73flugdXU SKsA== X-Gm-Message-State: AO0yUKViTq2yIOlYMLCNYplf83DqEklzkD7oqJFXL+EjkHLNB6llTXii JFPkojj+E7PZ3CYsCCV3zC3Wf+7vhbA= X-Google-Smtp-Source: AK7set+uKUXhAH67pBkP0k4EHvlIEzyVa0OcSKtR9cnxwl6BdvzYmXeDNI1cT8UA1WvSn+sX9cH9PA== X-Received: by 2002:a7b:c392:0:b0:3dc:5032:2895 with SMTP id s18-20020a7bc392000000b003dc50322895mr14427346wmj.0.1677330274741; Sat, 25 Feb 2023 05:04:34 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id t10-20020a05600c128a00b003dfee43863fsm6131991wmd.26.2023.02.25.05.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 05:04:34 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' In-Reply-To: <87cz5zgogo.fsf@gmail.com> References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <87h6vbgpxf.fsf@gmail.com> <87y1onkwm0.fsf@gmail.com> <87cz5zgogo.fsf@gmail.com> Date: Sat, 25 Feb 2023 13:29:16 +0100 Message-ID: <86zg92apyb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Fri, 24 Feb 2023 at 08:52, Maxim Cournoyer w= rote: > if the API was consistent it'd be much easier for everyone Indeed. However, when it is currently not, the implicit rule is to not break backward compatibility. That=E2=80=99s the whole point. :-) We need to be very cautious when we change the API; even when it is for fixing an inconsistency. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 14:43:21 2023 Received: (at 61684) by debbugs.gnu.org; 25 Feb 2023 19:43:22 +0000 Received: from localhost ([127.0.0.1]:41569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW0S1-00034v-KV for submit@debbugs.gnu.org; Sat, 25 Feb 2023 14:43:21 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:38563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW0Rz-00034j-Qr for 61684@debbugs.gnu.org; Sat, 25 Feb 2023 14:43:20 -0500 Received: by mail-qt1-f174.google.com with SMTP id c18so2892570qte.5 for <61684@debbugs.gnu.org>; Sat, 25 Feb 2023 11:43:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Bu9MKzF8KM62gPjunlgqW+h3Jfrk532sBBufVLJZg50=; b=canIwYLCuGGB5nWE8+my5bX28P66vu5yu5/oZZLN9vefdA4WjFLQJnhrGoIV/xFhM7 NADZ5je+BC1+evBBXHYT3t9J6ht5Lkgi4T/qnSr/5xBDHj4lerR/S+jh9Ryh/roI+wy6 pb0F6d5XOaHW+j28hHPfDtCPcORYklY6i5EOAD4a256SaFPFF6HFLkICLciYu8IozNgx +9/Rg31+IX+1KUubBjS4ArX1oQyacA3hwgAZDAPX6YQs2TPMTghY8EgyNuVrh6hT2b1m KYNAPty0igauJnjSasJbZCe/DN6VbbD5C2EE6e1gDwUU6ey+G6w7EYHMfBE+2V/X4dRT X6Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Bu9MKzF8KM62gPjunlgqW+h3Jfrk532sBBufVLJZg50=; b=aCuT4N/H3qCkQrJHOB04VnHxsyJCIdrR0Uc6qdewgoio4qyXVId+LuIrOtRpqnNp+T mAhihBSDmWlNQv0PX36jq5DJInxgKvSPJJ4TlOtYz/Fj1UoNcYpXs6InRx8wH5d4gutH D+1iQLuhX7pER4kLOdoQ3LLFg7CBIrqa+oMsLyAddNr9GFwszbgD6nQ/z46TMr9sI7zi 3LA6VR65BzoCGOcBjxGvhX0BJ+1D/qyEvcrXcsTSce8LUx5gCyhwqnHEakTPYCB5Dp+P Ng/BCl1rHP+5rq75HlZ3IXU+GoVNifWqKsikTsF2MBoLnn/1Thm6rYG8IrCJ/xWdHKQj rZtA== X-Gm-Message-State: AO0yUKWn4OxpgvogcW5t2tcc2k4TDqcjr5aVU7IQcnEp9eVDDHIH1Fso 5Z5QwTEazqdT0vm3DpmZV4lTLKytY4rGxg== X-Google-Smtp-Source: AK7set8m7INKx+mfLZbtly6VUd6RNCaokpuKOwSQlGoDSlDD6GY+lO9lit+rR7Tlz+km86WdX/QPbg== X-Received: by 2002:ac8:7e95:0:b0:3bf:c178:c6ea with SMTP id w21-20020ac87e95000000b003bfc178c6eamr7875515qtj.56.1677354193970; Sat, 25 Feb 2023 11:43:13 -0800 (PST) Received: from hurd (dsl-141-27.b2b2c.ca. [66.158.141.27]) by smtp.gmail.com with ESMTPSA id g2-20020ac870c2000000b003b868cdc689sm1826986qtp.5.2023.02.25.11.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 11:43:13 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <87h6vbgpxf.fsf@gmail.com> <87y1onkwm0.fsf@gmail.com> <87cz5zgogo.fsf@gmail.com> <86zg92apyb.fsf@gmail.com> Date: Sat, 25 Feb 2023 14:43:12 -0500 In-Reply-To: <86zg92apyb.fsf@gmail.com> (Simon Tournier's message of "Sat, 25 Feb 2023 13:29:16 +0100") Message-ID: <87a611fs4v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Simon Tournier writes: > Hi Maxim, > > On Fri, 24 Feb 2023 at 08:52, Maxim Cournoyer = wrote: > >> if the API was consistent it'd be much easier for everyone > > Indeed. However, when it is currently not, the implicit rule is to not > break backward compatibility. That=E2=80=99s the whole point. :-) > > We need to be very cautious when we change the API; even when it is for > fixing an inconsistency. Agreed; if the current behavior really provides well outlined benefits, we could always introduce a "--order-sensitive" option for its users. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 09:09:36 2023 Received: (at 61684) by debbugs.gnu.org; 27 Feb 2023 14:09:36 +0000 Received: from localhost ([127.0.0.1]:46431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWeC7-0001mH-SX for submit@debbugs.gnu.org; Mon, 27 Feb 2023 09:09:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWeC5-0001m5-Pj for 61684@debbugs.gnu.org; Mon, 27 Feb 2023 09:09:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWeBz-0000Yd-Vc; Mon, 27 Feb 2023 09:09:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=CPRYIrpfb/xFNtjsCP1NHTAWx6i4L7IDrO6rFlQYpL8=; b=BmV/MhKkwuAbOYykL1Tx jmpdGm1/aVnHBlQMM6V/1JBn0KFCI+ayJNZEsgZPBLq8+Ho7yvUyw6CZsZ9ur7N2cv19lFdWFrSGM 1L4hxVYiwhP3lbzoqBqs/QskgCpcWeRij8QKv9p3O2FIO6tgDXLNmcUB3BetBziMRRvod5swEdLfs +UjoR8hcgU+B952gf0VeEyjE+A0i5yzgU2X3A9JvQUmU8A9txTDDfFI62sNA/6tEAqmMLn+QnyzVI wh6k6KvYGk4WOoh7+ftN77oqFN+6p3xcjCvdsBJzJBeR8QxZRqCkpPE78p85EFNzQhicIgglSzTnS cyqEAr8J9V55MA==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWeBz-00083B-8w; Mon, 27 Feb 2023 09:09:27 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> Date: Mon, 27 Feb 2023 15:09:23 +0100 In-Reply-To: <875ybrmfuv.fsf@gmail.com> (Simon Tournier's message of "Fri, 24 Feb 2023 13:02:00 +0100") Message-ID: <878rgjkxnw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Simon Tournier skribis: >>>From my point of view (and what I tried stopping in the middle :-)) is > to report if the transformation makes sense or not. For instance, You stated that multiple times and there=E2=80=99s general consensus that reporting the issue would be great. However, as I explained before, there=E2=80=99s no clear way to do that for= two reasons: 1. Transformations apply to bags, not packages, so we cannot tell whether a transformation has an effect until after the transformed package has been lowered. Even then, it=E2=80=99s tricky. 2. In this case, this has to do with the semantics of transformations themselves: by definition, =E2=80=98with-source=E2=80=99 dismisses pat= ches. [...] > Well, I am not convinced that enforce the ordering is a good thing > because as Ludo said, some HPC user exploits this control of ordering to > generate complex transformations. My point is that there are folks who have been using package transformation options for years; any claim has to be evaluated in that light, and any change would have to be considered very carefully. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 09:12:38 2023 Received: (at 61684) by debbugs.gnu.org; 27 Feb 2023 14:12:38 +0000 Received: from localhost ([127.0.0.1]:46436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWeF4-0001qp-Eo for submit@debbugs.gnu.org; Mon, 27 Feb 2023 09:12:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWeF3-0001qb-5F for 61684@debbugs.gnu.org; Mon, 27 Feb 2023 09:12:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWeEx-0001Kv-NI; Mon, 27 Feb 2023 09:12:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=a9CPvaI5YdSn45lVFuWz8nLq2DK0kCVfJ7LEbfPMfxc=; b=h+g5OGit9f677Aop/gGd TvTN4nXHv6RcUXGV963lWz0PZDc6jJIy+UkIaMnSz5wXl77lqhfpJcJSsdLD7L7EvkPM7fx9aoc63 RdjfPi6JQ2k7LBguUicO5oVDED16a8eKGkjQ5D0oBkW4LTYzXmdiZU6JIYo12JmO3nBT2+Fi79jlc hmKoBgnVDQgtKYfeN8P2lGbOZPLpKlXTP2H6Gjh0jyaGoumMeVuNYrJRUQwJVJSn7oOrdZTu94ydz A8HG1aj6VMTPRbib+H4rz9uCjbcM9Ta1MAywLOoNs4kdJE2OQvLw+suBhAnAS/kUFd5zKikGS8xFT FB+OYi29OWr+Pg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWeEw-0002KH-RU; Mon, 27 Feb 2023 09:12:31 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <87h6vbgpxf.fsf@gmail.com> <87y1onkwm0.fsf@gmail.com> <87cz5zgogo.fsf@gmail.com> Date: Mon, 27 Feb 2023 15:12:29 +0100 In-Reply-To: <87cz5zgogo.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 24 Feb 2023 08:52:39 -0500") Message-ID: <87zg8zjiya.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: >> Quoting Ludo, >> >> (this is crucial for ou= r HPC >> users, who routinely combine a whole bunch of options; you have = no idea >> how far they go once you give them the tool :-)) >> >> >> >> and I agree with =C2=AB you have no idea how far they go once you give t= hem >> the tool :-)) =C2=BB. > > It seems a bit hypothetical at this point, so I wouldn't want to cripple > the design by it. It baffles me that you would consider other people=E2=80=99s experience as =E2=80=9Chypothetical=E2=80=9D. It=E2=80=99s not, really. The choice of words after the comma is also unfortunate in several ways. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 11:29:54 2023 Received: (at 61684) by debbugs.gnu.org; 27 Feb 2023 16:29:54 +0000 Received: from localhost ([127.0.0.1]:48654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgNu-00052j-BJ for submit@debbugs.gnu.org; Mon, 27 Feb 2023 11:29:54 -0500 Received: from mail-qt1-f171.google.com ([209.85.160.171]:39627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgNp-00052O-DT for 61684@debbugs.gnu.org; Mon, 27 Feb 2023 11:29:53 -0500 Received: by mail-qt1-f171.google.com with SMTP id w23so7271155qtn.6 for <61684@debbugs.gnu.org>; Mon, 27 Feb 2023 08:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Gldkw1ATZknEDLLNR6d0bdra3ybhwnX/3RrdLE7Xcc8=; b=mcr/fwcTw3dc2gjjp3/VQxoFfyay2VC8aJxyswrUi1dc3A9GQAhe2BFsXCbvNQdexb 17pjCkMVVsFrveQ9Z3U/imu02SE275I0QVtvZ+XEWADV3K44hllhs5KqIvqPkVYqhhi3 pEF53wBamzTzDO3+8kyRp39319BL4CAgDUp4/nsH68G8fqpNFCzhIaQUePEM1Gw+A7Xi xMftqQU+UPUKpN8fJfb2mxgVNPz7RobjUTu/WYV4nssWRk+K9oTeMjvaCBiEvT5Yhq5F Tk8yZkXBxCJjqL2MS7HWOKGv4Fc52ItM2lunIufrZDvKvPSqK9hIV6ZAywVhWYhJcVB3 feaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Gldkw1ATZknEDLLNR6d0bdra3ybhwnX/3RrdLE7Xcc8=; b=XA2aq/idY53JcPUjzZPRv57FKNdCj3AN75Qnznw3/JebYxU7U5VbSgpZP1JmigdLnD DICb35Qj7f1DlYmUiiROZGUnJLO9ZGLajZrrh2CE4/URUp6xzF18o57E+op8FfGBHLiQ nJfKyMWhRNPJg3qbfHwQwAFRzONWkGEdM4KlCoqmfcZmRLHuRTRfIICyazPBJf7w68ix V8c9esYmeuuU8ib+h60ATv4LBnIM4pz9tbg/1N4FZASX/EbfSF1OwHZyU+tC24yzPZ9N o0nuv/J/DR798ia65hit9YPjEtv0HfZyUQRMSHVa0zGcnKCc9IU6NT5ZMlBpuYb8UflV taHQ== X-Gm-Message-State: AO0yUKVclxBDZilA6VWz1fehcK0UUIGd3QzkFQbbNQZf9odjYziC3F3R MMWcKPwer1XChQ5ceOOWakU+t/HUKE+fhg== X-Google-Smtp-Source: AK7set8HWaDqBQ8eGZ/v/9J+TuCy9a21za1yLad3i8tcISgyS+NGZCadEPi3eY1sD0P7PqsfhbvBGA== X-Received: by 2002:ac8:58c3:0:b0:3bf:d490:f218 with SMTP id u3-20020ac858c3000000b003bfd490f218mr8790384qta.43.1677515383477; Mon, 27 Feb 2023 08:29:43 -0800 (PST) Received: from hurd (dsl-156-86.b2b2c.ca. [66.158.156.86]) by smtp.gmail.com with ESMTPSA id h21-20020ac87155000000b003b85ed59fa2sm4868495qtp.50.2023.02.27.08.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 08:29:43 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <87h6vbgpxf.fsf@gmail.com> <87y1onkwm0.fsf@gmail.com> <87cz5zgogo.fsf@gmail.com> <87zg8zjiya.fsf@gnu.org> Date: Mon, 27 Feb 2023 11:29:42 -0500 In-Reply-To: <87zg8zjiya.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 27 Feb 2023 15:12:29 +0100") Message-ID: <87fsarkr61.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >>> Quoting Ludo, >>> >>> (this is crucial for o= ur HPC >>> users, who routinely combine a whole bunch of options; you have= no idea >>> how far they go once you give them the tool :-)) >>> >>> >>> >>> and I agree with =C2=AB you have no idea how far they go once you give = them >>> the tool :-)) =C2=BB. >> >> It seems a bit hypothetical at this point, so I wouldn't want to cripple >> the design by it. > > It baffles me that you would consider other people=E2=80=99s experience as > =E2=80=9Chypothetical=E2=80=9D. It=E2=80=99s not, really. I didn't mean to dismiss other people experiences. The reason I'd like to orient this discussion toward use cases, is that these are easier to work with (more concrete/well defined) than user experiences. I'm sure people use it in many ways I can't think of, and what I'd like us to do is be able to put a finger on what these ways are, and how the current API could be improved in a way that satisfies them all (if possible). > The choice of words after the comma is also unfortunate in several ways. Noted. For the record I used in for its "flawed or imperfect" definition. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 05:36:39 2023 Received: (at 61684) by debbugs.gnu.org; 28 Feb 2023 10:36:39 +0000 Received: from localhost ([127.0.0.1]:49788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWxLa-0000I7-VQ for submit@debbugs.gnu.org; Tue, 28 Feb 2023 05:36:39 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:37624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWxLZ-0000Ht-G6 for 61684@debbugs.gnu.org; Tue, 28 Feb 2023 05:36:38 -0500 Received: by mail-wr1-f51.google.com with SMTP id h14so9190999wru.4 for <61684@debbugs.gnu.org>; Tue, 28 Feb 2023 02:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677580591; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=GfcTrYkN9JqnhY0sZHosQvmuMNwuwj+f+QTjtt7StW0=; b=drJ+j71MvDsPBkQ61rfX03gny3gsOggnY1Nz5KROh/KQgS5CebOy9amjnU1j9s8daO EiQZNWHpvskpR09TLifPL74cJ0u+cfqrw7TIN9iW3YHJMrwezDCAxMIJhbQLrYGXJgnc VzwEh5uqx5As0wGCiYqCtIJc/sZoVHuIi7OR5c1R+n6QeWNsVHmAzTID6htUSy8c6Ynk dSMr3US6OEXO9wtKLGx85/0vNrBzgNVgs+6/hPsdrWMcwNVRw5QEyrekp0RL5LqrNG57 EwHJhuzjGJCWEgYperGqCwfrHdYik8Ybis+Yc7Yih4wry7TYtPJZXYcS5+9N2/37SwQ+ kYcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677580591; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfcTrYkN9JqnhY0sZHosQvmuMNwuwj+f+QTjtt7StW0=; b=HELVmMfD71LtMnNO5iX3oN84pneMyAybThU3L364GKu0QR62SOJnfsY3gby52IifvM j87wvhdCXraafSPLm2n7rs38aklxqtBVRLR6dLqgh49Ev3zxq5zwpuQ27vWI2yPY+Kt3 97qaSa23cLfIR9XJZvbBJ+bs9HtIID2nOV5TIQ8TBg45x/pt0gQ54X8feSOus2fnGvY4 q4T1PdT8SG4Eq5NAEkuhwG/nPVNFCCHYaKoaQTjwOwYdVzi/CPjiDdh7BiOUuGSYSZTM 0JDFeOpeaPuH8pSIM6g3TqB1g5iWN/s5GK8PT0O28modqHxoGLc7TVLR23/LqjXBhwSe XBkQ== X-Gm-Message-State: AO0yUKU0LoK4+1Z44ciBnKVgnwnAy6/VGPkii3fRYooZv3ATApU8Y3IO HJctFT7t8aPbkuONUZSTmNk= X-Google-Smtp-Source: AK7set9gbeZ1fA2S4j93ea+qC2ilBZ9+GK4ejIXfgAn1B9K/lfD44T+2KQe+gv593TRH6SP0bll78w== X-Received: by 2002:a05:6000:90:b0:2c7:1a96:efc2 with SMTP id m16-20020a056000009000b002c71a96efc2mr1544466wrx.4.1677580591718; Tue, 28 Feb 2023 02:36:31 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003e876122dc1sm16488902wmq.47.2023.02.28.02.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 02:36:31 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' In-Reply-To: <878rgjkxnw.fsf@gnu.org> References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <878rgjkxnw.fsf@gnu.org> Date: Tue, 28 Feb 2023 11:00:08 +0100 Message-ID: <87y1oijejb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, On lun., 27 f=C3=A9vr. 2023 at 15:09, Ludovic Court=C3=A8s w= rote: > However, as I explained before, there=E2=80=99s no clear way to do that f= or two > reasons: > > 1. Transformations apply to bags, not packages, so we cannot tell > whether a transformation has an effect until after the transformed > package has been lowered. Even then, it=E2=80=99s tricky. > > 2. In this case, this has to do with the semantics of transformations > themselves: by definition, =E2=80=98with-source=E2=80=99 dismisses p= atches. I probably miss many details and that=E2=80=99s why I do not understand correctly your words. Or maybe we are not using the same meaning behind =E2=80=9Creport if the transformation makes sense or not=E2=80=9D. 1. From my point of view, the transformations are functions that you compose. The composition rule is not commutative maybe neither associative. Writing down how each function (transformation) composes with the others allows to specify the composition rules. 2. All the code in (guix transformations) acts at the package level, so I am still missing why it would not be possible to detect some issues there. For instance, --8<---------------cut here---------------start------------->8--- (define applicable ;; List of applicable transformations as symbol/procedure pairs in the ;; order in which they appear on the command line. (filter-map (match-lambda ((key . value) (match (transformation-procedure key) (#f #f) (transform ;; XXX: We used to pass TRANSFORM a list of several ;; arguments, but we now pass only one, assuming that ;; transform composes well. (list key value (transform (list value))))))) (reverse opts))) --8<---------------cut here---------------end--------------->8--- and I miss why, 1. it would not be possible to check if the transforms compose well; somehow verify the assumption. For instance, =E2=80=99package-with-upstream-version=E2=80=99 raises many w= arnings depending on various cases, and I miss why, 2. it would not be possible to have similar warnings for other transformations. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 10:49:43 2023 Received: (at 61684) by debbugs.gnu.org; 1 Mar 2023 15:49:43 +0000 Received: from localhost ([127.0.0.1]:54657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXOi7-0000Lb-3Z for submit@debbugs.gnu.org; Wed, 01 Mar 2023 10:49:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXOi5-0000LO-98 for 61684@debbugs.gnu.org; Wed, 01 Mar 2023 10:49:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXOhz-0006ri-U6; Wed, 01 Mar 2023 10:49:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=gy4Zib3CQWq/Yc7RYgBI8RN7QCcqriAeY303tdWeR7g=; b=Nz51uhQkofJ8hq/Oxjrq D4XwpXzw5CjN+J9drNegd/Nbwps6T8TBzVjjwM08MnPjktkLJ1ZNfdgX9qUeUFRC+n4bp/Ey2TLxO 1Cy90V2AG7bGh4xYA++5DoeUVDXbmBlniPD7K4dSgJ58gsK0plrGx2vwWDoc3p+qQ7OoYbTBnu51O hxpAGp/4oFdJ87RestgxHaKkKVANIhJcAVQAehFt6WMRO699ff6tWvGvnY/iPCinGqZMMDeO8vLtD myXzg1nQC8zCiuHPopOj29WsbJns8BG8cuQiheJZLcM/WEY1rMK4ivLmpqhz7GPEG5ZD4JgkNXIBX 9xNM8YwJK6L+dQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXOhz-00035L-HY; Wed, 01 Mar 2023 10:49:35 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon Tournier Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <87356whvaa.fsf@gmail.com> <875ybrmfuv.fsf@gmail.com> <878rgjkxnw.fsf@gnu.org> <87y1oijejb.fsf@gmail.com> Date: Wed, 01 Mar 2023 16:49:33 +0100 In-Reply-To: <87y1oijejb.fsf@gmail.com> (Simon Tournier's message of "Tue, 28 Feb 2023 11:00:08 +0100") Message-ID: <87pm9sbhf6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Simon Tournier skribis: > 1. From my point of view, the transformations are functions that you > compose. The composition rule is not commutative maybe neither > associative. Writing down how each function (transformation) > composes with the others allows to specify the composition rules. > > 2. All the code in (guix transformations) acts at the package level, so > I am still missing why it would not be possible to detect some > issues there. Please check out =E2=80=98package-input-rewriting=E2=80=99 and its behavior with #:deep? #t. Design discussion: . > 1. it would not be possible to check if the transforms compose well; > somehow verify the assumption. Try it. :-) I tried to explain it multiple times, I really did, but I guess there=E2=80=99s no substitute to first-hand experience. > For instance, =E2=80=99package-with-upstream-version=E2=80=99 raises many= warnings > depending on various cases, and I miss why, > > 2. it would not be possible to have similar warnings for other > transformations. =E2=80=98package-with-upstream-version=E2=80=99 raises warnings that depend= exclusively on local knowledge. Here we=E2=80=99re talking about warnings related to the composition to two different options which, like you wrote, are independent functions. It=E2=80=99s not similar. HTH! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 04:43:34 2023 Received: (at 61684) by debbugs.gnu.org; 3 Mar 2023 09:43:34 +0000 Received: from localhost ([127.0.0.1]:59649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY1ws-0005hM-0g for submit@debbugs.gnu.org; Fri, 03 Mar 2023 04:43:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY1wq-0005h7-0n for 61684@debbugs.gnu.org; Fri, 03 Mar 2023 04:43:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY1wk-0006Ve-M6; Fri, 03 Mar 2023 04:43:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=dXiivH0RSgbNh1xvMgkxztepZfOhrtsnB802O6hAe+c=; b=RJsU8TrPR7WJEWQ4L3p+ ncY5wrCGtxzvjdApvW4HEZ/9Bq6ECBQAHa9eEY3jjYLGybGQEOMohbxjJtMJaqg+PKU0G/ySqMLiL ys9rHMCytGlyrEDD5Ez6vxUpEcVweiI3WYCQDal2jCUFuhUyBg4Lvi2SJmU4dlVyp42QeH8Sm841F M0Wt0pujbEhs4hpTDyzTu87U5FP8T1Peio4sadfKcbx8HOgjqeXRbb/ge80EmyZ37gTOQyjOsNozc A7Llue/LUaRc51QiKqhP730xkEl2Qcgs2vKXqLj3LRVFeCneV4as20N7GQ881niX2eHVFQTybkTP4 3cxWf+hTwrHdoA==; Received: from [193.50.110.138] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY1wQ-0006JZ-An; Fri, 03 Mar 2023 04:43:11 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#61684: can't compose 'with-patch' with 'with-source' References: <87mt56gac6.fsf@gmail.com> <871qmg79u7.fsf@gnu.org> <877cw7go5k.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 13 =?utf-8?Q?Vent=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la Fumeterre X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 Mar 2023 10:43:04 +0100 In-Reply-To: <877cw7go5k.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 24 Feb 2023 08:59:19 -0500") Message-ID: <87h6v2187r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61684 Cc: 61684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, Maxim Cournoyer skribis: > Unfortunately the source derivation fails because it attempts to apply a > patch (a single one?) to a tarball: > > (begin > (use-modules > (guix build utils)) > (setenv "PATH" "/gnu/store/mp0syh29rjknflaiv0hkpdlb2mjk0rlx-patch-2.7.6= /bin") > (copy-recursively "/gnu/store/ig8awlxbzrasp9p4f9vq8fqcidrma5qj-jami-202= 30224.0.tar.gz" > ((@ > (guile) > getenv) > "out")) > (chdir > ((@ > (guile) > getenv) > "out")) > (for-each > (lambda > (patch) > (invoke "patch" "-p1" "--batch" "-i" patch)) > (quote > ("/gnu/store/iq7hd3f9kr2kvz7lvnygq51yxp85gxbn-jami-libjami-headers-se= arch.patch")))) That=E2=80=99s a bug we should fix (and indeed, =E2=80=98patched-source=E2= =80=99 has an XXX comment about it=E2=80=A6). Ludo=E2=80=99.