Subject: Re: [PATCH] gnu: podman: Add 'docker' alias script as 'docker' output

From: lWP6SrZsSwhCy5tUxadDfg <[email-masked]>
Date: Wed, 22 Feb 2023 05:52:47 +0000

> On Feb 22, 2023, at 13:19, Liliana Marie Prikler <[email-masked]> wrote:
>
> Am Dienstag, dem 21.02.2023 um 14:34 +0000 schrieb Zongyuan Li:
>> * gnu/packages/containers.scm: New 'docker' output for podman
> That ChangeLog looks somewhat incomplete.
>
>> Signed-off-by: Zongyuan Li <[email-masked]>
> Signed-off-by is for committers signing off the commits.
>
>> ---
>>  gnu/packages/containers.scm | 157 +++++++++++++++++++---------------
>> --
>>  1 file changed, 83 insertions(+), 74 deletions(-)
>>
>> diff --git a/gnu/packages/containers.scm
>> b/gnu/packages/containers.scm
>> index 272b67c38d..80c4aaa400 100644
>> --- a/gnu/packages/containers.scm
>> +++ b/gnu/packages/containers.scm
>> @@ -312,83 +312,92 @@ (define-public podman
>>    (package
>>      (name "podman")
>>      (version "4.3.1")
>> -    (source
>> -     (origin
>> -       (method git-fetch)
>> -       (uri (git-reference
>> -             (url "https://github.com/containers/podman")
>> -             (commit (string-append "v" version))))
>> -       (modules '((guix build utils)))
>> -       ;; FIXME: Btrfs libraries not detected by these scripts.
>> -       (snippet '(substitute* "Makefile"
>> -                   ((".*hack/btrfs.*") "")))
>> -       (sha256
>> -        (base32
>> "05hv4xdf06n728lmsx793zygypc9i404bgcgpy0fyrg8c2s11q2h"))
>> -       (file-name (git-file-name name version))))
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url "https://github.com/containers/podman")
>> +                    (commit (string-append "v" version))))
>> +              (modules '((guix build utils)))
>> +              ;; FIXME: Btrfs libraries not detected by these
>> scripts.
>> +              (snippet '(substitute* "Makefile"
>> +                          ((".*hack/btrfs.*")
>> +                           "")))
>> +              (sha256
>> +               (base32
>> +
>> "05hv4xdf06n728lmsx793zygypc9i404bgcgpy0fyrg8c2s11q2h"))
>> +              (file-name (git-file-name name version))))
> Don't mix style changes with functional ones.  `guix style', while
> recommended in the manual, often does more harm than good.
>
>> +    (outputs '("out" "docker"))
> Since this is a very non-standard output, perhaps try describing it
> with a output-synopsis package property.
>
> Cheers

Thanks for the review. I will take a look :)
By the way, should I post a new v2 patch in a new thread, or just continue with this one?