From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 09:31:31 2023 Received: (at submit) by debbugs.gnu.org; 21 Feb 2023 14:31:31 +0000 Received: from localhost ([127.0.0.1]:55116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUTg3-00018d-AD for submit@debbugs.gnu.org; Tue, 21 Feb 2023 09:31:31 -0500 Received: from lists.gnu.org ([209.51.188.17]:59348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUTg1-00018V-3A for submit@debbugs.gnu.org; Tue, 21 Feb 2023 09:31:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUTg0-0005EL-Pf for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 09:31:28 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUTfz-0002n1-6L for bug-gnu-emacs@gnu.org; Tue, 21 Feb 2023 09:31:28 -0500 Received: by mail-ed1-x52a.google.com with SMTP id cy6so12498292edb.5 for ; Tue, 21 Feb 2023 06:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=4cbf5Rvrtt2jFL6bidNox+DOc2K3pZ3LYRsL4s6N7SI=; b=QzHfa7syeMsMQkTS9Sz9ERSvG8OAtP9ogMit/YH30ZuHIjTJqupk+YJzhusqrb74p3 2L71RSzFVz0n019MSdXMMGJ6RqQoj4PqIhfJakjJ6HiRByXVUpv3Htx+Tw/5MkRN0Rck 0Tv/PDQqW/YHquOxmo28y6aqVYrT4RBBkaAYJqfxrJKXBLrD82Cl2VBq981b+vqvL8GI /lLea7lTZErOrtQ5KvjQKYUpdAdaVZ0jMy1DqlMlQELnu9k6En8FKXG0v0QvSro0kYHn 7V7ZjTXiXCfRzhOQffdHaSIGpeceDIzNg4HazCDrTSDaoOkDoC6VIU1Y9XxwTKruaNUb /pjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4cbf5Rvrtt2jFL6bidNox+DOc2K3pZ3LYRsL4s6N7SI=; b=C35jVDPh5YlYdHOR2R+2vR0UF3Du77E0pJh9vA5kL+HwO5Z51IdggxS54RtZwJVjUH 7qy0i86+9Km6stCs0YVYtXAiDojhGBdyUbYpsYZ3SEDEKanM04SkDG2FxEsxSNMu1niA 9kApNJwcA7TjabrwP+wDU/1xKkpWh8+ximYjg8XyLNmn35IlZZ6zUCOG7DKaDYxuzAGG HBlJVS1poKFTMmjzUimPW5k8EwBZ1v7mFz1BXHNX6cynUinuiVNW12tFYOFM2JnV6mAl nkwZj3P0/n45kBHKr+ud4ymveZN/KK2h5lvF+y8zVN41FX7tLvFQwY67TeK2miKAOB4U hTow== X-Gm-Message-State: AO0yUKWqIJFWishVR4+3dbIK80tL6hBy5J8mvpNR64MOy9RVvtjLXOoR Kh+wr0uozHrrQZLOJK9BApL1Hnb3C+4= X-Google-Smtp-Source: AK7set/pjtHFR6zD3s/Y6G3avrWko8SGJyK3RKNVHi54+CzrFMBqq5RhJpOdDW/CET1w1b5jGX6r1w== X-Received: by 2002:a17:906:d99:b0:8b2:2141:6de8 with SMTP id m25-20020a1709060d9900b008b221416de8mr14226190eji.73.1676989885007; Tue, 21 Feb 2023 06:31:25 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id p20-20020a1709060dd400b008be5b97ca49sm4572239eji.150.2023.02.21.06.31.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 06:31:24 -0800 (PST) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: 29.0.60; Eglot: staying out of trouble X-Debbugs-Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 21 Feb 2023 15:31:23 +0100 Message-ID: <87mt57f5tw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=arstoffel@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Eglot modifies several Emacs features, and it seems to do so independently of the server capabilities. For instance, it registers a capf and Eldoc functions even if the server does't provide completions respectively "hover"/signature help. In some cases (capf, xref) this seems innocuous, in others (eldoc) Eglot is really overwriting a possibly useful function with a possibly useless one. Now, the above are somewhat silly examples, but the Flymake case is quite problematic. There exist good servers that don't provide diagnostics, and Eglot still overwrites `flymake-diagnostic-functions'. To make things worse, LSP doesn't provide a way to the server to advertise whether or not it provides diagnostics. I would suggest that Elgot initially should keep flymake-diagnostic-functions unchanged, and only overwrite it when the first diagnostic comes from the server. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 10:01:07 2023 Received: (at 61679) by debbugs.gnu.org; 21 Feb 2023 15:01:07 +0000 Received: from localhost ([127.0.0.1]:57004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUU8g-0002Qj-Lw for submit@debbugs.gnu.org; Tue, 21 Feb 2023 10:01:06 -0500 Received: from mail-oi1-f170.google.com ([209.85.167.170]:39566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUU8d-0002Px-LI for 61679@debbugs.gnu.org; Tue, 21 Feb 2023 10:01:06 -0500 Received: by mail-oi1-f170.google.com with SMTP id y8so4719343oiy.6 for <61679@debbugs.gnu.org>; Tue, 21 Feb 2023 07:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bODIkMjue1gqDhs3OutHBDexR2LvWY0lqMTfh3TKMWU=; b=cdWDI5e8FfucwIzCHlUgmFlC575qPnPviZoqWU2fb+kNsBQVOo+TMcjz/cQaw9ptEE B0K4/81H17BXo+DKF1A8et9JYpvVMGDzyB9cQCO+duUOiM4pjyuh7GCLKtKkoxLqG18p mZYD7zu4nE4lKOFvpUyoYH9jicvPDxiikFMKt/HGCOKkQ1ZOhTcuB8RnW3s+LCAYWWlV gwE3m7qpQFDOdAMcFuK9EO0LQ5oGDO4ipccZTROi2IqrRhXorLwdL+IZ0QDzVuwpTLHN 3Onu5Ze0BMapgbmn0exOj6xpgqEi3+HxQLR65X2HMn7LAgKg5aw6vmwwrnHDBCwK2y7d AAag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bODIkMjue1gqDhs3OutHBDexR2LvWY0lqMTfh3TKMWU=; b=kk0Ei5qrw4rUDU3M7cNiTcCfJ+mFSEAmyrnuUOWUXlfn2aqeWtXhgtJF6sqbC2jUY4 p73dmvg9vhpZwVVstoWq6J1aLht37S7kQBztn90s/Q6jAJAOTON02N11lMEvW7dpr+SX W9zUPGaxGXwgNCf4GHohMZ/g/28n+p4g7poYPsszzqRC0R23sRvVIr6Ln/mggimKFGBa 7hxSnpyVXXawlE3H5GNHTviPSz4as4JNg+RKCsyD7QpGXyAP1tCtSDP8p91SEt59BC7H +bzNdRP+bSNjIK4ZDwDJOeBzACfQa3PYl39EbVys7SNIN5TYBlOSj5IAkhK3BxOnop76 K6pA== X-Gm-Message-State: AO0yUKVrzUoihlYI0b6QfmAz87LJLX6db/TTdXqTADt3D07lI16znRuN vJlTP681E1E+8yn81eM+YRPqEOJFPHzG1qLAKm1NPW6sbzk= X-Google-Smtp-Source: AK7set/gzTZ5WOeOzQolSHt8RwmnUzbq57yrjh2wQuq1yQW7AASl6Db26bM/t+6fJdvROO1FX/xabmgafS39e1jdD40= X-Received: by 2002:a05:6808:128b:b0:37b:9a3:136f with SMTP id a11-20020a056808128b00b0037b09a3136fmr700983oiw.6.1676991657874; Tue, 21 Feb 2023 07:00:57 -0800 (PST) MIME-Version: 1.0 References: <87mt57f5tw.fsf@gmail.com> In-Reply-To: <87mt57f5tw.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 21 Feb 2023 15:00:47 +0000 Message-ID: Subject: Re: bug#61679: 29.0.60; Eglot: staying out of trouble To: Augusto Stoffel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61679 Cc: 61679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Feb 21, 2023 at 2:32 PM Augusto Stoffel wrote= : > > Eglot modifies several Emacs features, and it seems to do so > independently of the server capabilities. For instance, it registers a > capf and Eldoc functions even if the server does't provide completions > respectively "hover"/signature help. > > In some cases (capf, xref) this seems innocuous, in others (eldoc) Eglot > is really overwriting a possibly useful function with a possibly useless > one. In the Eldoc case, as of yesterday, this no longer happens. Look at commit e83c78b8c7784254c2c6f043530ab325c2fa7f16 Author: Jo=C3=A3o T=C3=A1vora Date: Mon Feb 20 22:43:50 2023 +0000 Eglot: respect user's Eldoc configuration by default > I would suggest that Elgot initially should keep > flymake-diagnostic-functions unchanged, and only overwrite it when the > first diagnostic comes from the server. This seems way too complicated for a problem that hasn't even been demonstrated. The reason there's no capability announcement for diagnostics is likely because it's such a basic capability that virtually every server supports it, unless you go out of your way to find or craft one that doesn't. When activating Eglot, you're saying "let this here LSP server manage my buffer by connecting it with these Emacs infrastructures" You're letting go of some of your major-mode's configuration and user configuration for what is in 99% of the cases a much more integrated and hassle-free IDE experience. Even so, Eglot only temporarily overrides your configuration and will not do so gratuitously, as the commit above illustrates. In Flymake's case, it is really important to override the value by default or else super-popular languages like Python handled by python mode start showing confusing duplicate diagnostics to newbie users, and we don't want that. If you really like your pre-Eglot configuration, you can combine it with Eglot's by leveraging eglot-managed-mode-hook and eglot-stay-out-of. This was Eglot's philosophy from the start and I don't intend to change it. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 10:09:24 2023 Received: (at 61679) by debbugs.gnu.org; 21 Feb 2023 15:09:24 +0000 Received: from localhost ([127.0.0.1]:57014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUGi-0002cP-5N for submit@debbugs.gnu.org; Tue, 21 Feb 2023 10:09:24 -0500 Received: from mail-ed1-f51.google.com ([209.85.208.51]:39637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUGd-0002c9-U5 for 61679@debbugs.gnu.org; Tue, 21 Feb 2023 10:09:22 -0500 Received: by mail-ed1-f51.google.com with SMTP id f13so17932483edz.6 for <61679@debbugs.gnu.org>; Tue, 21 Feb 2023 07:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=A3WUoJUXQ5bWKpT6MFJTS6ZVPkp5bIvKpsubBEfQ5G8=; b=HMsk8y1vfQJr2LV8SriicVMS8JL/FEjGqQOPUfT8HzahVO3SwFGWVGAFbU8O9RsW/a 4i3urPp14gid428+fW+dnS9RFmiwXBXapbG466j7xB6K0br443uLXC1vLnFN26scdfRM JdJ1sG1AwuBeGcMidS/HlTeZ2eThnZ4YNjT8JkLkJey3dJA3MreLg3+4i1pAQsjvZbfw s9Cj39I3B0g9f3UZBnPgZuk6MAo/AlKQ8tOOKzzxWlvAcL5NWKBuN2YKGL9ct+X11439 Bo1pi8o2Ybuj0oNumtCCdzFXuuTdoAVu0IBLP25HCzpYUm8AkiZp6A3Yi3wX+Vmqlz14 pewQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A3WUoJUXQ5bWKpT6MFJTS6ZVPkp5bIvKpsubBEfQ5G8=; b=1Ax62Bi7pFWbxw4/OtXHtsA2qZkvVVRbntv7Rmzi2218sYDy6t++DmRXLXITLTPPBz NICuFjt1aiitziax9o5F7TZacWtA5jhvQvJF53PK7UzP5dlSBADmogasyb25UNAVOI8Y pvayqvxEB/N00O+aAszcoNupy6Yy1btmXlSH6WbYd28JVZ8E8f+aK86L+ThZW+WIJQ3C 3cc56udfKn/zjau5TErwlAzoWgwJunh4AJ5Rftt4hrEItg2Sak0yMG1VdbdzsWAPy4b6 EZVekfGLxPg8vpYFuBYw6XzxXD0oLW5ijT7n6MXnSmvbMxmZa15KwA0XwXBAyRpG8Z5R +cZQ== X-Gm-Message-State: AO0yUKUTbyIBnysvsy0FUBnwOANPnXwWYN7xBoAn7QCs5RCAnGLdhVoZ aFsHvNQ63py4Fs7o0jbx+Pe9Cy01txU= X-Google-Smtp-Source: AK7set/1nulPlkBCOo7a82Boo8Snuz1yN2gBpoalKRdk3W0eT69UUYxUHJCdGIfbswYtqSQjPONPjg== X-Received: by 2002:a17:907:d304:b0:878:5372:a34b with SMTP id vg4-20020a170907d30400b008785372a34bmr13416970ejc.45.1676992153581; Tue, 21 Feb 2023 07:09:13 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id w19-20020a170906b19300b008ddf3476c75sm1154004ejy.92.2023.02.21.07.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 07:09:13 -0800 (PST) From: Augusto Stoffel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#61679: 29.0.60; Eglot: staying out of trouble In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 21 Feb 2023 15:00:47 +0000") References: <87mt57f5tw.fsf@gmail.com> Date: Tue, 21 Feb 2023 16:09:11 +0100 Message-ID: <87ilfvf42w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61679 Cc: 61679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 21 Feb 2023 at 15:00, Jo=C3=A3o T=C3=A1vora wrote: > In the Eldoc case, as of yesterday, this no longer happens. Okay, nice. > This seems way too complicated for a problem that hasn't even been > demonstrated. jedi-language-server doesn't provide diagnostics and it's officially supported and rather popular. (My digestif server also doesn't support it but I'm not going to mention that.) Since I only ever used 3 servers, I think the situation is not that rare. > The reason there's no capability announcement for diagnostics is > likely because it's such a basic capability that virtually every > server supports it, unless you go out of your way to find or craft one > that doesn't. I think you are being too kind with the designers of the protocol :-). From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 10:18:10 2023 Received: (at 61679) by debbugs.gnu.org; 21 Feb 2023 15:18:10 +0000 Received: from localhost ([127.0.0.1]:57034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUPC-0002q1-04 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 10:18:10 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:41669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUP9-0002pk-Ma for 61679@debbugs.gnu.org; Tue, 21 Feb 2023 10:18:09 -0500 Received: by mail-oi1-f176.google.com with SMTP id bq17so4845904oib.8 for <61679@debbugs.gnu.org>; Tue, 21 Feb 2023 07:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xAKrqNhepTV56Pvw0BhdaBxTL9JrMQGBB8rkpbMOOCk=; b=NUpWTCL1N+W7kpq860Lo396oPRGzEz0yMMlzLV+sNHTDTPbroSNpl3hiVLo2OhczvH dHYTJgLP/AaVpAihuNBIHCRGRumQoGGS3gw4JHL+gj0NW8cs7TEQP2sh5xfTvQaejV0F f8PsiybRLYix6lKwXuWGRuTBMD6wDZ+Aq9zzWZqYfP2NN3iepohg8x7bb9cSZ6xGzHL8 3OFDVguNiCBV6hCsfDNMMkH3pcSWMMkLprLl8r8FLXX1jp3vT6UhuHmZHDn7Dy/4XAMp +59UixpRZS+rI20O5kii5M5xDoj3aR3wIglhOj7JjWv+G8OodpSdrwdlLiFq+w2ox/S4 FMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xAKrqNhepTV56Pvw0BhdaBxTL9JrMQGBB8rkpbMOOCk=; b=QZFF/qMX95gnriQSesEPIfNlhT3ePHIz0ukJcIxzD+oCLMZUccaDU3mY3YRGFHOYeH 9A/BwnlOx2IeJ0sByOnXIn1Pxc5IwRNx2RRxcq3+af0aJjJguNeVjhcktMRCJfv4djis k9Xn2oYBuK8Yo2P1IDv54hRcFrX81t/fPh4nBRjNzEil3NdhkvpIHXsbMYZ50mzX37rN syQsSdHZvB3xIc998+n9ak1Xxdm2izEhcwhzu8bpd4O7thbZW/8dkTB+DYv0C7g0eCmF vrP1wCldUdF3ZdWrVvjhEYNgOqUh19nn8ztyoitW8gveD1fbtz/vLJbsk3nQriBAoBWo iLiw== X-Gm-Message-State: AO0yUKUNC6BeKnbQf43ep9wHG+BR7Cmnxi1r8xwUvOBuzbYOLKrhagFh xh+TYJYw9cVfrSdPNl0kAt/y/7/LgIKAn815Lpk= X-Google-Smtp-Source: AK7set806AyqytXOR9glous29cbhgUDIKqmqfgm3q8/I7TSWDpOHG0zzPPQxD1G1NoJzqqZecqCOUyvp1PffRo9rmpk= X-Received: by 2002:a05:6808:128b:b0:37b:9a3:136f with SMTP id a11-20020a056808128b00b0037b09a3136fmr705638oiw.6.1676992681814; Tue, 21 Feb 2023 07:18:01 -0800 (PST) MIME-Version: 1.0 References: <87mt57f5tw.fsf@gmail.com> <87ilfvf42w.fsf@gmail.com> In-Reply-To: <87ilfvf42w.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 21 Feb 2023 15:17:50 +0000 Message-ID: Subject: Re: bug#61679: 29.0.60; Eglot: staying out of trouble To: Augusto Stoffel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61679 Cc: 61679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Feb 21, 2023 at 3:09 PM Augusto Stoffel wrote= : > > On Tue, 21 Feb 2023 at 15:00, Jo=C3=A3o T=C3=A1vora wrote: > > > In the Eldoc case, as of yesterday, this no longer happens. > > Okay, nice. > > > This seems way too complicated for a problem that hasn't even been > > demonstrated. > > jedi-language-server doesn't provide diagnostics and it's officially > supported and rather popular. I just read in https://github.com/pappasam/jedi-language-server that it supports textDocument/publishDiagnostics. If that's a mistake, then I guess it's meant to be used in conjunction with other language servers at the same time which complement its features. Eglot doesn't support that, but I'm working on a solution, even though it will take time. > My digestif server also doesn't support it but I'm not going to > mention that. Right :-) I'm also not going to mention that if there is some way at all to get diagnostics for Latex, then you could think of including that way into digestif. Many servers do that: they are just LSP aggregators of existing diagnostics/completions/etc tools. Just suggesting because it's one way to go. The other is for users to use eglot-stay-out-of, etc... Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 10:33:02 2023 Received: (at 61679) by debbugs.gnu.org; 21 Feb 2023 15:33:02 +0000 Received: from localhost ([127.0.0.1]:57066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUdZ-0005cL-QB for submit@debbugs.gnu.org; Tue, 21 Feb 2023 10:33:02 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:36717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUdW-0005bw-8N for 61679@debbugs.gnu.org; Tue, 21 Feb 2023 10:33:00 -0500 Received: by mail-ed1-f48.google.com with SMTP id da10so19988626edb.3 for <61679@debbugs.gnu.org>; Tue, 21 Feb 2023 07:32:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mWNbm8387MNzCAD7qTX+j8q7NN81l3HAT/ueVfFuRLE=; b=jIrsW1Ls633s6r/MT4sSYIDnv2LcVMei/qxuMVInae4GqY3WJ4dcBNfBmXnZVkddyk OhSsGKPjcL5wL5TeC3/aOxvL2jV5jHjKSUefFNewi/oguX/tHcr8KknztAJO43MijdIq rcAxH4VVfDsvGwaHXIreXw87mzOrcrndKjXEU18mhn+Ey6M7B9C93VZAqfdDsvAjQRzp AdrnACCuzLHET3jRGrLbCCOyLCdngTjRmGU6vtAzVklWz1Yboq24QFI+Li81/jZm5vYX UsiZcaE0I//ylotdqT42SNiPETcmwxDJjEPRXxasYgsgXgCDiXyBh8i27p7tbQfhfyIp PrFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mWNbm8387MNzCAD7qTX+j8q7NN81l3HAT/ueVfFuRLE=; b=qVGhLSLKkMRSkI4D0qKkg8v0Mk2YkVGETtdpuKln79J2oW3nDcxjEJQsVANc2fmTg6 upATl309Q5wIBBRHrqrD+tpewrSr7wioLtjKanPCn6xHh+OS/dyUTSId1VW7DI05nNaG EHt+rhnxese0l7L+oMxJ3VIcmAfX8JgDn4jwJ+8rlnDDO7Owm4GrKrF7ha5FJoYn1i2z FTVjpad75vPAFtAlRa75bj0edHT+ua/uggbF8Bqd0kBP0ip/ABvgCxLW+lgbakjQ6ft8 YJoY9+SZJORZKEvZzS4lAeTRG08zKwto7ycVoLaAs4lAq/uewDtBET1/6Ssozr/O7B4m PY+Q== X-Gm-Message-State: AO0yUKX7427gCJ86sVDUrMeJLqtgiEUljnpFn8YGdokNc2sJQDxuxNMi RVg2MRWD+y09kNMRxVhbJRSyTvQ/vAc= X-Google-Smtp-Source: AK7set/kSyuaRG0GTDHLl8sffg9uf/zO8sCg6PBMSxziNq5tF5xcpMJ2CXI0bPpZvYLVhh3SEByGyA== X-Received: by 2002:a17:907:d50c:b0:896:427b:148 with SMTP id wb12-20020a170907d50c00b00896427b0148mr12953610ejc.1.1676993571951; Tue, 21 Feb 2023 07:32:51 -0800 (PST) Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id oz39-20020a170906cd2700b008e0bb004976sm734293ejb.134.2023.02.21.07.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 07:32:51 -0800 (PST) From: Augusto Stoffel To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#61679: 29.0.60; Eglot: staying out of trouble In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 21 Feb 2023 15:17:50 +0000") References: <87mt57f5tw.fsf@gmail.com> <87ilfvf42w.fsf@gmail.com> Date: Tue, 21 Feb 2023 16:32:50 +0100 Message-ID: <87edqjf2zh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61679 Cc: 61679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 21 Feb 2023 at 15:17, Jo=C3=A3o T=C3=A1vora wrote: > On Tue, Feb 21, 2023 at 3:09 PM Augusto Stoffel wro= te: >> >> On Tue, 21 Feb 2023 at 15:00, Jo=C3=A3o T=C3=A1vora wrote: >> >> > In the Eldoc case, as of yesterday, this no longer happens. >> >> Okay, nice. >> >> > This seems way too complicated for a problem that hasn't even been >> > demonstrated. >> >> jedi-language-server doesn't provide diagnostics and it's officially >> supported and rather popular. > > I just read in https://github.com/pappasam/jedi-language-server that it > supports textDocument/publishDiagnostics. Okay, that's a somewhat new feature. The concept seems to be that it's better to provide rudimentary diagnostics than nothing at all. I'm not sure I like the idea. In any case, it seems to support your point that servers without diagnostics will be rare, so feel free to close the bug. > If that's a mistake, then I guess it's meant to be used in conjunction > with other language servers at the same time which complement its > features. Eglot doesn't support that, but I'm working on a solution, > even though it will take time. Oh well, if multiple servers is the new trend, then I guess this might become necessary... From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 10:53:39 2023 Received: (at 61679) by debbugs.gnu.org; 21 Feb 2023 15:53:39 +0000 Received: from localhost ([127.0.0.1]:57094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUxW-0006A7-W7 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 10:53:39 -0500 Received: from mail-oa1-f53.google.com ([209.85.160.53]:45714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUxT-00069u-QU for 61679@debbugs.gnu.org; Tue, 21 Feb 2023 10:53:37 -0500 Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-1720ea61e29so5608952fac.12 for <61679@debbugs.gnu.org>; Tue, 21 Feb 2023 07:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yetyMO2myhfmZfH07cGZZ8lrDuHlTRsDfhlChIIVbac=; b=nRCs3xgPH+yXT39WvH0pQOqPQKEamgpmP7BhWwSpMxB/Gos/G29SqxrFRzfLZtliDu vdf24pfYTMRlJdJCR9EqaiHy9S5s9U+i3P6rcw9yWv7Ec81N2U34dfKyTQ3R5YKLcV4b DBNjfSio96wrtbZLYnlR6Dh0OqFTfB8j+/+Kqz0xBVsD6ovj+EStLzU7ZXqMZq67831n BGPdOAFA15WRky/H1xqxwLMnW0g9PZkH6HcL9bncJG/ZltKP2KvkfZh2RP4tOjgDhHov vj9G7yKx7UMMynwUNMBdtsAmy4N8EVUGZ9pRmo4o6KdA4RB7RhA0IF4L/FcPe7F85xkl JsoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yetyMO2myhfmZfH07cGZZ8lrDuHlTRsDfhlChIIVbac=; b=qPhj4pJ/oFCA9rDq2qrnMq9awZOu+NiCowmtelomzdGik9XZahV+ig//nQZL4HjQtN dJCK9SpL0dckYaGmLmzCTOaWAoG6lkyTIqcvweCq3KEPTciFYDm/5oxCQtA7Z7dGvV3m PQgPGcKEuf9rwfLw8S6JpXsdtpn2U221wAU6UN3G+ZOEGzbZe3urr81v8Csy/Hef5yNO b5tuNX0DA27OBCI8PQIyqL2eJmuhUYQsgReuwonvRN8hlZtwetuGQgpzY+BCq5sHPqyX lT3wCuKATVuwAbBtyl7TIrK+pLlTY0AIzKyMpJD3ggtgFiif/Yq22O+YizJwtX7o/vrS 9Q3w== X-Gm-Message-State: AO0yUKVN0Lrcv3qcc2kncHWAEqsF3SwzfhRXZJ/l3zaCwx+wNP9OjY5c QBWyW2Cub5Kcp+oQS4WT+6xOu+tC2hgm4st6B9w= X-Google-Smtp-Source: AK7set+PkmZlcnWVMByXdppl+lVSA+CHIBzyQKTUH9/utByIK/AQfWwTQqYVc0TIrH8WPP1oxD82B9z5VN6PTRK8ZuI= X-Received: by 2002:a05:6870:d148:b0:16d:dc93:691d with SMTP id f8-20020a056870d14800b0016ddc93691dmr747259oac.6.1676994810156; Tue, 21 Feb 2023 07:53:30 -0800 (PST) MIME-Version: 1.0 References: <87mt57f5tw.fsf@gmail.com> <87ilfvf42w.fsf@gmail.com> <87edqjf2zh.fsf@gmail.com> In-Reply-To: <87edqjf2zh.fsf@gmail.com> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 21 Feb 2023 15:53:19 +0000 Message-ID: Subject: Re: bug#61679: 29.0.60; Eglot: staying out of trouble To: Augusto Stoffel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61679 Cc: 61679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Feb 21, 2023 at 3:32 PM Augusto Stoffel wrote= : > any case, it seems to support your point that servers without > diagnostics will be rare, so feel free to close the bug. OK. > > > If that's a mistake, then I guess it's meant to be used in conjunction > > with other language servers at the same time which complement its > > features. Eglot doesn't support that, but I'm working on a solution, > > even though it will take time. > > Oh well, if multiple servers is the new trend, then I guess this might > become necessary... I'm not sure it's a new trend, but it has some use cases, yes. I think it was once more urgent than it is now, where some servers do the aggregation from multiple sources themselves. In the Eglot Github page there are a few discussions: the biggest use case I've seen described is for JavaScript which normally wants to have EsLint linting and also other types of servers. But I think this also makes sense more generally. A spell-checking server could go hand-in-hand with multiple programming servers. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 10:53:55 2023 Received: (at 61679) by debbugs.gnu.org; 21 Feb 2023 15:53:56 +0000 Received: from localhost ([127.0.0.1]:57099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUxn-0006Ah-Jr for submit@debbugs.gnu.org; Tue, 21 Feb 2023 10:53:55 -0500 Received: from mail-oi1-f175.google.com ([209.85.167.175]:43650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUxk-0006AO-QV; Tue, 21 Feb 2023 10:53:53 -0500 Received: by mail-oi1-f175.google.com with SMTP id bk2so3858179oib.10; Tue, 21 Feb 2023 07:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uD2sptsWDGT9ewLOn3h9qnvzs2MunIoj4B372gshgJc=; b=qchqBz4pO4LJP6R/EV1O+SasMUJhQKXphNRWZgR2bwOQNRrBu9h/3uItAGm5AWws4V o/tD1QrxwA6lIT2Xlk0m7I0K3+bYN+F6L8B/g2m8OIKqd12pXXOS8ytQueUn69Iw/kDB Nx4jq7uUtDd9GOmOgqULAy0mrgLoZax3nU9sMrWu97e74rUR2iLXBOq5zh6ob7g62ZyE 4MF/l1MVupd7L6AvOwPu26V+2w2/7k6t1NzRc1XCuf6tZ/OPfcozqDEAVBqgASqX6t7n jPJ8R5LU1zotKodaUNMKzhxTE6tDbuHsvAJ6x1x841clN6/xvPJGbjnodSv39wJcHj5F a+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uD2sptsWDGT9ewLOn3h9qnvzs2MunIoj4B372gshgJc=; b=Fb1ylwrFUvprgqaRm7VdtjMSMei5fawpeV+Fi18w4Lrpc4QVlbnvCLplSOX0uIx3pM 5w2TnQoQLk7JC74YzyQSWA+Kj6iJh/bXWAGReSrpbrigUi+frkf5AAwZT1IddUJLgDFl iTJ/qKg34Z5cDcmod3u+5iOh9VXtrm1cQjAQZXQSC/hDRPneCCadWYeDg6dBMpIkvYjI +faCHA+Tw+lEOHqPsXYisIrAKQIiKsS4n4NVKhNtcnVboWjgIhg055m0uaQh8JJfCGT3 kGHCSS7DaN+VFKZUyjuTBIMhTH6UOgeifDdHym3mDnsWnUGJcb7/vQmwXvpvVfQQNbZ0 pG8g== X-Gm-Message-State: AO0yUKVbQWJ2WFqcluCo6/DQ+f/KDdHhQYXb2feC6yyWOVforjJ4B0fL ogGWrZfKkThINihIq06njxbShK1uzz8t1sRDw0IzX3ck X-Google-Smtp-Source: AK7set8au2PxU5JnAH7Y/GotAoqOYq0AnoMoV/YP99LuZ5Xn0E8Y7pEH9M2JXDxrUjOzf6tPTrJQy2GJ/BV0FKbbeXk= X-Received: by 2002:a05:6808:128b:b0:37b:9a3:136f with SMTP id a11-20020a056808128b00b0037b09a3136fmr714905oiw.6.1676994826966; Tue, 21 Feb 2023 07:53:46 -0800 (PST) MIME-Version: 1.0 References: <87mt57f5tw.fsf@gmail.com> <87ilfvf42w.fsf@gmail.com> <87edqjf2zh.fsf@gmail.com> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 21 Feb 2023 15:53:36 +0000 Message-ID: Subject: Re: bug#61679: 29.0.60; Eglot: staying out of trouble To: 61679-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61679 Cc: 61679@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Feb 21, 2023 at 3:53 PM Jo=C3=A3o T=C3=A1vora wrote: > > On Tue, Feb 21, 2023 at 3:32 PM Augusto Stoffel wro= te: > > > any case, it seems to support your point that servers without > > diagnostics will be rare, so feel free to close the bug. > > OK. > > > > > > If that's a mistake, then I guess it's meant to be used in conjunctio= n > > > with other language servers at the same time which complement its > > > features. Eglot doesn't support that, but I'm working on a solution, > > > even though it will take time. > > > > Oh well, if multiple servers is the new trend, then I guess this might > > become necessary... > > I'm not sure it's a new trend, but it has some use cases, yes. > I think it was once more urgent than it is now, where some > servers do the aggregation from multiple sources themselves. > > In the Eglot Github page there are a few discussions: the biggest > use case I've seen described is for JavaScript which normally > wants to have EsLint linting and also other types of servers. But I > think this also makes sense more generally. A spell-checking server > could go hand-in-hand with multiple programming servers. > > Jo=C3=A3o --=20 Jo=C3=A3o T=C3=A1vora From unknown Fri Jun 20 18:24:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Mar 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator