Subject: bug#61665: closed (Re: [bug#61665] [PATCH] gnu: python-clingo: Fix invalid G-expression input.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 21 Feb 2023 12:54:02 +0000

Your bug report

#61665: [PATCH] gnu: python-clingo: Fix invalid G-expression input.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
61665: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61665
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#61665] [PATCH] gnu: python-clingo: Fix invalid G-expression input.
From: Christopher Baines <[email-masked]>
To: [email-masked], [email-masked]
Date: Tue, 21 Feb 2023 12:52:54 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Liliana Marie Prikler <[email-masked]> writes:

>>  gnu/packages/maths.scm | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
>> index 1e40be8722..67634990ae 100644
>> --- a/gnu/packages/maths.scm
>> +++ b/gnu/packages/maths.scm
>> @@ -2703,12 +2703,20 @@ (define-public python-clingo
>>    (package
>>      (inherit clingo)
>>      (name "python-clingo")
>> +    (version (package-version clingo)) ;Fix error: invalid G-
>> expression #$version
> Reworded slightly and pushed (it's a hotfix and CI succeeds).

Closing accordingly.

Subject: [PATCH] gnu: python-clingo: Fix invalid G-expression input.
From: Simon Tournier <[email-masked]>
To: [email-masked]
Cc: Simon Tournier <[email-masked]>
Date: Tue, 21 Feb 2023 02:00:18 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/maths.scm (python-clingo)[arguments]: Add 'imported-modules'
and 'modules' in order to access to 'python:site-packages'.
[version]: Explicitly reuse from the package 'clingo'.
---

Hi,

This package seems broken:

--8<---------------cut here---------------start------------->8---
$ guix time-machine --commit=e8fcf1e424 -- build python-clingo
guix build: erreur : #<procedure version ()> : entrée G-expression invalide
--8<---------------cut here---------------end--------------->8---

The issue seems coming from the field 'version'.  Then, commit
8285093cee000d6e28c040f721ddf0be18d32c42 introduces #$version which introduces
the failure.

Well, I have not found the correct G-exp syntax for #:imported-modules.

Cheers,
simon

 gnu/packages/maths.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 1e40be8722..67634990ae 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2703,12 +2703,20 @@ (define-public python-clingo
   (package
     (inherit clingo)
     (name "python-clingo")
+    (version (package-version clingo)) ;Fix error: invalid G-expression #$version
     (arguments
      (substitute-keyword-arguments (package-arguments clingo)
        ((#:configure-flags flags #~'())
         #~(cons* "-DCLINGO_BUILD_WITH_PYTHON=pip"
                  "-DCLINGO_USE_LIB=yes"
                  #$flags))
+       ((#:imported-modules _ '())
+        `(,@%cmake-build-system-modules
+          (guix build python-build-system)))
+       ((#:modules _ '())
+        '((guix build cmake-build-system)
+          ((guix build python-build-system) #:prefix python:)
+          (guix build utils)))
        ((#:phases phases #~%standard-phases)
         #~(modify-phases #$phases
             (add-after 'unpack 'fix-failing-tests

base-commit: e8fcf1e42438113d7e4be82dc5a06de45eaceb76
-- 
2.38.1