GNU bug report logs - #61665
[PATCH] gnu: python-clingo: Fix invalid G-expression input.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61665 in the body.
You can then email your comments to 61665 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: [PATCH] gnu: python-clingo: Fix invalid G-expression input.
Date: Tue, 21 Feb 2023 02:00:18 +0100

* gnu/packages/maths.scm (python-clingo)[arguments]: Add 'imported-modules'
and 'modules' in order to access to 'python:site-packages'.
[version]: Explicitly reuse from the package 'clingo'.
---

Hi,

This package seems broken:

--8<---------------cut here---------------start------------->8---
$ guix time-machine --commit=e8fcf1e424 -- build python-clingo
guix build: erreur : #<procedure version ()> : entrée G-expression invalide
--8<---------------cut here---------------end--------------->8---

The issue seems coming from the field 'version'.  Then, commit
8285093cee000d6e28c040f721ddf0be18d32c42 introduces #$version which introduces
the failure.

Well, I have not found the correct G-exp syntax for #:imported-modules.

Cheers,
simon


 gnu/packages/maths.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 1e40be8722..67634990ae 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2703,12 +2703,20 @@ (define-public python-clingo
   (package
     (inherit clingo)
     (name "python-clingo")
+    (version (package-version clingo)) ;Fix error: invalid G-expression #$version
     (arguments
      (substitute-keyword-arguments (package-arguments clingo)
        ((#:configure-flags flags #~'())
         #~(cons* "-DCLINGO_BUILD_WITH_PYTHON=pip"
                  "-DCLINGO_USE_LIB=yes"
                  #$flags))
+       ((#:imported-modules _ '())
+        `(,@%cmake-build-system-modules
+          (guix build python-build-system)))
+       ((#:modules _ '())
+        '((guix build cmake-build-system)
+          ((guix build python-build-system) #:prefix python:)
+          (guix build utils)))
        ((#:phases phases #~%standard-phases)
         #~(modify-phases #$phases
             (add-after 'unpack 'fix-failing-tests

base-commit: e8fcf1e42438113d7e4be82dc5a06de45eaceb76
-- 
2.38.1

Message #8 received at 61665 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>, 61665 <at> debbugs.gnu.org
Subject: Re: [bug#61665] [PATCH] gnu: python-clingo: Fix invalid
 G-expression input.
Date: Tue, 21 Feb 2023 06:31:10 +0100

Am Dienstag, dem 21.02.2023 um 02:00 +0100 schrieb Simon Tournier:
> * gnu/packages/maths.scm (python-clingo)[arguments]: Add 'imported-
> modules'
> and 'modules' in order to access to 'python:site-packages'.
> [version]: Explicitly reuse from the package 'clingo'.
> ---
> 
> Hi,
> 
> This package seems broken:
> 
> --8<---------------cut here---------------start------------->8---
> $ guix time-machine --commit=e8fcf1e424 -- build python-clingo
> guix build: erreur : #<procedure version ()> : entrée G-expression
> invalide
> --8<---------------cut here---------------end--------------->8---
> 
> The issue seems coming from the field 'version'.  Then, commit
> 8285093cee000d6e28c040f721ddf0be18d32c42 introduces #$version which
> introduces the failure.
Thanks.

> Well, I have not found the correct G-exp syntax for #:imported-
> modules.
Quoting works fine.

> 
>  gnu/packages/maths.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 1e40be8722..67634990ae 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -2703,12 +2703,20 @@ (define-public python-clingo
>    (package
>      (inherit clingo)
>      (name "python-clingo")
> +    (version (package-version clingo)) ;Fix error: invalid G-
> expression #$version
Reworded slightly and pushed (it's a hotfix and CI succeeds).

Cheers

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 61665-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#61665] [PATCH] gnu: python-clingo: Fix invalid
 G-expression input.
Date: Tue, 21 Feb 2023 12:52:54 +0000

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

>>  gnu/packages/maths.scm | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
>> index 1e40be8722..67634990ae 100644
>> --- a/gnu/packages/maths.scm
>> +++ b/gnu/packages/maths.scm
>> @@ -2703,12 +2703,20 @@ (define-public python-clingo
>>    (package
>>      (inherit clingo)
>>      (name "python-clingo")
>> +    (version (package-version clingo)) ;Fix error: invalid G-
>> expression #$version
> Reworded slightly and pushed (it's a hotfix and CI succeeds).

Closing accordingly.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.