GNU bug report logs - #6164
24.0.50; scroll-all-mode is broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6164 in the body.
You can then email your comments to 6164 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; scroll-all-mode is broken
Date: Mon, 10 May 2010 23:51:45 +0200

1. emacs -Q
2. Visit two files that are big enough to scroll up and down.
3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
   filed in the split windows.
4. Type `M-x scroll-all-mode' to enable this minor mode.
5. Type `C-v'.
=> Only the selected buffer scrolls, whereas with scroll-all-mode
enabled both buffers should scroll.

This is because `C-v' is bound to scroll-up-command, whereas
scroll-all-mode expects (in scroll-all-check-to-scroll) scroll-up.  I
guess this is a consequence of this change:

2010-04-05  Juri Linkov  <juri <at> jurta.org>

	Scrolling commands which do not signal errors at top/bottom.
	http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01452.html

	* simple.el (scroll-up-command, scroll-down-command): New commands.



In GNU Emacs 24.0.50.2 (i686-pc-linux-gnu, GTK+ Version 2.18.6)
 of 2010-05-08 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.10605000
configured using `configure  '--without-toolkit-scroll-bars''

Message #8 received at 6164 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 6164 <at> debbugs.gnu.org
Subject: Re: bug#6164: 24.0.50; scroll-all-mode is broken
Date: Tue, 11 May 2010 02:19:20 +0300

> 1. emacs -Q
> 2. Visit two files that are big enough to scroll up and down.
> 3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
>    filed in the split windows.
> 4. Type `M-x scroll-all-mode' to enable this minor mode.
> 5. Type `C-v'.
> => Only the selected buffer scrolls, whereas with scroll-all-mode
> enabled both buffers should scroll.

Thanks for the bug report.  This patch should fix it:

=== modified file 'lisp/scroll-all.el'
--- lisp/scroll-all.el	2010-01-13 08:35:10 +0000
+++ lisp/scroll-all.el	2010-05-10 23:18:25 +0000
@@ -90,9 +90,9 @@ (defun scroll-all-check-to-scroll ()
 	 (call-interactively 'scroll-all-scroll-down-all))
 	((eq this-command 'previous-line)
 	 (call-interactively 'scroll-all-scroll-up-all))
-	((eq this-command 'scroll-up)
+	((memq this-command '(scroll-up scroll-up-command))
 	 (call-interactively 'scroll-all-page-down-all))
-	((eq this-command 'scroll-down)
+	((memq this-command '(scroll-down scroll-down-command))
 	 (call-interactively 'scroll-all-page-up-all))
 	((eq this-command 'beginning-of-buffer)
 	 (call-interactively 'scroll-all-beginning-of-buffer-all))

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #11 received at 6164 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6164 <at> debbugs.gnu.org
Subject: Re: bug#6164: 24.0.50; scroll-all-mode is broken
Date: Tue, 11 May 2010 09:53:48 +0200

On Tue, 11 May 2010 02:19:20 +0300 Juri Linkov <juri <at> jurta.org> wrote:

>> 1. emacs -Q
>> 2. Visit two files that are big enough to scroll up and down.
>> 3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
>>    filed in the split windows.
>> 4. Type `M-x scroll-all-mode' to enable this minor mode.
>> 5. Type `C-v'.
>> => Only the selected buffer scrolls, whereas with scroll-all-mode
>> enabled both buffers should scroll.
>
> Thanks for the bug report.  This patch should fix it:

Confirmed, so please install it at your convenience.  Thanks,

Steve Berman

Message #16 received at 6164-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: 6164-done <at> debbugs.gnu.org
Subject: Re: bug#6164: 24.0.50; scroll-all-mode is broken
Date: Tue, 11 May 2010 22:49:31 +0300

>>> 1. emacs -Q
>>> 2. Visit two files that are big enough to scroll up and down.
>>> 3. Type `C-x 2' or `C-x 3' and the `C-x b' to display the two visited
>>>    filed in the split windows.
>>> 4. Type `M-x scroll-all-mode' to enable this minor mode.
>>> 5. Type `C-v'.
>>> => Only the selected buffer scrolls, whereas with scroll-all-mode
>>> enabled both buffers should scroll.
>>
>> Thanks for the bug report.  This patch should fix it:
>
> Confirmed, so please install it at your convenience.  Thanks,

Installed and closed, thanks.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.