GNU bug report logs - #61639
30.0.50; [PATCH] Do not error out on non image file in image-dired

Previous Next

Full log

Message #23 received at 61639 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61639 <at> debbugs.gnu.org
Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file
 in image-dired
Date: Mon, 20 Feb 2023 17:41:35 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

[...]

>> So your idea is to keep `image-dired--get-create-thumbnail-file' as is
>> and filter its input in `image-dired-display-thumbs'?  But then we won't
>> get any message or error that something was not an image (this could go
>> unnoticed as well ;-)
>
> I don't necessarily see a reason to alert the user in this case, but
> if you think we had better done that, we could show a message when we
> find a non-image file in the list of the selected ones.

Ok.  Here is a new version of the patch that address those issues.  I
choose to not alert the user.

[0001-Do-not-error-out-on-non-image-file-bug-61639.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.