From unknown Tue Aug 19 10:02:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61639 <61639@debbugs.gnu.org> To: bug#61639 <61639@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] Do not error out on non image file in image-dired Reply-To: bug#61639 <61639@debbugs.gnu.org> Date: Tue, 19 Aug 2025 17:02:08 +0000 retitle 61639 30.0.50; [PATCH] Do not error out on non image file in image-= dired reassign 61639 emacs submitter 61639 Manuel Giraud severity 61639 normal tag 61639 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 15:09:59 2023 Received: (at submit) by debbugs.gnu.org; 19 Feb 2023 20:09:59 +0000 Received: from localhost ([127.0.0.1]:49741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTq0V-00021S-46 for submit@debbugs.gnu.org; Sun, 19 Feb 2023 15:09:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:54274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTq0T-00021K-8k for submit@debbugs.gnu.org; Sun, 19 Feb 2023 15:09:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTq0S-0005Y7-64 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 15:09:56 -0500 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTq0O-0003tD-2E for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 15:09:55 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ovAF12/8 Ol+tKNpJvoPfWXOFdHVIc5hX+n56ZOa9udc=; h=date:subject:to:from; d=ledu-giraud.fr; b=wZ3xYdaLDiZDwoDFpFe0XK8kJAPgfeHst4sEWZv5uwkEahzaxx LHlUiM++svdrn2aqZnzU3CxzkBqkQbu//rDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ovAF12/8Ol+tKNpJ voPfWXOFdHVIc5hX+n56ZOa9udc=; h=date:subject:to:from; d=ledu-giraud.fr; b=vb/t6hhB3mTd89OjncyoxirbSmuCYy5z4UIFeAso9I2mQi1ag8 /EYg0w/cn7ECp0DtuygExY5iPig1COzbodfIga2yNe6vp1aZc5E2+4Pgc90iSV/5HHHwcp R92kS2JwZMWq//L5cP6MfxvuFmsPLaB5xb1SqEz7ScGnN+F8aYwknkwOEGa5r9m10MXGny D+cBcWSxG5vJpAaFFhdXlJq3C7DBFPa0chVxh9UwidX/e6q7gezriwxeOJaMGFrGnQK0R8 GRAgQvXrz6vZKGwP1JkhdeTsbxy4AelyRQMo6m3d7gX/fCMtTCsQxMTTJezjnpQPd1tLAy swKT70mztgmw== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id fadef48c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 19 Feb 2023 21:09:48 +0100 (CET) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Do not error out on non image file in image-dired Date: Sun, 19 Feb 2023 21:09:47 +0100 Message-ID: <87sff1quwk.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, This patch prevent errors when using image-dired on non image files. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-error-out-on-non-image-file.patch >From 72f4dcd72d20fc2c0ead21300c0e2bff1795e8ee Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sun, 19 Feb 2023 21:03:57 +0100 Subject: [PATCH] Do not error out on non image file * lisp/image/image-dired.el (image-dired--get-create-thumbnail-file): Do not error out but return NIL for a non image file. (image-dired-display-thumbs): Do not insert non image file and do not display image-dired buffer if it is empty. --- lisp/image/image-dired.el | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index cfcd1851188..60f2abd982a 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -411,19 +411,20 @@ image-dired-insert-image (defun image-dired--get-create-thumbnail-file (file) "Return the image descriptor for a thumbnail of image file FILE." - (unless (string-match-p (image-dired--file-name-regexp) file) - (error "%s is not a valid image file" file)) - (let* ((thumb-file (image-dired-thumb-name file)) - (thumb-attr (file-attributes thumb-file))) - (if (or (not thumb-attr) - (time-less-p (file-attribute-modification-time thumb-attr) - (file-attribute-modification-time - (file-attributes file)))) - (image-dired-create-thumb file thumb-file) - (image-dired-debug "Found thumb for %s: %s" - (file-name-nondirectory file) - (file-name-nondirectory thumb-file))) - thumb-file)) + (if (string-match-p (image-dired--file-name-regexp) file) + (let* ((thumb-file (image-dired-thumb-name file)) + (thumb-attr (file-attributes thumb-file))) + (if (or (not thumb-attr) + (time-less-p (file-attribute-modification-time thumb-attr) + (file-attribute-modification-time + (file-attributes file)))) + (image-dired-create-thumb file thumb-file) + (image-dired-debug "Found thumb for %s: %s" + (file-name-nondirectory file) + (file-name-nondirectory thumb-file))) + thumb-file) + (message "%s is not a valid image file" file) + (values))) (defun image-dired-insert-thumbnail ( file original-file-name associated-dired-buffer image-number) @@ -586,13 +587,15 @@ image-dired-display-thumbs (erase-buffer)) (goto-char (point-max))) (dolist (file files) - (let ((thumb (image-dired--get-create-thumbnail-file file))) + (when-let ((thumb (image-dired--get-create-thumbnail-file file))) (image-dired-insert-thumbnail thumb file dired-buf (cl-incf image-dired--number-of-thumbnails))))) - (if do-not-pop - (display-buffer buf) - (pop-to-buffer buf)) + (if (plusp image-dired--number-of-thumbnails) + (if do-not-pop + (display-buffer buf) + (pop-to-buffer buf)) + (message "No images selected")) (image-dired--line-up-with-method) (image-dired--update-header-line)))) -- 2.39.1 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version 1.17.8) of 2023-02-19 built on computer Repository revision: ff2109d7202ad2bbad00edd2a2ab21e4917ca7a3 Repository branch: mgi/image-dired-doc Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD computer 7.2 GENERIC.MP#1052 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t gnus-dired-mode: t display-time-mode: t display-battery-mode: t server-mode: t shell-dirtrack-mode: t repeat-mode: t desktop-save-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-0.10.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs /home/manuel/.emacs.d/elpa/transient-0.3.7/transient hides /home/manuel/emacs/share/emacs/30.0.50/lisp/transient Features: (find-dired ffap net-utils cl-print image-file image-converter image-dired-dired image-dired image-dired-tags image-dired-external image-dired-util dabbrev misearch multi-isearch shortdoc help-fns radix-tree shr-color flow-fill gnus-cite gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-http url-gw url-cache url-auth qp utf-7 imap rfc2104 nndoc nndraft nnmh nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss w3m w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util network-stream nsm smtpmail textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check mailalias shadow sort mail-extr emacsbug whitespace magit-extras magit-patch pulse face-remap magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode diff git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-section magit-utils dash org-indent vc-dir ewoc vc mhtml-mode js c-ts-common reveal pascal vc-hg conf-mode css-mode sgml-mode facemenu imenu sh-script smie treesit executable oc-basic ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi paredit edmacro gnus-dired autorevert filenotify vc-git diff-mode bug-reference texinfo texinfo-loaddefs time battery exwm-randr xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server stimmung-themes modus-operandi-theme modus-themes ytdious osm bookmark mingus libmpdee reporter edebug debug backtrace transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt cl-extra help-mode speedbar ezimage dframe eieio-base pcase timezone visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat shell parse-time iso8601 ls-lisp slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop xref project arc-mode archive-mode pp hyperspec thingatpt slime-autoloads org-agenda org-element org-persist xdg org-id avl-tree generator org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint ansi-osc ansi-color ring org-list org-footnote org-faces org-entities time-date noutline outline icons ob-emacs-lisp ob-core ob-eval org-cycle org-table org-keys oc org-loaddefs find-func ol rx org-fold org-fold-core org-compat org-version org-macs format-spec view mule-util cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays holiday-loaddefs vc-dispatcher vc-svn appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-aux dired-x dired dired-loaddefs notifications dbus xml repeat easy-mmode desktop frameset stimmung-themes-autoloads rust-mode-autoloads ebdb-autoloads magit-autoloads debbugs-autoloads git-commit-autoloads magit-section-autoloads ef-themes-autoloads with-editor-autoloads paredit-autoloads dash-autoloads ytdious-autoloads transmission-autoloads transient-autoloads exwm-autoloads hyperbole-autoloads detached-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 1065525 388148) (symbols 48 64082 42) (strings 32 316403 24225) (string-bytes 1 9903231) (vectors 16 191008) (vector-slots 8 3234332 186563) (floats 8 1224 465) (intervals 56 21213 5652) (buffers 984 129)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 07:49:02 2023 Received: (at 61639) by debbugs.gnu.org; 20 Feb 2023 12:49:02 +0000 Received: from localhost ([127.0.0.1]:50857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU5bK-0001f5-GE for submit@debbugs.gnu.org; Mon, 20 Feb 2023 07:49:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU5bG-0001eX-IR for 61639@debbugs.gnu.org; Mon, 20 Feb 2023 07:49:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU5bA-0007v9-GJ; Mon, 20 Feb 2023 07:48:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ntTd1/+VGBqt3kySmGirZEEhfeCDV1fWqr9FTS0duJI=; b=csJQedrgtFmV KC7pCTcg+JXrux7oYD+yv9wwUTu1Is19HyAWCdOh3bhUDA2I3Td6UClxEX8lCa+AHpGDtYoxWOccl 61W+PPHSA1Lr2kpRiJqzd6kw+r8a4QM2qdS75Uf3Ij43Mo7HucCv+ZO6Hwe8jvLXw0i/5oYd46AAo rYmLyKc/OwRscGbPNTwekEat0oL6gj545JQG4r7aTu2xSOM5eDY3s5iu2MBCqT+zrCZRSze/hL92w dV7YF5IoLl0uO4gvYO1ZgC19rW+qO4c+pdOkPowzBz4x6VQFOLmYMRihRxkASIa5+Bn5tjhKsmR6F ys25ToukWcSjcqV/claMdQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU5bA-0006ys-0K; Mon, 20 Feb 2023 07:48:52 -0500 Date: Mon, 20 Feb 2023 14:49:00 +0200 Message-Id: <83sff0v6wz.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87sff1quwk.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired References: <87sff1quwk.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 19 Feb 2023 21:09:47 +0100 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This patch prevent errors when using image-dired on non image files. Why is it better to show a message than to signal an error? The former could go unnoticed, especially if some other message is shown in the echo-area soon enough. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 08:35:48 2023 Received: (at 61639) by debbugs.gnu.org; 20 Feb 2023 13:35:48 +0000 Received: from localhost ([127.0.0.1]:51010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU6Ka-0002we-JA for submit@debbugs.gnu.org; Mon, 20 Feb 2023 08:35:48 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:6904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU6KW-0002wT-Ua for 61639@debbugs.gnu.org; Mon, 20 Feb 2023 08:35:47 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=xvK2ur9C y1WH7PUTQFn7Gclr1P9F7UzeT51FQ82uBSE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=2XMmDN/Hu7pFqLw/V4oQMHpv6Fx+iv wt82t6oRGg+jA6lXeHRhZirkelUSOIORj7xXENI5CYi+PvCXVuhLTGAw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=xvK2ur9Cy1WH7PUT QFn7Gclr1P9F7UzeT51FQ82uBSE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=ICUA6squY42pMp3CBpV0E+WOVf5W+dmW92fH2x lslNpBZL+rX9Jb4FdOFsxQzR/gtsBkVx3eeE2sIk/FEDXosqx/TVsKQi6QwuRdsCrBthmo isC4B6mGyxOz9PVuVwvowD+4EolEmBFg2bza4OoO0Tyy49wX4hYgx0K6rr97eOwl2PjzTd 41Jv2KT4IyRTPWsxot8bCGaXxZVL0Rjx3Kt2hofQ6vwdDSVqwbDqCkuVBosAbM7K35hBHE SWCz7QsFqiMWdNY7P7sdJoOrnclWzh6PGjanz41jcFX7vfnGrACaib1DZzvlYG0nlVBmHs mJbwlgpYb5RIWNUg/tmQJegQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 66ae3ac9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 20 Feb 2023 14:35:43 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired In-Reply-To: <83sff0v6wz.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Feb 2023 14:49:00 +0200") References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> Date: Mon, 20 Feb 2023 14:35:42 +0100 Message-ID: <87ttzgtq6p.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Sun, 19 Feb 2023 21:09:47 +0100 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> This patch prevent errors when using image-dired on non image files. > > Why is it better to show a message than to signal an error? The > former could go unnoticed, especially if some other message is shown > in the echo-area soon enough. I don't think it is better. But for some image-dired usage, I do not find it convenient. Example: you carefully select some images from a dired buffer and hit `C-t d' to see them in image-dired. But your selection was not correct and one of those file is not an image: you receive an error (and have to correct your selection) and don't get to see any of the correctly selected images. So my idea was: yes, it is an error but it should not be one that unwinds all. Maybe it is a job for `warn' but having a *Warnings* buffer that pop up is a bit too much too IMO. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 08:46:51 2023 Received: (at 61639) by debbugs.gnu.org; 20 Feb 2023 13:46:51 +0000 Received: from localhost ([127.0.0.1]:51026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU6VG-0003DU-UA for submit@debbugs.gnu.org; Mon, 20 Feb 2023 08:46:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU6VD-0003DF-80 for 61639@debbugs.gnu.org; Mon, 20 Feb 2023 08:46:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU6V7-0004tA-6a; Mon, 20 Feb 2023 08:46:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AIWblfdOMme21V9ShYeMfTrGhbAyTN3IDjdfTnQ0/5A=; b=GhYFLDF65S1K QprbtlABawHaU6Jt4NjPAEylcNbxLyNn1VhESjvvSsi1QmQS1M2fKtXctGsOAG2Fk2dSIB9+rACV8 gLzzGtY5bzesnsWGbILYcO5l1kX482xU12KuUUKoKstLuPUU9R/O8mUpVakpM73AQMBMnW6M53AKQ utf65kI0bbqZqdQG+shWaXknjjhA5IBIjAT3VwcJOp+NCUZ0B8Gq8Ahk6Lus/UN81OpbCPRbg3i0P 1rD9WAYqFeCt99aomG8L6/ggrgK8IoU6eXD9Zfq/Fdp14fFKmG0HnbyavGkr8p58RdHK9l/jsvcv8 ZiUPAq927qhbT6O1QG6Xfg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU6V6-0004Vf-EI; Mon, 20 Feb 2023 08:46:40 -0500 Date: Mon, 20 Feb 2023 15:46:48 +0200 Message-Id: <83edqkv48n.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87ttzgtq6p.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 20 Feb 2023 14:35:42 +0100) Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61639@debbugs.gnu.org > Date: Mon, 20 Feb 2023 14:35:42 +0100 > > Eli Zaretskii writes: > > >> Date: Sun, 19 Feb 2023 21:09:47 +0100 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> This patch prevent errors when using image-dired on non image files. > > > > Why is it better to show a message than to signal an error? The > > former could go unnoticed, especially if some other message is shown > > in the echo-area soon enough. > > I don't think it is better. But for some image-dired usage, I do not > find it convenient. Example: you carefully select some images from a > dired buffer and hit `C-t d' to see them in image-dired. But your > selection was not correct and one of those file is not an image: you > receive an error (and have to correct your selection) and don't get to > see any of the correctly selected images. So maybe "C-t d" should filter the selected "images" before it calls the function which errors out? IOW, if the application doesn't want an API to fail for reasons specific to the application, the onus of avoiding the error is on the application, no? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 09:13:45 2023 Received: (at 61639) by debbugs.gnu.org; 20 Feb 2023 14:13:46 +0000 Received: from localhost ([127.0.0.1]:51090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU6vJ-000422-GX for submit@debbugs.gnu.org; Mon, 20 Feb 2023 09:13:45 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:28798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU6vD-00041e-Uj for 61639@debbugs.gnu.org; Mon, 20 Feb 2023 09:13:41 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=YFIlPWDA +BNtUryplftJPOJki98CF+10DxzOE4ssfIE=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Hkoy4rTpFxGj+ilkQZXdz9NHxuBVuy go6Bea6pFGjBMQ3kuD1UbXICRZi0PSY3fTJxS2I7RnYJw3FzQB2vL9AQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=YFIlPWDA+BNtUryp lftJPOJki98CF+10DxzOE4ssfIE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=s9fDQm3bcTnWDivLX2DcGZOAIS5znyGffChRx8 l8Qodjf+BqjldWwk5ajZV+pL1q6KlTRO9BTLiplxhwXKeEHT6dO7riA8Q5tB0TnbpHiVqt RddtgFMJ5nWBIJoP1vFvacGicikIJPmQvSFwTfiU7AsSN7SxXiNJ1m7j9QbhMcWrVJBs0l zO1JV5goAtYO3eCDyFffYve7AUzGBAj/utl7kWeY/XGjIr34+xPu0Vp35LZgTy63BcMOUN LCmPPuC78UFlwtw+D7y1i5oiZDZVu22pkIw71TdBbjPrdXuhYMRSIGCoyHk/zMSPZW667i UzTJvWjs73BK1uo5zlwtlj1g== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id fc4f3aca (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 20 Feb 2023 15:13:38 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired In-Reply-To: <83edqkv48n.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Feb 2023 15:46:48 +0200") References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> Date: Mon, 20 Feb 2023 15:13:37 +0100 Message-ID: <87k00ctofi.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 61639@debbugs.gnu.org >> Date: Mon, 20 Feb 2023 14:35:42 +0100 >> >> Eli Zaretskii writes: >> >> >> Date: Sun, 19 Feb 2023 21:09:47 +0100 >> >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> >> the Swiss army knife of text editors" >> >> >> >> This patch prevent errors when using image-dired on non image files. >> > >> > Why is it better to show a message than to signal an error? The >> > former could go unnoticed, especially if some other message is shown >> > in the echo-area soon enough. >> >> I don't think it is better. But for some image-dired usage, I do not >> find it convenient. Example: you carefully select some images from a >> dired buffer and hit `C-t d' to see them in image-dired. But your >> selection was not correct and one of those file is not an image: you >> receive an error (and have to correct your selection) and don't get to >> see any of the correctly selected images. > > So maybe "C-t d" should filter the selected "images" before it calls > the function which errors out? That is what `image-dired-show-all-from-dir' is doing: it selects files from the given directory with the correct "image files" regexp and so no non image will be present. So your idea is to keep `image-dired--get-create-thumbnail-file' as is and filter its input in `image-dired-display-thumbs'? But then we won't get any message or error that something was not an image (this could go unnoticed as well ;-) > IOW, if the application doesn't want an API to fail for reasons > specific to the application, the onus of avoiding the error is on the > application, no? Yes, but maybe `image-dired--get-create-thumbnail-file' is not really an established API. It is called twice in Emacs (and the other place it is called non images are already filtered out). Do you think it could have been used in third-party package? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 09:45:05 2023 Received: (at 61639) by debbugs.gnu.org; 20 Feb 2023 14:45:05 +0000 Received: from localhost ([127.0.0.1]:51144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU7Pd-0007DO-4p for submit@debbugs.gnu.org; Mon, 20 Feb 2023 09:45:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU7Pa-0007Ca-Jx for 61639@debbugs.gnu.org; Mon, 20 Feb 2023 09:45:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU7PU-0002q8-NO; Mon, 20 Feb 2023 09:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=x+MYMOSEr2l5pduTZiX9fAcCDB9Hv8r5H3mG0pQo/oA=; b=ry6Zn4iaYl+5 jYvfPnTmwcGMTbv4u4k30VytCA7EG9vwsXk6t3CKFW5fzIXrdHshFjd8spygFFioCzSnVr+tqAo2x Mdmax8zatv3lgg7W9eoV6HlKmN3dteccmL9etyksBeYgQyPtuYazPbsxO6NI1RsYXHadKlShFRdHi YEvezYpdINvsolJscdmyaMcPn94q4hW0BvHJnbGajR+eOthHM9YBjCuUELRbJ97xIRODpXmg3Su2A ONE/Ms+ZFBrMGXZrZLdlR2loNN+h3B+DI2miUdNWppPx2dHUssFwmIfdzKvXjl5YH/2JO2pVNaXzE Ox2/85alwk/Xfj+oo7uEaw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU7PT-0003QC-DU; Mon, 20 Feb 2023 09:44:56 -0500 Date: Mon, 20 Feb 2023 16:45:04 +0200 Message-Id: <83a618v1jj.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87k00ctofi.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 20 Feb 2023 15:13:37 +0100) Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61639@debbugs.gnu.org > Date: Mon, 20 Feb 2023 15:13:37 +0100 > > Eli Zaretskii writes: > > > So maybe "C-t d" should filter the selected "images" before it calls > > the function which errors out? > > That is what `image-dired-show-all-from-dir' is doing: it selects files > from the given directory with the correct "image files" regexp and so no > non image will be present. > > So your idea is to keep `image-dired--get-create-thumbnail-file' as is > and filter its input in `image-dired-display-thumbs'? But then we won't > get any message or error that something was not an image (this could go > unnoticed as well ;-) I don't necessarily see a reason to alert the user in this case, but if you think we had better done that, we could show a message when we find a non-image file in the list of the selected ones. > > IOW, if the application doesn't want an API to fail for reasons > > specific to the application, the onus of avoiding the error is on the > > application, no? > > Yes, but maybe `image-dired--get-create-thumbnail-file' is not really an > established API. It is called twice in Emacs (and the other place it is > called non images are already filtered out). > > Do you think it could have been used in third-party package? That's not what bothers me. What bothers me is that we burden a low-level API with considerations whose source is the application. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 11:41:43 2023 Received: (at 61639) by debbugs.gnu.org; 20 Feb 2023 16:41:43 +0000 Received: from localhost ([127.0.0.1]:53339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU9EU-0004jE-PP for submit@debbugs.gnu.org; Mon, 20 Feb 2023 11:41:43 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:5612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU9EQ-0004j0-9q for 61639@debbugs.gnu.org; Mon, 20 Feb 2023 11:41:41 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=5cscGKhg oyohE9eaG0WPOfNx0MzwDpL9ZHGRg1mGBlc=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=Pr5qEWvPTbbQ8B+ZHMFkHl7BGSSmh0 mChSv/JEPP1uWECaxNRpebKisKssLUVLI6YYOPPVQSamohDqpL7uCjDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=5cscGKhgoyohE9ea G0WPOfNx0MzwDpL9ZHGRg1mGBlc=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Q90HtCljcasTyl+ThB1SHO7V9bu+kEiIKj88BS iK50uY3e4gRX0ywMTApGk8QsslleNlZbSvdMflLAuvN1IDz+0haUHtriGzCjRrDrl8T/3F lVXHi8ZgU0f0YTSNplyk2jt/KXppGPA1DUQXhVSwGbNqDfMLwg4J3r3SFAELxW3jtKKtNh 3TfnWLEO6+t5XairbnDIoI/MQ2mdNFf2TxUL5LVoN+360kc7smjjWWDms8KTWSnsNjtjqH +Smm9IrnkJ/5Q0uF/8Be+oYqt9VZSRmyzTnDeB6wvGNL9pq+l8Bx0JMSZeR4+NKcglTpeD Ope6zRL4hzCjKHqaT3RpVyZg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id cde50a82 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 20 Feb 2023 17:41:36 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired In-Reply-To: <83a618v1jj.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Feb 2023 16:45:04 +0200") References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> Date: Mon, 20 Feb 2023 17:41:35 +0100 Message-ID: <87bklothkw.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] >> So your idea is to keep `image-dired--get-create-thumbnail-file' as is >> and filter its input in `image-dired-display-thumbs'? But then we won't >> get any message or error that something was not an image (this could go >> unnoticed as well ;-) > > I don't necessarily see a reason to alert the user in this case, but > if you think we had better done that, we could show a message when we > find a non-image file in the list of the selected ones. Ok. Here is a new version of the patch that address those issues. I choose to not alert the user. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-error-out-on-non-image-file-bug-61639.patch >From ddbeb1171c02f3865359edd9b2b435e329d35f7c Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sun, 19 Feb 2023 21:03:57 +0100 Subject: [PATCH] Do not error out on non image file (bug#61639) * lisp/image/image-dired.el (image-dired-display-thumbs): Do not insert non image file and do not display image-dired buffer if it is empty. --- lisp/image/image-dired.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index cfcd1851188..5798af77f35 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -586,13 +586,15 @@ image-dired-display-thumbs (erase-buffer)) (goto-char (point-max))) (dolist (file files) - (let ((thumb (image-dired--get-create-thumbnail-file file))) + (when (string-match-p (image-dired--file-name-regexp) file) (image-dired-insert-thumbnail - thumb file dired-buf + (image-dired--get-create-thumbnail-file file) file dired-buf (cl-incf image-dired--number-of-thumbnails))))) - (if do-not-pop - (display-buffer buf) - (pop-to-buffer buf)) + (if (plusp image-dired--number-of-thumbnails) + (if do-not-pop + (display-buffer buf) + (pop-to-buffer buf)) + (message "No images selected")) (image-dired--line-up-with-method) (image-dired--update-header-line)))) -- 2.39.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 07:01:36 2023 Received: (at 61639) by debbugs.gnu.org; 21 Feb 2023 12:01:36 +0000 Received: from localhost ([127.0.0.1]:54784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pURKx-0006uu-Od for submit@debbugs.gnu.org; Tue, 21 Feb 2023 07:01:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pURKs-0006uh-SX for 61639@debbugs.gnu.org; Tue, 21 Feb 2023 07:01:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pURKm-0004Lt-Fr; Tue, 21 Feb 2023 07:01:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NImICMgCkgkYT0UzuFDzpaVj2Mgo25bNtZqF2CjMhi8=; b=mKx4JFciioBf FluQnFL3+FG30F6Deg9nQzN/f+NXdR1mJx8omOfhlkOOsCJACPmSKMGSv7Cvfu3H0MDP+Lky9BlYX QbP4louN3N6GrQZnG1L1okV0+qhDCFm+j2lXAzWbTIC3a9Q8QMlI3m9ZJ6r+Wf1YuJ6RvuPiq7+Ai ML3KdFW0gt8c3XvHjOC5SCWnC8UdpB2RGEX7eZYUTKr0JAlxWEjokKt1eirtsw9c1cix8124mMZzi jXFe8H0Uom3rkud/cjntaxjjPk7kzviIlB2YzDWi6B5og6AG90mSbB8wELEM6zWcryTtrXFfH+bO/ QzADNsCJ/aWcCvX7lbE26w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pURKl-0004eZ-Vt; Tue, 21 Feb 2023 07:01:24 -0500 Date: Tue, 21 Feb 2023 14:01:34 +0200 Message-Id: <83ttzfteg1.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87bklothkw.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 20 Feb 2023 17:41:35 +0100) Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> <87bklothkw.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61639@debbugs.gnu.org > Date: Mon, 20 Feb 2023 17:41:35 +0100 > > Eli Zaretskii writes: > > > I don't necessarily see a reason to alert the user in this case, but > > if you think we had better done that, we could show a message when we > > find a non-image file in the list of the selected ones. > > Ok. Here is a new version of the patch that address those issues. I > choose to not alert the user. Thanks. This LGTM, but what is 'plusp'? > diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el > index cfcd1851188..5798af77f35 100644 > --- a/lisp/image/image-dired.el > +++ b/lisp/image/image-dired.el > @@ -586,13 +586,15 @@ image-dired-display-thumbs > (erase-buffer)) > (goto-char (point-max))) > (dolist (file files) > - (let ((thumb (image-dired--get-create-thumbnail-file file))) > + (when (string-match-p (image-dired--file-name-regexp) file) > (image-dired-insert-thumbnail > - thumb file dired-buf > + (image-dired--get-create-thumbnail-file file) file dired-buf > (cl-incf image-dired--number-of-thumbnails))))) > - (if do-not-pop > - (display-buffer buf) > - (pop-to-buffer buf)) > + (if (plusp image-dired--number-of-thumbnails) <<<<<<<<<<<<<<<<<<<<<< > + (if do-not-pop > + (display-buffer buf) > + (pop-to-buffer buf)) > + (message "No images selected")) > (image-dired--line-up-with-method) > (image-dired--update-header-line)))) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 07:16:14 2023 Received: (at 61639) by debbugs.gnu.org; 21 Feb 2023 12:16:14 +0000 Received: from localhost ([127.0.0.1]:54802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pURZ7-0007ay-Lr for submit@debbugs.gnu.org; Tue, 21 Feb 2023 07:16:13 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:28368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pURZ1-0007a4-Vd for 61639@debbugs.gnu.org; Tue, 21 Feb 2023 07:16:12 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=xpgJP+Nn R0b8Db/hbrinYEIKUQLxJC7sobYOXps/fug=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=ZRE4Hq9uK+r8SqQLtqLi+5yf9+5gcS rr6f7MYlHX0LmnMil0p9c4O3COKI1+kHcKyIn3zRoJrn5z4TZ5CHGBAw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=xpgJP+NnR0b8Db/h brinYEIKUQLxJC7sobYOXps/fug=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=OSWrSood52d3fm+oS/En7V0onq/vgKx9/7IKbI 7RZOqhjiJP5awfqBxQlaDIpWJr4dhAnQ/jUBkcKtTnLNpTh5Qw+4gFdsGyJjcDilltRUB6 yhqDqBANgESzvT78Vggz0lq7avDs430aMRmg4H7a9wCFD0btzrLMwxkyLyDdFBhb68aD47 h+D6HHLYEX2EwIQkIokgX3ENUiuBx6E/GqsoRdFUyfIkywxbirDtFL0a9ZMERcv2gnpBOD a32QDv3lwoVONGK22NwJazXXKgddiDHphYqwT/S3O0p1yssI9HSmcaWmwGfkbgqygTY5pD HtVFchTJSbXYgQoTOvDBxBWQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 83ac3487 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 21 Feb 2023 13:16:06 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired In-Reply-To: <83ttzfteg1.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Feb 2023 14:01:34 +0200") References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> <87bklothkw.fsf@ledu-giraud.fr> <83ttzfteg1.fsf@gnu.org> Date: Tue, 21 Feb 2023 13:16:04 +0100 Message-ID: <87y1orrz7f.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] > Thanks. This LGTM, but what is 'plusp'? 'plusp' is a classic Common Lisp predicate (that also seems to be defined in Emacs). It is equivalent to (> x 0)=E2=80=A6 maybe you prefer t= hat. Should I fix my patch? --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 08:03:42 2023 Received: (at 61639) by debbugs.gnu.org; 21 Feb 2023 13:03:42 +0000 Received: from localhost ([127.0.0.1]:54902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUSJ4-0003V7-IT for submit@debbugs.gnu.org; Tue, 21 Feb 2023 08:03:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUSJ0-0003Ur-Ug for 61639@debbugs.gnu.org; Tue, 21 Feb 2023 08:03:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUSIv-0002fO-4I; Tue, 21 Feb 2023 08:03:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mxg50jABpWIQ8hRDzJ7Xg5cdWbPPTX6Q6+ONBCCsW2k=; b=CdoQEk3FUKnIJDpifpVJ AQpb+MkM4qyg44VC/AkCWtDaAidkyTPedcMn55ishjEKIT+uZ92vKOnzQWGXz/aU4/6nHzdt93XCr Z5OpEavxDdJtdQYMb6iwQiuy9JRV0YGXAkEGToOJht7uNN5DpaSrFfQfGgn9rvuakNLizVYOSKk9h eildQ0N++fmofpzzYc0AA8N5psVv/F4YZcgSHgSK9Ujq3Er3KhNi7nUe+6qs5+eT28+P2/91GhFSy ocVXohPGkRYmFxAbFUYGipd+bzv1G4VbF5pht4wNS3ZqE3Jcebcz/fzqV+4zKoQYPWvbsYj/H+GsC 3YvJNSM+Dz822g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUSIu-00059G-G5; Tue, 21 Feb 2023 08:03:32 -0500 Date: Tue, 21 Feb 2023 15:03:44 +0200 Message-Id: <83cz63tbkf.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87y1orrz7f.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 21 Feb 2023 13:16:04 +0100) Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> <87bklothkw.fsf@ledu-giraud.fr> <83ttzfteg1.fsf@gnu.org> <87y1orrz7f.fsf@ledu-giraud.fr> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61639@debbugs.gnu.org > Date: Tue, 21 Feb 2023 13:16:04 +0100 > > Eli Zaretskii writes: > > [...] > > > Thanks. This LGTM, but what is 'plusp'? > > 'plusp' is a classic Common Lisp predicate (that also seems to be > defined in Emacs). It is equivalent to (> x 0)… maybe you prefer that. > Should I fix my patch? Where is it defined? It isn't defined in "emacs -Q", and not after loading image-dired. (Tested in Emacs 29.) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 09:23:10 2023 Received: (at 61639) by debbugs.gnu.org; 21 Feb 2023 14:23:10 +0000 Received: from localhost ([127.0.0.1]:55106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUTXx-0000w7-U7 for submit@debbugs.gnu.org; Tue, 21 Feb 2023 09:23:10 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:48940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUTXw-0000vt-2C for 61639@debbugs.gnu.org; Tue, 21 Feb 2023 09:23:09 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=ZJf5efg+ KC2EL6PPVywd8kxmAqtXX0M8BNyKsEccKVo=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=l6Y4k+GPHFSLHnQ9SpVVSN+Ebpq5hs 7Ijc/Cjy97PvjHp8/pmFZv7Vl4FbY6O6Z9E1YNMnXLhSzuyz0qB2gyDQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=ZJf5efg+KC2EL6PP Vywd8kxmAqtXX0M8BNyKsEccKVo=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=RND2chX2+kPa0AmBpkoOTPXt6RrZiE9nuG5HmS oVSieNYpniZKcjNmRm7OLYI05qNunYrwPc9Aaq7DyqfgDvbkPiV6c8Jspypu/xAK2535sv 9s8NxK30GnP8OItqKHyo8uC3WHHC6rzEQxOUkue5ekjmlPv+C909ruHrZ43Z1I5SkPjYU7 nyvZ/GEHd0lyHs9FbZUGFzENKpK3zO8oqWy5q//GceuX7mPVEDtU4jW/3n09/inXmbHVMU ljexXukERir6q5G8Klx6IfOkvtV/XI9DBsGVy6DopN1Nk4H03bEnRucXkHilADOE8v/QuQ eHU8duL0S6c9Ux6lYKQVHnGQ== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 8cce2996 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 21 Feb 2023 15:23:05 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired In-Reply-To: <83cz63tbkf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Feb 2023 15:03:44 +0200") References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> <87bklothkw.fsf@ledu-giraud.fr> <83ttzfteg1.fsf@gnu.org> <87y1orrz7f.fsf@ledu-giraud.fr> <83cz63tbkf.fsf@gnu.org> Date: Tue, 21 Feb 2023 15:23:01 +0100 Message-ID: <87mt57kshm.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61639 Cc: 61639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: [...] >> 'plusp' is a classic Common Lisp predicate (that also seems to be >> defined in Emacs). It is equivalent to (> x 0)=E2=80=A6 maybe you prefe= r that. >> Should I fix my patch? > > Where is it defined? It isn't defined in "emacs -Q", and not after > loading image-dired. (Tested in Emacs 29.) C-h f gives me this: --8<---------------cut here---------------start------------->8--- plusp is an alias for =E2=80=98cl-plusp=E2=80=99 in =E2=80=98cl.el=E2=80=99. This function is obsolete since 27.1; use =E2=80=98cl-plusp=E2=80=99 instea= d. --8<---------------cut here---------------end--------------->8--- =E2=80=A6 anyway here is an updated version of the patch to avoid this. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-error-out-on-non-image-file-bug-61639.patch >From e9b6f649a97800fcc045b52a63556d25ca4b472c Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sun, 19 Feb 2023 21:03:57 +0100 Subject: [PATCH] Do not error out on non image file (bug#61639) * lisp/image/image-dired.el (image-dired-display-thumbs): Do not insert non image file and do not display image-dired buffer if it is empty. --- lisp/image/image-dired.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index cfcd1851188..20697b3c9e0 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -586,13 +586,15 @@ image-dired-display-thumbs (erase-buffer)) (goto-char (point-max))) (dolist (file files) - (let ((thumb (image-dired--get-create-thumbnail-file file))) + (when (string-match-p (image-dired--file-name-regexp) file) (image-dired-insert-thumbnail - thumb file dired-buf + (image-dired--get-create-thumbnail-file file) file dired-buf (cl-incf image-dired--number-of-thumbnails))))) - (if do-not-pop - (display-buffer buf) - (pop-to-buffer buf)) + (if (> image-dired--number-of-thumbnails 0) + (if do-not-pop + (display-buffer buf) + (pop-to-buffer buf)) + (message "No images selected")) (image-dired--line-up-with-method) (image-dired--update-header-line)))) -- 2.39.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 08:22:05 2023 Received: (at 61639-done) by debbugs.gnu.org; 22 Feb 2023 13:22:05 +0000 Received: from localhost ([127.0.0.1]:58294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp4P-0002IW-3n for submit@debbugs.gnu.org; Wed, 22 Feb 2023 08:22:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUp4N-0002I0-4Q for 61639-done@debbugs.gnu.org; Wed, 22 Feb 2023 08:22:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUp4H-0001rY-9k; Wed, 22 Feb 2023 08:21:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=AgtRDBQnEbEiZI8oyxmv1wOiJlS/pmKdF3cGmQdtrqs=; b=Lj45EIcppMsBR2J+5ohI SgFSRJfakRx0jxgO4KZsn4QjXr1OUrxjF4xYMQuAjLBxfD9/o4ZWsAKovQH0qrz9k7kxNaAwh51qB V21ShzaY2nxKdprqdd/r/kp4DqVckSDAiJee8M8t4ak3LeEmtuNsm2KT1H6yMLJ8Shqjg2lU5T1tn JK6tkFMCj8kjoHTl2x81zBZ7li+JMDwV4HUIugr48fAlcaoEe+tpYxnDAnUm9UhCkmfOS6d6JbabL BqIJ7MB+qNFs9anNvKJIN0FI3imLW4vHMzSNWxq/Oa5vDGpZippmWW2OboeeHu2VYsU5l7pa9hchy XYZcB5ujZQTAQw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUp4G-0005KZ-It; Wed, 22 Feb 2023 08:21:56 -0500 Date: Wed, 22 Feb 2023 15:22:11 +0200 Message-Id: <83a615sum4.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87mt57kshm.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 21 Feb 2023 15:23:01 +0100) Subject: Re: bug#61639: 30.0.50; [PATCH] Do not error out on non image file in image-dired References: <87sff1quwk.fsf@ledu-giraud.fr> <83sff0v6wz.fsf@gnu.org> <87ttzgtq6p.fsf@ledu-giraud.fr> <83edqkv48n.fsf@gnu.org> <87k00ctofi.fsf@ledu-giraud.fr> <83a618v1jj.fsf@gnu.org> <87bklothkw.fsf@ledu-giraud.fr> <83ttzfteg1.fsf@gnu.org> <87y1orrz7f.fsf@ledu-giraud.fr> <83cz63tbkf.fsf@gnu.org> <87mt57kshm.fsf@ledu-giraud.fr> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61639-done Cc: 61639-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 61639@debbugs.gnu.org > Date: Tue, 21 Feb 2023 15:23:01 +0100 > > Eli Zaretskii writes: > > [...] > > >> 'plusp' is a classic Common Lisp predicate (that also seems to be > >> defined in Emacs). It is equivalent to (> x 0)… maybe you prefer that. > >> Should I fix my patch? > > > > Where is it defined? It isn't defined in "emacs -Q", and not after > > loading image-dired. (Tested in Emacs 29.) > > C-h f gives me this: > --8<---------------cut here---------------start------------->8--- > plusp is an alias for ‘cl-plusp’ in ‘cl.el’. > > This function is obsolete since 27.1; use ‘cl-plusp’ instead. > --8<---------------cut here---------------end--------------->8--- > > … anyway here is an updated version of the patch to avoid this. Thanks, I installed this on the emacs-29 branch, and closing the bug. From unknown Tue Aug 19 10:02:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Mar 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator