From unknown Sat Aug 09 01:11:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61577: 30.0.50; project-try-vc missing vc-got Resent-From: Omar Polo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2023 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61577@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167665299529933 (code B ref -1); Fri, 17 Feb 2023 16:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Feb 2023 16:56:35 +0000 Received: from localhost ([127.0.0.1]:41319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT42E-0007mi-P7 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 11:56:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:38502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT42D-0007ma-3m for submit@debbugs.gnu.org; Fri, 17 Feb 2023 11:56:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT42A-0002ay-WC for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:56:31 -0500 Received: from mail.omarpolo.com ([144.91.116.244]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT427-0005f0-22 for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:56:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1676652980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=He5uQTNL53KrbY3bBOQEjew5Zl7MuHKwD8AMbwaGN94=; b=oXk2KQbfO6iCAY+GASxlKKfC0CeBvNQnSpyWcgKcDeZlge1WahamTl9ZfUdYUFeqKI/RYL nFYDYe4HY/JNfZF+4NM+8jaIU+rFHi4WBoByK7pRRh1pXdNf+ukGj6AS1YtoEZEzsAINLb WW806SqJnXrkZ652dahv1zWkCP57FF0= Received: from localhost (host-87-2-235-1.retail.telecomitalia.it [87.2.235.1]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 947d7053 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 17 Feb 2023 17:56:20 +0100 (CET) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d790ff27 for ; Fri, 17 Feb 2023 17:56:19 +0100 (CET) Date: Fri, 17 Feb 2023 17:56:19 +0100 From: Omar Polo Message-Id: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> User-Agent: mblaze/1.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, project-try-vc (IIRC) used to loop over all the vc-backends to find the root of a project. Now, it=E2=80=99s just an hardcoded list in a local variable. This breaks the project-* functions on Got checkouts. I can imagine the reason of the change (avoid loading all the vc-*.el files I guess) but it would be nice for this variable to be at least user-configurable, otherwise we will always end up with missing entries. (Yeah, one could add their own hooks in project-find-functions for that, but seems replicating stuff that project.el tries to do anyway.) Attaching a diff that temporarly works around the problem by adding the Got -> .got mapping. Thanks, Omar Polo diff /home/op/build/emacs commit - dabd7feb950ef2dba0ce23ec74c5b141cff96a55 path + /home/op/build/emacs blob - 2343adf4698471cf5262ce7a4340a4b0c5b5fa7e file + lisp/progmodes/project.el --- lisp/progmodes/project.el +++ lisp/progmodes/project.el @@ -506,7 +506,8 @@ project backend implementation of `project-external-ro (Bzr . ".bzr") (SVN . ,vc-svn-admin-directory) (DARCS . "_darcs") - (Fossil . ".fslckout"))) + (Fossil . ".fslckout") + (Got . ".got"))) (backend-markers (delete nil In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, X toolkit, cairo version 1.17.8, Xaw scroll bars) of 2023-02-16 built on venera Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD venera 7.2 GENERIC.MP#1052 amd64 Configured using: 'configure --prefix /home/op/opt/emacs --with-x-toolkit=3Dlucid' Configured features: CAIRO DBUS FREETYPE GIF GLIB GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY KQUEUE PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Eshell Minor modes in effect: shell-dirtrack-mode: t eshell-prompt-mode: t eshell-pred-mode: t eshell-hist-mode: t eshell-cmpl-mode: t eshell-proc-mode: t eshell-arg-mode: t server-mode: t shackle-mode: t global-form-feed-mode: t electric-pair-mode: t savehist-mode: t save-place-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-quote-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t abbrev-mode: t Load-path shadows: ~/build/emacs-libpq/pq hides /home/op/.emacs.d/elpa/pq-0.1/pq /home/op/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/op/opt/emacs/s= hare/emacs/30.0.50/lisp/progmodes/eglot Features: (shadow sort mail-extr emacsbug bug-reference noutline outline reposition em-unix yaml-mode debug backtrace pcmpl-unix pcmpl-gnu warnings em-term term disp-table shell ehelp em-script em-prompt em-pred em-ls em-hist em-glob em-extpipe em-cmpl em-dirs em-basic em-banner em-alias esh-mode esh-var pcomplete eshell esh-cmd generator esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util cus-edit cus-start cus-load wid-edit diff-mode ispell term/xterm xterm files-x find-dired vc-got log-view compile vc-dir ewoc log-edit message sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log vc-annotate vc vc-dispatcher mule-util display-line-numbers icons xref vc-svn cl-print ielm pp comint ansi-osc ansi-color ring dired-aux dired-x dired dired-loaddefs puni pulse color imenu misearch multi-isearch jka-compr find-func shortdoc text-property-search cl-extra rx orderless project help-fns radix-tree server shackle trace checkdoc lisp-mnt thingatpt help-mode form-feed elec-pair savehist saveplace whitespace orderless-autoloads fennel-mode-autoloads geiser-guile-autoloads geiser-autoloads finder-inf gemini-mode-autoloads go-mode-autoloads haskell-mode-autoloads lua-mode-autoloads markdown-mode-autoloads puni-autoloads easy-mmode info sly-autoloads eglot-autoloads pq-autoloads web-mode-autoloads yaml-mode-autoloads cider-autoloads sesman-autoloads spinner-autoloads queue-autoloads parseedn-autoloads parseclj-autoloads clojure-mode-autoloads vc-got-autoloads vc-fossil-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib minimal-theme rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 386600 40031) (symbols 48 21832 1) (strings 32 116838 2419) (string-bytes 1 3104440) (vectors 16 41495) (vector-slots 8 615081 20384) (floats 8 287 891) (intervals 56 5909 2186) (buffers 976 34)) From unknown Sat Aug 09 01:11:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61577: 30.0.50; project-try-vc missing vc-got References: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> In-Reply-To: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> Resent-From: Omar Polo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2023 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61577@debbugs.gnu.org Received: via spool by 61577-submit@debbugs.gnu.org id=B61577.167665526211153 (code B ref 61577); Fri, 17 Feb 2023 17:35:01 +0000 Received: (at 61577) by debbugs.gnu.org; 17 Feb 2023 17:34:22 +0000 Received: from localhost ([127.0.0.1]:41499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT4cn-0002tp-N6 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 12:34:21 -0500 Received: from mail.omarpolo.com ([144.91.116.244]:52061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT4cm-0002ta-DY for 61577@debbugs.gnu.org; Fri, 17 Feb 2023 12:34:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1676655253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=lDwOd5QJiSpWvHMN8VHGBI1X9sF0uQlck/wimeTkx5I=; b=DkS+QWd2lUfnqE1JQ6AlF68MI+d1kYRm/CGAqgq+wZVor07WlJB/1K7Bke5x109R0bc6l8 ufpkX20eFU1pCBKbz6Y47kA4zqdKO74n4dZkWr/kZidvEsTYK2vYnZniNF+rol1ZZfwUBR 5ayhcVnzwOLWTaxl1aCyDx/vk1c6FC8= Received: from localhost (host-87-2-235-1.retail.telecomitalia.it [87.2.235.1]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 80684a3b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <61577@debbugs.gnu.org>; Fri, 17 Feb 2023 18:34:13 +0100 (CET) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 359f2f19 for <61577@debbugs.gnu.org>; Fri, 17 Feb 2023 18:34:11 +0100 (CET) Date: Fri, 17 Feb 2023 18:34:11 +0100 From: Omar Polo Message-Id: <37S9LBNTLNSPF.20HFUF5RQ7969@venera> User-Agent: mblaze/1.2 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) actually, isn't at least CVS missing too? diff /home/op/build/emacs commit - dabd7feb950ef2dba0ce23ec74c5b141cff96a55 path + /home/op/build/emacs blob - 2343adf4698471cf5262ce7a4340a4b0c5b5fa7e file + lisp/progmodes/project.el --- lisp/progmodes/project.el +++ lisp/progmodes/project.el @@ -501,12 +501,14 @@ project backend implementation of `project-external-ro ;; `project-vc-merge-submodules' or `project-vc-extra-root-markers' ;; changes. (or (vc-file-getprop dir 'project-vc) - (let* ((backend-markers-alist `((Git . ".git") + (let* ((backend-markers-alist `((CVS . "CVS") + (Git . ".git") (Hg . ".hg") (Bzr . ".bzr") (SVN . ,vc-svn-admin-directory) (DARCS . "_darcs") - (Fossil . ".fslckout"))) + (Fossil . ".fslckout") + (Got . ".got"))) (backend-markers (delete nil From unknown Sat Aug 09 01:11:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Omar Polo Subject: bug#61577: closed (Re: bug#61577: 30.0.50; project-try-vc missing vc-got) Message-ID: References: <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> X-Gnu-PR-Message: they-closed 61577 X-Gnu-PR-Package: emacs Reply-To: 61577@debbugs.gnu.org Date: Fri, 17 Feb 2023 23:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1676675522-21376-1" This is a multi-part message in MIME format... ------------=_1676675522-21376-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61577: 30.0.50; project-try-vc missing vc-got which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61577@debbugs.gnu.org. --=20 61577: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61577 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1676675522-21376-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61577-done) by debbugs.gnu.org; 17 Feb 2023 23:11:20 +0000 Received: from localhost ([127.0.0.1]:41837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT9su-0005XR-10 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 18:11:20 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:38515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT9st-0005XB-3z for 61577-done@debbugs.gnu.org; Fri, 17 Feb 2023 18:11:19 -0500 Received: by mail-wm1-f52.google.com with SMTP id o10-20020a05600c510a00b003e21e018039so1010426wms.3 for <61577-done@debbugs.gnu.org>; Fri, 17 Feb 2023 15:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=wzq10H/HOpxCBDwmg7N+Lbch0LaZD69f4YC1+PL82KU=; b=pYTirqP5ut6slXv1NXY6NFbBkkhPe1ro8BHMS22cqvA9YjjmrH8GpZkwc5J3lTAefI 66hasi6nb0c0qUjBYU6dlgd48BFTWL3+qWlv6GuAndTEXggbMD+scvJK4Nw6HUxx/IZS 89Wv2w7fV9aDODHf+iMIvQ9uVy9GCRWxO3rYhANgD/HI2giP0H3y5JH/Z5PZmnIZo969 U8L0qcmGWCGsqeC679pqB/XLLbuU09+aeUtmpr/c3s0N1yBMVRaLY32ML2g6cXL+pAI0 4lXBT6ttpkBlL9y52zH5ku3WSDP2+Mtk1HmwtB0TH0RMfr1ziJtgT6BTcv3ImgxNW2Zy rFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wzq10H/HOpxCBDwmg7N+Lbch0LaZD69f4YC1+PL82KU=; b=vr+RPVgDtsaWd0KQbmLQRQbalfMpVAa+Bs/i34X11NibyqGqlBmCX40KN15GI2GBlO OiKGT12Kvpt8jDQNBK+MAQ5MXSNqq5U9SWopxVeDgowlq2taoRQal/MuJdYm7NxzSh/A H8AE4fF591ISLtqm3MIbDW8lrmRPYeqMctPee2VWb48sjPnMqz3qESA5hxOt7exSRCrK 6/4D2rP/SeaHhjfD1Nc8+qV+6FScs49YhtfV+1+myQi8Nu3+HJiB/vBXkAUHlBuwhJFG ABq18ZfVFJDnCU2IQAuWqVrYRwRHNgtCyAO5RrQOaalaS6mYlhCu85EAZFpvPWXBga22 cq3g== X-Gm-Message-State: AO0yUKX60mM1Ujjb6Ebnh5Ot7f3DT70pGp6K6+fKAq4xOvBFA9QXwxir e2eo056icfMOQ+6/PWG9Qu0= X-Google-Smtp-Source: AK7set+5cjQqh/xEt0FwWZicLwNVEcf2D43g6kFyO56cmFeje0LPlUDHjXwJGUXihl91biX49NpjkA== X-Received: by 2002:a05:600c:502c:b0:3d1:caf1:3f56 with SMTP id n44-20020a05600c502c00b003d1caf13f56mr6195334wmr.9.1676675472921; Fri, 17 Feb 2023 15:11:12 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l33-20020a05600c1d2100b003db012d49b7sm3165475wms.2.2023.02.17.15.11.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 15:11:12 -0800 (PST) Message-ID: <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> Date: Sat, 18 Feb 2023 01:11:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#61577: 30.0.50; project-try-vc missing vc-got Content-Language: en-US To: Omar Polo , 61577-done@debbugs.gnu.org References: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> From: Dmitry Gutov In-Reply-To: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 61577-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) Version: 29.1 Hi! On 17/02/2023 18:56, Omar Polo wrote: > project-try-vc (IIRC) used to loop over all the vc-backends to find the > root of a project. Now, it’s just an hardcoded list in a local > variable. This breaks the project-* functions on Got checkouts. > > I can imagine the reason of the change (avoid loading all the vc-*.el > files I guess) but it would be nice for this variable to be at least > user-configurable, otherwise we will always end up with missing entries. The reasons were actually related to performance during the search. > (Yeah, one could add their own hooks in project-find-functions for > that, but seems replicating stuff that project.el tries to do anyway.) > > Attaching a diff that temporarly works around the problem by adding the > Got -> .got mapping. Thanks for the report, I've pushed your addition and also moved the list to a defvar. Not defcustom, though, to avoid encouraging people from changing it unnecessarily (instead of project-vc-extra-root-markers). Originally, I figured all major backends should be covered, but it won't hurt to add one more, especially since vc-got is in ELPA. ------------=_1676675522-21376-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Feb 2023 16:56:35 +0000 Received: from localhost ([127.0.0.1]:41319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT42E-0007mi-P7 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 11:56:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:38502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT42D-0007ma-3m for submit@debbugs.gnu.org; Fri, 17 Feb 2023 11:56:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT42A-0002ay-WC for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:56:31 -0500 Received: from mail.omarpolo.com ([144.91.116.244]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT427-0005f0-22 for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:56:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1676652980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=He5uQTNL53KrbY3bBOQEjew5Zl7MuHKwD8AMbwaGN94=; b=oXk2KQbfO6iCAY+GASxlKKfC0CeBvNQnSpyWcgKcDeZlge1WahamTl9ZfUdYUFeqKI/RYL nFYDYe4HY/JNfZF+4NM+8jaIU+rFHi4WBoByK7pRRh1pXdNf+ukGj6AS1YtoEZEzsAINLb WW806SqJnXrkZ652dahv1zWkCP57FF0= Received: from localhost (host-87-2-235-1.retail.telecomitalia.it [87.2.235.1]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 947d7053 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 17 Feb 2023 17:56:20 +0100 (CET) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d790ff27 for ; Fri, 17 Feb 2023 17:56:19 +0100 (CET) Date: Fri, 17 Feb 2023 17:56:19 +0100 To: bug-gnu-emacs@gnu.org Subject: 30.0.50; project-try-vc missing vc-got From: Omar Polo Message-Id: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> User-Agent: mblaze/1.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, project-try-vc (IIRC) used to loop over all the vc-backends to find the root of a project. Now, it=E2=80=99s just an hardcoded list in a local variable. This breaks the project-* functions on Got checkouts. I can imagine the reason of the change (avoid loading all the vc-*.el files I guess) but it would be nice for this variable to be at least user-configurable, otherwise we will always end up with missing entries. (Yeah, one could add their own hooks in project-find-functions for that, but seems replicating stuff that project.el tries to do anyway.) Attaching a diff that temporarly works around the problem by adding the Got -> .got mapping. Thanks, Omar Polo diff /home/op/build/emacs commit - dabd7feb950ef2dba0ce23ec74c5b141cff96a55 path + /home/op/build/emacs blob - 2343adf4698471cf5262ce7a4340a4b0c5b5fa7e file + lisp/progmodes/project.el --- lisp/progmodes/project.el +++ lisp/progmodes/project.el @@ -506,7 +506,8 @@ project backend implementation of `project-external-ro (Bzr . ".bzr") (SVN . ,vc-svn-admin-directory) (DARCS . "_darcs") - (Fossil . ".fslckout"))) + (Fossil . ".fslckout") + (Got . ".got"))) (backend-markers (delete nil In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, X toolkit, cairo version 1.17.8, Xaw scroll bars) of 2023-02-16 built on venera Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD venera 7.2 GENERIC.MP#1052 amd64 Configured using: 'configure --prefix /home/op/opt/emacs --with-x-toolkit=3Dlucid' Configured features: CAIRO DBUS FREETYPE GIF GLIB GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY KQUEUE PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Eshell Minor modes in effect: shell-dirtrack-mode: t eshell-prompt-mode: t eshell-pred-mode: t eshell-hist-mode: t eshell-cmpl-mode: t eshell-proc-mode: t eshell-arg-mode: t server-mode: t shackle-mode: t global-form-feed-mode: t electric-pair-mode: t savehist-mode: t save-place-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-quote-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t abbrev-mode: t Load-path shadows: ~/build/emacs-libpq/pq hides /home/op/.emacs.d/elpa/pq-0.1/pq /home/op/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/op/opt/emacs/s= hare/emacs/30.0.50/lisp/progmodes/eglot Features: (shadow sort mail-extr emacsbug bug-reference noutline outline reposition em-unix yaml-mode debug backtrace pcmpl-unix pcmpl-gnu warnings em-term term disp-table shell ehelp em-script em-prompt em-pred em-ls em-hist em-glob em-extpipe em-cmpl em-dirs em-basic em-banner em-alias esh-mode esh-var pcomplete eshell esh-cmd generator esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util cus-edit cus-start cus-load wid-edit diff-mode ispell term/xterm xterm files-x find-dired vc-got log-view compile vc-dir ewoc log-edit message sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log vc-annotate vc vc-dispatcher mule-util display-line-numbers icons xref vc-svn cl-print ielm pp comint ansi-osc ansi-color ring dired-aux dired-x dired dired-loaddefs puni pulse color imenu misearch multi-isearch jka-compr find-func shortdoc text-property-search cl-extra rx orderless project help-fns radix-tree server shackle trace checkdoc lisp-mnt thingatpt help-mode form-feed elec-pair savehist saveplace whitespace orderless-autoloads fennel-mode-autoloads geiser-guile-autoloads geiser-autoloads finder-inf gemini-mode-autoloads go-mode-autoloads haskell-mode-autoloads lua-mode-autoloads markdown-mode-autoloads puni-autoloads easy-mmode info sly-autoloads eglot-autoloads pq-autoloads web-mode-autoloads yaml-mode-autoloads cider-autoloads sesman-autoloads spinner-autoloads queue-autoloads parseedn-autoloads parseclj-autoloads clojure-mode-autoloads vc-got-autoloads vc-fossil-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib minimal-theme rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 386600 40031) (symbols 48 21832 1) (strings 32 116838 2419) (string-bytes 1 3104440) (vectors 16 41495) (vector-slots 8 615081 20384) (floats 8 287 891) (intervals 56 5909 2186) (buffers 976 34)) ------------=_1676675522-21376-1-- From unknown Sat Aug 09 01:11:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61577: 30.0.50; project-try-vc missing vc-got Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2023 23:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Omar Polo , 61577@debbugs.gnu.org Received: via spool by 61577-submit@debbugs.gnu.org id=B61577.167667647723037 (code B ref 61577); Fri, 17 Feb 2023 23:28:02 +0000 Received: (at 61577) by debbugs.gnu.org; 17 Feb 2023 23:27:57 +0000 Received: from localhost ([127.0.0.1]:41861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTA8z-0005zV-6J for submit@debbugs.gnu.org; Fri, 17 Feb 2023 18:27:57 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:37661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTA8x-0005zI-Ed for 61577@debbugs.gnu.org; Fri, 17 Feb 2023 18:27:55 -0500 Received: by mail-wr1-f50.google.com with SMTP id e10so2585184wrg.4 for <61577@debbugs.gnu.org>; Fri, 17 Feb 2023 15:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=dDqUxD60Z2RTu6LD2wtbNAIIBtnVVGprCR3SxZltNRc=; b=kRgjIJMAjF7lljoE5W0nt5SPtKCVp7t4daf2c+Vx5yaYbcojgrlC8LiBpAes22Nrs8 rrc41crqHE4SkbkAI+av845iE8C0d8bWfrUZupS+biaQ3ECgy4czZPOblC2PSizS4HZ+ 9F2ofvNl6+a4YnzGOF10GCGsm1M5mdyTrzkrpOKONBSWGLbf1EkvStER1RF8wOdR6s+L IozuOYoqVnsxYHO2y3dBGHhkNVPNOemuCqStH/IjXLNu3lZw2G1MAYU0iL66y5Tiid4c 2p4whBcdGMlOoIFCcWqQ8jWE4+A3aJQaCbTQXxz2Ul6oefLOK4JoUdqJ+4JHVF4BeABW 1otg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dDqUxD60Z2RTu6LD2wtbNAIIBtnVVGprCR3SxZltNRc=; b=c7SSsneJYONr1lyX6TeNDXB2QWMHa87t8gJgCRFz/tRVQuSqy2DJrOuMD4fHUGDZ6n oD4+klYwHFFQsnSjPRxFjLjauX7XGHOFkd93IFrNCoKtFwBz9mZGkYDLY14kTamuA/vU kKDyRVIAQJi4s8sTcsfkocylZeddvgph0T+tQlg+bLF4YzGRBCytAt8q/w4UWNxcRr3X IYjzIoJ7lTg+S7FVlU8vAc1tzS/gxUE3cLb1g4oQE7/KleKgffCXfELamH8+VrTdNG1T rscGJn2vzolaY7tLjAzQ/PmOfCDr45S2uz/s2qmco6vfROGbe39WWafYUzOUM6ADb3/A TKhQ== X-Gm-Message-State: AO0yUKU8LI6M8Yg35C7Z2GQ171y7rxexHVghHctpXkUv6TyVm9VyxC+E 03oR96FNMOn6FszvfkXnR+k= X-Google-Smtp-Source: AK7set9bPvfZp9AmG40dQpslEtySfeGreJEw1QSvVvEVxBSoQ2+QjpjjCnGepi4WEdmcYlm26Yu3Vw== X-Received: by 2002:a5d:6147:0:b0:2c1:28e7:5081 with SMTP id y7-20020a5d6147000000b002c128e75081mr2149307wrt.68.1676676469337; Fri, 17 Feb 2023 15:27:49 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r8-20020a5d4e48000000b002bfd524255esm5311483wrt.43.2023.02.17.15.27.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 15:27:48 -0800 (PST) Message-ID: Date: Sat, 18 Feb 2023 01:27:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> <37S9LBNTLNSPF.20HFUF5RQ7969@venera> From: Dmitry Gutov In-Reply-To: <37S9LBNTLNSPF.20HFUF5RQ7969@venera> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 17/02/2023 19:34, Omar Polo wrote: > actually, isn't at least CVS missing too? CVS, RCS, SCCS and SRC never were supported before because they don't define the method vc-*-root. The reason for that is they're not tree-based: every subdirectory of a CVS project contains a CVS subdir. Now that we stopped delegating the root-finding logic to VC, we could probably do something about CVS as well, but just your change won't cut it, I think, because with it the search will always return the current directory, rather than the actual root. From unknown Sat Aug 09 01:11:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61577: 30.0.50; project-try-vc missing vc-got Resent-From: Omar Polo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61577-done@debbugs.gnu.org Received: via spool by 61577-done@debbugs.gnu.org id=D61577.167671731830669 (code D ref 61577); Sat, 18 Feb 2023 10:49:01 +0000 Received: (at 61577-done) by debbugs.gnu.org; 18 Feb 2023 10:48:38 +0000 Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTKlh-0007yb-I4 for submit@debbugs.gnu.org; Sat, 18 Feb 2023 05:48:37 -0500 Received: from mail.omarpolo.com ([144.91.116.244]:65436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTKlf-0007y0-8m for 61577-done@debbugs.gnu.org; Sat, 18 Feb 2023 05:48:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1676717308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tO3ITojurrX5eMUIrP43rzW+ELoc4jnoZX/kf/SOPTg=; b=Gz0HtDU9ZD3YjCKvDMJam5zD7Zwkhop+w2eD7pAy1yseRHxp/JO4XL7pmedoVehkLOBk8w 7vQfhgXf9AP9iI2x3Yo7Vky3SJp0XZcd0t166feo0oFQG3GSzYBo96pSCPrEUbCQygVPrf x3dCKLmWEuszS2ABggNg46G94XgSxcA= Received: from localhost (host-87-2-235-1.retail.telecomitalia.it [87.2.235.1]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id f2434e7e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Feb 2023 11:48:28 +0100 (CET) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b2c4a4e9; Sat, 18 Feb 2023 11:48:26 +0100 (CET) Date: Sat, 18 Feb 2023 11:48:26 +0100 From: Omar Polo References: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> In-Reply-To: <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> Message-Id: <33K7WG12CN39M.2BL8XP3YCDT9O@venera> User-Agent: mblaze/1.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2023/02/18 01:11:10 +0200, Dmitry Gutov wrote: > Version: 29.1 >=20 > Hi! >=20 > On 17/02/2023 18:56, Omar Polo wrote: >=20 > > project-try-vc (IIRC) used to loop over all the vc-backends to find the= > > root of a project. Now, it=E2=80=99s just an hardcoded list in a local= > > variable. This breaks the project-* functions on Got checkouts. > >=20 > > I can imagine the reason of the change (avoid loading all the vc-*.el > > files I guess) but it would be nice for this variable to be at least > > user-configurable, otherwise we will always end up with missing entries= =2E >=20 > The reasons were actually related to performance during the search. I thought so, thanks for confirming :) > > (Yeah, one could add their own hooks in project-find-functions for > > that, but seems replicating stuff that project.el tries to do anyway.) > >=20 > > Attaching a diff that temporarly works around the problem by adding the= > > Got -> .got mapping. >=20 > Thanks for the report, I've pushed your addition and also moved the list=20= > to a defvar. Not defcustom, though, to avoid encouraging people from=20 > changing it unnecessarily (instead of project-vc-extra-root-markers). >=20 > Originally, I figured all major backends should be covered, but it won't=20= > hurt to add one more, especially since vc-got is in ELPA. I guess that now the (require 'vc-svn) could go away too. Thanks! P.S.: thanks also for the explanation about CVS/RCS/SCCS/SRC. To be fair I never used the project-* functions in a CVS checkout before yesterday, and it makes sense not to include them by default. Well, maaaybe a vc-cvs-root that walks up until the root of the checkout could be provided, but I'm not too knowledgable about CVS and my usage of it is scarce enough that I didn't feel the reason to have it. Hardly used anything other than C-x v =3D in CVS checkouts. diff /home/op/build/emacs commit - 0be5f7ab6368175953c0a5bcbbd485fd9edda2b0 path + /home/op/build/emacs blob - 1228c73fee86bbae3727fddd8a9687496849b040 file + lisp/progmodes/project.el --- lisp/progmodes/project.el +++ lisp/progmodes/project.el @@ -512,8 +512,6 @@ See `project-vc-extra-root-markers' for the marker val See `project-vc-extra-root-markers' for the marker value format.") =20 (defun project-try-vc (dir) - (defvar vc-svn-admin-directory) - (require 'vc-svn) ;; FIXME: Learn to invalidate when the value of ;; `project-vc-merge-submodules' or `project-vc-extra-root-markers' ;; changes. From unknown Sat Aug 09 01:11:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61577: 30.0.50; project-try-vc missing vc-got Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Omar Polo Cc: 61577-done@debbugs.gnu.org Received: via spool by 61577-done@debbugs.gnu.org id=D61577.167672626723691 (code D ref 61577); Sat, 18 Feb 2023 13:18:01 +0000 Received: (at 61577-done) by debbugs.gnu.org; 18 Feb 2023 13:17:47 +0000 Received: from localhost ([127.0.0.1]:42754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTN63-0006A2-Is for submit@debbugs.gnu.org; Sat, 18 Feb 2023 08:17:47 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:41595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTN62-00069m-6t for 61577-done@debbugs.gnu.org; Sat, 18 Feb 2023 08:17:46 -0500 Received: by mail-wr1-f43.google.com with SMTP id bl19so402544wrb.8 for <61577-done@debbugs.gnu.org>; Sat, 18 Feb 2023 05:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=kLYPHMAifpUP4ZoqoTO51VIOFHVaFppNM52bIHn2pSc=; b=ZBjObS97uefXXKSQ3aLeedAo12ZA4My4D5h8TrOv7Y0vNOecgF/OPDivWpenqrBdZU ptGZMw3kzhIsxjyQqdclo2v8XsUwj5Lc/QXfLsedQA76UJqKPB/9T00q7B5RXpcNg5iu pSa6WSWEt+k30wsGQvntrZQylDlNjXrHGjPYEmVXy0J8Gux23sEFwMNBFOOGVd4k6pAd bIGa50eVQ1Qzd1SRNlr64EHDhI7HbuVGr/jHfI7M1uZnN4hHZlWIwpqegCPN2oGZFlfK qz+tbF2BAmaFhFJpzp+oLfSGZb9IUqHwZMewENesRA2ldLHmfMsO6aAO107fuTtTYr0V c5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kLYPHMAifpUP4ZoqoTO51VIOFHVaFppNM52bIHn2pSc=; b=dk+Mkiyxr7l1GIqVfDSkHgzh4p4zv9zHyO+nafsYXxfFkhYLMrueWVk6/E5BDtjQlE Hw1F0FwRbhawKni+KEehMHfW9OV0U+fO2bDhhW/VLDMiQr1Nx6WZUQZdywH+rnUoF9Zf 7t8wOgnMrithBPSRwvmy1rf5WsJEJVU9W8H3JzEf3WtZ4hZdl6P+6kUlFaB27C+g+ROz 4MjwcMsZR7hDnKPeVim2pJsZjvnh7obCGTfO/ky006LUWn2rUGi9nrpHWwJ1UjsCWdP/ FtVgDzItOeFA7CVCN0bLJ6OG3o+FbccqmXiyS4m1hwndCohTOEww49y4KDUG/MclJXQu rI+w== X-Gm-Message-State: AO0yUKVK0tvgTJ+e2RjSLfXq9Li0SrRb/49HXS9lqy7A5hI4F5PNeHsg bJTs+MOS7yyXnfEuoLjzlpo= X-Google-Smtp-Source: AK7set/xiyMq9w41PA6sjoGXlQOwEVZ1HMGb+ZWOutjt62GB67s9Qd9oO1X6N9+0woMp/05nYHtm/g== X-Received: by 2002:a5d:40c7:0:b0:2c6:b7e:e4c0 with SMTP id b7-20020a5d40c7000000b002c60b7ee4c0mr4869846wrq.28.1676726259037; Sat, 18 Feb 2023 05:17:39 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f3-20020adffcc3000000b002c559626a50sm7019345wrs.13.2023.02.18.05.17.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Feb 2023 05:17:38 -0800 (PST) Message-ID: <20c435f7-5e85-c80d-98b5-cdb059986f1f@yandex.ru> Date: Sat, 18 Feb 2023 15:17:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> <6c541782-294f-49cb-7138-93b45016a79e@yandex.ru> <33K7WG12CN39M.2BL8XP3YCDT9O@venera> From: Dmitry Gutov In-Reply-To: <33K7WG12CN39M.2BL8XP3YCDT9O@venera> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 18/02/2023 12:48, Omar Polo wrote: >> Originally, I figured all major backends should be covered, but it won't >> hurt to add one more, especially since vc-got is in ELPA. > > I guess that now the (require 'vc-svn) could go away too. Ah yeah, thanks for the suggestion. > Thanks! > > P.S.: thanks also for the explanation about CVS/RCS/SCCS/SRC. To be > fair I never used the project-* functions in a CVS checkout before > yesterday, and it makes sense not to include them by default. Well, > maaaybe a vc-cvs-root that walks up until the root of the checkout > could be provided, but I'm not too knowledgable about CVS and my usage > of it is scarce enough that I didn't feel the reason to have it. > Hardly used anything other than C-x v = in CVS checkouts. Given that CVS is both unable to provide a faster file listing, and (IIUC) its file ignore settings are spread between the directories, a user might as well add a new element to project-find-functions, to get the basic features. And closer integration will require more work.