GNU bug report logs -
#61567
30.0.50; Define display-time-time-and-date-indicator face
Previous Next
Reported by: Protesilaos Stavrou <info <at> protesilaos.com>
Date: Fri, 17 Feb 2023 06:08:01 UTC
Severity: normal
Found in version 30.0.50
Done: Protesilaos Stavrou <info <at> protesilaos.com>
Bug is archived. No further changes may be made.
Full log
Message #22 received at 61567 <at> debbugs.gnu.org (full text, mbox):
>>>>> On Fri, 17 Feb 2023 12:40:22 +0200, Protesilaos Stavrou <info <at> protesilaos.com> said:
>> From: Robert Pluim <rpluim <at> gmail.com>
>> Date: Fri, 17 Feb 2023 11:31:08 +0100
>>
>>>>>>> On Fri, 17 Feb 2023 08:37:32 +0200, Eli Zaretskii <eliz <at> gnu.org> said:
Eli> ** New face 'display-time-time-and-date-indicator'.
Eli> This is used for displaying the time and date components of
Eli> 'display-time-mode'.
>>
Eli> should be enough.
>>
>> >> +(defface display-time-time-and-date-indicator nil
>> >> + "Face of the `display-time-format'."
Eli> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Eli> "Face for `display-time-format'."
>>
>> Thatʼs a very repetitive name. How about just
>> `display-time-indicator-face' (although I have a vague memory of there
>> being a guideline to not end faces in -face)
Protesilaos> Indeed, the name is awkard. I also remember that use of "-face" is
Protesilaos> discouraged, but could not find the resource for it.
I canʼt find anything in the elisp manual. But I do note that all the
font-lock faces end in '-face'
Protesilaos> My initial idea was to use "display-time-face", which would also be
Protesilaos> symmetric with "display-time-mail-face". Note though that the latter is
Protesilaos> defined as a 'defcustom', so I wasn't sure what the right approach is.
`defface' defined faces are customizable, so I donʼt think it matters.
Robert
--
This bug report was last modified 2 years and 93 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.