GNU bug report logs - #61560
[Guix Data Service] Comparing package derivations: Fix inconsistent verbage.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61560 in the body.
You can then email your comments to 61560 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [Guix Data Service] Comparing package derivations: Fix inconsistent
 verbage.
Date: Thu, 16 Feb 2023 17:26:45 -0500

Harmonize "Build change" options between the selection menu and the documentation

I don't have a preference about which phrase is chosen. Please use your
judgement in fixing this to ensure consistency throughout the user interface.

* guix-data-service/web/compare/html.scm (compare/package-derivations): Replace
"Still broken" with "Still failing" in the "Build change" help text.
---
 guix-data-service/web/compare/html.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm
index 58fb514..44acb81 100644
--- a/guix-data-service/web/compare/html.scm
+++ b/guix-data-service/web/compare/html.scm
@@ -797,7 +797,7 @@ derivation")
                            (dd
                             "At least one successful build for both the base
 and target derivations")
-                           (dt "Still broken")
+                           (dt "Still failing")
                            (dd
                             "No successful builds and at least one failed builds for both the base and target derivations")
                            (dt "Unknown")
-- 
2.39.1

Message #10 received at 61560-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 61560-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#61560] [Guix Data Service] Comparing package derivations:
 Fix inconsistent verbage.
Date: Fri, 17 Feb 2023 17:11:29 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> Harmonize "Build change" options between the selection menu and the documentation
>
> I don't have a preference about which phrase is chosen. Please use your
> judgement in fixing this to ensure consistency throughout the user interface.
>
> * guix-data-service/web/compare/html.scm (compare/package-derivations): Replace
> "Still broken" with "Still failing" in the "Build change" help text.
> ---
>  guix-data-service/web/compare/html.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix-data-service/web/compare/html.scm b/guix-data-service/web/compare/html.scm
> index 58fb514..44acb81 100644
> --- a/guix-data-service/web/compare/html.scm
> +++ b/guix-data-service/web/compare/html.scm
> @@ -797,7 +797,7 @@ derivation")
>                             (dd
>                              "At least one successful build for both the base
>  and target derivations")
> -                           (dt "Still broken")
> +                           (dt "Still failing")
>                             (dd
>                              "No successful builds and at least one failed builds for both the base and target derivations")
>                             (dt "Unknown")

Looks good to me, I've pushed this now.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.