From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 01:02:03 2023 Received: (at submit) by debbugs.gnu.org; 16 Feb 2023 06:02:03 +0000 Received: from localhost ([127.0.0.1]:34654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSXLG-0005f1-No for submit@debbugs.gnu.org; Thu, 16 Feb 2023 01:02:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:57944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSXLB-0005eO-BN for submit@debbugs.gnu.org; Thu, 16 Feb 2023 01:02:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSXKt-0001Pn-SF for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 01:01:48 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSXKp-0003Vf-Mq for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 01:01:38 -0500 Received: by mail-wr1-x434.google.com with SMTP id bu23so751445wrb.8 for ; Wed, 15 Feb 2023 22:01:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=84oD02kiLfJ+OyfJNGZTW574xmNmbDV/Uljsx/BbiiQ=; b=OEFViZqFXWHXMkQdJNF43tHbIwl+xgX39G9QOLfE4ahImpMB6KO7MLUnPHO7uQNLwO Uj4hfHjtXsj2fVhKH35qvWpGkgG0u5b5BAYTiTv3diFaLCu45lmkppCtJDeaWSwD//sx SUvm/APzDznBhuCzSwdm9fZUhTWwTW7jaPog70IZctbHRYRTduScUY61WoeTD70Zt+DF QzI51AWX+TavhpZLlGUcDmtdqEWzBWmnO9JYt7UOucNF04nnppedPNizu/xWrJwLWkIB RIBD7/IkZ4y5yDVFLGAxSd6Sdk+/HnnoKq6bZJBYZWLfQnBhtYb67Ht6Ed+9H8B8YOYc Vvhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=84oD02kiLfJ+OyfJNGZTW574xmNmbDV/Uljsx/BbiiQ=; b=CjwX6mO3nvhbVpjt/OD9GOUOQY82CBJQQpkCMVVtzm256oqza8C8dfg9DAteUS0dST NsAEi2j5ua5reXF8HGC5DQYvQoT5aYZ0esBTVyp4pDj4Ind5C2/Jv846MP7osfq8jEMU q8fQdSeXSgEP86yOqAUZZWN4kuFh3GRXWH+68i2hcgmAuKiAVytNzeuVwqu//zLJlBCb G6DKFF4fIZdJunr+DN286F2CQfOpxlHP4CKOva62QNfL9CiUPxMx5zO9aBmupQ+oMsO0 ln9C4fLOrIYEHLP3H5PzEn9oTzKv/Y/FNSNnBDPYYqHBzJKcbezvluRW2clAJDsTeQxw 1xCw== X-Gm-Message-State: AO0yUKWflrvCfIQnHYQQn43+hj9lIub/LB50PNwHOYwbUuS5ipBpeKJD C/RApYGbYyHFCs+X0gVduLDP7uQoViI= X-Google-Smtp-Source: AK7set+ovPLUFNXfa26w6G8JJVUQKRvjA86M3SgqvkwokqVX9U3knOSiw+oo0EoybIcbqUttc9caNQ== X-Received: by 2002:adf:f40f:0:b0:2c5:512b:afc1 with SMTP id g15-20020adff40f000000b002c5512bafc1mr3623746wro.47.1676527293253; Wed, 15 Feb 2023 22:01:33 -0800 (PST) Received: from thuna ([90.147.71.250]) by smtp.gmail.com with ESMTPSA id d11-20020adffd8b000000b002c54536c662sm561533wrr.34.2023.02.15.22.01.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 22:01:32 -0800 (PST) From: Thuna To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' Date: Thu, 16 Feb 2023 07:01:23 +0100 Message-ID: <87r0uq2los.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=thuna.cing@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Some code in org seems to break when calendar-buffer is modified, as they rely on it being its default value, "*Calendar*". The attached patch fixes that. I haven't tested it, however, it should work fine. The `require's all seem correct as well. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Use-the-calendar-buffer-variable.patch Content-Description: The main patch >From 1facad66a10211470cc7d785dfd4418217553b57 Mon Sep 17 00:00:00 2001 From: Thuna Date: Tue, 14 Feb 2023 19:52:37 +0100 Subject: [PATCH 1/3] Use the calendar-buffer variable * lisp/org/org.el (org-read-date org-eval-in-calendar org-timestamp-change org-modify-ts-extra org-goto-calendar): lisp/org/org-agenda.el (org-agenda-clock-goto): test/lisp/calendar/cal-julian-tests.el (with-cal-julian-test): Use the variable `calendar-buffer' instead of its default value, the literal string `"*Calendar*"'. --- lisp/org/org-agenda.el | 2 +- lisp/org/org.el | 12 ++++++------ test/lisp/calendar/cal-julian-tests.el | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el index 3db33c4d63e..63757cf5e1c 100644 --- a/lisp/org/org-agenda.el +++ b/lisp/org/org-agenda.el @@ -10555,7 +10555,7 @@ org-agenda-clock-goto (defun org-agenda-diary-entry-in-org-file () "Make a diary entry in the file `org-agenda-diary-file'." (let (d1 d2 char (text "") dp1 dp2) - (if (equal (buffer-name) "*Calendar*") + (if (equal (buffer-name) calendar-buffer) (setq d1 (calendar-cursor-to-date t) d2 (car calendar-mark-ring)) (setq dp1 (get-text-property (line-beginning-position) 'day)) diff --git a/lisp/org/org.el b/lisp/org/org.el index 9a4f7803cf4..f602bfb8c8a 100644 --- a/lisp/org/org.el +++ b/lisp/org/org.el @@ -13710,7 +13710,7 @@ org-read-date (calendar) (when (eq calendar-setup 'calendar-only) (setq cal-frame - (window-frame (get-buffer-window "*Calendar*" 'visible))) + (window-frame (get-buffer-window calendar-buffer 'visible))) (select-frame cal-frame)) (org-eval-in-calendar '(setq cursor-type nil) t) (unwind-protect @@ -13746,7 +13746,7 @@ org-read-date (when org-read-date-overlay (delete-overlay org-read-date-overlay) (setq org-read-date-overlay nil))))) - (bury-buffer "*Calendar*") + (bury-buffer calendar-buffer) (when cal-frame (delete-frame cal-frame) (select-frame-set-input-focus cur-frame)))))) @@ -14103,7 +14103,7 @@ org-eval-in-calendar Unless KEEPDATE is non-nil, update `org-ans2' to the cursor date." (let ((sf (selected-frame)) (sw (selected-window))) - (select-window (get-buffer-window "*Calendar*" t)) + (select-window (get-buffer-window calendar-buffer t)) (eval form t) (when (and (not keepdate) (calendar-cursor-to-date)) (let* ((date (calendar-cursor-to-date)) @@ -14952,7 +14952,7 @@ org-timestamp-change (org-get-heading t t))))))))) ;; Try to recenter the calendar window, if any. (when (and org-calendar-follow-timestamp-change - (get-buffer-window "*Calendar*" t) + (get-buffer-window calendar-buffer t) (memq timestamp? '(day month year))) (org-recenter-calendar (time-to-days time)))))) @@ -14995,7 +14995,7 @@ org-modify-ts-extra (defun org-recenter-calendar (d) "If the calendar is visible, recenter it to date D." - (let ((cwin (get-buffer-window "*Calendar*" t))) + (let ((cwin (get-buffer-window calendar-buffer t))) (when cwin (let ((calendar-move-hook nil)) (with-selected-window cwin @@ -15022,7 +15022,7 @@ org-goto-calendar (defun org-get-date-from-calendar () "Return a list (month day year) of date at point in calendar." - (with-current-buffer "*Calendar*" + (with-current-buffer calendar-buffer (save-match-data (calendar-cursor-to-date)))) diff --git a/test/lisp/calendar/cal-julian-tests.el b/test/lisp/calendar/cal-julian-tests.el index e0d74e8a6cd..4207d1ee285 100644 --- a/test/lisp/calendar/cal-julian-tests.el +++ b/test/lisp/calendar/cal-julian-tests.el @@ -47,7 +47,7 @@ with-cal-julian-test (progn (calendar) ,@body) - (kill-buffer "*Calendar*")))) + (kill-buffer calendar-buffer)))) (ert-deftest cal-julian-test-goto-date () (with-cal-julian-test -- 2.38.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 04:24:40 2023 Received: (at 61546) by debbugs.gnu.org; 16 Feb 2023 09:24:40 +0000 Received: from localhost ([127.0.0.1]:34882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSaVM-00031J-GU for submit@debbugs.gnu.org; Thu, 16 Feb 2023 04:24:40 -0500 Received: from mail-oi1-f172.google.com ([209.85.167.172]:45053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSaVF-00030z-Mk for 61546@debbugs.gnu.org; Thu, 16 Feb 2023 04:24:38 -0500 Received: by mail-oi1-f172.google.com with SMTP id bj22so1083680oib.11 for <61546@debbugs.gnu.org>; Thu, 16 Feb 2023 01:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=HVXHXZyYrIJ1iSgw+N9F1IDOLVP3WJlKYsSU0Fbi62U=; b=hmGBGAUypdJhqZCFtz8f5qXfAVpFjh8+OmdS4Z5d1PDTKjyHEwUTWRKmog7H4YxSWW PuheD7wreKDtAGa6746/a1FW+yahRoflSZYpfbbKlwSumRGUZGZDNkZrBI7nEOwJviFj JoinURXc86QhrBc+hh0JBjT6zgsDLmQehXMsVqJfSwkPdXw43pz2Qd7SAmimvv4aGmgL SmwqrqUs2Beux2l7cdzGucykXk7v0QOZL6A6gbyWRRh7fYdEDjBWVkauys1OOG3ZEocJ lBsuMBZI680xCgzKXzllJE/ASY8hE5rRsa4Np+d4v+/L/eY6oHIqAsYFBRjKCNzF2X/B ak4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HVXHXZyYrIJ1iSgw+N9F1IDOLVP3WJlKYsSU0Fbi62U=; b=uXB82sX/94LSKWee8xbYsDchQpYLdcpMRqkWvy20BNT2Temb+DGuEXLr6Wr2qY38e6 P2mPhfbaMu/4Wo4HZJyDadfLoPqimw6CzXsxSZmOS90YRUht0rk4dRv0/1T707tXSx19 YLDrkKWnLSj+31ZJjfPCmVVe3Erz3JXkMVrgApcc/8NZ6O68SFz9rlA0zYH4SobFNcAz vc3qyMjxrTYlXB0BoCbbcuBWGk234oXMKq78xUXMlPcg9HfxTxxi3ApGFs2uBIzJa7QL bHtMfpf2itXaAGuvwV1T161ZHkKxu8rU5AUd7Ew5eIcXWKXP0fdZXW/jELajg1h4At0a YfQw== X-Gm-Message-State: AO0yUKX6jvPnE+bHglMImLR5+/8xS+oq1gm7gjynURZtGFAFpDHd2wfR AF+p2rxWDhxTGxdNjTOID26iGOfmXbIWqYiujDw= X-Google-Smtp-Source: AK7set/4ZMNWgPzzJjeBvhZi2fVot7t7OzgFTh+xy5UJ2XSO/dW54DyTqWEZgoosRQyAWwVf8R+asI4zTvuZ+CxfF5A= X-Received: by 2002:a05:6808:179b:b0:360:ceaa:7e4e with SMTP id bg27-20020a056808179b00b00360ceaa7e4emr113047oib.199.1676539467648; Thu, 16 Feb 2023 01:24:27 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Feb 2023 01:24:27 -0800 From: Stefan Kangas In-Reply-To: <87r0uq2los.fsf@gmail.com> References: <87r0uq2los.fsf@gmail.com> X-Hashcash: 1:20:230216:thuna.cing@gmail.com::t2s9KHIiC4qceQ8c:2rdH MIME-Version: 1.0 Date: Thu, 16 Feb 2023 01:24:27 -0800 Message-ID: Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' To: Thuna , 61546@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61546 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thuna writes: > Some code in org seems to break when calendar-buffer is modified, as > they rely on it being its default value, "*Calendar*". The attached > patch fixes that. I haven't tested it, however, it should work fine. > The `require's all seem correct as well. In general, it's better to send patches for org-mode to the org-mode mailing list. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 04:35:23 2023 Received: (at 61546) by debbugs.gnu.org; 16 Feb 2023 09:35:23 +0000 Received: from localhost ([127.0.0.1]:34903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSafi-0003Jf-3C for submit@debbugs.gnu.org; Thu, 16 Feb 2023 04:35:23 -0500 Received: from mail-ed1-f45.google.com ([209.85.208.45]:33466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSafc-0003JK-U0 for 61546@debbugs.gnu.org; Thu, 16 Feb 2023 04:35:21 -0500 Received: by mail-ed1-f45.google.com with SMTP id n20so2093191edy.0 for <61546@debbugs.gnu.org>; Thu, 16 Feb 2023 01:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=2JjGdtqtmBfKUv6SXKJAmQY7Pk1Q2ddyut8mMw9E3hw=; b=ny6QP8g3x6YBiYzJMvqoOvU5es5P6/eMiPhcaTv5nJN5AoklTiClaobIP4iGN5TPv1 lBfxGmDcVYzl2TJ4EAoQCIEwUj4rGDu7YMTLp3OYHTEqTQd5XkWBue3HMFpSBVRw/txw VLwoQTGkDSCxnjGDlfhwvq8Eia3aLQ3Urw9ZFld3GYhhJnkdRwjwlM+2YSgf9YT6MRQs u5ZMxE0WGDm52h+F6r1OUGlDNM5EY7HsIu0OhqRml6sgrkxJZqOEO6iOF6YqCwPnOqnv xHRA0G/2elmcWAhRfXLcayAX0ybh+FGWPU84uWB8yAkKoY46Y1wsmF4w3jbbRfytsciF ln2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2JjGdtqtmBfKUv6SXKJAmQY7Pk1Q2ddyut8mMw9E3hw=; b=Y4i4k0XHlJgcHlkKIxxa6LRH751gRrsoI5HHRzK7Gw9agjoEGgwdiHOLPjy1oDoAdw D+WGes1QN+ZpxlDyTO5vXYrgRoBvFcBNUXn9fySkjcRlF70Ge1/UKZYMYfZCMGjZV5BC g6FzrA3qxheEAxrw3qVpoU/P5rY4hFN6tOQGZoBCLeFqn7MnlYrG2tva9DfekWzumeV5 9jOmZOlLc7ygzdQUvAqr+ZgYjaHP1tMCro1gPZePkAjV4HlfO7ZS+yhJCvIYQ0+8lBLH dV8eYMcBvM0qjQk7JPjEz9bo9hhte7nBUg9DfR4xTHkKyqwQk/Hws5Ubr84QVvMh1Tv9 QdgQ== X-Gm-Message-State: AO0yUKU8hLd8XTiDxqHqJtqWmKA2HWk4ZNR1ktw4rIUW/KQoNXnf84fX ScRwIhevXx7k17rkfn8WSSdjMwVvqVg= X-Google-Smtp-Source: AK7set9wRSk+rj+AAt8n2lvkja0T/ZSck1CczfSYKWI4ngzeFRpwNq3LNjsVLH9Jstx232RGej/tuA== X-Received: by 2002:aa7:d683:0:b0:4ac:c6ca:b1f8 with SMTP id d3-20020aa7d683000000b004acc6cab1f8mr5220607edr.12.1676540110678; Thu, 16 Feb 2023 01:35:10 -0800 (PST) Received: from thuna ([193.205.22.53]) by smtp.gmail.com with ESMTPSA id h24-20020a50cdd8000000b004accd5604a8sm564942edj.50.2023.02.16.01.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 01:35:10 -0800 (PST) From: Thuna To: Stefan Kangas , 61546@debbugs.gnu.org Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' In-Reply-To: References: <87r0uq2los.fsf@gmail.com> Date: Thu, 16 Feb 2023 10:35:09 +0100 Message-ID: <87mt5e2bsi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61546 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > In general, it's better to send patches for org-mode to the org-mode > mailing list. Right, sorry, I split this off of 61547 and forgot to send it to the org-mode mailing list. Should I do it now or is it fine here also? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 04:56:52 2023 Received: (at 61546) by debbugs.gnu.org; 16 Feb 2023 09:56:52 +0000 Received: from localhost ([127.0.0.1]:34927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSb0W-0003sU-1X for submit@debbugs.gnu.org; Thu, 16 Feb 2023 04:56:52 -0500 Received: from mout02.posteo.de ([185.67.36.66]:60569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSb0S-0003sF-RM for 61546@debbugs.gnu.org; Thu, 16 Feb 2023 04:56:50 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B571D240442 for <61546@debbugs.gnu.org>; Thu, 16 Feb 2023 10:56:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1676541402; bh=QFg/yTbFiekcA1/iO+vT1psxt2FR/b4ij6v2RJqYMaA=; h=From:To:Cc:Subject:Date:From; b=V/regFZTlSANeVcSvS5Pn673neMY509VLDsfwNVFVzgBFuN3HcL1SUEwY/yK0So72 dRkToLbgWuVezLbD9oR1/mblqTs/zsLn43VQWa+ksrcw48ZJecUmnXzeQHEwD6BEZK SzNk2mOJxd2K/x+T8AL0myjrTzGwb6TRqfniRYyHvGg54LiWLQH3U+w4y0Ibv5D94o rlYXf/Pax2g5TsTXOj63XZEckhZ/4/EUoxqXstiElauSk6VtrhNzajJfIPRYY05KWA MyZiIH8VpMKpiwiV++d5eaUw8Eo4mgib7TJzg6rNIlcDGfQb/VZP8p7tqTVFy1iIuu aPZ7YKw7N2BrQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PHVhk1sFZz9rxF; Thu, 16 Feb 2023 10:56:37 +0100 (CET) From: Ihor Radchenko To: Thuna Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' In-Reply-To: <87mt5e2bsi.fsf@gmail.com> References: <87r0uq2los.fsf@gmail.com> <87mt5e2bsi.fsf@gmail.com> Date: Thu, 16 Feb 2023 09:57:09 +0000 Message-ID: <87y1oy2aru.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61546 Cc: 61546@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thuna writes: >> In general, it's better to send patches for org-mode to the org-mode >> mailing list. > > Right, sorry, I split this off of 61547 and forgot to send it to the > org-mode mailing list. Should I do it now or is it fine here also? I happen to see this email. The patch looks fine, even if the other patch is not merged. It is also compatible with Emacs 26. However, I need to know if you have FSF copyright assignment. If not, you will need to add TINYCHANGE cookie to the commit message. See https://orgmode.org/worg/org-contribute.html#first-patch -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 05:02:40 2023 Received: (at 61546) by debbugs.gnu.org; 16 Feb 2023 10:02:40 +0000 Received: from localhost ([127.0.0.1]:34935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSb67-00042f-QW for submit@debbugs.gnu.org; Thu, 16 Feb 2023 05:02:40 -0500 Received: from mail-ej1-f52.google.com ([209.85.218.52]:36735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSb65-00042R-7C for 61546@debbugs.gnu.org; Thu, 16 Feb 2023 05:02:37 -0500 Received: by mail-ej1-f52.google.com with SMTP id a3so3892667ejb.3 for <61546@debbugs.gnu.org>; Thu, 16 Feb 2023 02:02:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=C7ecs2pqQb3JzVuRja7uoGKnSfaeLVe4pRloHvIGTfc=; b=nvhmkc84FcTlsw1G7NQTqiUVZfnBIZpQJ8Uo6TwrjKJwSPQ6+vwii0ORUIfMkV/X0J Z/l6o0MhL+pvEB8XflnbHY5shnSigzO4IaOLQA6KU6E8AZM6rknbjYXGmQQaWUDZ3PMK dXa/14BQcK/vQgf4Ym55s1W5ZJcaSQgW8LSqVp7XdXPFIvkGuLjQLiqwXyyAhMuJ5fZA vxYpCsMAsdSM6SdwiL8ow/Cjm8FO0ZNmZ+6UiEI2bfrO4aka8P5yuE4Mo6ZWOkOAl8mF ZKHxr08zzgqjtlnn8X9owu/qCU9Nb+Yx9c/pL7sIwDxdir/x4Q67XtYcPSipAXMXI8Bx ULAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C7ecs2pqQb3JzVuRja7uoGKnSfaeLVe4pRloHvIGTfc=; b=bxyH5gucJ8Dwg4e7DFxYYcUgUfHcookWtktD41a6lLOlbSzq2b6uqDqqdLD7F3BE2m BlM9qU/Cw4vF6WTgcx9IKifD4LwupPgi0A+oB1qzGAuXhhriK/IzkBu/38E1WTcR9i8F OtIR4hIXfqh/wyNRo+keoUCbQIS8Mzjy1ZkapWBYYC/7oZN3N2qlFJkJ72PUyLWg9iag R1Ks7Cs+wl3W8CdsQTs0fxqrb60FZT8OsKD+ZTydG4MpLi9bSgcqNhDUn5+WX/asbDOB UyzE7LByszvI75FHWsmLqYONlYueH2Z3pnlJ6lJddqVVGEDgSPBkBetiSXDSCP4YOCPs stYA== X-Gm-Message-State: AO0yUKVI9c1p6EVbik6bCOaPMwbWDydQcngW6Oh7VcvFfvAUE2vnsePR 8jm0D4WclOlOykkT+/TiJaVrdTEfPoc1TQ== X-Google-Smtp-Source: AK7set8e08wSWjfnr+HzonzvXJhXVn/AqF7+QGhcc+xZHllctxp1PvgkGc1UmrUhnjb/kJZrvanEFA== X-Received: by 2002:a17:906:5e19:b0:888:5d34:dc79 with SMTP id n25-20020a1709065e1900b008885d34dc79mr6034829eju.40.1676541751056; Thu, 16 Feb 2023 02:02:31 -0800 (PST) Received: from thuna ([193.205.22.53]) by smtp.gmail.com with ESMTPSA id qt24-20020a170906ecf800b008b126051fbdsm596918ejb.47.2023.02.16.02.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 02:02:30 -0800 (PST) From: Thuna To: Ihor Radchenko Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' In-Reply-To: <87y1oy2aru.fsf@localhost> References: <87r0uq2los.fsf@gmail.com> <87mt5e2bsi.fsf@gmail.com> <87y1oy2aru.fsf@localhost> Date: Thu, 16 Feb 2023 11:02:29 +0100 Message-ID: <87k00i2aiy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61546 Cc: 61546@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I happen to see this email. > > The patch looks fine, even if the other patch is not merged. > It is also compatible with Emacs 26. Ok, that is good to know. > However, I need to know if you have FSF copyright assignment. I am in the process of getting my copyright assignment however it is happening extremely slowly; I would not be surprised if it took another month. > If not, you will need to add TINYCHANGE cookie to the commit > message. See https://orgmode.org/worg/org-contribute.html#first-patch That is a bit of an issue. Do org contributions and emacs contributions count towards the same 15 LoC limit? If so, I have already exhausted mine, so TINYCHANGE won't work. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 05:16:40 2023 Received: (at 61546) by debbugs.gnu.org; 16 Feb 2023 10:16:40 +0000 Received: from localhost ([127.0.0.1]:34940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSbJe-0004ND-8D for submit@debbugs.gnu.org; Thu, 16 Feb 2023 05:16:40 -0500 Received: from mout02.posteo.de ([185.67.36.66]:50581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSbJZ-0004Mv-OG for 61546@debbugs.gnu.org; Thu, 16 Feb 2023 05:16:37 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3D4CB2405FE for <61546@debbugs.gnu.org>; Thu, 16 Feb 2023 11:16:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1676542588; bh=1ZBao206u2migZzVTRVguA+OHFG3SqKMuyLMMZ4jSWw=; h=From:To:Cc:Subject:Date:From; b=Fy91RQo87RMwuevLgh7Li9F1rIX+nSNKWjMp+vWFiJMO1Iqc5SKpjnR+lG7idnZEm 8T7iErJSFoIVgBwi6G7uTeQpSCis5GhdhuQcu9pTl93DwU0blgO/gsL3CsgIMn/CUn plgD/fmp93xk+wHcg2AXx7mtg9L/dSOalABmsWXZNFq34A2Xn2rHBC+dICpk9cxk1z J301dr9OOYJcGmV7WdAcJwF8YtzsoCQtxJAoIi9hJwH3+SPTcMULEUZkZmyorzazRj y96d4eLOkgTEW8JdCPIMQjiEwo9EctrJGSPyiJk8xefqx0HdX5rbjoB1X7Li40KoSM y4bwLIQRz6E4Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PHW7Y264jz9rxG; Thu, 16 Feb 2023 11:16:25 +0100 (CET) From: Ihor Radchenko To: Thuna , Bastien Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' In-Reply-To: <87k00i2aiy.fsf@gmail.com> References: <87r0uq2los.fsf@gmail.com> <87mt5e2bsi.fsf@gmail.com> <87y1oy2aru.fsf@localhost> <87k00i2aiy.fsf@gmail.com> Date: Thu, 16 Feb 2023 10:17:01 +0000 Message-ID: <87v8k13of6.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61546 Cc: 61546@debbugs.gnu.org, emacs-orgmode@gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thuna writes: >> If not, you will need to add TINYCHANGE cookie to the commit >> message. See https://orgmode.org/worg/org-contribute.html#first-patch > That is a bit of an issue. Do org contributions and emacs contributions > count towards the same 15 LoC limit? If so, I have already exhausted > mine, so TINYCHANGE won't work. AFAIK, we count separately. Org mode is a separate project, despite being distributed together with Emacs. At least, we usually only consider LOCs contributed to Org. Let me CC Bastien (the Org maintainer) to clarify. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 04:28:43 2023 Received: (at 61546) by debbugs.gnu.org; 28 Feb 2023 09:28:43 +0000 Received: from localhost ([127.0.0.1]:49722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWwHr-0006tG-Bl for submit@debbugs.gnu.org; Tue, 28 Feb 2023 04:28:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWwHn-0006t0-DD for 61546@debbugs.gnu.org; Tue, 28 Feb 2023 04:28:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWwHh-0001IY-7w; Tue, 28 Feb 2023 04:28:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=N25Wg4hMWPLfNZKNF8Js1zDYmjqcygtwz9eokKArcTA=; b=p+vkTlDxKq6Rd2zOClUn B0hYOysVhcXD1QRAQ4zW/YgDLT04kKZQXX0648qYU5XlcgrO6uqJgkB7gA2S+BjlTlled8obpqp7L 2ydXUJ0NuSOXX3DK+cxnY9u4TOftHrKqo6/wTPDaXlbEjHQ3Z5Ux2ARFsEWuDahoxByeG7bFrusa2 vVjXWrtSxfi4CYP863G/ag66z75dMM8szCjtYnet5duMtCJCSk/xEt2V2ChOBWI57uwVsHkjWhoIr jKM+yUZnU82r7EKiVVRyCWM0xltJHyxKcaeUgp6KQ/3nEyMj1PhW7gvRAEaHVPmd44+NWVWa+HCoj 3UDbgQqwmpo7Rw==; Received: from [185.24.184.132] (helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWwHg-0004Ea-Ui; Tue, 28 Feb 2023 04:28:33 -0500 Received: by hal (Postfix, from userid 1000) id 797F81E0403; Tue, 28 Feb 2023 10:28:31 +0100 (CET) From: Bastien Guerry To: Ihor Radchenko Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' In-Reply-To: <87v8k13of6.fsf@localhost> (Ihor Radchenko's message of "Thu, 16 Feb 2023 10:17:01 +0000") References: <87r0uq2los.fsf@gmail.com> <87mt5e2bsi.fsf@gmail.com> <87y1oy2aru.fsf@localhost> <87k00i2aiy.fsf@gmail.com> <87v8k13of6.fsf@localhost> Date: Tue, 28 Feb 2023 10:28:31 +0100 Message-ID: <874jr6nnpc.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61546 Cc: 61546@debbugs.gnu.org, emacs-orgmode@gnu.org, Stefan Kangas , Thuna X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ihor Radchenko writes: >> That is a bit of an issue. Do org contributions and emacs contributions >> count towards the same 15 LoC limit? Yes. Copyright-wise, contributions to Org are contributions to Emacs. >> If so, I have already exhausted mine, so TINYCHANGE won't work. > > AFAIK, we count separately. Org mode is a separate project, despite > being distributed together with Emacs. At least, we usually only > consider LOCs contributed to Org. > > Let me CC Bastien (the Org maintainer) to clarify. Hopefully done, thanks! -- Bastien Guerry From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 07:35:47 2023 Received: (at 61546) by debbugs.gnu.org; 2 May 2023 11:35:47 +0000 Received: from localhost ([127.0.0.1]:41837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptoIK-0000Bz-3D for submit@debbugs.gnu.org; Tue, 02 May 2023 07:35:47 -0400 Received: from mout02.posteo.de ([185.67.36.66]:55275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptoIH-0000Bg-8C for 61546@debbugs.gnu.org; Tue, 02 May 2023 07:35:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2F2CB240322 for <61546@debbugs.gnu.org>; Tue, 2 May 2023 13:35:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683027335; bh=cpH+a/Bx4SD5GkCqV/yTf44KLlOvIvhHLTJhxhGTMvo=; h=From:To:Cc:Subject:Date:From; b=OhVikk27BL72j8OMoZkUmbqcZriKvReXfe41wQWO3644sVS7h7L3WqGtmS3FrGZxu 73fHKZZJpi3VbqEn3eeyMTcNvXEviTGr0Wc8OXPB1v2M0kPglLtJOSshgPpBvqsJIW N28pGvPwnVjLk99327gRMTVdxqGN0JP+pGYhKNK14fby/kjc6GmmOBafCVJUJSsocm V5Go2Yi3X3piD6GRNl4X3s5gTEmvYx2RngLmYXQqpKMruyRKn6KoK3hUyoMgrmkV+o NJEq9Q+U8YlZt5vu6d+gWf+iR/jU9aQlHrYulyuMAcp1bPi2PxfM9O9e6H+KZl2Eh7 MH/mvpN6X39PA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q9dLG4lcBz6txj; Tue, 2 May 2023 13:35:34 +0200 (CEST) From: Ihor Radchenko To: Thuna Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' In-Reply-To: <87r0uq2los.fsf@gmail.com> References: <87r0uq2los.fsf@gmail.com> Date: Tue, 02 May 2023 11:38:40 +0000 Message-ID: <87pm7jdku7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61546 Cc: 61546@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thuna writes: > Some code in org seems to break when calendar-buffer is modified, as > they rely on it being its default value, "*Calendar*". The attached > patch fixes that. I haven't tested it, however, it should work fine. > The `require's all seem correct as well. I now applied an equivalent patch onto main in Org. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9ea50ca21 Stefan, please note that part of the patch is for Emacs: test/lisp/calendar/cal-julian-tests.el > diff --git a/test/lisp/calendar/cal-julian-tests.el b/test/lisp/calendar/cal-julian-tests.el > index e0d74e8a6cd..4207d1ee285 100644 > --- a/test/lisp/calendar/cal-julian-tests.el > +++ b/test/lisp/calendar/cal-julian-tests.el > @@ -47,7 +47,7 @@ with-cal-julian-test > (progn > (calendar) > ,@body) > - (kill-buffer "*Calendar*")))) > + (kill-buffer calendar-buffer)))) > > (ert-deftest cal-julian-test-goto-date () > (with-cal-julian-test > -- > 2.38.2 > -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 14:03:40 2023 Received: (at 61546-done) by debbugs.gnu.org; 2 May 2023 18:03:40 +0000 Received: from localhost ([127.0.0.1]:45011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptuLj-0004D5-QN for submit@debbugs.gnu.org; Tue, 02 May 2023 14:03:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptuLh-0004Cs-AK for 61546-done@debbugs.gnu.org; Tue, 02 May 2023 14:03:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptuLZ-00066E-QA; Tue, 02 May 2023 14:03:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/ZBQvhNs+lcWoZc2drMNOIyjiGXoMWaUbqUPBiW3efY=; b=bYz+d1CNREc5 MRZdpnwZPhPlPDiJMPpz4xGv4Q6eGqGaIz6+JvC0c4dnmEq9D24AUcjmDIoj++O3+s6CUJw9TFLpe mYKIFORfpPvFBKYIDXrB0m8Pf0mJcjXx2ZnbwR8OujmOEJf5XA/oXMS4b/O/7uZ785nb+vY8gt2lv WKMtcvW5hD6ifxp/qpKsK6LcUasA8/i8Dtj/f07BOVfRM9tMK/O5TaJwwu/oIOIvFSBYlJuh7N4K8 gW83qSMGmUUzdMy5zcKOQl5LTgT16Y4l3cYGSIjc9mfoL93aROlOJBxWbC9MfHAi3Xg3pWennpbhO 9bsgUjt9bKsFl3sN2gESGA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptuLY-0005Ja-6J; Tue, 02 May 2023 14:03:28 -0400 Date: Tue, 02 May 2023 21:04:13 +0300 Message-Id: <83jzxqmwyq.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko In-Reply-To: <87pm7jdku7.fsf@localhost> (message from Ihor Radchenko on Tue, 02 May 2023 11:38:40 +0000) Subject: Re: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' References: <87r0uq2los.fsf@gmail.com> <87pm7jdku7.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61546-done Cc: 61546-done@debbugs.gnu.org, stefankangas@gmail.com, thuna.cing@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 61546@debbugs.gnu.org, Stefan Kangas > From: Ihor Radchenko > Date: Tue, 02 May 2023 11:38:40 +0000 > > Thuna writes: > > > Some code in org seems to break when calendar-buffer is modified, as > > they rely on it being its default value, "*Calendar*". The attached > > patch fixes that. I haven't tested it, however, it should work fine. > > The `require's all seem correct as well. > > I now applied an equivalent patch onto main in Org. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9ea50ca21 > > Stefan, please note that part of the patch is for Emacs: I'm not Stefan, but I've installed this part on the emacs-29 branch, and I'm therefore closing the bug. From unknown Sat Jun 21 05:16:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 31 May 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator