Subject: bug#61545: closed (Re: bug#61545: [PATCH] gnu: Add waybar-experimental)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 22 Mar 2023 18:22:02 +0000

Your bug report

#61545: [PATCH] gnu: Add waybar-experimental

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
61545: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61545
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#61545: [PATCH] gnu: Add waybar-experimental
From: Maxim Cournoyer <[email-masked]>
To: Erik Giorgis <[email-masked]>
Cc: [email-masked]
Date: Wed, 22 Mar 2023 14:21:02 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Erik Giorgis <[email-masked]> writes:

> ---
> Waybar built with the experimental flag has support
> for additional features, such as displaying the 
> number of active workspaces in Hyprland.
>
>  gnu/packages/wm.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index f2149b5be5..07e834df8a 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -1875,6 +1875,15 @@ (define-public waybar-cpu-histogram
>      (home-page "https://github.com/plattfot/cpu-histogram/")
>      (license license:expat)))
>  
> +(define-public waybar-experimental
> +  (let ((base waybar))
> +    (package
> +      (inherit base)

A subtlety of inheritance; this should be package/inherit base, as the
same source code is shared (thus same vulnerabilities may exist and need
the same replacement treatment by grafts).

> +      (name "waybar-experimental")
> +      (arguments
> +       (list #:configure-flags #~(list "-Dexperimental=true")))
> +      (synopsis "Waybar with experimental features"))))
> +
>  (define-public wlr-randr
>    (package
>      (name "wlr-randr")

I've made the above change, along a correct change log message:

--8<---------------cut here---------------start------------->8---
gnu: Add waybar-experimental.

* gnu/packages/wm.scm (waybar-experimental): New variable.
--8<---------------cut here---------------end--------------->8---

and installed the change.

Thank you!

-- 
Maxim

Subject: [PATCH] gnu: Add waybar-experimental
From: Erik Giorgis <[email-masked]>
To: [email-masked]
Cc: Erik Giorgis <[email-masked]>
Date: Wed, 15 Feb 2023 23:22:56 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

---
Waybar built with the experimental flag has support
for additional features, such as displaying the 
number of active workspaces in Hyprland.

 gnu/packages/wm.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index f2149b5be5..07e834df8a 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1875,6 +1875,15 @@ (define-public waybar-cpu-histogram
     (home-page "https://github.com/plattfot/cpu-histogram/")
     (license license:expat)))
 
+(define-public waybar-experimental
+  (let ((base waybar))
+    (package
+      (inherit base)
+      (name "waybar-experimental")
+      (arguments
+       (list #:configure-flags #~(list "-Dexperimental=true")))
+      (synopsis "Waybar with experimental features"))))
+
 (define-public wlr-randr
   (package
     (name "wlr-randr")
-- 
2.39.1